- 12 Nov, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d565d557945e..119ab23ab620 Created with: gclient setdep -r src-internal@119ab23ab620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:984162,chromium:1004848,chromium:1018879,chromium:None,chromium:None Change-Id: I8392ef4c764779c03f3df2ecb65ce0643188de6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714646}
-
Ionel Popescu authored
This CL removes the background-color added for date/month/time controls in order to continue using the highlight and highlightext colors to match the active selection background and foreground colors (specified in input_multiple_fields.css?l=54). Bug: 1021328 Change-Id: Ic064697f14f508e3336b41c2c4801122d0175ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907595 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714645}
-
Yue Zhang authored
Bug: 1017141, 1023530 Change-Id: Ie5868b781a929d09987edcdd6ca3e140b14d9946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912651Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714644}
-
Theresa Wellington authored
This test is failing when checking whether an item was selected on tablets. Restricting to phones only. BUG=966644 TBR=mdjones@chromium.org Change-Id: I56be49800d1381db7b17670d73f389405341e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912085Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714643}
-
Patrick Noland authored
This allows us to: 1) Remove getAppMenuHandler from ToolbarManager 2) Move ToolbarButtonIPHController to be owned by RootUICoordinator as well 3) More safely inject ToolbarManager to CustomTabToolbarCoordinator; previously, this had an implicit ordering dependency 4) In a follow-up, move feature-specific IPH out of ToolbarManager Bug: 865801 Change-Id: I72e5476477b4f3897962bb71e37b802f7809b0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874569Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#714642}
-
James Hollyer authored
We had turned it off because the tests were leaking memory. They are not leaking anymore so I am turning them back on. Bug: 969160 Change-Id: I9b61f4f4f71010778e95b54a18881147c9eaf777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900435 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714641}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer3. Bug: 1022215 Change-Id: Iee652ed3477175346f99c7a490d1637e754644ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907413Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714640}
-
James Cook authored
Also rename WizardController::ForceOfficialBuildForTesting() to ForceBrandedBuildForTesting(). "Branded" controls Google Chrome vs. Chromium. "Official" controls compiler optimizations. This doesn't change behavior, just makes tests clearer. Bug: none Change-Id: Ibbd6561a8970366aa38288da510e9636e5d69fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912657 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714639}
-
Christopher Grant authored
This change does the following: - Allow disambiguation of which APK(s) should be used for decoding by adding an APK directory override argument to stack.py. The alternate directory is also handy if using bundles, where the APK files need to be generated from an .aab file. - Augment Clank binary wrapper scripts with a "stack" command, effectively acting as a stack.py wrapper that points stack decoding at only the relevant APK files (as opposed to a typical stack.py invocation, forced to look at out/../apks/, which may contain many APKs). - For lines in the trace that already have symbols, but cannot be decoded by the script (ie. lines from on-device Android runtime libraries), don't print <UNKNOWN> - fall back to the symbol given in logcat instead. Bug: 1015159 Change-Id: Ib65b82f3a6d85e79f61c8381b3aa1828f7214a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903926Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#714638}
-
Gang Wu authored
Change-Id: I4b585e3498b97709277928dc1b91ede72e7fa61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906339Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Kevin Marshall authored
If an executable is run with "-d" and either the flag --fuchsia-out-dir or the GN arg default_fuchsia_build_dir_for_installation are set, the runner script will publish to the Fuchsia output directory's Amber repository and rely on an existing instance of "fx serve" for delivering the package to the target. Encapsulates Amber repo interactions into a new abstract class, AmberRepo. Adds two concrete classes, one for ephemeral repos (used by emulator runs), and one for external repos (used for publishing to devices or persistent Fuchsia AEMU instances.) Bug: 1022002 Change-Id: Ieb330dd8cd92239c1c5341741ef559483af3285b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907488 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714636}
-
W. James MacLean authored
This CL started out as a re-implementation of WebPluginContainerTest.PluginDocumentPluginIsFocused to work without BrowserPlugin, but in the process I realized that we had regressed the behaviour that was originally fixed in https://codereview.chromium.org/1389093002. That regression is also fixed in this CL. Bug: 1019360, 536637, 1022469 Change-Id: I25bbe47fb602b8a3ef5d9be931e7d5fe486c4008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903653 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714635}
-
Lan Wei authored
Because now we can support that adding pause action for the key and pointer source type, https://chromium-review.googlesource.com/c/ chromium/src/+/1900650, we should check all the pause duration in every tick and get the maximum value and sleep for the maximum amount of the pause value at the end of every tick. Bug: 1020674 Change-Id: I25f992731cd1d982d5fedcf657e72aa3e7ecd7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910816Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#714634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2bd2d85f65e8..dcc910a2095d git log 2bd2d85f65e8..dcc910a2095d --date=short --no-merges --format='%ad %ae %s' 2019-11-12 srte@webrtc.org Adds simulated TCP message route for testing. 2019-11-12 titovartem@webrtc.org Add ability to specify custom video source for PC framework. 2019-11-12 ilnik@webrtc.org Revert "Reset RtpFrameReferenceFinder on long pause" 2019-11-12 thaloun@chromium.org Don't leak device moniker when BindToStorage fails. Created with: gclient setdep -r src/third_party/webrtc@dcc910a2095d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/143372501 Change-Id: Id599398aa3d94b407a555bc6ca3f091ee9b81cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714633}
-
James MacLean authored
This reverts commit fc5589ac. Reason for revert: compile failures on fuschia-x64-dbg https://cr-buildbucket.appspot.com/build/8896967608768520752 Original change's description: > [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager > > This change adds functionality to the Accessibility Bridge: > * Listens for change in AccessibilityMode from Fuchsia > * Gets the semantic tree from Chrome accessibility and sends it to the > SemanticsManager > * Sends live updates when nodes are added, updated or removed > > To send updates, this change includes the following: > * Creates a ViewRefPair and registers it with the SemanticsManager > * Initialize an AccessibilityBridge > * Listen for changes in the Chrome Accessibility tree, serializes them > to Fuchsia data structures and sends that data to the Fuchsia > SemanticsManager > > Testing: Added AccessibilityBridge browsertests. > > Bug: 973095 > Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171 > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714588} TBR=dtseng@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org Change-Id: If2774f0bc5d9a27dc8ba5af3ee00c608e0f6b786 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913211Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714632}
-
Quinten Yearsley authored
This has been dead code since the LUCI migration. Bug: 1002702 Change-Id: I6410a979d121bfec9867d3663000d65c86e2329a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909274Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#714631}
-
Alex Chau authored
- Return nullptr key when local sync is enabled and avoid DCHECK Bug: 1023827 Change-Id: I73fac96233ff0b17611b8d0ffb150d9977417d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911218 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714630}
-
Ryan Hansberry authored
Update accessibility name of Smart Lock icon when the Chromebook can be unlocked via Smart Lock, and update accessibility name of password field to communicate to a11y users that they can unlock by simply pressing Enter. Fixes: 1007036 Change-Id: Id65ceaa44428946afb3321c11c863c08954b38d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905049 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714629}
-
Hazem Ashmawy authored
Bug: N/A Test: compile and manually tap UI elements to copy Change-Id: I69690788734f627cd24adff8eb8309817fe0eba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911753 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#714628}
-
Sarthak Shah authored
When tracing category "disabled-by-default-viz.surface_id_flow" is enabled, if the value of local_surface_id_allocation is not set on visual_properties via RenderWidgetHostImpl::GetVisualProperties, tracing code throws an error resulting in crash. This CL fixes this issue by returning default value for LocalSurfaceIdAllocation if it is not set by RenderWidgetHostImpl::GetVisualProperties. Bug: 1022882 Change-Id: I45df560ff35d3f0c51f7c716a5f5fadfd50b5c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906940Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714627}
-
Mei Liang authored
This CL adds strings for closing suggestion, and suppresses the un-used resources error util the strings are being used in code. Change-Id: I636a6262064c6f0938955ac651de9d8a3272b38b Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902441Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714626}
-
Elly Fong-Jones authored
Whether this control creates a footnote view or not (and the state of the footnote view if it does create one) depends on several pieces of state in the controller, some of which are only present after the controller's ShowPrompt method is called. This change therefore: 1) Changes ShowPrompt to take a factory callback that manufactures the concrete View class 2) Invokes that factory callback once all the state needed for the View is ready 3) Moves creation of the View's footnote view into the View's constructor, now that all the needed state is guaranteed to be available. This change exposed a bug in the tests: the production code passed ownership of a raw pointer in for the View, but the tests instead retain ownership and pass in a weak raw pointer. This happens to work because View tolerates being destroyed while still parented, but this behavior of View is deprecated. I have not fixed this test behavior in this CL to keep the size down. Bug: 1011446 Change-Id: I1ad6f12cc59b2f77c75ac81b13f41eae67738205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907069 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714625}
-
Scott Violet authored
moves weblayer/shell/android/javatests to weblayer/browser/android/javatests My plan is to move weblayer/browser/java into this directory next. BUG=none TEST=none Change-Id: If442c9ebe6204a26038585e4fa53875c866a1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910814 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714624}
-
Mike Dougherty authored
Additionally add a boolean parameter to [ChromeEarlGrey reload] to make the wait after the reload optional based on the parameter value. Bug: 987646 Change-Id: I2d6aecf5ed34274b256c66a0b9504cd9a2799992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909710 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#714623}
-
Elly Fong-Jones authored
This change: 1) has FlagsState take (and internally store) its set of FeatureEntry as a base::span<FeatureEntry> rather than a (FeatureEntry*, size_t) pair, and rewrites all iterations over the set of FeatureEntry to use new-style for loops. 2) introduces FlagsState::Delegate for users of the component to customize the behavior of FlagsState, and replaces existing uses of the exclude predicate with uses of this delegate. This is a preparatory refactor for the work to show flag expiration milestones within the flags UI. As that work proceeds FlagsState::Delegate will gain new methods. Bug: 1020637 Change-Id: Ia61abb4ba7fe42df874a9089531be69f5b076fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912419Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714622}
-
Lambros Lambrou authored
This adds a PermissionWizard::Delegate implementation which runs the Me2Me or IT2Me binary with a command-line for checking permissions. This can be used to create a PermissionWizard which checks the permissions on either the ME2ME or IT2ME host. Bug: 1015201 Change-Id: I24f24e5b1928608bbf310b33a6802db86c9f80bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903934Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714621}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f647b1bf9a4..4f023f565a61 git log 3f647b1bf9a4..4f023f565a61 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 syoussefi@chromium.org Enable passing end2end test Created with: gclient setdep -r src/third_party/angle@4f023f565a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: Iefb86174c64e27f4aa840c26ddded31fdabfb86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912680Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/197a5725f2fe..e2f83aa33d88 git log 197a5725f2fe..e2f83aa33d88 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bclayton@google.com Regres: Add workaround for Khronos Gitlab issues Created with: gclient setdep -r src/third_party/swiftshader@e2f83aa33d88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I90b9bc330d5c4eaa1e129037a1db0a63fade4c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911706Reviewed-by:
-
Bettina authored
Renaming leaked credentials table to compromised table because password protection will be using the same table to store phished saved passwords. This depends on cr/1888392. Bug: 1015671 Change-Id: I394c2d4e722bb43d146df815de70fe2040e08f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888782 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714618}
-
Daniel Rubery authored
This CL extends the following metrics: SafeBrowsing.FileTypeUpdate.ResourceBundleResult SafeBrowsing.FileTypeUpdate.DynamicUpdateResult These have been added to Chirp alerts, since they indicate problems with the FileTypePolicies rollout. In order to debug these alerts, the following metrics have also been extended: SafeBrowsing.FileTypeUpdate.ResourceBundleVersion SafeBrowsing.FileTypeUpdate.DynamicUpdateVersion The following metrics were obsoleted, since they are not being used, and are not useful in case of an alert: SafeBrowsing.FileTypeUpdate.ResourceBundleTypeCount SafeBrowsing.FileTypeUpdate.DynamicUpdateTypeCount Fixed: 988663 Change-Id: I0ff456bf2fbbbe018781c39824fa3aa59b711252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895387Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714617}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cfc9c6e322f4..eac7382eb232 git log cfc9c6e322f4..eac7382eb232 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@eac7382eb232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I48444a9347eb83e7c3db923408a32805e8f46888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911665Reviewed-by:
-
Aga Wronska authored
Status reporting refactoring that landed recently makes it only relevant for child users. Rename to ChildStatusReportingService to reflect that. Bug: 1022231 Change-Id: I6a6763fc977eaf572bee9ec27eb90b76030c75a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910700Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 82 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-10. Change-Id: If195f3ab7c1a13f8adb22add5a9e0f3aff7e1bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911104 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#714614}
-
Oksana Zhuravlova authored
Change-Id: I38f6d8e4756e9da69f733e0b6a356ef9a7cd9082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909816Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714613}
-
Christoph Schwering authored
* Removed autofill-inl.h. * Moved FindByContents() from autofill-inl.h to personal_data_manager.cc. * Replaced functor structs with lambdas: - IsEmptyFunctor - FormGroupMatchesByGUIDFunctor - FormGroupMatchesByCompareFunctor * Fixed that IsEmptyFunctor, FormGroupMatchesByGUIDFunctor used copies instead of references to std::string. Since FormGroupMatchesByGUIDFunctor was instantiated for each element, this should save many unneeded allocations. Bug: 1007974 Change-Id: I68bdced7819cb439dd9c6f5af9d67304f1c19ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900995 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#714612}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c85c137c5de6..1afa8b609752 git log c85c137c5de6..1afa8b609752 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 nigi@chromium.org Fix rendering issue regarding Type2 CIDFont with illegal CIDToCIDMap. 2019-11-12 nigi@chromium.org Add a pixel test for PDF with illegal CIDToGIDMap stream. Created with: gclient setdep -r src/third_party/pdfium@1afa8b609752 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I2bf09dc30eb122f5a6987dc7065dd9794e64a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912679Reviewed-by:
-
Regan Hsu authored
Currently, when the device screen width is too small, associated preview wallpaper buttons are chopped. This CL ensures that they are not, and keeps the preview navbar centered with css instead of js. Before screenshot- https://screenshot.googleplex.com/GEmgWH8EPu3 After screenshot- https://screenshot.googleplex.com/e3icCqdwX3J Bug: 1022743 Change-Id: I92f77c682a0395996066cb148d14428b21d487c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907709 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714610}
-
Robbie McElrath authored
This was accidentally removed in crrev.com/c/1880070, and causes a crash when launching the license activity. I tested the aforementioned CL by selecting "System WebView licenses" in the Settings UI, but it turns out that launches the first android.settings.WEBVIEW_LICENSE activity it finds in the system image, so it wasn't actually testing my change. This also removes an about_ui_android dependency from //aw:libwebviewchromium since that's already in //aw:apk where it belongs. Test: adb shell am start -n com.google.android.apps.chrome/org.chromium.android_webview.app.LicenseActivity Bug: 934152 Change-Id: I8115d6bd5291249da0b6c625c5f210b0d953c62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904615 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714609}
-
Dmitry Torokhov authored
This change implements PluginVmProcessTask responsible for handling Plugin VM processes form the task manager, and teaches VM task provider how to identify Plugin VMs. As pert of this Crostini's task provider implementation was moved into .../vm sub-directory, and intermediate VmProcessTask class was factored out, and CrostiniProcessTaskProvider was renamed to VmProcessTaskProvider in preparation to adding handling of Plugin VMs. Also the Plugin VM manager class was adjusted to accept VM name when stopping a Plugin VM. Bug: b:144190453 Change-Id: I23f6cef063e4877dcdb2498fbd7064d93a766f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907711Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#714608}
-
Yuchen Liu authored
Disable the test to unblock PoG. Bug: internal b/143135800 Test: None Change-Id: I61b63dde2177dbcb687dce97d08fb0b2cd68f18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913051 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714607}
-
