- 18 Jul, 2018 40 commits
-
-
Mark Cogan authored
This Cl fixes the spacing between the grid cell title and the close button. When setting a constant offset for a trailing anchor, a positive constant results in the trailing anchor being further in the trailing direction, so a negative constant is needed to ensure the trailing anchor is on the leading side of the anchor it is constrained to. Per UX, the offset between the label and the button is set to 4 points. Bug: 862343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I01fc0e927c281ea5b174af4126c7e44fd3fc4f7f Reviewed-on: https://chromium-review.googlesource.com/1140316Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576145}
-
Kyle Qian authored
This CL changes the constructor for CountDownLatchImpl to use a DCHECK to disallow initialization counts less than 0. An initialization count of exactly 0 is still allowed, in which case countDown() will never Signal() its WaitableEvent, and all calls to Await() will immediately return. Bug: 861813 Change-Id: Ic7807544c792be010f46ca58391a02f64ab1638e Reviewed-on: https://chromium-review.googlesource.com/1141101 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#576144}
-
Tim Zheng authored
Unfortunately some Linux apps don't abide to the desktop specification. This change add some hard coded mapping so that those apps can be identified. BUG=chromium:854911 TEST=Manually tested on a eve device. Change-Id: Id53c889d46337766b77802682d964d5e2bda85dd Reviewed-on: https://chromium-review.googlesource.com/1141055 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576143}
-
Fabio Tirelo authored
The current implementation considers that a hover on the label or the icon corresponds to a mouse exit event for the row, leading to the current row being deselected. This CL fixes that by notifying the row view on mouse enter/exit on child events as well. Bug: 861996 Change-Id: If187048b2893afb7c779f91010b7b225d0da49d7 Reviewed-on: https://chromium-review.googlesource.com/1142035Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576142}
-
David Dorwin authored
WebXRGamepadSupport remains unchanged because there are no API changes. Bug: 864810 Change-Id: Ic3f3e37f90521781a199a27444f9e696c855c2dc Reviewed-on: https://chromium-review.googlesource.com/1132385Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576141}
-
Sergey Ulanov authored
After http://crrev.com/575378 webrunner used --type=web-context argument to distinguish between web::ContextProvider and web::Context processes. This approach didn't work properly because there is a lot of code that assumes that process_type is not set (or empty) in the browser process, which corresponds to web::Context. This CL removes --type=web-context. Instead webrunner uses presense of the Context request handle in the startup info to distinguish between the two process types. Also updated ContextProviderMain() to initialize MessageLoop as it's required on all threads that use FIDL. Bug: 852145 Change-Id: I2d308c712530f5802a4783cbebcffa49fade326d Reviewed-on: https://chromium-review.googlesource.com/1141174 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576140}
-
Oscar Johansson authored
When building using jumbo, files gets merged and variables with the same name may end up in the same scope. This commit renames such varaibles to something more descriptive or file specific. Bug: 803406 Change-Id: Ia43af0d95b0693ce917722397bc23db655441c29 Reviewed-on: https://chromium-review.googlesource.com/1141579Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#576139}
-
Christian Fremerey authored
Adds a class FakeV4L2Impl for replacing the actual V4L2 Apis in unit testing. Adds a simple first test case for enumerating a single fake device. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Test: capture_unittests --gtest_filter=VideoCaptureDeviceFactoryLinuxTest Bug: 768887 Change-Id: I7db4bed17453c4636158b9660ad1a5da4d74781c Reviewed-on: https://chromium-review.googlesource.com/1123021 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576138}
-
Oscar Johansson authored
Specifying what subclass of NSView being called, in this case BubbleView. Bug: 803406 Change-Id: Iabc0a02ab17a881993f34b9c120978ca7f45264c Reviewed-on: https://chromium-review.googlesource.com/1141879Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#576137}
-
Thomas Tangl authored
Changes: - String update for footer in privacy section - Minor string tweak for Autocomplete setting title - Update text for "turn off sync" confirmation dialogue - String tweak for activity and interactions Bug: 864755, 864752, 863965, 863934 Change-Id: Idf94963717f54832be123f4c575178c9d2399298 Reviewed-on: https://chromium-review.googlesource.com/1141868 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576136}
-
Sammie Quon authored
This reverts commit b8738136. Reason for revert: crbug.com/863795 Original change's description: > overview: Fix crash with hiding title bars on entry. > > Using OnCompositorStarted does not work for overview anymore. See stack > trace in bug. > > Test: manual > Bug: 863795, 843851 > Change-Id: I3dc8965cbece03ac36f1dc404c9b19b7dcac5b5e > Reviewed-on: https://chromium-review.googlesource.com/1138737 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575447} TBR=oshima@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863795, 843851 Change-Id: Ibc5965bc51a62e08b44d034a81f6954b8e799cad Reviewed-on: https://chromium-review.googlesource.com/1142166Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576135}
-
Koji Ishii authored
By reviewing the results of build 8070. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I10cd2eeea7aa6098d868ebf858c68d1ddcde2ccc Reviewed-on: https://chromium-review.googlesource.com/1142052 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576134}
-
Dale Curtis authored
This allows things like resolution, codec, and decoder changes to avoid finalizing UMA watch time, while preserving a somewhat similar finalization for UKM. This is becoming more important as we move into a multi-codec world since we don't want every secondary property change to cause a loss of UMA watch time (see linked bug). Similar in the sense that secondary property updates will flush the current watch time values outside of the normal timer driven updates and skip the finalize step if one is pending. The next timer update would finalize or update as normal, we've just added an extra update in between. Bug: 779192 Test: new unittests. Change-Id: Ica4479e763ca3ea2cf51595bed24a3078ec199c6 Reviewed-on: https://chromium-review.googlesource.com/1123688 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576133}
-
Mark Pilgrim authored
Bug: 844947 Change-Id: Iab736aaeffc70816f803a30d09bf65d712802134 Reviewed-on: https://chromium-review.googlesource.com/1135591 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576132}
-
Robbie McElrath authored
One of the tests starts a request that will repeatedly retry itself on failures, with backoff. The test asserts that the delay has a certain value, which is effectively the same as asserting that the request is on a certain retry attempt, but sometimes the request has time to retry more than once before the test assertion occurs. This changes to assert to not expect a specific value, just one that's larger than the default. Bug: 864797 Change-Id: Ia8fced88b119f724bb2e2c93602ed6034b0b87d1 Reviewed-on: https://chromium-review.googlesource.com/1141299Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#576131}
-
Lei Zhang authored
Fix some nits as well. Change-Id: I8340ee189d751643a74841ef826fd2df2b8884b5 Reviewed-on: https://chromium-review.googlesource.com/1141107Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576130}
-
Koji Ishii authored
The 'text-justify' property was implemented under the runtime flag but currently there are no active plans to ship. This patch skips tests for the property. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iccbdf6087be326c934ab5dbdde965c9b2a12b4ac Reviewed-on: https://chromium-review.googlesource.com/1142051 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576129}
-
Yue Li authored
Show Assistant UI on flow completion if relaunch parameter is set. Bug: b/111406040, b/110847784 Test: Manual Test Change-Id: I86c02bc90de7a4e797c1c57c7fd9fdab8b1b0cf0 Reviewed-on: https://chromium-review.googlesource.com/1139183 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#576128}
-
Peter Boström authored
This reverts commit 8025aa7e. Reason for revert: Inadvertently affects the attached bookmarks bar. Original change's description: > Changed kBottomMargin of the detached bookmark bar from 4 to 2 pixels. > > This makes the detached bookmarks items vertically centered. > > Bug: 863697 > Change-Id: Icf6529ec0b33255dc8072d5bfacc2f32b0495f93 > Reviewed-on: https://chromium-review.googlesource.com/1139191 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575746} TBR=bsep@chromium.org,cyan@chromium.org Change-Id: I9381f0796b85cd658d2101981e3a1ef7071fb4ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863697 Reviewed-on: https://chromium-review.googlesource.com/1142168Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576127}
-
Becca Hughes authored
It looks like standalone apps will still show the system UI (and should) so they will be blocked by the Android OS from extending into the display cutout. Therefore, we should not give them default control of the cutout BUG=859241 Change-Id: Ie26d41fe983c1f45e4177676a3f936a03ca3a07c Reviewed-on: https://chromium-review.googlesource.com/1134080 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576126}
-
Justin Cohen authored
Conditionally set IDEBundleInjection and libXCTestBundleInject.dylib based on Xcode version. Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2a13fd1e93cbe87e80b045c1d3010f518a6ed862 Reviewed-on: https://chromium-review.googlesource.com/1141276Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576125}
-
Becky Zhou authored
+ Change color for icons from google_grey_600 to v2 Grey 800 + Add custom attribute for tinting preference icons set from XML + Update icon color for Download spinner and location dialog Bug: 834884, 863519 Change-Id: I7c9b61ad8983ef0fa01ad69065bdfe0b3baafa23 Reviewed-on: https://chromium-review.googlesource.com/1141128Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576124}
-
tmartino authored
This CL fixes an undesired interaction between the rounded corners and the scroll view in the new dropdown. Specifically, we observed that the clipping path was not being respected on Mac when applied to the contents of the scroll view. This is fixed by applying the existing padding outside, rather than inside, the scroll view, so that the region being clipped is guaranteed to be non-scrollable padding. (n.b.: the padding calculation ensures this is at least as much as large as the corner radius.) This also introduces a minor visual change in the scrolling case only, as the padding above and below the suggestions no longer scrolls along with the suggestions. Besides fixing the clipping bug, on platforms other than Mac this also ensures the top of the scrollbar does not get partially clipped. Change-Id: I6ef7319db094ec66b64859df64031f6330dd567c Bug: 863930 Reviewed-on: https://chromium-review.googlesource.com/1140913 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576123}
-
Tommy Nyquist authored
The action happens whenever the DownloadActivity is resumed, which can happen multiple times when it is triggered. This leads to the dashboard being cluttered with many of these events, that are not really helpful notions of user actions. BUG=786102 Change-Id: I534d2fa8f147281b619f8f10085a0aab8e3815bf Reviewed-on: https://chromium-review.googlesource.com/1138723Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576122}
-
Matthew Cary authored
This adds mojo/edk initialization to media/gpu/video_decode_accelerator_unittest. This is necessary for future changes that use mojo machinary for shared memory manipulation. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6d04891a4d306f7c458eb2bb4ce3fd42a1b77759 Reviewed-on: https://chromium-review.googlesource.com/1122095 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576121}
-
Kevin Bailey authored
Bug: 780835, 853929 Change-Id: I9f5018fa6522d76ab7a8c57b635b084764f482db Reviewed-on: https://chromium-review.googlesource.com/1142129Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576120}
-
Jacob Dufault authored
Bug: 858858 Change-Id: Ie3dbc2e390e1f1432c58ed18d821c57ea6e1f908 Reviewed-on: https://chromium-review.googlesource.com/1140751Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#576119}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: Icfc48871f853797a15de7c50f247dc5400eab77f Reviewed-on: https://chromium-review.googlesource.com/1095985 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576118}
-
Sky Malice authored
Bug: 831648 Change-Id: Ibaca5b3501997d0c4538a9d8a79ae6050c10ec01 Reviewed-on: https://chromium-review.googlesource.com/1131692 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#576117}
-
Vasilii Sukhanov authored
When there are saved credentials on the page we should suggest them on any password field. If the field is eligible for generation we append it to the end of the suggestions. A screenshot is attached in the bug. Bug: 859495 Change-Id: I614faa89037074345794cd4107c8801f715142f4 Reviewed-on: https://chromium-review.googlesource.com/1140718Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576116}
-
Tommy C. Li authored
This CL has no behavioral changes and is a name clarification only. 1) kRichSuggestionMarginHeight => kRefreshTwoLineRowMarginHeight We are using this margin height for all two-line suggestions, which include tab-switch suggestions and old-style answers in addition to rich entity suggestions. This rename makes that explicit. 2) "Split" suggestions => "One-line" suggestions. We originally named these split suggestions because the title and URL were split by a hyphen. However, since we are calling two-line suggestions "two-line", I think calling these "one-line" suggestions would be most clear. Bug: 863982 Change-Id: Id56f6798c9a609276bbd0b0de5e565a3cf2cd475 Reviewed-on: https://chromium-review.googlesource.com/1141207 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576115}
-
Jacob Dufault authored
Bug: 864270 Change-Id: I8bdcbfa8f9d3a84776a08cb1e39d609a77ba08b0 Reviewed-on: https://chromium-review.googlesource.com/1141091 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576114}
-
Xiaoqian Dai authored
It was introduced when rebasing this refactoring CL https://chromium-review.googlesource.com/c/chromium/src/+/1134503. Previously it was rebased against a child branch (which was later discarded), then then rebased against master branch, but some changes from the child branch remained. The CL reverts the changes that's introduced by the child branch. The refactoring CL should not do any functionality changes. Bug: None Change-Id: I05af1fd5fc61be4f357106ae58404f9a2d2f5b0d Reviewed-on: https://chromium-review.googlesource.com/1141112 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#576113}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12b0170b4dcd821a4b7026bbfb968b7347a48d5e Reviewed-on: https://chromium-review.googlesource.com/1142196Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#576112}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5dbb0c3db56a..dc97fdc23571 git log 5dbb0c3db56a..dc97fdc23571 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 robertphillips@google.com Fix Valgrind skinning bug 2018-07-18 caryclark@skia.org fix bookmaker 2018-07-18 senorblanco@chromium.org GrTessellator: fix overlap outer boundary winding. Created with: gclient setdep -r src/third_party/skia@dc97fdc23571 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863389 TBR=bungeman@chromium.org Change-Id: I26bc0a79b28a21c9f653586280e7cb42102ecfe8 Reviewed-on: https://chromium-review.googlesource.com/1142004Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576111}
-
Alexander Semashko authored
Now it will quit the message loop immediately after receiving the notification. Also it does not allow nested tasks anymore. Bug: 668707 Change-Id: I8d8a0ffb073236c3bbd00877bd48cc496b1c5036 Reviewed-on: https://chromium-review.googlesource.com/982612Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#576110}
-
Orin Jaworski authored
The "= " was getting removed from start of calculator answers but now it will be left in when new answer layout is enabled. Bug: 838733 Change-Id: Ice7bf2087cc51cd052744164018ff74f4aeb68a7 Reviewed-on: https://chromium-review.googlesource.com/1141126 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576109}
-
Charlie Ma authored
The limit of this implementation is unintentional launch, e.g user click some notification and go to external activity and then go back, it will also be counted. Solution is create a histogram of launch type, if majority if launches come from hitting Chrome icon, then the noise have less impact to the accuracy of daily launch count histogram. Bug: 806240 Change-Id: Iec367758267bba806b4ed2c34c9e030e0ec65909 Reviewed-on: https://chromium-review.googlesource.com/1103838Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Charlie Ma <charliema@chromium.org> Cr-Commit-Position: refs/heads/master@{#576108}
-
Aldo Culquicondor authored
Bug: 837334 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5724d2c97e663afb5b2dc0ee9ad994a81db2052 Reviewed-on: https://chromium-review.googlesource.com/1138645Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576107}
-
Yafei Duan authored
Removing the isNewTabPageUsedAsHomepage from HomepageClient interface, since it can be combined with isHomepageEnabled and was only used in a check on native side along with isHomepageEnabled. So those two methods are combined on Java side to make interface simpler. Bug: 862786 Change-Id: I32f112590afe206da8d3d2264e36202d8cf2b9ed Reviewed-on: https://chromium-review.googlesource.com/1140691Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#576106}
-