- 13 Aug, 2019 40 commits
-
-
Thomas Tangl authored
This CL removes code paths of unused bubble view modes in ProfileMenuView and refactors related code. Bug: 966388 Change-Id: Icece4828989c61d8be9ac85de27874d934fa92ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751788Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#686449}
-
Lijin Shen authored
Update the color palettes so that Incognito and Dark mode share some same colors, including toolbars, text and icons. Bug: 985064 Change-Id: I512cfecf6774883bba935a20d56b03df8d2143a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742517Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#686448}
-
Shaojiang authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c267899484ba..7e90794dfac8 $ git log c26789948..7e90794df --date=short --no-merges --format='%ad %ae %s' 2019-06-24 alanlxl power_manager: Remove kScreenDimImminentSignal and kDeferScreenDimMethod 2019-07-15 zuan cryptohome: Add calls for obtaining RSUDeviceID to UserDataAuth and proxy 2019-08-02 victorhsieh system_api: rename BOOTLOCKBOX_ERROR_CANNOT_READ 2019-07-11 sjzhong system_api: Add AddDataRestoreKey and MassRemoveKeys in dbus-constants.h. Created with: roll-dep src/third_party/cros_system_api Bug: 977321 Change-Id: Id32afe66517a243302b90f7b1b182709e22b7562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750930Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Shaojiang Zhong <sjzhong@google.com> Cr-Commit-Position: refs/heads/master@{#686447}
-
Javier Ernesto Flores Robles authored
Use dynamic colors instead of static ones. Bug: 976675, 991209 Change-Id: I5750a55eb00de7ae510c9561c7bace2f1fac63c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749089 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686446}
-
Javier Ernesto Flores Robles authored
Looks like the original bug is fixed in MDC and these lines now are causing the opposite bug. Bug: 767428, 992935 Change-Id: I5604d5fdfd7b8225e4ef0cfd2a3eec629ff1d835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751329Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#686445}
-
Sigurd Schneider authored
Change-Id: I5022809873bb40787087d4b62d5cc3a412170a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751726 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#686444}
-
Yasmin authored
Bug: 988461 Change-Id: I2a4c6e5f64643db8349aaad4d54f15ac5961253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751790 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686443}
-
Mitsuru Oshima authored
Ash.WindowCycleController.CycleTime Ash.WindowCycleController.SelectionDepth Also added expiration date for other two to revisit on ms79. Bug: 975391 Test: NOne Change-Id: I1fa1ebebf85cf5f03e794c5cfec04567fe40b137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707551 Commit-Queue: Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#686442}
-
Christopher Thompson authored
Ask has confirmed that the suggest URL we had in our list is for legacy use only now and given us their new URL. (This new URL matches the hostname in the certificate served if you attempt to load the old URL over HTTPS.) Manually testing of the Baidu suggest URL shows that it now supports HTTPS, so this also updates it to use HTTPS in Chrome. Bug: 869453 Change-Id: I5f520f5e9abe0d08195d273847103757dd0309ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747980Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#686441}
-
Bruce Long authored
For Windows spellcheck, adding/removing word via language settings page should commit to platform custom dictionary. Fix is to make same calls to spellcheck_platform::AddWord and spellcheck_platform::RemoveWord that are performed when adding or removing a word using the spelling context menu. Bug: 993072 Change-Id: I97f9c91c0f5dfdce475f2f9e09fefc98efd44b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750105Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686440}
-
sczs authored
Bug: 979673 Change-Id: I82df2334bff60dd2867e336f7f7a89f9163ebd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750044Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686439}
-
Yuki Shiino authored
Exposed(A B, C D) is supported, but Constructors are not. Constructors will be supported separately. Bug: 839389 Change-Id: Ibc000c0c454478e006daa02a7246deae52da3f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752263Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686438}
-
Robbie Gibson authored
This CL also replaces the old uses of the Apple system colors with the Chrome-specific text colors. Bug: 976641 Change-Id: I1520252177ea0f12d18cd97d8b808e70af56b0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751330Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#686437}
-
Andrew Grieve authored
Change-Id: I3563d2fd96365635d9f9f623cddfb7dd5c881cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749003Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686436}
-
Caleb Raitto authored
Since the TestUrlRequestCallback used by the test uses the default encoding [1], the tests that use it should as well. [1] https://cs.chromium.org/chromium/src/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java?l=242&rcl=6970d0e3493e5aec7c655313ef717140e68f790a Change-Id: Ibdb32319a696fd9342a231c34eb235627712252c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747251Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686435}
-
Peng Huang authored
Bug: 974359 Change-Id: Idcc3c80eda39d4c94470c7f5542fea68dc65cc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751823 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686434}
-
Thomas Tangl authored
The menu width no longer depends on the Dice state. The Dice menu width is always used from now on. Reasons: - The pre-Dice menu works perfectly with the Dice menu width. - pre-Dice users are a very small percentage of users. - pre-Dice users will soon be migrated. Bug: 966388 Change-Id: I0721a0f7d2f56891ad9d01c99bce77505b3b9779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751842 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#686433}
-
Eugene But authored
This change is made because all subdirectories of ios/web/public represent features, while web_state subdirectory is class name. The move proposal was discussed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit TBR=blundel@chromium.org Bug: 942244 Change-Id: I0cd8cfc540ccf22335bde366bc9d1de3f5aeef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748085Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#686432}
-
Joe Mason authored
Also adds a presubmit check in //chrome/chrome_cleaner to make sure no BUILD.gn files are added to subdirs without an explicit visibility declaration. This is a safety measure to ensure that changes to the //chrome/chrome_cleaner directory won't affect anything else in chromium. R=vakh Bug: 985787 Change-Id: I8185a74542bea3bb96df31144c1d5a641de4a527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749529 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#686431}
-
Christos Froussios authored
When PasswordStoreDefault initialises the LoginDatabase, if the step fails, it will set the database to null. In that case, PasswordStoreX should not attempt to perform a migration. Bug: 991213 Change-Id: Id31a65b228532c1206283f6af175f339efbb292b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746167Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#686430}
-
Takuto Ikuta authored
This is followup for https://chromium-review.googlesource.com/c/chromium/src/+/1750477 Change-Id: Ib1151a14b482d015985e5d0bc4f5cb00898dfafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752262 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686429}
-
Mike Frysinger authored
Python 3 moved StringIO.StringIO to io.StringIO. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I2e6c19c5009a1bf77ca427b94272ba475d96861e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700506Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686428}
-
Nick Burris authored
This fixes a bug with ChromeOS touchpad scrolling where a fling scroll is initiated even if the scroll events are consumed. Fling scroll events are not cancellable so this results in a fling scroll happening at the end of a consumed touchpad scroll, as demonstrated on https://jsfiddle.net/kuqhjem4/. Bug: 894223 Change-Id: I38f9f3ba3b6651540c26304832fc662b6d72a5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733575 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686427}
-
Kevin Babbitt authored
Narrator frequently calls ExpandToEnclosingUnit() for page or document units when moving by words. This call was accounting for a sizable fraction of each movement step, and about 56% of it was spent creating the start and end positions. Switching to tree positions to find them eliminates almost all of that cost. Bug: 928948 Change-Id: I447aae5f089a27d041c2b173b16bf40629cb64ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745547 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686426}
-
Yann Dago authored
Bug: 990538 Change-Id: I8707e2b3dbf4083460f4e5bbe52b35d95bd26b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746646Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#686425}
-
Navid Zolghadr authored
This CL sends scrollend event if GSE is being handled on the main thread after the snap (if the snap has started after GSE). It also takes care of sending scrollend event for snap after fling. This CL is exactly the same as previous CL that got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1743253 with some modification to the test and input injection instrumentation to solve the leak bots. TBR=bokan@chromium.org Bug: 907601 Change-Id: I02f501573cb2021473df0b36f4c512b82e617fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749790 Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686424}
-
Chris Mumford authored
This CL moves the "Android WebView and the UI thread" document at: https://docs.google.com/document/d/1sDMN-K4TPh8osNBt-4ANfhf9FrRWl3xxrGRp7O-hkB8 into Markdown. Bug: None Change-Id: Ia33d68f92b881485c43b7a7dcfab37f8cfabf258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746488 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686423}
-
Rouslan Solomakhin authored
Originally landed in: https://crrev.com/c/1687795 Reverted in: https://crrev.com/c/1746959 Reason for revert: Use-after-free of browser context. Fix in reland: Store service instance group token in the callback and map that to the browser context when necessary. If the browser context has been freed, the mapping will return a nullptr. Bug: 980249, 992285 Change-Id: I8a92dd448cc81c940cb18bc9596f6af3329aee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749982Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686422}
-
Dominik Röttsches authored
Additional underline tests from Mozilla testing offset and thickness. Bug: 785230 Change-Id: Iabfbf884beb1d827f27cee82acef2743d5bc5bf2 Tbr: schenney Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751727Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#686421}
-
Mohamed Heikal authored
aapt2 optimize --enable-resource-path-shortening is non-deterministic in the latest aapt2 release. This is has been fixed in aapt2 ToT. Also add myself as an OWNER to the package. Bug: 753402 Change-Id: I356b123251130601c1746dbe5c2fad791cdfbf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749847Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#686420}
-
Makoto Shimazu authored
Previously it doesn't care about the throttles, but it means the update requests will be missed from the embedder. This CL is to use ThrottlingURLLoader in ServiceWorkerSingleScriptUpdateChecker, and also this makes ServiceWorkerNewScriptLoader be able to inherit the throttling loader if it's resuming a cache writer. Now throttles work only on the UI thread, so this CL introduces a thin wrapper to invoke method calls on the UI thread. After this CL lands, I'm going to add code to send the paused state to the renderer as a resource override so that the renderer doesn't create ThrottlingURLLoader for the request which is already using ThrottlingURLLoader in the browser process. Bug: 988957 Change-Id: I32e19d3cd7071dddc056ffdab2bfad36679d5b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728889 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686419}
-
Tibor Goldschwendt authored
This will make the modules target SDK version 29 if we build with the Q SDK. TBR=yfriedman@chromium.org Bug: b/139271004 Change-Id: I5777893c61644f4c27292d57295553352ff0cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751903Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686418}
-
Julie Jeongeun Kim authored
This CL converts SetupDevToolsFrontend from devtools_frontend.mojom to new Mojo types. Along with updating mojom interfaces, it also updates methods and members which take DevToolsFrontendAssociatedPtr, DevToolsFrontendAssociatedPtr, DevToolsFrontendHostAssociatedPtrInfo, DevToolsFrontendAssociatedRequest with new Mojo types. Bug: 955171, 978694 Change-Id: I7896a82b81b36066b5d36ca91fc86f858fd9c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748966Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#686417}
-
Roger Tawa authored
This reverts commit dd7de273. Reason for revert: See crbug.com/993369 for details. ContextMenu2/FilesAppBrowserTest.Test/checkInstallWithLinuxStateForDebianFile_DriveFs fails consistently. Original change's description: > Add integration test for Install with Linux context menu option > > Add test to ensure the "Install with Linux" context menu option is > hidden/shown when Crostini root access is allowed or disallowed by > kUserCrostiniRootAccessAllowedByPolicy policy preference control. > > Feature flag kCrostiniAdvancedAccessControls is enabled for file > manager browser tests to test this functionality which is hidden > behind the flag. > > Follow up CL to crosreview.com/1730907 > > Bug: 983997 > Change-Id: I12f70ea516528275b327525119587d0f0742a50d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738686 > Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686349} TBR=noel@chromium.org,lucmult@chromium.org,chrisgunadi@google.com Change-Id: I588c0d21861b603f972977cb34aff66a1e88dd24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752124Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686416}
-
Manu Cornet authored
Change-Id: I1e561547fe954e8516ed0daf80ccd8dcf33517c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750347 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686415}
-
Donn Denman authored
Fixes a null-dereference regression from a recent CL that added support for scrolling to a position:fixed element when there a scrollable visual viewport. Also implements GetSmoothScrollSequencer by getting it from the main frame if possible. BUG=992683 Change-Id: I75cbb7e25e1a8289e1405f01d2d9ddfafb785361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749549 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#686414}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/259645392 to client. Change-Id: Iae12415e75902d0199d84dc0e0b99714609164c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751248Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#686413}
-
Jun Cai authored
This CL changes sms dialog background color to use sheet_bg_color so that when Chrome changes to different theme, the dialog background is also changed. This is to fix the text on the dialog not visible when Chrome changes to dark theme. I uploaded some dialog screenshots when using default theme and dark theme on the issue page. Bug: 991392 Change-Id: Ib685689e7f150a09243edf9d02b61b166ea54276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749764Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686412}
-
Andy Paicu authored
This represents steps 7 and 8 of: https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj Bug: 950905 I have combined these two steps as they make a lot of sense together. 1) A new bool `obey_origin_policy` has been added to ResourceRequest 2) Based on its presence: a) The `Sec-Origin-Policy` HTTP header is set b) The OriginPolicyManager is used to retrieve the policy c) The policy is saved on the ResourceRequest 3) The OriginPolicyThrottle has all the necessary information to trigger the interstitial or allow the navigation. Change-Id: I75b4da55f01c0eff461e005a92f24b28925eef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706428Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686411}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ideec0f3a60319eee3354642074ff3be7d078b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751827 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686410}
-