GitLab

Now that Timeline uses tracing as its back-end it is time to remove old front-end implementation.

BUG=428700,344238,298188,359961,371276

Review URL: https://codereview.chromium.org/709423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

JSONArray can contain thread-unsafe Strings and thus isn't safe to be contained in TracedValue.
However, TracedValue::setArray takes JSONArray as input.

This CL removes setArray and adds ScriptCallStack::toTracedValue() that uses other thread-safe methods in TracedValue instead.

BUG=427893

Review URL: https://codereview.chromium.org/688623002

git-svn-id: svn://svn.chromium.org/blink/trunk@185034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simply passing the RenderStyle(s) to computeLengthDouble, and letting it decide
how to convert units is ugly, since the conversion factors depends on context.
(Notably font-size, where parent specified font size is to be used rather than
current computed font size).

The same applies to zoom, where we normally want to use the effective zoom
of some RenderStyle, and in other cases some alternative specific zoom.

To make matters worse, the same RenderStyle from which we produce font unit
factors, and (maybe) effective zoom, is also marked as having viewport units (if
encountered), even though the RenderStyle we want to mark is not always the same
as the one we want to produce factors from.

This patch reworks CSSToLengthConversionData to contain more specific coversion
data, instead of just forwarding RenderStyles into dark places.

CSSToLengthConversionData now consists of:

 * CSSToLengthFontSizes which knows which factors to use for em/rem/ex/ch.
   The units that only depend on FontDescription (em, rem) are always computed,
   and the units which depend on FontMetrics (ex, ch) are computed on demand.
   This is to avoid loading of fonts in cases where its metrics weren't really
   needed after all.
 * CSSToLengthViewportSize just contains the size of the viewport, and exists
   only to improve the structure of CSSToLengthConversionData. (Less params).
 * Zoom. This is the zoom used in all cases. Effective/non-effective is now
   handled by the outside.
 * (Private) RenderStyle. Only to mark as having viewport units.

This is better, because:

 * The special situation of computing font-size is now handled in the converter
   for font-size, not computeLengthDouble, which really shouldn't have to care.
 * The RenderStyle we're passing is only used for viewport unit marking, so we
   can actually pass the correct one for font-size.
 * The ... extravagant ... constructors of CSSToLengthConversionData are now
   under control.

Notes:

 * StyleResolver now calls inheritFrom on styles before setting the style on the
   StyleResolverState. This ensures that correct font unit factors are computed
   (as the Font is inheritable).
 * An extra updateFont is needed if we inheritFrom a cached style.
 * StyleResolver::defaultStyleForElement does not need to use a
   StyleResolverState anymore. A FontBuilder will suffice.

Review URL: https://codereview.chromium.org/705783002

git-svn-id: svn://svn.chromium.org/blink/trunk@185033 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425586

Review URL: https://codereview.chromium.org/693893002

git-svn-id: svn://svn.chromium.org/blink/trunk@185032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/712923002

git-svn-id: svn://svn.chromium.org/blink/trunk@185031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=235436

Review URL: https://codereview.chromium.org/704193004

git-svn-id: svn://svn.chromium.org/blink/trunk@185030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=427868
R=yurys, vsevik

Review URL: https://codereview.chromium.org/694753002

git-svn-id: svn://svn.chromium.org/blink/trunk@185029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mmap can return MAP_FAILED in some unlucky cases (e.g., a specified address was too large etc).
This CL adds a logic to handle a case where mmap returns MAP_FAILED.
Specifically, this CL tries mmap at most 10 times until mmap succeeds.

BUG=429911

Review URL: https://codereview.chromium.org/682993007

git-svn-id: svn://svn.chromium.org/blink/trunk@185028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL makes DOMDataStore receive the v8::Isolate from the caller
(creator of DOMDataStore), which should better know what isolate is
to be used.

BUG=235436

Review URL: https://codereview.chromium.org/707213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL corrects the counter values in the cases of allocation failure.

Review URL: https://codereview.chromium.org/710963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358074

Review URL: https://codereview.chromium.org/653283006

git-svn-id: svn://svn.chromium.org/blink/trunk@185025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the main thread passes a pointer of GarbageCollected object to a
HRTFDatabase thread (via postTask), the HRTFDatabase thread creates
a CrossThreadPersistent handle for the pointer. However, this is not
allowed because the HRTFDatabase thread is not attached to Oilpan.

We should attach the HRTFDatabase thread to Oilpan.

This CL removes MutexLocker from HRTFDatabase's destructor since we don't need to clear m_htrfDatabase in the destructor.

BUG=427303

Review URL: https://codereview.chromium.org/685153005

git-svn-id: svn://svn.chromium.org/blink/trunk@185024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the near future, Window.idl will be implemented as DOMWindow, not
LocalDOMWindow. Some of the custom Window bindings try to call
UsageCounter methods using Document as the reference, but DOMWindows
do not have a Document if they are remote.

BUG=425623

Review URL: https://codereview.chromium.org/707333003

git-svn-id: svn://svn.chromium.org/blink/trunk@185023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replaces ArrayBuffer with DOMArrayBuffer in core/ and modules/.

This CL is retry of http://crrev.com/708983002
Fixes Windows (64-bit) build.

BUG=235436

Review URL: https://codereview.chromium.org/711763002

git-svn-id: svn://svn.chromium.org/blink/trunk@185022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431643
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/710013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These tests consistently pass (see bug), and the bug assigned
to them was closed long ago.

TBR=dpranke@chromium.org
BUG=237270
NOTRY=true

Review URL: https://codereview.chromium.org/716483002

git-svn-id: svn://svn.chromium.org/blink/trunk@185020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, core/rendering and core/painting has no unneeded
forward references any more.

This patch also move some forward declarations into correct
header files.

Review URL: https://codereview.chromium.org/713553002

git-svn-id: svn://svn.chromium.org/blink/trunk@185019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/699053004/)

Reason for revert:
Reverting the revert. This turned out not to be the cause of https://code.google.com/p/chromium/issues/detail?id=431608

Original issue's description:
> Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/)
> 
> Reason for revert:
> Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608
> 
> Original issue's description:
> > Fix RemoteFrame detachment to signal its client.
> > 
> > We were seeing crashes in checkFrameCountConsistency() because during
> > RemoteFrame detachment the client was not getting signalled to modify
> > the frame tree, resulting in inconsistent state. This CL corrects that
> > problem.
> > 
> > BUG=430972
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987
> 
> TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=430972
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185015

TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430972

Review URL: https://codereview.chromium.org/709363002

git-svn-id: svn://svn.chromium.org/blink/trunk@185018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After issue 409435 fixes, both text and image baselines should be
better optimized across blink ports.

BUG=409435, 405803
TBR=dstockwell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/691943003

git-svn-id: svn://svn.chromium.org/blink/trunk@185017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

select() API is already supported, test cover scenarios for email, number, date, datetime-local, color and file.

While support for selection API does not exists.

BUG=415391
R=tkent, keishi

Review URL: https://codereview.chromium.org/707853002

git-svn-id: svn://svn.chromium.org/blink/trunk@185016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/)

Reason for revert:
Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608

Original issue's description:
> Fix RemoteFrame detachment to signal its client.
> 
> We were seeing crashes in checkFrameCountConsistency() because during
> RemoteFrame detachment the client was not getting signalled to modify
> the frame tree, resulting in inconsistent state. This CL corrects that
> problem.
> 
> BUG=430972
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987

TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430972

Review URL: https://codereview.chromium.org/699053004

git-svn-id: svn://svn.chromium.org/blink/trunk@185015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for changing Window.idl ImplementedAs to
DOMWindow. These should be the remainder of the methods needed by V8
bindings.

BUG=425623

Review URL: https://codereview.chromium.org/710873003

git-svn-id: svn://svn.chromium.org/blink/trunk@185013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The reason of that is a difference in URL for TempStorageSharedWorker between the host and the device front-ends
If DevTools window for a host page was opened before DevTools window for a device then the second DevTools
window will fail to run the shared worker and vice versa.

BUG=430794

Review URL: https://codereview.chromium.org/712593002

git-svn-id: svn://svn.chromium.org/blink/trunk@185012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

original search implementation had no idea about flame chart and did search only for data grid nodes.

Also there was a single search box for both types, cpu and heap.

Two separate search view were introduced in the patch.
One for cpu view, the other for heap view.

New code for search in flame chart was written.

Original code for search in cpu data grid was moved to CPUProfileDataGrid.

HeapSnapshot search implementation was slightly tweaked.

BUG=425928

Review URL: https://codereview.chromium.org/696703003

git-svn-id: svn://svn.chromium.org/blink/trunk@185011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/705373004

git-svn-id: svn://svn.chromium.org/blink/trunk@185010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bka_hQuzAu0/tjD-GhJ6zDAJ

Attribute::setPrefix() was unused and showed up in grep.

BUG=431552

Review URL: https://codereview.chromium.org/688333002

git-svn-id: svn://svn.chromium.org/blink/trunk@185009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be necessary once Push events support event.waitUntil to keep the
Service Worker alive until the Promise is resolved
(https://github.com/w3c/push-api/issues/85).

Depends on Chromium https://codereview.chromium.org/708913003
Required by Chromium https://codereview.chromium.org/707243003

BUG=430888, 401438

Review URL: https://codereview.chromium.org/709103002

git-svn-id: svn://svn.chromium.org/blink/trunk@185008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The referenced bug is caused by a composited descendant that has an opacity
animation not having the correct background painted for its ancestor that it needs
to blend with.

However, HasOwnBackingButPaintsIntoAncestor is also just an optimization to reduce
the number of composited layers that draw content, in cases where we think we can
get away with it. (e.g. only existing to pass along preserves-3d state).

In exchange for these optimizations, the feature introduces significant complexity,
and has caused a number of bugs. Let's just kill it.

BUG=418521

Review URL: https://codereview.chromium.org/708213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Creating container class for nullable union types would generate a lot of
duplications. Suppose we have (A or B) and (A or B)?. The current
implementation will generate two classes: AOrB and AOrBOrNull.
The only difference between them is whether toImpl() checks
isUndefinedOrNull() at first. To avoid duplication, this CL generates
toImpl() only for nullable union types.

This CL includes part of Jens' work[1]

[1] https://codereview.chromium.org/700093002/

BUG=240176

Review URL: https://codereview.chromium.org/698423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=430507
NOTRY=true

Review URL: https://codereview.chromium.org/709893002

git-svn-id: svn://svn.chromium.org/blink/trunk@185004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch begins the parser portion of the CSS parser rewrite. To avoid
making a copy of the CSSPropertyParser, we temporarily add a conversion
from the new CSSParserTokens to CSSParserValues. Note the runtime flag
is not marked as test/experimental, so this code is not yet being run.

This patch passes all tests except CSSPropertyParserTest.GridTrackLimits
and fast/css-grid-layout/named-grid-line-get-set.html, which will be
fixed in a later patch. The former fails due to bad handling of large
numbers in the new tokenizer, and the latter fails as the Bison CSS
parser is a bit more restrictive in handling brackets.

BUG=330389

Review URL: https://codereview.chromium.org/647483009

git-svn-id: svn://svn.chromium.org/blink/trunk@185003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It looks like this test needs to be rebaselined after the changes in
https://crrev.com/303364 are fully implemented.

BUG=384723
TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/708103003

git-svn-id: svn://svn.chromium.org/blink/trunk@185002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL will be followed by chromium side CL which will expose Ruby tag.

BUG=426893

Review URL: https://codereview.chromium.org/710663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix Runtime.executionContextCreated for crafted iframes. (patchset #6 id:100001 of https://codereview.chromium.org/686763002/)

Reason for revert:
Speculatively reverting to fix telemetry_unittests failures.

Original issue's description:
> Fix Runtime.executionContextCreated for crafted iframes.
> 
> BUG=331407
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184995

TBR=vsevik@chromium.org,yurys@chromium.org,sergeyv@chromium.org,aandrey@chromium.org,eustas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331407

Review URL: https://codereview.chromium.org/711853002

git-svn-id: svn://svn.chromium.org/blink/trunk@184999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/713613002

git-svn-id: svn://svn.chromium.org/blink/trunk@184998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we should stop testing
it so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/709193003

git-svn-id: svn://svn.chromium.org/blink/trunk@184997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536

Review URL: https://codereview.chromium.org/709803003

git-svn-id: svn://svn.chromium.org/blink/trunk@184996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=331407

Review URL: https://codereview.chromium.org/686763002

git-svn-id: svn://svn.chromium.org/blink/trunk@184995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Android has a feature where if you have headphones plugged in, the screen
reader speaks the password text as you type it. Without headphones, it says
"dot dot dot". To implement this we need to get the password out of Blink.

BUG=399043

Review URL: https://codereview.chromium.org/704363004

git-svn-id: svn://svn.chromium.org/blink/trunk@184994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch the content property parsing did
not allow comma separated values but did use comma
separated value lists for serialization. This patch changes
that behavior to always use space separated lists and
adds a test to make sure roundtripping content works.

BUG=428445

Review URL: https://codereview.chromium.org/707923003

git-svn-id: svn://svn.chromium.org/blink/trunk@184993 bbb929c8-8fbe-4397-9dbb-9b2b20218538