GitLab

This change
* completes the implementation of ResolvePrinters(),
* updates the corresponding unit tests to pass,
* fixes a bug in PpdMetadataManager::GetPrinters(), and
* fixes a bug in PpdMetadataManager::OnLocalesFetched().

Bug: chromium:888189
Test: chromeos_unittests --gtest_filter='PpdProviderTest.ResolvePrinters*'
Change-Id: I5d30a3d1bcb4db91b62551ef940813d0fde178be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315390
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792988}

Add deep links for bluetooth settings: turn bluetooth on/off,
pair device, unpair device, connect device, disconnect device.
Ensured that focusing works correctly when paired/unpaired
list loading async and handled a conflict with Focus Row
Behavior.

Bug: 1084154
Change-Id: Ib91a80ceacc7a424d657560668bbd7ff6f380b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305194Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#792987}

Using wpt-import in Chromium e4a7f92a.
With Chromium commits locally applied on WPT:
3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes"
6d63b58a "Split iceGatheringState tests into separate files & update expectations"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: I6ce4f87074530058f0b2220ee26c051b768358ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327616Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792986}

This OverviewModeController wrapper is originally introduced in
crrev.com/c/1484734 for the purpose of showing GTS correctly, then
gradually, this wrapper becomes primarily for attaching observers as
early as possible and avoiding null checks.

This CL removes the wrapper and allows other components to use the new
API, getOverviewModeBehaviorSupplier(), to attach the observers. The
getOverviewModeBehavior() method now only uses in tests.

Change-Id: Ie3fdfad94b443e7ba054d75e89c15af692df4604
Bug: 1108496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314557Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792985}

Bug: 1110487
Change-Id: I43e28b7291211b5bfe73461b14ef2b9ebb7aa62b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327843
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792984}

Construct the high-level contact, certificate, and local device
data manager instances in the Nearby Share service. Their
lifetimes mirror that of the service. Add public accessor
functions to these managers in the service.

Bug: 1093634
Change-Id: I2d0ce3189d05a0f59c42ecce432802b594b363ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316855
Commit-Queue: Juliet Levesque <julietlevesque@google.com>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792983}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3e5d86a2375a..343f63643b43

2020-07-29 robertocn@google.com [resultdb] Bump up the cipd pin of rdb in depot_tools
2020-07-29 vapier@chromium.org cros: raise python version requirement to 3.6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1110107,chromium:997354
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Test: Test: `cros_sdk` still works
Change-Id: If2b9d209603ed4363839b2287a4fa0ef04c31e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327740Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792982}

For now, there is no proper role for BlinkIsolate. So this CL deletes the BlinkIsolate class.

Bug: 1105403
Change-Id: Ifc562ae891f7233ae0e9513c7ee3a30fff293493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320289
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tal Pressman <talp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792981}

https://chromium.googlesource.com/angle/angle.git/+log/d019af80a3a9..cc846039201d

2020-07-29 cnorthrop@google.com Capture/Replay: Fix GetTexImage on Luminance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: tobine@google.com
Test: Test: angle_end2end_test --gtest_filter="*GetTexImage*"
Change-Id: I14713e7bbc30a0b25cc89255534a7ba5bdb9bdbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327656Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792980}

This reverts commit ee4eb865.

Reason for revert: Breaks ios-simulator-full-configs/25351

Original change's description:
> [iOS] Add fieldtrial config for IOSRequestDesktopByDefault
> 
> Bug: None
> Change-Id: Iea882e82e5573edaf917d8f3d976d876e2120de9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317789
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792621}

TBR=mpearson@chromium.org,gambard@chromium.org

Change-Id: I1819597f0a0a2477aebd70066c5edf732527b4e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328031Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792979}

Update chrome/browser/extensions/process_manager_browsertest.cc to
use WebContentsConsoleObserver instead of ConsoleObserverDelegate.
This allows us to observe console messages added without overriding
the existing delegate of the WebContents.

Bug: 1034150
Change-Id: I887ead0ef81b5ea8b76dbf0696c48882a2fb48cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327146Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792978}

These metrics will log user actions in the fullscreen promo modal
and taps on the NTP promo link.

Bug: 1107489
Change-Id: I310e5b57d4624c26a62613f97dd2c5ccca35b186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321840
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792977}

ClipboardData can be potentially large. Example: user opens a large
document and does Ctrl+A then Ctrl+C. This being the case, we should try
to minimize the number of extraneous copies we retain in memory to track
Clipboard history unless we have a strong need.

This CL switches the backing container of ClipboardHistory to a double
linked list. Sort order by recency is enforced at insertion time.

Also done in this CL:
- Just minor nit of removing "clipboard history" from ClipboardHistory
  members to avoid redundancy.

Bug: 1109292
Change-Id: Ib859a0df78b1f68b4de3ae4d31817d3219de408f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317714
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792976}

In the function WebFrameWidgetImpl::HandleInputEvent, it looks like not
need to check LocalRootImpl(), this patch removes it.

Change-Id: I13ff011721e748875635b8894a57501a71efeb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318893Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#792975}

Bug: 1110965
Change-Id: I22163cec177e51309e3730f5158df63b4240cf8b

TBR=ioanap@chromium.org

Change-Id: I22163cec177e51309e3730f5158df63b4240cf8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327861Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792974}

Instead of claiming success and writing 0 bytes.

Bug: 1045918
Change-Id: I729ecff8753d0486f101fdf0e801509363636a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316440
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792973}

This change saves the last time an HTTP(S) link was opened. It
will be used to identify default browser usage.

Bug: 1107489
Change-Id: I27fed2285dd42a44bbdcfa6c4043a12b4bc30e5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320079
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792972}

Currently, SkiaRenderer does not support RGBA_TEXTURE
CopyOutputRequests which are used in Chrome OS for screen rotation
animations [1] (among other things). As part of a larger effort to
enable SkiaRenderer on Chrome OS, this CL implements RGBA_TEXTURE
support in SkiaOutputSurfaceImplOnGpu::CopyOutput:

1. Refactor SharedImageFactory ownership out of
   DirectContextProviderDelegateImpl (used only for the
   use_gl_renderer_copier bypass) and directly into
   SkiaOutputSurfaceImplOnGpu.
2. Create a SharedImage and its Skia representation in CopyOutput and
   blit the request rect from the source into the output SkSurface.
3. Send the SharedImage's mailbox back through the CopyOutputResult
   with a release callback that destroys the SharedImage.
4. Enable SKIA_GL tests in cc_unittests.

[1] https://source.chromium.org/chromium/chromium/src/+/master:ash/rotator/screen_rotation_animator.cc;l=214;drc=b15cb5fd43aff2d181355401d99e47e2e44aa61f?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1046788, 971257, 1098435
Change-Id: I62d41390828ed0c79a1dc29c508efc748924ce06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302733Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792971}

Bug: 1007815
Change-Id: I1f05b1d64a821a64815c95e778b04e3ff08ca023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325334Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792970}

This allows us to be more confident we are covering a wide set of
possible Web Apps rather than having correlations in fields due to
repeated reuse of the low-entropy suffix bits.
It also makes reading/writing the test more clear (expresses more
intent and less implementation).

Change-Id: I7f7d522ebac4b25972470b524892e9a6e2ae5450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325530
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792969}

This change includes the report of number of zero-prefix
search suggestions shown to the user via assisted query stats.

Bug: 1110414, b/159807386
Change-Id: I1258961a9328b8082feb77b5da9e839b6c8c1953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324114
Commit-Queue: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792968}

Sometimes, when the unit tests finish, the icon files are deleted,
however, ArcAppIcon::ReadFile is still called, so
DCHECK(base::PathExists(path)) could cause the crash. Modify ArcAppIcon
to check the file path and whether the file exists again when read the
file to avoid crash.

BUG=1106782

Change-Id: Ida3544228f9f722646622e022ac44c5186295cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326791Reviewed-by: Long Cheng <lgcheng@google.com>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792967}

The manual calculation of label width in layoutSubviews seems to cause problems for AutoLayout and on some iPhone models, AutoLayout has to break some constraints that make the main button smaller than its content.

Removing the whole layoutSubviews method helps resolve the layout problems.

Note: Currently, the BookmarkHomeMediator uses the BookmarkHomePromoItem. It would be good to reduce code duplication by using TableViewSigninPromoItem instead of BookmarkHomePromoItem. However, that would require some refactoring in BookmarkHomeMediator.

Screenshot before the fix (iPhone 11 on the left, iPhone SE 2nd Gen on the right): https://drive.google.com/file/d/1QDTQUpcD_7YcMB6wD1CrLFCqCHun8PQZ/view?usp=sharing
Screenshot after the fix: https://drive.google.com/file/d/15iF45ZjSaMNHI4ANaTtU4TGWfYMDML3q/view?usp=sharing
Screenshot after the fix, with very long strings, both in the label and in the button, to demonstrate that it behaves like other Sign in promos: https://drive.google.com/file/d/14ckOxh5VwF-un2bKaYNwrI0fstX80aaM/view?usp=sharing

Bug: 1102043
Change-Id: Iea8ccf8a0fdc3eaeaa1f6d4176f287244168d8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313959Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Maxime Charland <mcharland@google.com>
Cr-Commit-Position: refs/heads/master@{#792966}

https://skia.googlesource.com/skia.git/+log/a40e7b77fbb1..994ce8cf2300

2020-07-29 johnstiles@google.com Add a dev tools section about debug visualizers.
2020-07-29 bungeman@google.com Create a gn link pool which is disabled by default.
2020-07-29 adlai@google.com Migrate MakeFromAdoptedTexture to GrDirectContext
2020-07-29 johnstiles@google.com Remove constexpr workarounds for no-longer-supported compilers.
2020-07-29 jvanverth@google.com Change GrRingBuffer::finishSubmit to be a finishedProc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: I2a7fc6577ae9cd7bb3993fb9a6ca056932a9d1b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327737Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792965}

Lacros will not launch from the stateful_partition if it is marked as
noexec. This is often confusing to developers. Add custom UI error
handling for developer builds.

Bug: 1107709
Change-Id: Ie766af95fc6119f1b84bfd952a72b97331715a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321778Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792964}

A popup containing an empty document (e.g. opened via: `window.open('',
'_blank')) might need to inherit its URLLoaderFactoryBundle from its
opener (or parent).  This might be problematic if the popup lives longer
than the parent, because:

1. Before this CL, inheriting the factory bundle is triggered lazily,
   on-demand.  If the opener is closed before the inheritance is
   triggered, then there is nobody to inherit from.

   This CL fixes this, by inheriting eagerly - see the changes in
   RenderFrameImpl::DidCommitNavigation.

   One additional benefit of these changes is that before this CL, the
   popup-without-opener might have been falling back to the deprecated,
   frame/origin-agnostic, always-network/http-bound factory (see
   CreateDefaultURLLoaderFactoryBundle).  After this CL, the deprecated
   factory won't be used in the scenario exercised by the test.  We
   therefore hope that the current CL will reduce the volume of DwoC
   reports tracked in https://crbug.com/1105794.

   Another additional benefit is that this CL is a step toward being
   able to DCHECK in RenderFrameImpl::DidCommitNavigation that the
   factory bundle is present and has a valid default factory.  After
   this CL such DCHECK should only be failing in a handful of unit tests
   (such as RenderViewImplTest or other tests that depend on
   TestRenderFrame).  The DCHECK will hopefully be added in a follow-up
   CL here: https://crrev.com/c/2321346.

2. Before this CL FileURLLoaderFactory owned by
   RenderFrameHostImpl::non_network_url_loader_factories_ and will be
   gone once RFHI representing the opener goes away - this will break
   the pipes that the popup might have obtained to the factory.

   This CL fixes this, by using mojo::MakeSelfOwnedReceiver in
   FileURLLoaderFactory::Clone to make sure the cloned factory's
   lifetime and mojo::Receiver's pipe lifetime is not tied to the
   original factory.  This is a short-term fix - the proper long-term
   fix is still under discussion in https://crbug.com/1106995.  The
   long-term fix will need to cover not just FileURLLoaderFactory but
   other URLLoaderFactory implementation as well.

Change-Id: I633c3e35c276a53bf7d4280ece333bb468f747ed
Bug: 1106995, 1105794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305213
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792963}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3273521f4089..986a340dd528

2020-07-29 apodtele@gmail.com Unbreak compilation.
2020-07-29 apodtele@gmail.com Hide internal functions with SunPro.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: Ie42f4f920c61260eba34d5b842a99c0e8d466afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327652Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792962}

Re-enables or provides disable reasons for all remaining PyLint
disables in the //content/test/gpu pylintrc files and fixes any
resulting warnings.

Bug: 1076144
Change-Id: Ia2732ad9063812e89f00beb6f1d36f989958b624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327180Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792961}

This CL is part of the effort to make Views default
constructible, allowing UI to be built in a declarative fashion.

* Default button listener to nullptr
* Add button listener setter
* Add unittest for setter

Bug: 1108460
Change-Id: I694acd0422b78951b1a7d17a90dcee3f8c8195d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327150Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792960}

This change updates the parsing code for Printers metadata to
accommodate the new version we are pushing from our serving root.

Bug: chromium:888189,b:161547656
Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*'
Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*'
Change-Id: I54d3cbffdbbc3e51f4e636d0a904179a05c9132f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315158Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792959}

https://chromium.googlesource.com/catapult.git/+log/14ca9390e34a..395d1d531f44

2020-07-29 bsheedy@chromium.org [Telemetry] Add screenshot retry/timeout logic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC eseckler@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1106927
Tbr: eseckler@google.com
Change-Id: I8a6425dd26b66b26c9a38b74be3b30201af16cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792958}

This change:
1. Adds a new class called UserActionMonitor. This class stores a queue
of actions and blocks all other ChromeVox execution until the actions
are matched and consumed. The initial version of the
class intercepts key presses and keyboard commands; this is done by
hooking into the CommandHandler and BackgroundKeyboardHandler.
Later iterations will listen to range changes, mouse events, gestures,
and braille commands in a similar fashion.
2. Adds some simple tests for UserActionMonitor.
3. Adds tutorial lessons for the OOBE. These lessons are geared toward
brand new users. When showing one of these lessons, the tutorial
initializes UserActionMonitor with expectations, which allows us to
provide interactive walk-throughs. The lessons cover the search key,
basic navigation, and using search + space.
4. Wires up communication between UserActionMonitor and the tutorial.
Most of this wiring is done through the panel.

Bug: 1075752
AX-Relnotes: N/A

Change-Id: I521016192929d9655234b055cc63ca6d83aa9efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253021
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792957}

Bug: 1102655
Change-Id: I59819545332a419aad616aca406385692f3fc873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327842Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792956}

Speculative fix for WindowManager$BadTokenException when trying to show
the app menu. Internally PopupWindow uses the supplied parent view to
get a window token, so check that the anchor view / it's root view are
attached to a Window in addition to checking if the decor view is
attached.

BUG=1105831

Change-Id: Ie270a6395c541a9be508f161913fb1ef79c0c74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327316Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792955}

This is incomplete as the OS version number from base/system/sys_info.h
is the Linux variant instead of the ChromeOS variant. That will be
resolved as a follow-up CL.

Bug: 1096590
Change-Id: Ibce956eeb3a5baafc0c98cf94f2fe988cb13173d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267855Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792954}

In the future, we may also consider doing this for role=switch, which
is also exposed as a toggle button for ATK/IA2. However, as of
CL:1101849 Chrome purposely exposes both pressed and checked for
role=switch toggle buttons in IA2.

announcements in NVDA with ARIA toggle buttons.

AX-Relnotes: avoid potential for superfluous announcements unchecked
Bug: None
Change-Id: Id10319e59cb39356862e7356177f21a6cadc4b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316329
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792953}

This is intended to replace the ExternalPrintServersAllowlist policy. The
old policy will still be used in the absence of the new one for at least
a few releases of Chrome.

BUG=chromium:1098046

Change-Id: I3e656555cd373a98d0dc0197fea327826720d7b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325027
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792952}

After crrev.com/c/2319540, partial invalidation is for LayoutBoxes
only, and no longer needs to combine with selection invalidation.

Change-Id: I427797f85976f24b3c4c8238437ca1e49a21d840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321051
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792951}

This is a reland of e1e445e8
with fixes for a compile error on chromeos_linux when building
with the optimize_webui flag enabled.

Original change's description:
> Split MainPageBehavior between browser and OS settings.
>
> This is a prerequisite to implement lazy loading for Polymer 3.
>
> Bug: 1045266
> Change-Id: I92c428cd2c18d6f4096ee5fbdd26ae77efb831ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321954
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Jon Mann <jonmann@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792491}

Bug: 1045266
Change-Id: Ie3e50ceb5cf23dc8e2eedf69cc7b169a790b0f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327312Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792950}

Previously, any time there was a layout, the accessibility
serialization code would scan every AXObject to see if any
needed to update their bounding box.

Instead, replace this with a mechanism that uses
PaintInvalidator to mark AXObjects that might have
dirty bounding boxes.

Existing tests already provide some coverage; if you
comment out the code in paint_invalidator.cc, a
handful of browser tests fail.

To provide even more coverage, a debug-only check
walks the entire tree and ensures that no nodes
have incorrect bounding boxes. If you try commenting
out the code in paint_invalidator.cc now, hundreds
of browser tests fail. This provides some good
confidence that it's working correctly.

Finally, add a new blink perf test demonstrating a
simple scenario where this results in a dramatic
speedup, just by focusing links in a document with a
few thousand nodes.

Bug: 1109081
AX-Relnotes: makes accessibility less sluggish on very large web pages

Change-Id: I51a89d0b37ff356c5443b324080acefe0e7f3fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319411
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792949}