GitLab

default

Follow up from CL:2086359 to ensure that the Crostini mic sharing
dialog only shows when Crostini needs to be restarted. Tests were
added to check this and the flag regarding the mic sharing settings
is now enabled by default. Note that the mic is not shared by default.

Tests: Tested mannually and expanded the appropriate browser test
Bug: 1016193
Change-Id: I4b416feedddbe4e3b7f0c5fc638701f9f809ae66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123579
Commit-Queue: Daniel Ng <danielng@google.com>
Reviewed-by: Julian Watson <juwa@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754807}

In BrowserActionsContainer::GetFlexRule() the width is clamped between
a min width and a max width. If the min width is > max width it should
still win. This CL ensures this behaviour in the boundary condition and
fixes a bug where resizing the extension icons in the toolbar to 0 would
not be able to be reversed.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439709&signed_aid=C2ncXrrBkAc-NH_GjVaSmg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439710&signed_aid=9D3JktJW8DssKm2eMOvAYg==&inline=1

Bug: 1066337
Change-Id: I6602673fdefb84ee0a3c2b1eaa728238d3175573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128039
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754806}

Add user actions for:
- The menu being opened
- The pin button being pressed
- The user activating an extension from the menu
- The user activating an extension from the toolbar

Bug: 1064111
Change-Id: I6978c1ffefcbb4171e756375e9bc9798d2674be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116583Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754805}

Tried 100 times by tools/run-swarmed.py and the test never failed,
so enable the test.

Bug:791021

Change-Id: I903fa0abd132aea10e8a2b84b7282c5476bb7487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125871Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754804}

The new web apps backend is explicitly disabled in ARC++ Kiosk mode,
which causes a crash as ApkWebAppInstallService now depends on the new
web apps backend.

This CL disables ApkWebAppInstallService when the new web apps backend is disabled.

BUG=1065655

Change-Id: I1488cb9a57e89c76e4c011f11e86349322501516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127989Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754803}

This reverts commit 1e688ea3.

Reason for revert: This CL breaks Clank build.
Failed builder: https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/21232

Compiler message:
../../components/feed/core/v2/feed_stream_unittest.cc:251:7: error: predefined identifier is only valid inside function [-Werror,-Wpredefined-identifier-outside-function]
      FROM_HERE, base::TimeDelta::FromSeconds(1)};
      ^
../../base/location.h:123:52: note: expanded from macro 'FROM_HERE'
#define FROM_HERE ::base::Location::CreateFromHere(__func__, __FILE__, __LINE__)
                                                   ^


Original change's description:
> Work toward synchronizing feed store and model
> 
> - Added LoadStreamFromStoreTask to read model data from the store.
> - Update LoadStoreTask to try loading from the store first, via the new
>   task.
> - Save operations executed to persistent storage.
> - Added some conversions to textproto for tests.
> 
> My primary goal when making this change was to save operations to
> persistent storage as they are executed. Pulling this thread led to
> several changes.
> 
> We were saving a bit too much data in the single 'stream_data' record,
> which meant we would have to re-serialize the whole model to save a
> single piece of information. I went ahead and split 'stream structures'
> out into another record. All stream structures for the stream now need
> to be read in at load time, and they need to be sequenced appropriately.
> 
> In making that change, I wanted to verify we could actually load the
> data back in. So I implemented loading a stream from storage as well.
> 
> Bug: 1044139
> Change-Id: I98767281b4a5d1ae401dba5db5bff966f3473452
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123249
> Commit-Queue: Dan H <harringtond@chromium.org>
> Reviewed-by: Ian Wells <iwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754782}

TBR=iwells@chromium.org,harringtond@chromium.org

Change-Id: I7a1955a0a4dbb76cf6d17497be63b8256218ca31
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129234Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754802}

https://chromium.googlesource.com/angle/angle.git/+log/1288aa12369e..05fa1a99914a

git log 1288aa12369e..05fa1a99914a --date=short --first-parent --format='%ad %ae %s'
2020-03-31 ynovikov@chromium.org Skip test flaky on SwANGLE bots

Created with:
  gclient setdep -r src/third_party/angle@05fa1a99914a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ie6e0c404ed94b56f14bd2ec2ef44e3b9a9f41e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129268Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754801}

In https://crrev.com/c/2119933 I added a new call to GetScrollbarTheme
which caused a number of unit tests to start crashing.

On Android, unit tests run without a ThemeEngine
(Platform::Current()->ThemeEngine() == nullptr). This means that they
must use a mock scrollbar theme, otherwise anything scrollbar
related might crash. Currently, it was possible for some tests to avoid
setting a mock theme and run successfully if they got lucky and avoided
code paths that called into the theme.

This CL adds a DCHECK when a blink::Page is created to ensure we can
access the theme. This flushed out all tests that were in this situation
and we fix them here. It also ensures future tests are made to install a
mock theme so we don't run into this situation again.

Bug: 1039501
Change-Id: I78dbf406b6168a71b67e75f09ef824b5cdc2a8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125952Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754800}

This CL moves flexitem-stretch-range[-expected].html test from
css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, and test description.

Additionally, this CL removes <p></p> paragraph because it's the
same to the assert.

Bug: 1063749
Change-Id: If2811c22ddb2d38e9bb233d8fca416c8c5f0452d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124280
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754799}

We changed find-in-page to use normal tasks instead of idle tasks in
crrev.com/c/2041711, but it's currently causing crashes. To ensure
stability in M83, we're reverting the change (but not all of it, we're
keeping the scheduler-side changes to use later - it won't affect the
revert). We'll investigate this and reland after the M83 branch point.

Bug: 1065371
Change-Id: Ib7b0db989910a5c1c0da82eea65af1ab6f617441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127998Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754798}

This CL uses the web app registrar to make DoShowAppInfoFlow extension
agnostic.

Bug: 1064877
Change-Id: I3c10831be43da207edc1d007e5f3b74891d3df84
Fixed: 1064877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124282
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754797}

https://dawn.googlesource.com/dawn.git/+log/4da46462d786..276b0652658d

git log 4da46462d786..276b0652658d --date=short --first-parent --format='%ad %ae %s'
2020-03-30 yunchao.he@intel.com Add validation tests for resource usage tracking - 4
2020-03-30 cwallez@chromium.org Fix compilation on iOS where setDisplaySyncEnabled isn't available.
2020-03-30 bungeman@chromium.org Add std:: to nullptr_t
2020-03-30 rafael.cintron@microsoft.com Call ID3D12SharingContract::Present on WebGPU swap buffer destroy

Created with:
  gclient setdep -r src/third_party/dawn@276b0652658d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I4356776b53fbc158b0c1579977c0eee36503b617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129177Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754796}

The PipelineReporter trace-events can be a bit confusing sometimes
because some child-events seem to not be parented correctly. There seems
to be at least one issue with the trace-viewer: if a parent-event has
only a single child-event, and both have the same start/end timestamps,
then the parenting seems to break.

So change how the trace-events are generated to account for this.
Notable changes:
 . All trace-events are generated at the end of the frame. This makes it
   possible to not report the child-events if there's only one child
   event for a parent. This also moves all the trace-related code into
   one place, clearing up the other code.
 . The 'is single threaded' information in the traces is not really all
   that useful, since that information is already available in the trace
   viewer (only Browser is single-threaded). So remove that information
   from the trace (and the associated plumbing), and instead include the
   BeginFrameId.

BUG=none

Change-Id: I319fb764bf24acba6ed3f8427bb0d0a79a891613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125822
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754795}

We split up the crostini tests so that each suite runs in a separate
test.

This requires factoring tests from SubPageDetails into a leaf suite
called "SubPageDefault".

We also re-enable all the tests except the Port Forwarding suite, which
we suspect is responsible for the flakes but we can not reproduce the
flakes locally.

Bug: 1056268
Change-Id: I8f4a6af5943845c67178e2fe3d9edde69fc9616f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124281Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#754794}

This reverts commit 33a9de15.

Reason for revert: Broke unvisited links in light theme on Android.

Original change's description:
> [ReaderMode] Update background and text colours for themes
> 
> Updates background, text and link colours to match Figma mocks, and also
> fix some colour contrast issues.
> 
> Bug: 1025300
> Change-Id: I1fca11a04863718ffa1676fe978538a2ebacd6c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114475
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Meredith Lane <meredithl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753037}

TBR=wychen@chromium.org,gilmanmh@google.com,meredithl@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1025300
Change-Id: I08fd60558a65e24685df8bb62a1d886c567f2960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128034Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754793}

Essentially, it is writing some callbacks and callback adaptors to
handle the updater and the COM RPC in the correct sequences and threads.

This CL fixes a small bug when saving prefs during the updater setup
when no --appid was specified.

Bug: 1053729
Change-Id: I0effe3eee25315e42d09ac51fe5f32df6701082e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123758
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754792}

Change-Id: Ic6e92db4c24b7b13804f84824b82c89f26ab5bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128945Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#754791}

The media app has the ability to "interrupt" image decodes by revoking
Blob URLs, but this makes tests confusing.

Update the chrome://media-app tests to properly propagate the
completion of image loads on the initial loads and on navigation.

Bug: b/152729704
Change-Id: Iaca65ac183f5fd4cfa5f84be93c724266e4ae4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127996Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754790}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I11957d8c1127bec834147200278586cc53112db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129109Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754789}

As explained in https://crbug.com/1021172#c5 and #c6, tests working with
extension popups are sensitive to focus/activation changes.  This can
manifest as flaky test failures if such tests execute in browser_tests
test suite.  To avoid this, this CL moves the affected tests to the
interactive_ui_tests.

Bug: 1021172
Change-Id: Icf4bcd43a3343c32ebe693b42026d7822d9ded41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108082Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754788}

This CL adds a mojo interface which will be used between //content
and the storage service to handle storage operations. This interface is
similar to LocalStorageControl but for service worker storage.

ServiceWorkerStorage will directly implement the interface. However,
to reduce impacts on existing code base, the interface is going to be
implemented by a thin wrapper calls ServiceWorkerStorageImpl for now.

This CL only adds methods to find a registration. Subsequent CLs will
add more methods.

Bug: 1055677
Change-Id: I7d8cd0677356a6953144896dd7f05a4ed04a2608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120838
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754787}

Dwell time is the time the user spent interacting with the current demo
session, measured from first user activity to last user activity.
While there is an existing metric which measures this,
DemoSession.SessionLength, there are some key differences:

- SessionLength measures the duration to logout. DwellTime measures the
  duration to the last user activity.
- SessionLength is measured to the nearest minute and uses linear
  bucketing up to 2 hours. DwellTime is measured to the nearest second
  and uses exponential bucketing up to 1 hour.
- SessionLength persists across crashes and is reported at the start of
  the next session (possibly to ensure that metrics are sent correctly),
  while DwellTime is not crash-resistant and is reported at the end of
  the session.

Bug: b/148752593
Test: ash_unittests --gtest_filter="DemoSessionMetricsRecorderTest.DwellTime"
Change-Id: I179c59ecd537f33e36e329ba9853b35198ccc793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114319
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Patti <patricialor@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754786}

This CL fixes the MailboxVideoFrameConverter to let ScopedSharedImage be
owned by the unwrapped DMA-buf VideoFrame (a.k.a. origin_frame in the
code). Note that the mailbox VideoFrame sent to the client has a
reference to the wrapping VideoFrame. Therefore, the new ownership model
ensures that the SharedImage lives at least as long as the mailbox
VideoFrame, even if the MailboxVideoFrameConverter dies in the meantime
(this has been observed to happen when pausing a video then switching to
another tab to play another video and then switching back to the
original tab - see referenced bug for more details).

Note that ScopedSharedImage is changed to be mutable. That's because we
need to handle a case in which the visible rectangle of a VideoFrame
changes and the SharedImage needs to be regenerated.

Bug: 1044890
Test: forced the use of VD in krane and went through scenario in bug.
Change-Id: I4ff20b0b5088a7a202efc98747fdb5e7a9e9d5f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119153
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754785}

The current logic doesn't actually get the correct timezone
for determining UTC offsets, this fixes that.

Bug: 1054951
Change-Id: I46a704647c77adf9fb2806d415ecd219c56d0378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124542
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#754784}

This CL moves flex-item-contains-strict.html test from
css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, a proper title,
and test description.

Bug: 1063749
Change-Id: I8c688b51efc8890250073778b76bef1f23f8fa24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123573Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#754783}

- Added LoadStreamFromStoreTask to read model data from the store.
- Update LoadStoreTask to try loading from the store first, via the new
  task.
- Save operations executed to persistent storage.
- Added some conversions to textproto for tests.

My primary goal when making this change was to save operations to
persistent storage as they are executed. Pulling this thread led to
several changes.

We were saving a bit too much data in the single 'stream_data' record,
which meant we would have to re-serialize the whole model to save a
single piece of information. I went ahead and split 'stream structures'
out into another record. All stream structures for the stream now need
to be read in at load time, and they need to be sequenced appropriately.

In making that change, I wanted to verify we could actually load the
data back in. So I implemented loading a stream from storage as well.

Bug: 1044139
Change-Id: I98767281b4a5d1ae401dba5db5bff966f3473452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123249
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754782}

The current return type of base::SHA1HashSpan() is too long.

Change-Id: I6220807ba411933e9494bed09ce95bd0f5cc5c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125625Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754781}

The current implementation is looking for a currently running tabbed
activity to handle the incoming intent. This is the correct thing to do
when handling outside intends, such as an open request from a messaging
app.  When reparenting tabs in multi-window mode, this clobbers a
ChromeTabbedActivity instance which is being recreated as a result of a
theme change.

Bug: 1055228
Change-Id: I722365c43ec97ab12120e9139eb43a781de8090a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117062Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754780}

This links to zsh-users/zsh-completions, which includes a completion
script for the Android emulator command line tool.

Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I527c5da96af560ad9853c00050fc5e7dcc36705d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128786Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754779}

Change 'auto' with 'percentage the test title and file name.
And, the attribute of the bug link rel is changed to 'issue'
with a full bug link.

Bug: 1063749
Change-Id: I0a25c6caa3d3afd6c928bb8bc2b692037c0f57c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126329Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#754778}

RELNOTES=Fixes developer logging page (Search+o, w)

Bug: none
Change-Id: I2829ef09c530d8fc8594d7bd5fd1704b3bafa11e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128939Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754777}

Add a test that validates presentation of the app menu bookmark item
based on whether the current page is bookmarked.

BUG=1065043

Change-Id: I882b7e55f1f5df7a977f5135702d9c9d029d9362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128528
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754776}

This CL moves flexitem-stretch-image.html
test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, and test description.

Additionally, this CL adds 100x100-blue.png to
external/wpt/css/css-flexbox/support directory.

Bug: 1063749
Change-Id: I1424f3fb9ca5a79046e3e451393a4eaa0f080347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126428
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754775}

This CL moves flexitem-percent-height-change.html test from
css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, and test description.

Bug: 1063749
Change-Id: I265c8cc40707ffa6cffbacb544aea66add617658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124278
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754774}

in surface aggregator.

The |can_use_backdrop_filter_cache| flag is first set in cc when damage of
all render surfaces is accumulated. If no damage is present under the
render surface with backdrop filters, the flag is set to true to indicate the cache
can be used. In surface
aggregator, if damage from a surface is under the RPDQ with backdrop filter,
the |can_use_backdrop_filter_cache| flag will be reset to false, indicating
the backdrop filters on the RPDQ has to be re-calculated.

Bug: 1035639
Change-Id: I365a0e01196ce1a01d474a0338734a966911a48e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103311Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754773}

Only one CI/try builder pair: ios-simulator-code-coverage

Schedule of migration:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: I64f527f57be72e60a85a53d7ae59d3b0b33c98c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119293
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754772}

This patch adds split histograms of the following metrics when
rendering delay for web font preloading has been triggered:
- PaintTiming.NavigationToFirstPaint
- PaintTiming.NavigationToFirstContentfulPaint
- PaintTiming.NavigationToLargestContentfulPaint
- LayoutInstability.CumulativeShiftScore

This will help us understand the effectiveness of this optimization, and
adjust the length of the delay to the best value.

Bug: 1040632
Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754771}

When two event definitions are grouped under a project, their recorded
events should share an user event ID. This adds a test to make sure
that's the case.

Bug: 1016655
Change-Id: I32476ece7dd80c7366230a456d5e9d8210355115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119457Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754770}

R=agable@chromium.org, tikuta@chromium.org

Bug: 1063727
Change-Id: I477b1c06e0b0993f7b7b5caff8b66dcee32cef8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127993Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754769}

The test comments for DeviceCommandRunRoutineJobTest were
inside the tests themselves. They should be above the test.

Bug: chromium:1066251
Change-Id: I6397f37dfd292a41ae27e8efb868bd3c0b2f1aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128929Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754768}