- 26 Jul, 2019 40 commits
-
-
Michael Crouse authored
Only attempt to fetch hints if the network is available. Note: The Optimization Guide does not support iOS but is in components due to supporting Previews. A future refactor of Previews may allow for moving Optimization Guide to the browser layer. An assertion was added to the BUILD.gn file to make the iOS decision more clear. Bug: 986817 Change-Id: Iafa4101b42147530e0b38f2d6a4eb36a7ddac37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715505Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#681180}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/365720e237c2..e3614ad6f574 git log 365720e237c2..e3614ad6f574 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e3614ad6f574 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I534edc0f35a03d2bb72a6f98d2cdcfd3f6ced779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681179}
-
Nigel Tao authored
There are two syncer::ModelType enum values that are revelant to the TwoClientAppListSyncTest.RemoveDefault sync test: ModelType::APPS and ModelType::APP_LIST. ModelType::APPS is about whether or not an app is installed. ModelType::APP_LIST is about, for an installed app, where it belongs in various app-related UI: its position in the app list and the shelf, and which folder (if any) it is organized into. The AppListSyncableService has existing code for detecting when an "uninstall the such-and-such app" request is for a default-installed app, and if so, sending a new ModelType::APP_LIST sync change out, one marked with sync_pb::AppListSpecifics::TYPE_REMOVE_DEFAULT_APP. Call this new sync change the Override. When sync'ing "uninstall such-and-such" from Profile #0 to Profile #1, that code path is only tickled by the sync'ing of ModelType::APPS, not by sync'ing ModelType::APP_LIST. It's tickled by the uninstallation of the actual app (calling into the AppListSyncableService via AppListModelBuilder::RemoveApp), not by anything related to UI positioning per se. The existing code passes the existing test because that uninstallation from Profile #0 triggers two sync changes - one for ModelType::APPS and one for ModelType::APP_LIST - call them ChangeA and ChangeAL. It is somewhat coincidental that ChangeA is processed first, generating the Override, which nullifies ChangeAL. Override (triggered via ChangeA) and ChangeAL are not equivalent: - Override updates the sync'ed AppListSyncableService::SyncItem's "item type" to sync_pb::AppListSpecifics::TYPE_REMOVE_DEFAULT_APP. It is sent out, when processing ChangeA, only if a SyncItem (for that App ID) already exists. - ChangeAL deletes the SyncItem. Importantly, they do not commute (the order matters), because of that "if it already exists" condition. If ChangeA is processed first, the condition is true, so a new change (Override) is sent out. Latest one wins. ChangeAL is overridden. If ChangeAL is processed first, the item is deleted, so when ChangeA is processed second, the condition is false, and the new change (Override) is never sent out. Even though there are multiple ModelType::APP_LIST related sync changes - Override and ChangeAL - the test expects that Override wins the conflict (e.g. it ASSERT's that the SyncItem exists and is TYPE_REMOVE_DEFAULT_APP). This is contingent on the coincidence that ChangeA is fully processed before ChangeAL. The App Service is a Mojo based service, and Mojo calls are inherently more asynchronous then regular function calls, as Mojo calls are potentially inter-process (IPC). Enabling the App Service introduces more asynchrony into how app-related change notifications are propagated, and breaks the coincidence. Prior to this commit, the RemoveDefault test fails with the App Service enabled, because Override no longer wins the conflict: it's never sent out in the first place. This commit pulls out the "detect an uninstall for a default-installed app" code so that it's tickled not just when triggered by sync'ing ModelType::APPS, but it is now triggered when sync'ing either ModelType::APPS or ModelType::APP_LIST. This fixes `sync_integration_tests --enable-features=AppServiceAsh --gtest_filter="TwoClientAppListSyncTest.RemoveDefault"`. It fails before and passes after this commit. Note that `sync_integration_tests --gtest_filter="TwoClientAppListSyncTest.RemoveDefault"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: Idcd9a56f905a9ea17f43540642f2514f80dd0f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716040 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681178}
-
Chih-Yu Huang authored
BUG=chromium:979115 TEST=run video_decode_accelerator_tests --use_vd on Kevin Change-Id: I97ed910d7f94ea146ee75aa776b2aad1b62116a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720110Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681177}
-
Rakib M. Hasan authored
Typ has a method that check for conflicts between test expectations and also a method that checks if there are any test expectations that do not apply to a test in a test suite. This CL will remove existing logic in test_expectations_unittest.py and make tests call these new functions to validate gpu test expectations. This CL also refactors gpu driver conflict checker logic by moving some data structures and functions into gpu_helper.py Bug: chromium:976505 Change-Id: I6552941284c147108feb99a373c9881b83405cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718788 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681176}
-
Andres Calderon Jaramillo authored
This CL makes the VaapiJpegDecodeAcceleratorWorker extract the result of a JPEG decode as a DmaBuf and return it to whoever requested the decode. Currently, the visible size of an image is not readily available when the result of a decode is exported as a NativePixmapDmaBuf. Therefore, most of this CL plumbs this visible size because it's needed so that it can be returned to the rest of the rendering pipeline after an image is decoded. The plumbing consists in keeping track of the visible size inside the ScopedVASurface that refers to the decode result. This is then used when either 1) exporting the surface as a NativePixmapDmaBuf, and 2) extracting a VAImage out of the surface. The JPEG decoder unit tests are correspondingly adapted so that odd images are only tested when exporting decodes as DmaBufs. This is because odd images are only expected in this path (as opposed to the camera capture path which may use VAImages, and odd sizes seem to misbehave in that case). Test: tests for the worker are added in media_unittests. Bug: 868400 Change-Id: Icb78d9c7f5b3c9213e36c885cf9ff16480d1c545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657568 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#681175}
-
Xida Chen authored
As a matter of fact, cc::PaintWorkletInput already exists in paint_worklet_painter.h. Bug: None Change-Id: I2c5c1f66df81ccc9470d16188da8ad221527d933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719226Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681174}
-
Nico Weber authored
They've been unused since they were added in https://codereview.chromium.org/2233103002 . All these test .cc files are also listed in either unit_tests_shared or unit_tests_desktop, which _are_ referenced (by components_unittests). No behavior change. Bug: none Change-Id: I5a21eab61de2cee66f5358151b9ea423ffb5fa1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719293 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681173}
-
Takashi Toyoshima authored
After Web MIDI started using mojo, MIDIAccessor, MIDIAccessInitializer, and MIDIDispatcher classes do not much work any more. As the first step to simplify these unnecessary layering, this patch removes MIDIAccessor layer. Bug: 582328 Change-Id: I9377d7afab56eefe96f6818d089af54d5f4d80d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718465 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Jun Cai authored
This CL creates a subdirectory sms under: //chrome/browser/ui/android/ and moves sms related files into this subdirectory. This CL also adds OWNERS files for this subdirectory. Bug: None Change-Id: I88fab6f685b7cd2a0e55787dbfb161eadfaa6fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718994Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#681171}
-
Miyoung Shin authored
This CL renames interfaces to mojom in //ui/base/ime/chromeos. ui/base/ime/chromeos/public/interfaces => ui/base/ime/chromeos/public/mojom Bug: 806965 Change-Id: I9b407ac58559fc0063d1105933676bc895e67ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716003Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If3584925766330e95c4aa93d8f3efec1bb540c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700905Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681169}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/091864c00bff..b3891c1e6e90 git log 091864c00bff..b3891c1e6e90 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 primiano@google.com UI: Get rid of RTL ellipsis and fix GPU icon Created with: gclient setdep -r src/third_party/perfetto@b3891c1e6e90 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I3e53ea7affbb571343ea3abdb860623bcdc203d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719893Reviewed-by:
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/base/accelerators. *_struct_traits.* => *_mojom_traits.* ui/base/accelerators/mojo => ui/base/accelerators/mojom Bug: 806965 Change-Id: Ife7875554bdd656e1a9588a941ae61894f95aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715783Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Honglin Yu authored
Prior to crrev.com/c/1710251, the metrics of each type of system resource usage (RAM, cpu time etc.) of ml-service are aggregated over all the models. So one cannot see the resource usage of a particular model. In this CL, we make such histograms model-specific. For example, assume there are two models with |metric_base_name| "SmartDim" and "TestModel", respectively. In logging the cpu usage of "model loading", the previous code will only generate one histogram on UMA: MachineLearningService.LoadModelResult.CpuTimeMicrosec which contains metrics of both "SmartDimModel" and "TestModel". Now there will be two histograms, MachineLearningService.SmartDimModel.LoadModelResult.CpuTimeMicrosec MachineLearningService.TestModel.LoadModelResult.CpuTimeMicrosec which record the metrics for each model separately. Currently, two groups of histograms are added, for model "SmartDimModel" and "TestModel" respectively. BUG=chromium:924709 Test: ran validate_format.py and pretty_print.py Change-Id: I77e53d6ea6302c15b20778782a0068e91c96b6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714405Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681166}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Also adds the closure_compile target to webui_closure_compile. Otherwise there is no type checking. Bug: 968369 Change-Id: Ie1e050a754a86ab7134ddacf8ebe482636221af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717407 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Yao Xiao authored
Parameterize the worker network isolation key tests with the feature kAppendFrameOriginToNetworkIsolationKey Bug: 955476 Change-Id: Id9f9b5bd76157892ed33231c5900e874ba9459cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715757Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Iaf9b2a80a458188c3b95801aa3843e481fc12b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700919Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681163}
-
Maggie Cai authored
Currently the intent picker bubble is aligned to the intent picker icon, this CL aligns the intent picker bubble to the Omnibox. BUG=986145 Change-Id: I4940e000b7d9738b4fb886b79efe2edc7b1a18ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715349 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I13984a7fcec68dda11f2664a92bc0ef58d30e455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700936Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681161}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Idc2bf0d7371a9febba1471732f47d94e7df3303a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700826Reviewed-by:
-
Ian Vollick authored
Adds a minimal test file suitable for demonstrating spatial navigation behavior. Bug: 956209 Change-Id: I908d5c2f6c7c8e38c075ff5ee87dce3214ca2dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719769 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681159}
-
Ahmed Fakhry authored
ui::RecreateLayers() works only with LayerOwners. This means that Shadow which creates its own layers won't be recreated and the old layers won't be returned in the old layer tree returned by ui::RecreateLayers(). This fixes the shadow disappearing for the window-move-to-desk animation. BUG=977434 TEST=Manually, shadow should show while animating, no change in behavior. Change-Id: Iabd12036821a35b56804b5ac774714598fb39e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711046 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Disable input for some browser and content Android tests. Disable input until we present something to the user When a document loads, there is a significant period between when the frame is created and when the user sees content. During this time, the document is not processing lifecycle updates but Javascript is scheduled and the RenderWidget exists to handle input. A major concern is that users might click on some place where there is something reactive laid-out and available for hit testing and processing (an ad, a link, start a video) before they have actually seen anything to click on. Think of something like a last ditch attempt to click on something on the page you're navigating away from only to hit something on the page you're navigating to. It seems safer to avoid this rather than have unexpected and potentially very nasty behavior. In theory this situation was possible before with deferred lifecycle updates though it apparently never warranted concern. But we're preparing to enable the flag that defers the first compositor commit until we have some content ready to raster (or a timeout), in which case document lifecycles are running and there is content there to hit-test against and send events to, but the user hasn't seen it yet (for half a second at most, right now). This patch adds a flag to suppress all input from the time when RenderWidget navigates to a frame to the time we are notified of the first compositor commit and paint, which is the best estimate we have for the user seeing something. This patch may affect the FirstInputDelay (FID) web platform metric. FID may improve because dropped input won't be measured at all, and the delay for the first event we actually process will be smaller because it will come when the system is less stressed. i.e. after initial layout and paint. Regardless, the impact on FID will be monitored when this patch lands. Tests disable this feature, with an open bug crbug.com/987626 to fix the tests and enable the feature. Bug: 958424 Change-Id: I9d288b6861f88e7101d9957d1a21b6bebb38bca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590415 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681157}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I14e62dde98538aaed89091cba8be8f246de19ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720111Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#681156}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib0a8e987ee5259872c1ff8d64eff577ef758d863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700868 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#681155}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I86538c3364443afcda7ac0090461ef56557dabe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699959 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681154}
-
Varun Khaneja authored
This should have been added with the code but was mistkenly not. R=holte Bug: 965587 Change-Id: I0ce554f6570aa9d0548b9d3c6215a7c98e79a043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717481 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681153}
-
Gabriel Charette authored
WaitableEventPerfTest.Throughput was incorrect; it relied on a const samples() but was looping through as many iterations as possible for 1 second... so the report was garbage. The test was disabled because the vector went over the allocated capacity (faster machines now mean this test can do in the order of 1'000'000 operations in 1 second). Allocating a vector of a million entries just to accumulate later is overkill. Switched to accumulating as we go. An upcoming change of mine will improve perf further I think; cleaning up and re-enabling these tests before helps show the delta. Renamed the tests to have them prefixed by "WaitableEvent" so they're easier to find on the perf dashboard (continuity is not an issue). R=kylechar@chromium.org Bug: 848499, 905412 Change-Id: I021886b472bfbb698af615038e393a92e654a122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718598 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681152}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic1551309a2c143a6298cd7a6a663616aa0bff434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700727Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681151}
-
Ian Vollick authored
Two tests needed to be updated after crrev.com/c/1716952 TBR=mahmoudi,dewittj Bug: 983734 Change-Id: I6bf9233601875f2f1dc973560eed6417a1ecb907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720109Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681150}
-
rajendrant authored
When Lite mode is turned off, lazyload and site-breakdown should not report byte savings. Also, the milestone bytes saved IPH should not show up when Lite mode is off. Bug: 987114 Change-Id: I4ee07774666524c7dd0cfff7e0442aecf37dae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716111 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681149}
-
Jyun-jhe Chou authored
There are some devices will have video encoder on it, and we will need to test these video encoder. We have check the building flags of some devices and find proper flags for adding video encode accelerator unittest to the build list. Run the default tests on the device. Bug: b/129457839 Test: Rebuild the image and check if the binary exists. Change-Id: I5133b65573edc7a8137244c163d0baefd5632201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712442Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jyun-jhe Chou <hobexd@google.com> Cr-Commit-Position: refs/heads/master@{#681148}
-
Nicolás Peña Moreno authored
Currently startTime is 0, which is a problem because getEntries() methods all sort by startTime. To help with this problem, we set the startTime to renderTime, if available, or to loadTime, if renderTime is nt available. Bug: 965505 Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681147}
-
Chris Harrelson authored
This presumably avoids defeating a RVO optimization in the compiler, and recovers nearly all of the performance lost in the referenced bug in local testing on Linux. Bug: 984965 Change-Id: I99567cc96391d410e71aba2fe4c2d29d5324fd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717923 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681146}
-
Chih-Yu Huang authored
Tegra driver calculates the wrong plane size of NV12. This CL disable all tests on nyan family for NV12 test. BUG=chromium:965348 TEST=`tast run $(DUT) video.EncodeAccelH264NV12` on nyan_big Change-Id: I4e79a5380501d866ffc4192dcfc35423f26f1bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715516 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I7c7f730f2cf326fa4e3cc40f9c7fe30698eaf4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700831 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#681144}
-
Mohamed Heikal authored
Resource name stripping was enabled in both debug and release when it was new so that issues are more likely to be found early. Now that the optimization has been on for some time without issue, it makes sense to disable it in debug mode so as to not annoy developers that are looking into resource related issues. Change-Id: I68ac00396dc8e2b5d37d276c22c58a1d020e1392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719451 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681143}
-
John Rummell authored
Bug: 987067 Test: EME content_browsertests pass Change-Id: Ia1573232a0c43b347e26ea4707406b92c652a82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719452Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681142}
-
Johannes Henkel authored
Please make sure I didn't simplify it too much. :-) Also, please let me know what comment to put (if any) for the second return. Thanks. Change-Id: Iffa201442e99c1df4896fe4c168845df2bcb9bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718781 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#681141}
-
