- 23 May, 2019 40 commits
-
-
Friedrich Horschig authored
The ViewPager has timing issues that surface if any bottom sheet is invoked very, very quickly after its creation. I witnessed this approximately 1 out of 30 times when testing manually and approximately 1 in 5 times in automated tests. As far as I know, this test flakiness wasn't reported yet and the most affected test has yet to land. This CL posts a SetCurrentItem call right after it's regularly called. That way, if there are no async issues, it will work as it should. But if another SetCurrentItem marks the wrong item active, it will be overridden very soon after. Visually, the difference can (afaict) only be perceived during the very first opening _if_ the wrong sheet would trigger. The flickering is not perceivable unless expected (since the sheet is still opening at the moment when the switch happens). Bug: None Change-Id: I2dcd7ab329746efed6aff294f2dbdb5657357a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624816Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#662545}
-
Chen Xing authored
Bug: 966001 Change-Id: I7546061c0b7e245720c3706aa7d5e48a510cf059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625109 Auto-Submit: Chen Xing <chxg@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Chen Xing <chxg@google.com> Cr-Commit-Position: refs/heads/master@{#662544}
-
Jordan Demeulenaere authored
This CL disables the clipping of the bottom sheet content if it is not scrollable. This allows to correctly display the details shadow if it is the only visible element in the scrollable area. We still need to enable the clipping of the content if it is scrollable, otherwise scrolled content will overlap the carousel and header (given how the ScrollView works internally). This is fine as the details are usually shown at the top of the scrollable area, so clipping it when it happens shouldn't have an impact on the details shadow. Given that the actions carousel was relying on the clipChildren flag to be disabled, the spacing before and above the carousel has been moved into the carousel item decorations. * Before: https://screenshot.googleplex.com/p6DUiOBnyDp.png * After: https://screenshot.googleplex.com/AAKU42uvhgv.png Screenshots: Change-Id: I900f47ab41a36cb3f2140d1387671e392d694d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624194 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662543}
-
Yi Su authored
This CL moves all certificate related files from //ios/web/net into //ios/web/security. This is a prerequisite work for navigation refactor. Bug: 956511,942244 Change-Id: Iddf802f75b8ca7038e00a062fcb26773d7948a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624572Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662542}
-
Timothy Loh authored
This reverts commit b128ac8e. Reason for revert: Some cookie tests failing on linux-chromeos-dbg The following tests are failing consistently when the network service is disabled (aka the non_network_service_browser_tests task)" CookieSettingsTest.AllowCookiesUsingExceptions/1 CookieSettingsTest.AllowCookiesUsingExceptions/3 CookieSettingsTest.BlockCookiesUsingExceptions/1 CookieSettingsTest.BlockCookiesUsingExceptions/3 Failure output: ../../chrome/browser/content_settings/content_settings_browsertest.cc:390: Failure Expected equality of these values: 1u Which is: 1 blocked->GetCookieCount() Which is: 0 Failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12530 Original change's description: > RestrictedCookieManager: report activity to ContentBrowserClient > > ...So that things done via async cookie-store API show up in used/blocked > cookies GUI. > > This is done via NetworkContextClient, with some existing reporting via > NetworkServiceClient converted to it, as in case of service worker it's > not associated with process + routing ID pair. > > This now invokes ContentBrowserClient::OnCookie{sRead,Change} on IO, > not UI, thread. > > Bug:958923 > > Change-Id: I7d1832ad30f57c67ea292481444a5e6ca07657df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577493 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662253} TBR=falken@chromium.org,jam@chromium.org,tsepez@chromium.org,msramek@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org Change-Id: I4e587a04252b135a48f5e0d09414f62df65f9278 Bug: 958923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626207 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662541}
-
Chromium WPT Sync authored
Using wpt-import in Chromium db450183. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" 8e9cad0d "Cookies WPTs: Add test coverage for SameSite=None" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic4b17b54f8d7400bf8d82f65bfd3bb2dee3ae7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662540}
-
David Benjamin authored
This is probably a false positive. The test currently assumes that, in the period when it's calling SetClearSiteDataHeader, there are no requests in flight. This appears to be true, however, it depends on signals across processes, which I suspect TSan is not taking into account. The race doesn't trigger with --single-process, which supports this theory. Still, adding a lock is easy and seems prudent when state is accessed in this way across threads. Bug: 965719 Change-Id: I7c5c34a06df4684845f76c0e8730c4bfea7170c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626297 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#662539}
-
Rob Schonberger authored
Will increment a histogram on arc install/uninstall, with reason for install or uninstall included. Adds unittest for behavior. Change-Id: I174ed9a2dc5d2c3c74904a1685810ea3c9129c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616825 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662538}
-
Jan Krcal authored
These histograms were motivated by an investigation for WALLET_DATA and are not needed any more. Bug: 960074 Change-Id: Ic0024664ef58c7ecfbf717102c965821d8ba9219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621905Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#662537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbb4f6b5b7c6..9d034a4e2c20 Created with: gclient setdep -r src-internal@9d034a4e2c20 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ic8f441f492b28321ebd0cbb5a5c3e4a1a42a1041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627016Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662536}
-
Maksym Onufriienko authored
Navigation test is updated in smoke_egtest to exercise all of them. Bug: 922813 Change-Id: I4d9fe1dec5133310ebc771d7b94240761b0e1003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622920 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This CL does followings - Renames pickle files in bindings code generators from CamelCase to snake_case. - Moves bindings/modules/InterfacesInfoOverall.pickle to bindings/interfaces_info.pickle - Renames InterfacesInfo{Core,Modules}Individual.pickle as interfaces_info_{core,modules}.pickle - Cleans up dependencies in 'idl_impl' template. Bug: 839389 Change-Id: Ib840c323b536a7c3f857c653f73506fa1a4f6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626200 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#662534}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I84b8115dd650d21dbc6887d66f17ebe9da7d0b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662533}
-
Maciej Pawlowski authored
This one works with strings and other complex types in addition to integrals. Bug: 954080 Change-Id: Ic9961e0ccffdce89d160a5b4d8cab9b7d94a100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617481Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#662532}
-
Takashi Toyoshima authored
- Rename CorsOriginAccessMatchMode to CorsDomainMatchMode in order to introduce network::mojom::CorsPortMatchMode. - Replace int32_t port with uint16_t port and CorsPortMatchMode. Bug: 936900 Change-Id: Ic5cbf91ee74366f3380fedc35349edf6c5f09bb6 Tbr: rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626061 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662531}
-
Hiroshige Hayashizaki authored
This CL introduces - WorkerGlobalScope::WorkerScriptFetchFinished() as the single point that is always called when worker script fetch is successfully finished. - WorkerGlobalScope::RunWorkerScript() as the unified interface to synchronously evaluate the worker top-level script. For this function, this CL introduces Script::RunScriptOnWorker(), merging code from - WorkerGlobalScope::EvaluateClassicScriptInternal() - WorkerModuleTreeClient::NotifyModuleTreeLoadFinished() - ServiceWorkerModuleTreeClient::NotifyModuleTreeLoadFinished() - Simplifies pausing mechanism by making RunWorkerScript() called when both WorkerScriptFetchFinished() and ReadyToRunClassicScript() are called. (Previously EvaluateClassicScriptInternal() was re-triggering itself when not ready) After this CL, code paths after successful worker script fetch are unified into the single path of WorkerScriptFetchFinished() + ReadyToRunClassicScript() -> RunWorkerScript(). Behavior changes: After this CL, module service worker scripts wait for ServiceWorkerGlobalScope::ReadyToEvaluateScript() before evaluation. Bug: 945673 Change-Id: I20c57d28cf908c4e6492ea56ac4962f3b4674acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618628 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... in AnimationWorkletMutatorDispatcher code. Since the code in case is within Blink, there is no need to convert the WTF::CrossThreadOnceFunction to base::OnceCallback (with ConvertToBaseOnceCallback). CL adopts the use of WTF::CrossThreadOnceFunction to simplify the code. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I8586dc1397f0861bb42c59dd88bfb7defc534b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625969 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Maksim Sisov authored
This is a prerequisite to unite WaylandShmBufferManager and the WaylandBufferManager. The last requires buffer_id to be passed when managing buffers. Thus, make canvas assign new ids when creating new SkSurfaces and buffers for them. Bug: 963853 Change-Id: I0d980d468a2cc000fd23f0c4abffab2322dcacd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617503 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#662528}
-
Yutaka Hirano authored
It is no longer used. Bug: 914739 Change-Id: Ic5d4df6954ea1bee276b0ac41735c4c1bae2fba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619523Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#662527}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I2e2ffb7f98d3911547f7f0ffef7d8b0e52db34f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627291Reviewed-by:
-
Jia authored
[On-device adaptive brightness] Fixes a bug that does not set metrics reporter when model is disabled Bug: 881215 Change-Id: Icb120b47a37c078b3b98dd947369f4240da81d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626059 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662525}
-
tzik authored
ServiceWorkerHost used to use the default task queue to notify its API completion to the user. However, an upcoming change breaks down the global MicrotaskQueue into per-global scope, and disables the microtask checkpoint on the default task queue. That implies that Promises settled in the default task queue will not trigger the promise handler immediately. This CL updates the ServiceWorkerHost setup to use an GlobalScope-bound TaskRunner. Change-Id: Iaea71470917d37d1444b83698315036b1ce2f92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617045Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
Following r661908 Autofill Mojo types are now available in the browser and on all platforms. However, the provided StructTraits assume the existence of renderer ids in NewPasswordFormGenerationData, which currently don't exist on iOS. This change fixes this. Bug: 962853 Change-Id: I08d664d88d99c4bc76df8b6e0330a3c719e1063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624919 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662523}
-
Ramin Halavati authored
Accessible window titles in guest mode had an (Incognito) addition. This is changed in this CL to (Guest mode). Bug: 947933 Change-Id: Ica441beb893140218a8448e94313c0d06fe38855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611933Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#662522}
-
Adam Langley authored
Prior to this change, it was possible to request an assertion with an empty allowList and UV=discouraged. If an authenticator had internal UV then this would be passed down as-is. But we don't want resident credentials without UV to be a thing on the Web. Bug: 941120 Change-Id: I8e246cba0f2d687ee14ddcc822430dbe1eff46af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626730 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#662521}
-
Tsuyoshi Horo authored
This reverts commit 6d9fb7a5. Reason for revert: Fixed test Initial CL: https://crrev.com/c/1616937 Revert CL: https://crrev.com/c/1624588 The original CL was reverted due to the data race bug in test. Change-Id: I7280e271f4739da54b9fcf5e022b3a57256b05ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625026 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Lowell Manners <lowell@google.com> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
May Lippert authored
This will only be shown on relevant devices. BUG=965657 TEST=ran on all relevant devices and verified the link is correct. Ran on other devices and verified the link does not appear. Change-Id: I204c64fbb8ccf8633bff9631c2c4b0928f88aa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622617 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#662519}
-
Dominik Röttsches authored
The last remaining user of this method was removed in 95e51a93, removing this static method. Change-Id: I12865334448ef07ebb2c1b8c82ef3b1c60464e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622167Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#662518}
-
François Degros authored
Change-Id: I3e22e420bd7281dae51cbc7432712a60d6b608ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626057 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#662517}
-
Takashi Toyoshima authored
Since origin_access_entry.* are files just to forward Blink calls to equivalent services/network functions, let me add myself to the OWNERS file as the network service side implementation author. NOTRY: true Change-Id: I9150caedc53e67ef9c18c37407fdbd85466bba43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616829Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#662516}
-
Igor Kobylin authored
R=dbeam@chromium.org Bug: None Change-Id: Ifb305d275749627cf9a4da47eb951f5dc589819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623091Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Igor Kobylin <ikobylin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#662515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5093ba67643c..8224a58b4749 git log 5093ba67643c..8224a58b4749 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 aleino@nvidia.com Normalize fragment color in Texture2DIntegerTestES3 Created with: gclient setdep -r src/third_party/angle@8224a58b4749 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963595 TBR=ynovikov@google.com Change-Id: I0d99daefb194b56ba85dc721c9353e20e74852b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626140Reviewed-by:
-
Peter Kotwicz authored
This CL hooks up the SplashscreenObserver#onTranslucencyRemoved() callback (which runs the delayed screen orientation lock requests) BUG=957835 Change-Id: Ifc23d1cdbe37606c5bed3191b3b4534b586ec684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622641 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#662513}
-
Timothy Loh authored
This CL adds a 'Shut Down' option to the shelf and launcher context menus for the Plugin VM app. These will only show while the app is open. For now we simply dispatch a StopVm message, but we may want to expand this to also close the UI window once the shut down is complete. Bug: 940319 Change-Id: I3acbbaf540384fad1dbb68e6226420b47d586793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621987 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662512}
-
Ehsan Karamad authored
Mojo calls from browser to renderer are currently on a non-associated channel. Essentially, the SetInternalId API on MimeHandlerViewContianerManager must be received before the document is loaded. Right now this is not guaranteed and there is room for race bugs. Right now SetInternalId seems to be the only IPC which requires to be on an associated channel. Eventually this IPC could be singled out into its own interface and have a separate binding in MHCVCM for it. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: I2b337c4876f3eb3e4bc6b1e6f72033ccd4edda03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617016Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
-
Ting Shao authored
When taking update check, request's validate cache flag should be set depending on the conditions like update via cache option, time elapsed since last update, etc. Bug: 648295 Change-Id: Id2de38a65d8eccc393c1c7c40b8f82894ec52093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560905 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662510}
-
François Degros authored
This convenience method allows usage patterns that are easier to read and maintain, and promotes better error propagation by discouraging exception swallowing. Used it in VolumeManagerImpl. Change-Id: Idfb1832d7262a37245fc818a063d3d36575d11b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621480 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84137d6f7099..cbb4f6b5b7c6 Created with: gclient setdep -r src-internal@cbb4f6b5b7c6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ife89aa412e41a5d443f7ac9ce434f16d18c2866b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627012Reviewed-by:
-
Yutaka Hirano authored
platform/probe has only one tracing event: "PlatformResourceSendRequest" which is called in ResourceFetcher::StartLoad. This is very similar to what we are doing for "ResourceSendRequest" in InspectorTraceEvent::WillSendRequest also called in ResourceFetcher::StartLoad through ResourceLoadObserver::WillSendRequest. As the event has never been actually used, let's remove it. This CL will allow us to remove PlatformProbeSink. Bug: 914739 Change-Id: I0f93e363214ac6da071ee480ee155d3492fb3e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616839 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Historically, we run IDL code generator in modules/ component, but it's actually independent from all components. This CL moves the task to bindings/ to make it clear. Bug: 953125, 839389 Change-Id: I89cd99fb05717f287a3573cf86690280b88036c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573303Reviewed-by:
-
