- 21 Aug, 2018 40 commits
-
-
Jinsuk Kim authored
This CL addresses the bug that scrolls to the bottom of the page opened by anchor in a new tab. The size of the contents should have been set earlier at |initializeTab|. This change comes with a risk of reintroducing the regression fixed by https://crrev.com/c/795479 since it's basically reverting what the CL did. As of this change, the reported regression is not reproducible, and it's not easy to find any other sites that exhibit the issue. The plan is to land this CL and react timely to any problems it might cause. Bug: 850868 Change-Id: Ie4fdbaa012f72a2b667b7b27c177fcc6b7a21032 Reviewed-on: https://chromium-review.googlesource.com/1180637Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#584662}
-
Xianzhu Wang authored
- fast/multicol/composited-layer-nested.html According to discussions and data in crbug.com/854192, we should not fragment a composited/squashed layer as a whole no matter if there are nested composited layers under it (as current BGPT code does). - fast/multicol/vertical-rl/composited-relpos-overlapping-will-change.html The new result looks more correct (the composited layer is placed in the second column where the layer's border box rect starts). Also updated the test to show more clearly. Bug: 854192 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1ad00980034c6c991fa82d2ee4f675010292cdb Reviewed-on: https://chromium-review.googlesource.com/1180405 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584661}
-
Jinsuk Kim authored
Moved new test-only methods added to WebContents/RenderFrameHost in https://crrev.com/c/1163831 to targets content*test_support. Bug: 862153, 875742 Change-Id: Id9be5f53b45e2b28861a35401bba71020cf5fc0f Reviewed-on: https://chromium-review.googlesource.com/1180824Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#584660}
-
Yoshifumi Inoue authored
This patch disables NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks since this test attempt to create process with too long command line. TBR=fdoray@chromium.org Bug: 876184 Change-Id: I593569e46dc8bb127aacafba22cb05be9df506f3 Reviewed-on: https://chromium-review.googlesource.com/1182910Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584659}
-
Jun Choi authored
In current implementation, we auto-select transport type to previously used transport type. Disable this feature for MakeCredential request. Bug: 868212 Change-Id: I4b0c3e642df1eaffa8f76956223a6a7f9b66a21b Reviewed-on: https://chromium-review.googlesource.com/1182101 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584658}
-
Alex Kalugin authored
Bind VerifyChecksum operation callback to weak_factory_on_io_. Currently VerifyChecksum callback is not dropped when V4Database instance is destroyed which leads to possible crashes in V4LocalDatabaseManager with the following stack safe_browsing::V4Database::GetStoreStateMap() (this is null here) safe_browsing::V4LocalDatabaseManager::GetStoreStateMap() safe_browsing::V4LocalDatabaseManager::DatabaseReadyForUpdates(...) ... This can happen if V4LocalDatabaseManager is disabled and reenabled before DatabaseReadyForUpdates for the first V4Database instance callback is called. Steps to reproduce the crash: - Install Chrome - Run it in V4 Only mode - Go to chrome://settings and open advanced settings - click on "Protect you and your device from dangerous sites" toggle - Press and hold spacebar in order to toggle SB enabled/disabled states Change-Id: I75564e1a6d56184f5e49e901520ce16eeb91ab6c Reviewed-on: https://chromium-review.googlesource.com/1180884 Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584657}
-
Byoungkown authored
As following the spec[1] at XRView, The eye has changed to use XREye instead of VREye. And it is nullable. [1] : https://immersive-web.github.io/webxr/#xrview-interface Bug: None Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib8e698f714ea107bc0ac9a275a6466d419a067e3 Reviewed-on: https://chromium-review.googlesource.com/1180629Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#584656}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd0c341bd251..85f5e7ccd1af git log dd0c341bd251..85f5e7ccd1af --date=short --no-merges --format='%ad %ae %s' 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 rrangel@chromium.org my_activity: Add review.coreboot.org as a source 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@85f5e7ccd1af The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=agable@chromium.org Change-Id: I62be0f7f911f1501375bacc6ea87781fc06996be Reviewed-on: https://chromium-review.googlesource.com/1182642Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584655}
-
Siddhartha authored
Add a config param to limit the total trace buffer size BUG=859260 Change-Id: Ic15e5aa0d381273eadcdad270d955441386cd288 Reviewed-on: https://chromium-review.googlesource.com/1182510 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#584654}
-
Yuzu Saijo authored
This CL implements CrashMemoryMetricsReporter on the renderer side and CrashMemoryMetricsManager on the browser side in order to manage the shared memory between the two process, which contains OOM related information. Shared memory now reports whether the crash was because of virtual address space OOM. TBR=sky@chromium.org Bug: 854073 Change-Id: Iebf12b83ac66417e71cba2ba647b080aed3e9da9 Reviewed-on: https://chromium-review.googlesource.com/1139845Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#584653}
-
Victor Costan authored
This CL introduces SqlTempStoreMemory flag, which is intended to be managed via Finch. When set, the flag causes sql::Database to run a PRAGMA temp_store=MEMORY [1] query on every opened database. This approach is intended to approximate the effect of building SQLite with the SQLITE_TEMP_STORE=3 [2] macro, to measure the memory consumption impact. Ideally, we'd test the macro directly, but //sql is a core component of Chrome, so we can't load different versions of it based on Finch. [1] https://www.sqlite.org/pragma.html#pragma_temp_store [2] https://www.sqlite.org/compile.html#temp_store Bug: 875538 Change-Id: I537d90d763be1100503ed4bd2ada2ee19eb090bb Reviewed-on: https://chromium-review.googlesource.com/1180530Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584652}
-
JunHo Seo authored
Convert list: snav-1st-stop snav-aligned-not-aligned snav-clipped-overflowed-content snav-container-only-white-space snav-container-white-space snav-date Bug: 803086 Change-Id: Id5723780293df17fd0c0020914630d2f1ea7d198 Reviewed-on: https://chromium-review.googlesource.com/1177527Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#584651}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I116723e6f80fcfd9d665ad7f80d0cd1636dd2019 Reviewed-on: https://chromium-review.googlesource.com/1182876Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584650}
-
Yoshifumi Inoue authored
This reverts commit be7c1259. Reason for revert: Can't find gold. /bin/sh: 1: ../../build/toolchain/cros/build/cros_cache/chrome-sdk/tarballs/daisy+10974.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.27.0-gold: not found Original change's description: > Relativize cros compiler path > > Combined with https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180801 > this patch removes absolute path from command line for simple chrome build. > > This is a part of effort for build cache sharing when using goma by > removing absolute path from compile result. > > Bug: chromium:846610 > Change-Id: Ia40a7194b4e485f26424f27ebfc210355e352cc0 > Reviewed-on: https://chromium-review.googlesource.com/1180826 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584648} TBR=vapier@chromium.org,dpranke@chromium.org,tikuta@chromium.org,manojgupta@chromium.org Change-Id: I93891636a39e5b72f019f262c297c4f07239d0e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:846610 Reviewed-on: https://chromium-review.googlesource.com/1182882Reviewed-by:
-
Takuto Ikuta authored
Combined with https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180801 this patch removes absolute path from command line for simple chrome build. This is a part of effort for build cache sharing when using goma by removing absolute path from compile result. Bug: chromium:846610 Change-Id: Ia40a7194b4e485f26424f27ebfc210355e352cc0 Reviewed-on: https://chromium-review.googlesource.com/1180826Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#584648}
-
Justin Cohen authored
Bug: 869392 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49d6eb03cecf76d8ed7ec476f300b6b4cb5de23 Reviewed-on: https://chromium-review.googlesource.com/1180550Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584647}
-
Tom Anderson authored
The GTK theme draws a different top area depending on if Chrome or the window manager draws the frame [1]. On themes like KDE's Breeze, these colors can be very different. This can cause colors calculated from the frame color (like the inactive tab text color) to be calculated incorrectly. This CL caches the system and Chrome frame colors in GtkUi and gets the appropriate one depending on the user's preferences. Also fix the GTK2 build. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/native_theme_gtk3.cc?rcl=ae5bd514aea0486e53a743ddc2870ac3029eb9b3&l=654 BUG=875844 R=pkasting Change-Id: Ia3e8065de1f843618277b6c562bb9fb54671691d Reviewed-on: https://chromium-review.googlesource.com/1182508 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584646}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f2bae22e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23106 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I835e44bffee560c96453d83cf02d2c7c9ae379d4 Reviewed-on: https://chromium-review.googlesource.com/1182607 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584645}
-
Yuzu Saijo authored
This CL fixes a bug in test_suites.pyl and introduces sharding to memory.leak_detection benchmark. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1180788 TBR=nednguyen@chromium.org,dpranke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ie1a3be0b3b47a9feb57d77a779a6df8cf8257a3c Reviewed-on: https://chromium-review.googlesource.com/1182714Reviewed-by:
-
Dominic Mazzoni authored
In http://crrev.com/c/1152180, we introduced AXTreeSerializer::InvalidateSubtree. This replaced AXTreeSerializer::DeleteClientSubtree, which was problematic and led to subtle, hard-to-catch unserialization errors. This patch adds comprehensive tests for InvalidateSubtree by introducing it into the "generated tree" tests, which try every permutation of trees with up to a certain number of nodes and every possible change to those trees. Now those tests also try every possible way to invalidate a subtree before serializing. This uncovered one subtle bug: the code to detect reparenting also needed to check the 'invalid' flag and recursively check invalid children. Bug: 870661, 866293 Change-Id: I45313b712e50db4fba16a5d55f72ecd440f04335 Reviewed-on: https://chromium-review.googlesource.com/1180091Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#584643}
-
Sadrul Habib Chowdhury authored
The fix from the original change is to share the shared-memory handle with the child process only if a child process is actually launched. There can be configurations where a child-process is not launched (e.g. for in-process gpu etc.), and in such cases, it is not necessary to create a separate PersistentMemoryAllocator, since there already is an existing one for the browser process. Original change's description: metrics: Initialize persistent metric allocator early. The PersistentMemoryAllocator in the gpu (and other) process is created asynchronously. If any uma-histogram is reported before that time, then those Histograms are not stored in the shared memory. This has some implications: . If the process crashes (which is common for the gpu process on android), then these metrics are lost. . If the process stays alive, then the metrics are reported periodically, but because it is buffered, it doesn't match up correctly with the other metrics that are reported in the shared memory. The allocator is created in response to a message from the browser, which includes the handle for the shared memory to use for the allocator. The browser waits until the process has been launched and connected. So this happens much later, compared to other messages which are sent from browser over mojo without waiting for the connection to have been established first. Therefore, change this so that the browser immediately shares the shared-memory segment with the gpu process. mojo takes care of waiting for the process-launch etc. BUG=865179, 778749, 875640 Change-Id: Ieffc014ae711d4bc922cda8034bc4a05fd861bde Reviewed-on: https://chromium-review.googlesource.com/1182041Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#584642}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I564642174a6ceee6002c6e041b0f32e5d5adf7b5 Reviewed-on: https://chromium-review.googlesource.com/1182942Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#584641}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5b10a4c713fb..b2b00c31f48c git log 5b10a4c713fb..b2b00c31f48c --date=short --no-merges --format='%ad %ae %s' 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in JBig2_GrdProc.h 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in CXFA_GEColor. 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in CPDF_ObjectWalker. 2018-08-20 tsepez@chromium.org Use more UnownedPtr<> in CPWL_Wnd::CreateParams. 2018-08-20 thestig@chromium.org Fix nits in CXFA_Node. 2018-08-20 thestig@chromium.org Clean up CXFA_Graphics::SetLineDash(). 2018-08-20 thestig@chromium.org Fix reversed arguments to GenerateResourceDict(). 2018-08-20 thestig@chromium.org Simplify CPDF_InterForm::GenerateNewResourceName(). 2018-08-20 thestig@chromium.org Avoid an integer overflow in CFX_RTFBreak. 2018-08-20 thestig@chromium.org Use more consts in CFX_Break. Created with: gclient setdep -r src/third_party/pdfium@b2b00c31f48c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875282 TBR=dsinclair@chromium.org Change-Id: Ib1dfc7139886c5721ccd3180cb512b04ce4c293f Reviewed-on: https://chromium-review.googlesource.com/1182641Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584640}
-
Jeremy Klein authored
The PWA install API always needs the experiment URL params for now, but the service worker logic can never have those or stuff breaks. This change resolves that discrepancy. Also switch the staging url to point to one that doesn't require uberproxy because the PWA install API doesn't play well with URLs that have redirects. This still points to the same actual Messages code, though. R=azeemarshad@chromium.org Bug: 870072 Change-Id: I23f6f0c4d375f2301cfd1b8efb94d36bf88581cf Reviewed-on: https://chromium-review.googlesource.com/1182868Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#584639}
-
Timothy Loh authored
Since we have crostini_pref_names, the kCrostiniRegistryPref for the Crostini registry should be in there instead of being separated. Change-Id: Ia89192dc2ac11c9cd38bf79725fc3951e3d99211 Reviewed-on: https://chromium-review.googlesource.com/1179510Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584638}
-
Alexander Alekseev authored
min-height/min-width => height/width if(getAttribute) => if(hasAttribute) Bug: 864686 Change-Id: If179f64af2d3ced1f2902a6c1b205a37558f709c Reviewed-on: https://chromium-review.googlesource.com/1182502Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#584637}
-
Artur Khachatryan authored
Handle the case where args.GetSize() > 1. This happens when the first arg is a printf-style format string. We previously return the first arg format string to the test client. Now, we return all args separated by spaces. The oroginal author of this change was sblancov84@gmail.com Bug: chromedriver:669 Change-Id: I9d1f3389baf967108858254df847c358ec1a35c2 Reviewed-on: https://chromium-review.googlesource.com/1179069Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584636}
-
Eric Karl authored
We currently populate a |current_surface_size_| variable in Render... WidgetHostViewAndroid via frame sizes in SubmitCompositorFrame. In Viz mode we don't get SubmitCompositorFrames, so we miss these udpates. This variable is used for fullscreen transition improvements and general frame-readiness checks. This value is present in RenderFrameMetadata, and can be populated from there in the Viz case. Bug: 871774 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6892cbb35590e03e2b8a7d2d822a7b29308f7439 Reviewed-on: https://chromium-review.googlesource.com/1180517Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584635}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/820ebd0f6616..bcdf5f1a944e git log 820ebd0f6616..bcdf5f1a944e --date=short --no-merges --format='%ad %ae %s' 2018-08-20 buildbot@webrtc.org Roll chromium_revision c092e144..e247d795 (584376:584490) 2018-08-20 aluo@chromium.org Default runner to junit4 Created with: gclient setdep -r src/third_party/webrtc@bcdf5f1a944e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:868610 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fb236891fecb882f247195ee49737cfe1bfa7eb Reviewed-on: https://chromium-review.googlesource.com/1182203Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584634}
-
rbpotter authored
settings.pages is used outside of pages_settings.js for 3 reasons: (1) To send page numbers to the PDF plugin (2) To set the page count in the print header (3) To set the page count in the print ticket During the development of the N-up printing feature it has become clear that the n-up pages need to be used in place of the original document page indices in all 3 of these locations, so we should set settings.pages to the n-up values. Note that the print preview ticket still needs to use the page indices for the original document, in order to know what pages should be included in the preview. However, since PrintPreviewHandler expects this setting to be in ranges format, the print preview ticket uses settings.ranges, which this CL keeps the same as before (i.e. using the original document's page numbers). Bug: None Change-Id: Ieaad8d75e5125c0dac185f407c665b336aaf4334 Reviewed-on: https://chromium-review.googlesource.com/1174704Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584633}
-
braveyao authored
The IOSurfaceCapturer for MacOSX has great experiment results on all channels. So move on to next step to enable it by default on TOT before enabling it 100% everywhere. Bug: 840597 Change-Id: I99f0dd64c3ce280173f89cb73012bbd3077f54a2 Reviewed-on: https://chromium-review.googlesource.com/1181921Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d744124a6f8..ca0cdef06349 git log 8d744124a6f8..ca0cdef06349 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 enne@chromium.org Add flush_on_framebuffer_change workaround 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f26b27e29535..d20e80b840e4 (1 commits) 2018-08-20 bungeman@google.com Improve name table handling. 2018-08-20 csmartdalton@google.com ccpr: Rename GrCCPathParser to GrCCFiller 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Remove occluded rrect blur benchmark 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Change drawPathWithMaskFilter to drawShapeWithMaskFilter Created with: gclient setdep -r src/third_party/skia@ca0cdef06349 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 829614 TBR=fmalita@chromium.org Change-Id: I53a902631a3e1f5d1048232bc64016304574109b Reviewed-on: https://chromium-review.googlesource.com/1182682Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584631}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f8268f7ccb65..4b9089142927 git log f8268f7ccb65..4b9089142927 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 vapier@chromium.org tree_status: remove unused modules 2018-08-21 vapier@chromium.org pylintrc: document deprecated-modules field 2018-08-21 vapier@chromium.org pylintrc: ban exit & quit builtins 2018-08-21 xixuan@chromium.org cbuildbot: Let SkylabHWTestStage run any suite. 2018-08-21 xixuan@chromium.org cbuildbot: Add ASyncSkylabHWTestStage for skylab. 2018-08-21 xixuan@chromium.org autotest: Enable '--use-fallback' for Skylab suites 2018-08-20 manojgupta@google.com chromeos_config: Start testing ubsan builds. 2018-08-20 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-20 bmgordon@chromium.org chromeos_config: Add grunt to pi pfq Created with: gclient setdep -r src/third_party/chromite@4b9089142927 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I179a70c432a655ae5535f02484371bf03fd333af Reviewed-on: https://chromium-review.googlesource.com/1182681Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584630}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f26b27e29535..d20e80b840e4 git log f26b27e29535..d20e80b840e4 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 tobine@google.com More EGL validation refactor Created with: gclient setdep -r src/third_party/angle@d20e80b840e4 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib6fb43baf13622ddebe23aacd54d381cf196a7ec Reviewed-on: https://chromium-review.googlesource.com/1182262Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584629}
-
Xianzhu Wang authored
The bug no longer reproduces. Remove the failure expectation, rename it to scrolling-neg-z-index-descendants.html because there is no repaint needed for the composited neg-z-index layer, and update the baseline. Bug: 702006 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87f2f2d93b8024a21aed5929f1fe601065db9806 Reviewed-on: https://chromium-review.googlesource.com/1181522 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#584628}
-
Anand K. Mistry authored
At the same time, fix up two outstanding TODOs: 1. A potential memory leak due to lack of callback data ownership. 2. Not correctly reporting unmount errors on a multi-parition device. Also add some tests for UnmountDeviceRecursively. BUG=873903 Change-Id: I3e99afa4e0185b18c1d7077a5c65fc225a5751b3 Reviewed-on: https://chromium-review.googlesource.com/1179421Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584627}
-
Sam McNally authored
For DriveFS, most operations are handled as native file operations. However, some operations require special-casing; for those we need a custom filesystem implementation to override those implementations. Bug: 874314 Change-Id: I91fffdfb260d6dc53241eed13b734f2df8354f8a Reviewed-on: https://chromium-review.googlesource.com/1180829 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
The test should use better way to compare floating point numbers to handling below case: ../../content/browser/renderer_host/input/fling_controller_unittest.cc:303: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.121721 vs 0 TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996, 875777 Change-Id: Ib9eab4988b1809a753068f7cc2da5815ee7780f1 Reviewed-on: https://chromium-review.googlesource.com/1182713Reviewed-by:
-
Eugene But authored
-[CRWWebController setDocumentURL:] will have a DCHECK when new document URL does not match last committed URL in WKBasedNavigationManager. This DCHECK will help to diagnose possible URL spoofing bugs in Slim Navigation feature. Mocking WKWebView.URL will prevent that DCHECK from firing in CRWWebControllerTest.CurrentUrlWithTrustLevel. Bug: 1171671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19e317079859306948fa6a925bd37d2157987876 Reviewed-on: https://chromium-review.googlesource.com/1182320Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584624}
-
Bo Liu authored
Also ensure members are initialized so the move constructor doesn't use uninitialized values. Bug: 871604 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ab800fec100ccf7ec4de3dd63dfcd28b1e5c5df Reviewed-on: https://chromium-review.googlesource.com/1178302Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584623}
-
