- 24 Oct, 2018 40 commits
-
-
mrefaat authored
Use webstateImpl method for tests instead. Also remove tab_private includes where it's no longer used Bug: 620465, 898381 Change-Id: I0db31eecf93eef1f8e88aa4428f16f25ff3a03b7 Reviewed-on: https://chromium-review.googlesource.com/c/1298243Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#602426}
-
Aga Wronska authored
When during demo mode setup error occurs the message displayed to the user contains description of the problem and suggested recovery method. It helps users as well as support and developers. Bug: 889604 Test: demo setup unit and browser tests. Change-Id: Ia2ea4b1d9e1b4667ca9dde139d3a4aaba3a58cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1280311Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#602425}
-
rajendrant authored
This CL removes session network stats and historic network stats shown in net-log bandwidth tab. Bug: 894946 Change-Id: I8a18f2ae62c17bf877af398c61168b05da315c6c Reviewed-on: https://chromium-review.googlesource.com/c/1297646Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#602424}
-
mrefaat authored
Remove with its users. Bug: 898379 Change-Id: Ie5a127c17c93b811e230c19b5998d81feee81270 Reviewed-on: https://chromium-review.googlesource.com/c/1298234Reviewed-by:
-
mrefaat authored
Not used. Bug: 898382 Change-Id: I796eac237414917a12944a2ce67b3963f035dfb0 Reviewed-on: https://chromium-review.googlesource.com/c/1297463Reviewed-by:
-
Scott Violet authored
Biggest non-style/c++11 change is to convert from NotificationRegistrar to BrowserListObserver. This should not result in any functional change. BUG=889097,268984 TEST=covered by tests Change-Id: I8ea1c89f28c66f312fbcfda925591f96852d2173 Reviewed-on: https://chromium-review.googlesource.com/c/1298123Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602421}
-
yiyix authored
Update the expected behavior for OnDestroyedCompositorFrameSink and OnInvalidatedFrameSinkId: OnDestroyedCompositorFrameSink(element): Set the |element| to not connected, move all its children to |element_root| and remove |element| from its parents. OnInvalidatedFrameSinkId(element): free the memory of |element| and follow the same steps as OnDestroyedCompositorFrameSink. TEST=Manual, doesn't crash after connected. Change-Id: I06eb18fe14a017d50fc8209cc20251da9ed7f0a5 Reviewed-on: https://chromium-review.googlesource.com/c/1294411Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#602420}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8bc0f79a..7bd88028 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3639e3a07bc6e252d1bd6b74d59c84a1858384c Reviewed-on: https://chromium-review.googlesource.com/c/1298224Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602419}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I9aa48df17b16259fd9635e226c6bb9ea347e0fda Reviewed-on: https://chromium-review.googlesource.com/c/1296595 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#602418}
-
Scott Graham authored
Bug: 808287, 898088 Change-Id: I7aa9dd73aa405e32a46118dfe8474c7849471caf Reviewed-on: https://chromium-review.googlesource.com/c/1297460Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602417}
-
Eugene Kim authored
No more needed 'NullString' identifier because '[TreatNullAs=NullString]' doesn't belong per spec. Bug: 497307 Change-Id: I06356118e3b061fb5801fd1704dd470d7f13407e Reviewed-on: https://chromium-review.googlesource.com/c/1293046 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#602416}
-
Nico Weber authored
Bug: 870611 Change-Id: I311f2dcdafe25fea71ce0494424602e0e1989bb7 Reviewed-on: https://chromium-review.googlesource.com/c/1298174Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602415}
-
Alexandre Frechette authored
Bug: 883456 Change-Id: I990f680aeb7cb7c18571abc63c09573bcc6f3b1c Reviewed-on: https://chromium-review.googlesource.com/c/1297486 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
-
Scott Graham authored
(Probably could use some improvement to make file:/// work more Fuchsia-like, but this at least makes the file compile.) Bug: 808287 Change-Id: Id4476f6ec9d2f37006df439a72855587bb18b4c3 Reviewed-on: https://chromium-review.googlesource.com/c/1298178Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602413}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c294aaed. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" 36e64bc7 "Updating tests for Window onerror is not triggered bug fix." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26640 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Iab28747a0ad819fdd6108eb37314ad46de4859e8 Reviewed-on: https://chromium-review.googlesource.com/c/1298117 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602412}
-
Peter Kotwicz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1253206 made WebApk.apk and NewSplashWebApk.apk use the same AndroidManifest.xml template. In doing so, the CL caused the NewSplashWebApk.apk-specific-code in AndroidManifest.xml to be uploaded to the WebAPK server. This CL changes the "webapk_tmpl" GN template to run pystache twice. Pass #1 to generate AndroidManifest.xml to be uploaded to the WebAPK server. Fields which cannot be customized by the WebAPK server on a per-site basis are filled in. Pass #2 fills in the remaining fields to generate AndroidManifest.xml for the test APK (WebApk.apk, NewSplahWebAPk.apk). These APKs are for local testing and are not uploaded to the WebAPK server. BUG=817263 Change-Id: I3d4849d122195ba2e3d82bfb7bb5661dd765e3f7 Reviewed-on: https://chromium-review.googlesource.com/c/1279953 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/472639d9f12f..2d123ad73f85 git log 472639d9f12f..2d123ad73f85 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 herb@google.com Remove unique glyph IDs from glyph runs 2018-10-24 jvanverth@google.com Reland "Some more clean-up of YUVA code" 2018-10-24 bsalomon@google.com Make GrOp base class responsible for merging bounds. Created with: gclient setdep -r src/third_party/skia@2d123ad73f85 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Ia06d6e9d8d70930b9cba6883d99b852163f79080 Reviewed-on: https://chromium-review.googlesource.com/c/1298154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602410}
-
Alexandr Ilin authored
PreconnectManager is designed with restriction on the maximum number of simultaneous dns requests. There are instances of violation of this constraint. Each dns job has an alternative proxy resolve job that can finish first, cancel pending dns job and schedule a new one. However, this cancelling is asynchronous and wouldn't have an effect if a dns job was already scheduled in the network stack. This CL makes the PreconnectManager wait for dns job being cancelled before scheduling a new one. Bug: 883806 Change-Id: I8e90ad0dce55b569a4c77b202435f70a6b776231 Reviewed-on: https://chromium-review.googlesource.com/c/1292880Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602409}
-
Jeremy Roman authored
This is deprecated in favor of explicitly checking with v8::Maybe<bool>::To. Bug: 670615 Change-Id: I71e8f3c1f643a7eabfaf25359581c15565513302 Reviewed-on: https://chromium-review.googlesource.com/c/1298049Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602408}
-
Rayan Kanso authored
Bug: 774054 Change-Id: I42ce8c29699701aec0df0de806ca5077bf49a056 Reviewed-on: https://chromium-review.googlesource.com/c/1297144Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#602407}
-
Khushal authored
This reverts commit e9928022. Reason for revert: Speculative fixes have landed in skia. Original change's description: > Revert "cc: Cache text blobs in the GPU service." > > This reverts commit 57df0676. > > Reason for revert: Seems to be causing a crash on Mac. > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28Intel%29/327 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Release%20%28Intel%29/6072 > > Crash in __ZN13GrCCPathCache5evictEP18GrCCPathCacheEntry > > Bug: 897507 > > Original change's description: > > cc: Cache text blobs in the GPU service. > > > > Since skia's internal caching is keyed on text blobs, its important to > > reuse the same object. Make sure we cache text blobs in the > > ServiceTransferCache to get a cache hit in skia. > > > > R=enne@chromium.org > > > > Bug: 894200 > > Change-Id: I8808d649ca3520211d034e07e7d4670ffb39094c > > Reviewed-on: https://chromium-review.googlesource.com/c/1292722 > > Commit-Queue: Khushal <khushalsagar@chromium.org> > > Reviewed-by: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601404} > > TBR=enne@chromium.org,khushalsagar@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 894200 > Change-Id: I5e0a151c5a539aa8a9b6cac5f9bcf710ba2f405a > Reviewed-on: https://chromium-review.googlesource.com/c/1292384 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601451} TBR=jmadill@chromium.org,enne@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897507, 894200 Change-Id: I345adbbfaff91ab201d68e73e861dd4ccce41775 Reviewed-on: https://chromium-review.googlesource.com/c/1298235Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602406}
-
Eugene But authored
This change will only allow blob URLs loading into WKWebView. blob URL downloads are still unsupported. Bug: 847073 Change-Id: I09a963c5b427eb7e3f8530f5b999c34da0fcfa7a Reviewed-on: https://chromium-review.googlesource.com/c/1297390Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#602405}
-
Anders Hartvoll Ruud authored
This special serialization behavior belongs in the css directory. Also, in a subsequent CL (for css-properties-values-api), it will be necessary to expose the alpha rounding part of the serialization, and I don't want to add this function to platform/color.h. Change-Id: I4512e695016b6495c6b9197b521cda6431642962 Reviewed-on: https://chromium-review.googlesource.com/c/1293614Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#602404}
-
Kevin Marshall authored
Fuchsia SDK source library manifests have a special entry just for FIDL dependencies that is separate from the other dependencies. Use it! Bug: 898088 Change-Id: Iab2fdbdefbb3b6cbf169aac81860e698108bd2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1297467Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#602403}
-
Justin DeWitt authored
This fixes a TODO where we weren't requesting that the server send us an empty catalog when we have already downloaded the current version. Bug: 898327 Change-Id: I39c0911a71947ac553ef224830d97fcdd39eed3d Reviewed-on: https://chromium-review.googlesource.com/c/1297607Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#602402}
-
mrefaat authored
After CRWWebDelegate removal & AppLauncher refactoring, U2F schemes are not handeled by the app launcher correctly. The reason is that the check for valid URL was happening after the x-callback URL conversion by the U2F delegate. This CL moves that check to happen before the conversion and add some simple tests on the applauncher tab helper to make sure that errors in that part is caught. Bug: 897329 Change-Id: I45445248a8d676528b362e0cae8f2ddec4ffbe3b Reviewed-on: https://chromium-review.googlesource.com/c/1297293 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#602401}
-
Geoff Lang authored
BUG=angleproject:2708 BUG=angleproject:2394 BUG=angleproject:2672 BUG=angleproject:2722 BUG=angleproject:2885 BUG=angleproject:2887 BUG=angleproject:2897 BUG=angleproject:2898 BUG=angleproject:2899 BUG=angleproject:2900 BUG=angleproject:2901 BUG=angleproject:2902 BUG=angleproject:2903 BUG=angleproject:2904 BUG=angleproject:2905 BUG=angleproject:2909 BUG=angleproject:2910 BUG=angleproject:2911 BUG=angleproject:2912 BUG=angleproject:2913 BUG=angleproject:2914 BUG=angleproject:2915 BUG=angleproject:2916 BUG=angleproject:2917 BUG=angleproject:2918 BUG=angleproject:2919 BUG=angleproject:2920 BUG=angleproject:2921 BUG=angleproject:2922 BUG=angleproject:2926 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95256ed99a046297a4f38af2e25d1f72a4d711a3 Reviewed-on: https://chromium-review.googlesource.com/c/1284393 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602400}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cebaec875850..334f03f88fc4 Created with: gclient setdep -r src-internal@334f03f88fc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d89b2db510fb1154d6d896af573470fb22e030e Reviewed-on: https://chromium-review.googlesource.com/c/1298072Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602399}
-
Fernando Serboncini authored
Bug: 888458 Change-Id: Ib17eff8795d8daaa2e67f3c478f71079a52b9d5a Reviewed-on: https://chromium-review.googlesource.com/c/1283488Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602398}
-
Etienne Bergeron authored
This CL is adding a trace events to debug some failures happening in the field. An instant event will be present with an error code. R=wittman@chromium.org BUG=882982 Change-Id: I0a55ca82c4312bb212a5b7d1f3e391b42d3d38c9 Reviewed-on: https://chromium-review.googlesource.com/c/1297065 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602397}
-
Justin Cohen authored
Also adds x86 compilation. Change-Id: I10adee5c61795ea0f13004db26471367e0482c7a Reviewed-on: https://chromium-review.googlesource.com/c/1296877Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602396}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/962ec4e02afc..b6c3804254e9 git log 962ec4e02afc..b6c3804254e9 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 yshaul@google.com chromeos_config: Migrate no_hwtest_builder to test config 2018-10-24 yshaul@google.com chromeos_config: Migrate no_vmtest_builder to test config Created with: gclient setdep -r src/third_party/chromite@b6c3804254e9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If30a631bad91780e2c8b6b5e5fa675a8f31b9d42 Reviewed-on: https://chromium-review.googlesource.com/c/1298155Reviewed-by:
-
Scott Graham authored
Bug: 898088 Change-Id: Iaf7c0013ff0c7fa64f008023619962526bc41b81 Reviewed-on: https://chromium-review.googlesource.com/c/1298223Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602394}
-
Xiaocheng Hu authored
The passed-in position in DragCaret::SetCaretPosition is a hit test result (see DragController::TryDocumentDrag), which is already a canonical position. Hence, there's no need to canonicalize it again. Bug: 897983 Change-Id: I58f9bff731842a4d9f7c201f95ec2af769e158d7 Reviewed-on: https://chromium-review.googlesource.com/c/1297641Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602393}
-
Wez authored
We have neither a use for, nor an implementation of, named platform channels under Fuchsia, so remove the APIs and NamedPlatformChannel handle type entirely under that platform. Bug: 754038 Change-Id: I85319f7b2df2e897e1fd34046911a2a11d5f4a20 Reviewed-on: https://chromium-review.googlesource.com/c/1288900Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602392}
-
Zhenyao Mo authored
We could blacklist WebGL based on GL version, which is after creating a context. Right now this will trigger a failure and GPU process will exit and then relaunch with SwiftShader mode, which pre-load SwiftShader before sandbox init. So users will not notice, but this GPU process exit and relaunch is less optimal and unnecessary. BUG=897914 TEST=manual R=kerrnel@chromium.org,kbr@chromium.org,sugoi@chromium.org Change-Id: Idcd018ca1f2e5161002cdae4563462c76316c606 Reviewed-on: https://chromium-review.googlesource.com/c/1297481Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602391}
-
David Jacobo authored
git cl lint pointed TouchSelectionControllerImpl should include set. Bug: None Test: Build. Change-Id: I8b78fbf36092116e35e287edb96557fc9be9f70d Reviewed-on: https://chromium-review.googlesource.com/c/1297247Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602390}
-
danakj authored
When a RenderWidget is created for a RenderViewImpl, it may be considered "swapped out". This means the main frame for this RenderView's frame tree is not local, the RenderView exists to hold some other local subframe, which will be composited and have a RenderWidget. Thus the RenderWidget attached to the RenderViewImpl is not actually used, there is no output from the remote main frame in this tree. I like to refer to these swapped out RenderWidgets as zombies. During navigations, a RenderViewImpl's main frame may change to or from being local, in which case the RenderWidget attached to it changes to or from being a zombie. When becoming a zombie, the WebFrameWidget attached to the RenderViewImpl (wrapping the WebViewImpl) is destroyed, and this marks the compositor as SetVisible(false) on the RenderWidget (via the WebViewImpl). When becoming alive again, a new WebFrameWidget is attached to the RenderViewImpl, and the WebFrameWidget marks the compositor as SetVisible(true) on the RenderWidget (via the WebViewImpl). While a zombie, the WebViewImpl is also told not to allow any visibility changes to be passed along to the RenderWidget. This is because as the local subframe becomes visible with the Page, we'd tell the WebView about this, to tell the Page. But since the WebView now has a zombie RenderWidget, it shouldn't also tell that. Note when the RenderViewImpl is created and initially swapped out it creates a RenderWidget but nothing tells its compositor about the zombie state of affairs, so it becomes visible, which makes it acquire a Gpu channel and start its scheduler etc. Woops. This CL rearranges things a bit. - A new RenderWidget does not SetVisible(true) if swapped out. - RenderViewImpl directly marks it SetVisible(false) when removing the WebFrameWidget. - RenderViewImpl *also* removes the LayerTreeFrameSink to drop the Gpu channel since we don't need to be fast at becoming visible (the RenderWidget is a zombie!) - RenderViewImpl directly marks it as SetVisible(true) when getting a new WebFrameWidget as the RenderWidget stops being a zombie. - WebViewImpl stops calling SetVisible on the RenderWidget when its main frame is not visible. In the future the RenderWidget should be a member of the main LocalFrame, and thus won't even exist when the main frame is not local. R=dcheng@chromium.org, piman@chromium.org Change-Id: I87a5d0dfeaaf08cb91c9348b26b4205db55b3a81 Bug: 894899, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1290140Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#602389}
-
Erik Chen authored
Restarting content shell between layout tests increases run time by 2-5x but produces more consistent results. Previously, this was implemented as a flag to content shell that would restart the renderer between tests. This CL changes the test runner to instead restart content shell between tests. This has comparable run time, with less complexity and even less probability of state carrying over between tests. The content shell flag --reset-shell-between-tests is now unused, and will be removed in a future CL. Bug: 894527 Change-Id: Idce9a74006000ded0d308affaff0568226a2cf7f Reviewed-on: https://chromium-review.googlesource.com/c/1296673 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602388}
-
Ricardo Quesada authored
Update Underlay candidates' damage_rect even if they don't get promoted to overlays. At the moment they do have the damage_rect updated when they get promoted. But not otherwise. There is corner case when the damage_rect is must be updated redarless whether the candidate gets promoted. This CL fixes that. And also fixes some "git cl lint" warnings (missing #include <vector>) BUG=b:116355420 BUG=b:117341940 TEST=viz_unittests --gtest_filter=UnderlayTest* Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic543d844c09f47c845cfe0103f0462f5f67a9dbc Reviewed-on: https://chromium-review.googlesource.com/c/1286275 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#602387}
-
