- 20 Aug, 2020 40 commits
-
-
Kyle Horimoto authored
PhoneModel stores an in-memory model of the phone during a Phone Hub session. Currently, it only holds a PhoneStatusModel, but future CLs will add support for other parts of the model (e.g., notifications, Chrome tabs, and quick action button status). PhoneModel also provides an observer interface for clients to use to be notified when the model changes. This CL also creates the MutablePhoneModel class, which provides setters which can cause the model's data to change. PhoneHubManager instantiates a MutablePhoneModel when it is created and exposes it publicly via a PhoneModel*, which ensures that clients of the model cannot edit its contents. Bug: 1106937 Change-Id: I011c4f62916b158b291eb4abb0f38ab91fef7ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365225 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799975}
-
sczs authored
Bug: 1085419 Change-Id: I3462548de584dbc49601c0c608d1046f6dd770ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363725 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#799974}
-
nancylingwang authored
Web apps usually provide multiple images with different sizes. When the system supports multiple scales, calculate the different sizes for scales and load images for all supported scales to get higher icon quality. This method is consistent with the websize icon shown on the browser tabs. Due to the different visual effects for maskable and non-maskable icons, and to keep the consistent icons from multiple monitors, check whether the maskable icon is available for all scales. If yes, use the maskable icons for all scales, otherwise, use the non-maskable icon for all scales. BUG=1083331 Change-Id: Ieca447e41780c09d5c818cda9a990899b2af74ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362063Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799973}
-
Justin Donnelly authored
Includes a new id() field on OmniboxPedal containing values from the existing OmniboxPedalId enum to support the recording of the histogram. Bug: 893183 Change-Id: Id2ee32bf92fdac869cfcc822710ca61c55d77971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363852 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#799972}
-
Joey Arhar authored
As part of the origin trial for beforematch, we are supposed to add a UseCounter for beforematch. Bug: 1117539 Change-Id: Ic312dbd9e54a7cda343babf0cd8df8fdd34f720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363468 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799971}
-
Arthur Eubanks authored
Ran `./tools/clang/scripts/upload_revision.py a1caa302970de86b15d360212b526be8f1d59641`. Bug: 1113154 Change-Id: I2fd71f7e0c200b9f3527a0773e70946fd4669808 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363329 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799970}
-
Ian Kilpatrick authored
Follow up of: https://chromium-review.googlesource.com/c/chromium/src/+/2363325 There should be no behaviour change. Change-Id: I435a75bcc51bcf17acd17fc9079bbb563cd587aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365913 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#799969}
-
Ahmed Mehfooz authored
Bug: 1114942 Change-Id: I09ed115f500bc32900f724c9718ec23396a0c5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364272 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799968}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/abfdfbb66838..c244e33eadec 2020-08-19 pasko@chromium.org [Telemetry] Always flush pagecache for browser directory on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1119406 Tbr: eseckler@google.com Change-Id: Id278e92513ad695505d6e6eb92cf4cf340b077e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799967}
-
Peter Kasting authored
* Make more things constexpr and/or make it possible to do so later * Inline SaturatedAdd/Sub(), FromDouble(), FromProduct() * Order the FromUnits{,D}() pairs together * Init members in declaration * Briefer implementations of various functions * IWYU * Fix declared-but-not-defined issue for FromTimeSpec() w/OS_FUSCHIA * Use more specific DCHECKs * No else after return * Omit needless qualifiers * EXPECT -> static_assert where possible * <atomic> is legal now * Don't handle DCHECK failure The inlines don't hurt size: this saves 4 KB off chrome.dll in my local release build. First landed as r799459, reverted due to test flakiness. Bug: none Change-Id: I385263d97494946e1693062063cb27f7e0ea9f7f TBR: stevenjb, tsepez Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365092Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799966}
-
Adam Langley authored
caBLEv2 no longer uses a FidoCableDevice and thus the |FidoCableDeviceConnected| and |FidoCableDeviceTimeout| callbacks only come from v1 devices. With that the discovery data can drop out of |observed_devices_| Change-Id: I430d9d9fdbb8681194dff30c12fb0dc835c1785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365360 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799965}
-
Toni Barzic authored
Introduces HoldingSpaceItem::Type enumeration with types that will be supported in the holding space UI - pinned files, downloads and screenshots. Also adds data that will needed to represent the items in the UI (in addition to the existing text item representation) * the item's absolute file path * the file system URL of the file backing the item * the image representation of the item Changes how the item ID is calculated - instead of a randomly generated GUID, the ID is now deffered from the item type and file system URL. Changes HoldingSpacePresenter to track items per type (the class is still only used by a test, but should be eventually be hooked up with the holding space tray bubble code). Updates screenshot grabber to add the screenshot to the holding space after creating the screenshot file and loading the screenshot bitmap. BUG=1112014 Change-Id: Ibc13dfb7bc59fbe5079bd4bafeb354f438dc7f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359230 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#799964}
-
Matt Falkenhagen authored
This reverts commit 19d1314e. Reason for revert: The speculative revert did not result in improvement. Original change's description: > Revert "Use typesafe helpers to pass WebEmbeddedWorker Mojo pipes across Blink public API" > > This reverts commit da054331. > The code review was https://chromium-review.googlesource.com/c/chromium/src/+/2227103 > > Super speculative revert since we have no other clues about the perf > regression which started in a range the CL landed in. > > Bug: 1096423, 1059157 > Tbr: dcheng > Change-Id: Ia291b0c16c0cacfcdd40387a6b8badd135fcf7b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355630 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798067} TBR=falken@chromium.org,dcheng@chromium.org,shimazu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1096423 Bug: 1059157 Change-Id: Ibaa28a209cc2ac79d6e60b78c5b1d0860d65f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366172Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#799963}
-
Renjie Tang authored
Change-Id: I8a03f403342f90340224eddfaa12b04a47e9ff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364955 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799962}
-
Ian Barkley-Yeung authored
Document the problems with base::FileEnumerator::GetInfo() when used with INCLUDE_DOT_DOT. It doesn't work correctly (gives incorrect last-modified times) on Windows or Fuchsia. The unit test mentions the problems, but it's good to have it more visible. Also, fix up GetInfo() comment overall. BUG=chromium:1106172, chromium:1119546 TEST: None, comment only. Change-Id: If96fb2b9b59b9b70f7e51cb1bc0cc9266bef1bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365359 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799961}
-
James Cook authored
We've decided to require backwards compatibility for lacros interfaces starting now. This requires marking mojo_base.mojom.FilePath as [Stable] as well. Bug: 1110184 Change-Id: Ia931fe5fa7b46af1199047945d6fb273d9d82e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363450Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#799960}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Ia336322e51a0b1884b588db934c58b6dea294b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364695 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799959}
-
Maggie Chen authored
For Windows 10 only. We only promote one YUV overlay even if there are more than one YUV quads in a frame. We might not save power if the rest of YUV quads are drawn in the Renderer by 3D hardware. The previous overlay strategy that promotes the quad with the biggest pixel size is removed. Bug: 1117240 Change-Id: Id729e5d8af842682528c2dcb9d0e70e4f49fea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362084 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#799958}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b4f6e3193cf..f6fb6da87dc4 2020-08-19 khushalsagar@chromium.org Revert "Feedback Loop Redesign 2/3: Track bound FBOs in Texture." 2020-08-19 ynovikov@chromium.org Adjust roll_chromium_deps.py to work with autoroller. 2020-08-19 jonahr@google.com Fix language inclusivity for SurfaceMtl.mm 2020-08-19 reveman@google.com Vulkan: Enable VK_KHR_bind_memory2 extension 2020-08-19 jonahr@google.com Fix typo in test harness README 2020-08-19 lehoangq@gmail.com Metal: autogen for EXT_draw_buffers & ANGLE_framebuffer_blit 2020-08-19 amy.liu@arm.com Delete extra initialization in spirv shader. 2020-08-19 jmadill@chromium.org Vulkan: Check aggregate barrier feature instead of caching. 2020-08-19 jmadill@chromium.org Vulkan: Name image layouts. 2020-08-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 1590d46aaaeb to eceb318c06a2 (1 revision) 2020-08-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6f74415e2f74 to cbfd396756c6 (1 revision) 2020-08-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9d431ae2eeb4 to c97acd1d3e07 (1 revision) 2020-08-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e28436f2b8a2 to 3434cb0b006d (2 revisions) 2020-08-19 jmadill@chromium.org Vulkan: Track RP's read/write access for depth/stencil. 2020-08-19 jmadill@chromium.org Feedback Loop Redesign 2/3: Track bound FBOs in Texture. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Id21165189cd3253c8e153b46edc55038e0164438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799957}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/72e31331da03..ef0fb4c2707e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iac14297119ced0a9a34d77d969b9e47335e41e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799956}
-
Nohemi Fernandez authored
Removes method confirmSigninConfirmationDialog from SigninEarlGreyUI. Bug: 1103274 Change-Id: I6c1aead8dbd94e0a5f760c83139af4f99c0e1098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364633 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#799955}
-
Mike Dougherty authored
Tests have become particularly flaky on ios14-sdk bots, often failing at the !gSyncFakeServer DCHECK. The HTTP server and Mock Authentication are always enabled after checking the boolean state so those DCHECKS were not useful. Track the state with static booleans instead which more accurately represents the state. The instance methods will be removed in a follow-up CL once all call sites are updated to call the class methods directly. Change-Id: I6643ffd0eda69d221563150fc08d3127f1bcf416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353092 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799954}
-
Ian Kilpatrick authored
In favour of having logic within: TextFieldInputType::ShouldHaveSpinButton There should be no behaviour change. Change-Id: I07b3222931687c96139ac791d9aca9692caa6659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363464 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799953}
-
Adrienne Walker authored
Once AppCache has been removed from Chrome, sites will have no way of cleaning up user data in local profiles. To fix this, when a storage partition is accessed when AppCache has been disabled, we will delete the AppCache directory from that profile directory. This is a relanding of: https://chromium-review.googlesource.com/c/chromium/src/+/2343588 Bug: 1081897 Change-Id: I14498094d0262c2806eb66ca3cfde85956d59d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357071Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799952}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkNetworkListTest* Change-Id: I34f03657486f03027c4adb5c6ae36aa421a2c239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360925 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799951}
-
Roberto Moura authored
- Change the tabstrip's background to clear to allow the thumb strip to be seen from behind it during enter/exit animation. - Add a pan gesture recognizer to reveal/hide the thumb strip by dragging down/up the tabstrip. Bug: 1094335 Change-Id: I193d848f4ba2aaf07202c6d986496c2ed4b708a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315884 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799950}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: Id2f5fbd3e6a41fad40f1cb2920015b6966281557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351281 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799949}
-
Yutaka Hirano authored
Currently we get a UKM source ID from the frame in WebRequestAPI::MaybeProxyURLLoaderFactory but it's too early - the frame has not been fully committed yet, and the UKM source ID for the previous URL is returned. Get the UKM source ID in WebRequestProxyingURLLoaderFactory::CreateLoaderAndStart, to work around the problem. Bug: 1119320 Change-Id: I1fdd8d301aad916b11eef50e521d7f42087ed41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362071Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799948}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/72e31331da03..ef0fb4c2707e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I979f0a122615ebd44d02a080547697ec4672488c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799947}
-
Hirokazu Honda authored
Encoded bitstreams can contain frames that are worse than the specified tolerance, while the quality of the overall stream is good. To evaluate with the overall quality, this CL adds an option to PSNR and SSIMVideoFrameValidator that the validation fails when the average of the values are worse than their tolerances. Bug: 1045825 Test: video_encode_accelerator_tests on rammus Change-Id: I3d68616081d00a164d0495ed9b295bc6afa0e235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359876Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799946}
-
wutao authored
Bug: b/162880032 Test: added new AmbientControllerTest Change-Id: I9e1104b6d3a8999b2799efa29fc656545b77289a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339642 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799945}
-
Alex Ilin authored
The `ntp-grid` element is going to be useful for new components outside of new_tab_page. This CL moves `ntp-grid` into a common location. Bug: 1115301 Change-Id: Ia8b2e8bb0cebad38b71e17f0eaf251b3bc59e482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362814 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799944}
-
Tal Pressman authored
The AgentSchedulingGroup class is effectively empty, and is not yet instantiated by anything. The mojo interface is currently empty. Bug: 1111231 Change-Id: I0c22cf38033a43c15594863d565b688319a69668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348241 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#799943}
-
Stephen Sigwart authored
there's already a dot. Bug: 1107145 Change-Id: Idda3fc05e148dc8623221bff280c2de965bb1d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358491Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#799942}
-
Piotr Bialecki authored
In addition, alphabetize few outlier methods to make it consistent with the rest of the code here. Change-Id: Iefdd9657e4507f393ee1c2e60dcde33012f2a592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363218 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#799941}
-
Wan-Teh Chang authored
There is also a test named canvas-createImageBitmap-e_srgb.html in wpt/html/canvas/element/manual/wide-gamut-canvas. This CL carries back three recent changes I made to that copy of the test. 1. commit 407ec471: Run sRGB Blob tests with multiple image formats 2. commit a2c09a7b: Add AVIF to canvas-createImageBitmap-e_srgb.html The AVIF test images pattern-srgb.avif and pattern-srgb-transparent.avif were generated from pattern-srgb.png and pattern-srgb-transparent.png using the 'avifenc' program in libavif v0.8.0 with the following command lines: avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \ pattern-srgb.png pattern-srgb.avif avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \ pattern-srgb-transparent.png pattern-srgb-transparent.avif 3. commit 6c2ddda1: Generate one promise_test() for each image format third_party/blink/tools/run_web_tests.py -t Default \ fast/canvas/color-space/canvas-createImageBitmap-e_srgb.html Test: Change-Id: Ic887a9a77170c6ba18db7022180193c205954ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360117Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799940}
-
Claude van der Merwe authored
Bug: 1045266 Change-Id: Ibb0b121d814795aa5b513c740cb32cdac3332188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355555 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799939}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b259fd1b84c..90adfcb7b606 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1116656,chromium:1118191,chromium:1119325,chromium:1119485,chromium:1119510 Tbr: alexmos@google.com Change-Id: I18dfeab2c6c67392c2d39275608344cf4809f1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365275Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799938}
-
Moe Ahmadi authored
Given that ZPS is enabled by default for Desktop and Android, we don't necessarily require new Features to gate ZPS experiments. A dedicated about:flag entry, however, is helpful in that it allows opting in or out of trending zero-suggest experiment. - The added feature does not change any behavior in Chrome. - Adds about:flags entries for Desktop and Android. Bug: 1117219 Change-Id: I146f86af97d37dfb294da956580b832b208f5686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360951 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799937}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/afdbedf7..d2f63b51 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I94d5e24e14db83f9634a752d915709d5f9bffd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365415Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799936}
-