- 03 Jan, 2018 40 commits
-
-
Doug Turner authored
The DNSErrorPageTest::DoClickLink tests clicks on a anchor pointing at title2.html which was handled internally by net. This CL converts loading and testing this resource to use the embedded test server. There are two parts to this CL. The first is a handling the response to mock-link-doctor.json requests need to be modified to return an embedded server url. This is so that urlCorrection returns something that can be loaded by the embedded test server. Note that the embedded server does not run on default ports and that we can not use relative links. The second part of the CL is plumbing to ensure that the Expect* functions know what url to look for. I also moved the starting the server to one place and factored out the test that needed to do something special (SniffSmallHttpErrorResponseAsDownload). Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7af69dec8bc376aa2fe45a9f0c06cb6299f55440 Reviewed-on: https://chromium-review.googlesource.com/848415Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526716}
-
Tim Volodine authored
This patch implements the mechanism for the tracing api in the chromium part of android webview. Contains AwTracingController.java and its native counterpart aw_tracing_controller.{h,cc} with JNI. There is not more than one instance of AwTracingController which is created on first call to getTracingController() in AwBrowserContext. Also makes sure that the TraceRecordMode enum Java counterparts are created in org.chromium.base. BUG=781249 Change-Id: Ie407117efb97da0894f8441e9db5d1c5b60e5a7e Reviewed-on: https://chromium-review.googlesource.com/824605 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526715}
-
stkhapugin@chromium.org authored
Removes usage of scoped_nsobject in ios/web/public. Bug: 717540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icec9644b72efd0d57db00c4ed106575d5de59c9f Reviewed-on: https://chromium-review.googlesource.com/846804Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526714}
-
Randy Smith authored
Bug: 785420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id4d111a9bdae51a4b83438239c09c3e4d41127e9 Reviewed-on: https://chromium-review.googlesource.com/844454Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/d8724a947bd8..93b059db4a5a $ git log d8724a947..93b059db4 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 oetuaho Index symbols by id in OutputHLSL Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I44e352223ba5f81eadd7e3ee5c619668357ef297 Reviewed-on: https://chromium-review.googlesource.com/848750 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526712}
-
Mohamed Heikal authored
Removes static and member functions that initialize CmdLine from BaseChromiumApplication. Functionality is moved to ChromeApplication as well as other "Application"s Bug: 560466 Change-Id: Ia5115dc5ce6009e645e01432c0013af5491e15e4 Reviewed-on: https://chromium-review.googlesource.com/794031 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526711}
-
Antonio Gomes authored
... rather than on the stack. In practice, although the change brings no behavior difference, it will allow WaylandTest ctor to set the proper KeyboardLayoutEngine instance before the WaylandConnection object is created, which in turn will allow WaylandKeyboardTest unittests to be fixed (follow up patch). BUG=None Change-Id: I7f18965a90ea468591c7a6ac7a473c31a1a827cf Reviewed-on: https://chromium-review.googlesource.com/847612Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#526710}
-
Gauthier Ambard authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I05511ee9479c12153ac69b4c794c769d73c0f329 Reviewed-on: https://chromium-review.googlesource.com/848833Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526709}
-
Dave Tapuska authored
The DCHECK was wrong since it can fire if a touch timeout fires and then a touch action is returned. BUG=692729 Change-Id: I00e89e454f7ead0b20db05072809a0c865024cde Reviewed-on: https://chromium-review.googlesource.com/847080 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526708}
-
Hans Wennborg authored
It was bumped in LLVM r321712. TBR=thakis,rnk Bug: none Change-Id: Ief1c0855a99be9d23330b91b8e804348a070822c Reviewed-on: https://chromium-review.googlesource.com/848748Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#526707}
-
Jérôme Lebel authored
Removing the experimental flag from the plist. It should have been done with the rest of the code in this patch: crrev.com/c/653160 This flag has been added in: crrev.com/2779693003 Bug: 739910 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I172af77ff7c9946522441d5710d870ad188acf14 Reviewed-on: https://chromium-review.googlesource.com/848854Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526706}
-
Christopher Grant authored
This will let testers and developers manually verify rendering of secure, insecure, dangerous and offline origins. BUG= R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2cc3d4a2ec3fbb5f4de386fb88eb2364208f9047 Reviewed-on: https://chromium-review.googlesource.com/848254Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#526705}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-disabled-addcue.html 2. track-disabled.html 3. track-element-dom-change-crash.html 4. track-element-src-change-error-handling.html 5. track-element-src-change.html Bug: 782555 Change-Id: I9b4c6a105c8ceae5f8787f511025b2cdaaefc6b9 Reviewed-on: https://chromium-review.googlesource.com/848436Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526704}
-
Helen Li authored
This CL reorders methods in proxy_resolving_client_socket.cc to match that in the header file. Bug: 721401 Change-Id: Id9fb467c335e88f2437ce649d1f969109731d22d Reviewed-on: https://chromium-review.googlesource.com/847286Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#526703}
-
Jinho Bang authored
Bug: 755727 Change-Id: I5ee0dd42892933c502f2fac139ea7c1e6f46d449 Reviewed-on: https://chromium-review.googlesource.com/846601 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526702}
-
Gauthier Ambard authored
The bubble tips are presented with an anchor point to know where the tip of the arrow should be positioned. A delegate was used to get this point. This CL changes it to a named layout guide for the clean toolbar. The named layout guide can't be used with the old toolbar as it is not positioned with auto-layout internally. Bug: 788371 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbca4372faa2738a65161112d0a4ec59c17e3b36 Reviewed-on: https://chromium-review.googlesource.com/848894 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Ned Nguyen authored
Change-Id: I9198c35c130fd59c8e1f1674e9e428edd066413d Reviewed-on: https://chromium-review.googlesource.com/848074Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#526700}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: Id7056e254e7aed6c99cb12ae24bfb9359c39f53f Reviewed-on: https://chromium-review.googlesource.com/840844Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526699}
-
Xida Chen authored
TBR=battre@chromium.org NOTRY=true Bug: 62538 Change-Id: I306085f0649628fbc0bdabfe4a58a83b29daa13d Reviewed-on: https://chromium-review.googlesource.com/848077Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526698}
-
Nicolas Pena authored
This CL adds correctness tests for the toJSON methods for the idls that are modified in this change: https://chromium-review.googlesource.com/c/chromium/src/+/802019 Bug: 740094 Change-Id: I3fcdcf913c7f8a30b9f090a4538b159bf8b6200b Reviewed-on: https://chromium-review.googlesource.com/818114Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526697}
-
Xida Chen authored
TBR=battre@chromium.org NOTRY=true Bug: 798735 Change-Id: I74d9b1aba079c247e2d971e61fb130c78851e39c Reviewed-on: https://chromium-review.googlesource.com/848054Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/910a3dafda47..d8724a947bd8 $ git log 910a3dafd..d8724a947 --date=short --no-merges --format='%ad %ae %s' 2017-12-29 oetuaho Start D3D constant register allocations from 1 on NVIDIA Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Idc36700426655049aaacadd8b9c0949818e854c5 Reviewed-on: https://chromium-review.googlesource.com/848740Reviewed-by:
-
Daniel Bratell authored
Names used in the BaseWindow class are also windows.h macros. That the names are the same as in the Windows API is no coincidence but for now we don't want the Windows macros to interfere so we undef them. There are already undefs in widgets.h but depending on the order of includes they might not be effective. Bug: 773275 Change-Id: I2be80c8a3f64f4741163def9c27e386c95753a40 Reviewed-on: https://chromium-review.googlesource.com/845582Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526694}
-
stkhapugin@chromium.org authored
This reverts CL 779191. Wraps omnibox textfield into a container that positions the textfield inside of itself and clips its bounds so that the optimal clipping is used. The clipping logic replicates that of the pre-iOS 11 solution with UITextField overrides that are now broken in iOS 11. To mask the clipped ends of the omnibox, a ClippingMaskView is used as a maskView of the clipping view. All of this is behind kClippingTextfield flag that is enabled by default. Bug: 749788 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4cc6673200a8fbdc57451dc9120dfd4eeec5a853 Reviewed-on: https://chromium-review.googlesource.com/844079 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Fady Samuel authored
A late arriving CompositorFrame should not activate if the dependent CF has been dropped. This can happen if a CompositorFrame is marked for destruction and then pulled out of the destruction queue ("surface resurrection"). This CL ensures that when a surface is reset, a SurfaceDiscarded notification is sent to the SurfaceDependencyTracker followed by SurfaceCreated to mimic creating a new surface. Bug: 796602 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I20d1e96526db6464f9a095d59ea9633f81ddd615 TBR: samans@chromium.org Reviewed-on: https://chromium-review.googlesource.com/848633 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526692}
-
Rouslan Solomakhin authored
TEST=PaymentRequestPaymentAppTest* Bug: 781287 Change-Id: I81317d3b6299b5617c1886e37596dcbb7f4435de Reviewed-on: https://chromium-review.googlesource.com/814575 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#526691}
-
Daniel Bratell authored
ScriptExecutionCallbackHelper is the name of two different helper functions which in some non-standard jumbo configurations (huuuge jumbo chunks) end up in the same translation unit. This patch changes the scope of one of the classes to not clash. Bug: 745732 Change-Id: Ifed9bcd247c43afb110c9b008062383a2a7d74df Reviewed-on: https://chromium-review.googlesource.com/848835Reviewed-by:
-
Samuel Huang authored
Demangle failure may cause superficial diffs between .size ELFs created from Gold (using c++filt) vs. from LLD (using llvm-cxxfilt). This CL logs the number of such failures, using the '_Z' prefix as a heuristical indicator. Bug: 723798 Change-Id: I1ffa247939f5efccfb66ebfddaf781adc0203496 Reviewed-on: https://chromium-review.googlesource.com/846530Reviewed-by:
-
Dave Tapuska authored
Since there is only one implementation of TouchEventQueue now it no longer needs to have a pure virtual interface. Instantiate the concrete class always. BUG=None TBR=jochen@chromium.org Change-Id: If267c326e7008bca6685b9a0734c7eb3e95f9318 Reviewed-on: https://chromium-review.googlesource.com/846313 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Helen Li authored
This CL deprecates Net.URLRequestContext.OutstandingRequests and Net.URLRequestContext.OutstandingRequests.Type histograms. This CL left URLRequestAnnotationType in tools/metrics/histograms/enums.xml as is, because enums.xml doesn't need deprecation. We know from these histograms that majority of users have reasonable number of outstanding requests. In fact, 50th percentile of users on desktop and on mobile have < 100 outstanding requests for a URLRequestContext. Most of requests that become outstanding are from blink resource loader. There are pathological cases where a single URLRequestContext has more than 20k outstanding requests, but we do not know what caused those cases. These histograms won't help us on that either. They are taking a lot of space, so I am removing them ahead of M65 branch date This CL essentially reverts the following commits: - "Add UMA to track the number of live URLRequests." crrev.com/3fcbcc19. - "Use NetworkTrafficAnnotation in URLRequestContext UMA logging" crrev.com/669c3102 Bug:711721, 797615 Change-Id: Idc3a5ae5f8cc32b2d12d00881a58be02745d68ca Reviewed-on: https://chromium-review.googlesource.com/847455 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#526687}
-
Peter E Conn authored
Bug: 793267 Change-Id: Ia3bfa5852b2d00031a8467e75b4ee9f686397660 Reviewed-on: https://chromium-review.googlesource.com/816869Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#526686}
-
Rune Lillesveen authored
Change-Id: Ifccfac91fe63ea626d885c65b7c4a7e57bb021de Reviewed-on: https://chromium-review.googlesource.com/848917 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#526685}
-
Dave Tapuska authored
Chrome implementation: https://chromium-review.googlesource.com/c/615424 W3C UIEvents issue: https://github.com/w3c/uievents/issues/154 BUG=488886 Change-Id: I732ef83ea7ca916d564d3af0419f4da0e3db1d45 Reviewed-on: https://chromium-review.googlesource.com/615146 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ecdadd98e0ae..aebad197dcaf $ git log ecdadd98e..aebad197d --date=short --no-merges --format='%ad %ae %s' 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 910a3dafd..d8724a947 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ic36bac7906748c356da43f913ca55d5aa41ecee7 Reviewed-on: https://chromium-review.googlesource.com/848741Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526683}
-
Dominik Röttsches authored
Expectation should fit for Win7 and Win10. Bug: 796926 Change-Id: I6a05bfddfe7ab65597e4a6a65463c9cdf071cd88 Tbr: rogerm@chromium.org, eae@chromium.org Reviewed-on: https://chromium-review.googlesource.com/846981 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#526682}
-
Brian White authored
Bug: 760317 Change-Id: I70f61a33dac932d7f28502e3abc46f81a59b1260 Reviewed-on: https://chromium-review.googlesource.com/847288Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#526681}
-
Fady Samuel authored
When a surface is evicted and then is "resurrected", we drop the active and pending frame. However, we do not return resources or call draw callbacks. This prevents video from updating the content in its texture. In this CL, if a surface is resurrected to the same client, then we return resources and call draw callbacks on the previously held frames. Bug: 796541 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I12e8c8a31324887afe24300bc1b8ccbb4354ec86 Reviewed-on: https://chromium-review.googlesource.com/847336 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#526680}
-
Michael Lippautz authored
This reverts commit f5c15f9c. Reason for revert: Breaks https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20(1)/32917 Original change's description: > [oilpan] Fix stack limit check for recursive tracing > > The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows > 64bit and thus extended with 0 for uintptr_t. This results in bogus return of > StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled > due to stack pressure. > > Bug: chromium:798479 > Change-Id: I13710b3dca4d3785e35aedd8ba5f7ece167b20e4 > Reviewed-on: https://chromium-review.googlesource.com/847580 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526666} TBR=haraken@chromium.org,mlippautz@chromium.org Change-Id: I11083aa7a596161e556f1f03521105db36f91668 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:798479 Reviewed-on: https://chromium-review.googlesource.com/848853Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526679}
-
Jérôme Lebel authored
The SigninPromoViewMediator should not be deallocated until the sign-in is finished. When the user clicks on "Continue as ...", the sign-in is done as soon as the sign-in dialogs arrives. RecentTabsTableViewController should not be updated as long as the sign-in started by SigninPromoViewMediator is in progress. Once the sign-in is done, the RecentTabsTableViewController can be reloaded. cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Bug: 798443 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4a0937986e236473a7c0314c056cf437a0088c36 Reviewed-on: https://chromium-review.googlesource.com/846995 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526678}
-
Jinho Bang authored
Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I25f46d97d5ba065edd15aeeb9fc31cc4747354ee Reviewed-on: https://chromium-review.googlesource.com/846645 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526677}
-
