- 23 Aug, 2019 40 commits
-
-
Alex Cooper authored
Adds four new tests around tailored consent/level scenarios: * TestConsentNotNeededForInline * TestConsentPersistsLowerLevel * TestConsentRepromptsHigherLevel * TestConsentRepromptsAfterReload Refactored WebXrVrConsentDialogBrowserTest methods into the base class and re-works how base class methods work. The mock (which always accepts consent requests, but does not call out to display the dialog) is now used unless the fake consent manager has previously been set up. This allowed changing the consent tests to run on all runtimes rather than just the OpenVr Runtime. Renamed existing tests so that all test names fit a similar pattern. Bug: 987029,996454 Change-Id: I9a4224fb169ee7df764a061fdb65038e42c05a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767085 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690024}
-
Christopher Cameron authored
apps::AppShimHandler has two separate "things" in it which shouldn't be stuffed into the same class. It has - the apps::AppShimHandler interface (and setter for the current handler) - the "thing that terminates chrome if it was kept alive for an app". Mechanically separate these, not changing any behavior. While we're at it, use a base::NoDestructor instead of base::Singleton. Bug: 982024 Change-Id: Ieea0fe80573e8350a010f1b5c4c55f01c0b8222a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765830 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690023}
-
Lei Zhang authored
Automatically call FPDFLink_CloseWebLinks(). Change-Id: Ic94d2bd5005ce815774dd5776bb04259d6d8ff9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757458Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#690022}
-
Max Li authored
Bug: 923594 Change-Id: I1511c1c6496643092368a91b2c589e2641f00607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767100 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690021}
-
Toni Barzic authored
Replaces the current approach of applying scale transform on app list main view when the app list grid cannot fit into available screen bounds. The approach has caused few issues, and lately produces pixelated icons when the screen is zoomed in. The new approach that scales down individual app list item tiles. The tile dimensions are controlled by AppListConfig - this adds support for "scaled down" AppListConfig which is created off the default AppListConfig::instance(). The config is created by using the display work area bounds and the bounds available for apps grid ( if needed, i.e. if the available grid does not match the min required dimensions for the default config). The apps grid item dimensions are scaled down to fit the available dimensions (up to a certain point.) Adds support for per app list AppListConfigs - when the app list widget window bounds are changed, AppListView creates a scaled down config if needed. The created config is then used by apps grid and its child views for sizing during layout. Currently, this is used for apps grid only, but in future, the config might have to be propagated to search box widget, too. Has few fixes that try to reduce off-by one errors in layout, animations (top items animation between folder view and the folder icon) now that relationship between tile dimensions is less well defined. BUG=996444,995976,983479 Change-Id: I27c0a107014e97345470730ae231465945a95da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759856 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#690020}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f15d7373bf1..a0ed070aa0c7 git log 0f15d7373bf1..a0ed070aa0c7 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 47820316fcec..d7c7dd8b955e (1 commits) Created with: gclient setdep -r src/third_party/skia@a0ed070aa0c7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None Change-Id: I50307eb533b15c5d6d55f82b342074be7b87a8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690019}
-
Filip Gorski authored
Bug: 979043 Change-Id: Ib25a2a3217f2b72b39c459e0cd9f3c1a789ce4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764608Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#690018}
-
minch authored
- See the green part at https://screenshot.googleplex.com/HasHu2BgGbz for the area that ImeMenuListView::Delegate::GetBackgroundColor take effect. It is enough to keep the background as TRANSPARENT by default, then the list will have the same background color as the whole IME tray bubble. - Delete some unnecessary header files include. Bug: 982950 Change-Id: I9fddff4aa82b67764b2c907c839bed679f6c0cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764356Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/472c74c60ca2..d7d425404bf4 git log 472c74c60ca2..d7d425404bf4 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 clemendeng@google.com Don't build symbol table for GLSL built-ins if on Android 2019-08-23 dongja@google.com Vulkan: support dynamic indices in array of arrays 2019-08-23 svaisanen@nvidia.com Add several angle bugs for end2end tests failing on NVIDIA 2019-08-23 svaisanen@nvidia.com Add AtomicCounterIncrement test case 2019-08-23 jaedon1.lee@samsung.com Vulkan: Implement EXT_texture_type_2_10_10_10_REV 2019-08-23 jonahr@google.com Revert "Remove skipping of groupMemoryBarrierAndBarrierTest on NVIDIA" 2019-08-23 syoussefi@chromium.org Vulkan: Support mixed column/row-major buffer fields Created with: gclient setdep -r src/third_party/angle@d7d425404bf4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:996286 Change-Id: I18a441dfbb130c483d21419d496f7263e3b343a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769154Reviewed-by:
-
Kevin Marshall authored
This is a reland of d4f8b3f6 All Fuchsia bots are now configured to download boot images, which should address the previous breakage. Original change's description: > [Fuchsia] Make hardware boot image downloading opt-in by .gclient. > > Only download SDK system images for target CPU architectures which are > explicitly configured in .gclient. Attempting to boot the SDK > system image on a target CPU that was not configured will cause an > explanatory message to be printed. > > If the .gclient variable is not set, then only QEMU images are > downloaded for x64 and ARM64. This typically reduces the SDK download > time by 30s, and data transfer/storage footprint by ~2.4GB versus > the previous defaults, which downloaded boot images for all > platform types and archs. > > This is useful for Chromium developers (e.g. sheriffs) who need to > be able to build and run tests on Fuchsia, but don't want or need > physical devices. It also speeds up the "gclient runhooks" step on > Fuchsia buildbots. > > Bug: 990513 > Change-Id: I55a310830c050f247e37dae8289c472c16ff5dca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732805 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Auto-Submit: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685798} Change-Id: I05df027d4830ecc7bb0510642436af2b36117d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761058Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690015}
-
Maksim Moskvitin authored
We write NigoriLocalData in encrypted form to corresponding file using ImportantFileWriter. Reading is just mirrored version of writing. Bug: 922900 Change-Id: I299f55450e74edac29beaacf7b5dc659f5fd8f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768424 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#690014}
-
Andrew Luo authored
Bug: 996501 Change-Id: I664ebb130f949b9f4ccb0c24fd760c56db8cb0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764869 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690013}
-
Victor Costan authored
Bug: 611935 Change-Id: I1795886cefad11e6481fd3081346a9bfb43132e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767597 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#690012}
-
Benjamin Beaudry authored
The previously merged text runs heuristic change to support vertical text runs (https://crrev.com/687072) introduced a bug described in the linked bug. This change fixes it. It adds a new heuristic that verifies if the difference between the angle formed by the first and last character of a run (the |text_run_angle|) and the angle formed by the current and previous character (the |current_angle|) is greater than 90 degrees. If so, the text run breaks. The file directional-text-runs.pdf has been updated to detect any future regression. Bug: 994958 Change-Id: I21fbe389fe5527c6dba9f05a23fd865a5b3a221e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758833Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690011}
-
Jeevan Shikaram authored
This CL integrates the App Management frontend into OS Settings. Bug: 979531 Change-Id: Ie23a3c9cee242ccdc1a4130c5c2dc4832786f18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752487 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#690010}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 71ce99e0. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 28f1aff3 "Fix font-variation-settings interpolation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I208992714272e2f79b4a7ce1387eff6ee61733ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768782Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690009}
-
Connor Clark authored
This resolves the issue where device emulation doesn't survive the DevTools - Lighthouse connection handoff. It also allows for local overrides, blocked urls, and other things DevTools sets up to be used during an audit. Bug: 991906 Change-Id: I8a0b982e7b77f923219943feb12758b203c701a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743411 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#690008}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6e0bc79fa4e..4c555ee9b300 Created with: gclient setdep -r src-internal@4c555ee9b300 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:991478 Change-Id: I4dab4ed77eddfa6f4cc031b7e73f8aea0627a5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769145Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690007}
-
minch authored
Delete not used LabelTrayView. Also DEFAULT_VIEW_LABEL and AddIconAndLabelForDefaultView that only used by this class. Also delete AddIconAndLabels, which is not used any more either. Bug: 982950 Change-Id: If1fd29d8273394ae0e38705c68ba7b53156a158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764271Reviewed-by:
-
Peter Boström authored
Bug: chromium:996915 Change-Id: Idd0a9b3c8d01af0c53d0fc52576a64025e655542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769027 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#690005}
-
Hwanseung Lee authored
Use enum class instead of enum for Wigdet::FrameType enum class is more type safety. Bug: 940736 Change-Id: I2242ea272731a6136ee0e48ce7a66495ed70fed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767292 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#690004}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7aecaad3386..0a07831a9da9 git log e7aecaad3386..0a07831a9da9 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 hjd@google.com Merge "Make checkerboard boarding full height" Created with: gclient setdep -r src/third_party/perfetto@0a07831a9da9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I13437cdccdeb0e29eda6f4690748419a42dfeb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769144Reviewed-by:
-
Jeevan Shikaram authored
This CL copies files from c/b/r/app_management into c/b/r/settings/chromeos/os_apps_page/app_management_page. Bug: 979531 Change-Id: Ibfb4cdb7201743f86c6601b8a1c97f2bd0f6a597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752497 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94dbee77eb6c..afad531cd256 git log 94dbee77eb6c..afad531cd256 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 dhanyaganesh@chromium.org config: Mark mistral as experimental Created with: gclient setdep -r src/third_party/chromite@afad531cd256 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I27905cd9f05d0112b6aa6e079f993bb42f82914c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769140Reviewed-by:
-
Erik Chen authored
There are several call sites that call WebView::MainFrameWidget()->Close() when they actually intend to call WebView::Close(). This happens to work because WebView::MainFrameWidget() currently returns itself, but will break when MainFrameWidget() is updated to return a real frame widget. Bug: 995981, 419087 Change-Id: I69068b86ce4af81766076a56349e999d675e67cb TBR: blundell@chromium.org, rockot@chromium.org, dalecurtis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767104 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Robert Ogden authored
Bug: 996870 Change-Id: I26b329130c19ff8cf9811e5ac504e2c358669a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766253Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689999}
-
Robert Liao authored
No one seems to use subtitles or sublabels. BUG=865318 Change-Id: Ia850adabeab5aa280b2730e2a4177ac7a9f8d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764883 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#689998}
-
Sophie Chang authored
This is pretty much guaranteed for DataSaver users to always happen and this reduces the likelihood of the race condition between data updates being in flight Bug: 997106 Change-Id: If2d827e9dc74e93dc8d203a6f7aa27cd590d617f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768819Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689997}
-
Moe Ahmadi authored
- Adds NTP_REALBOX page classification to BaseSearchProvider::IsNTPPage() and makes it a public static method to use in AutocompleteResult. - Makes the logic to fall back to most visited site for zero suggest mobile only as there are currently no zero suggest experiments on Desktop and CrOS is handled differently. Bug: 996516 Change-Id: I25c33ea961a0afb53abe33f3326696160c6dc3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767605 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#689996}
-
Chris Harrelson authored
It has been in stable for a few releases now. Change-Id: Id550a5c03b6a5c0575df47ca313ca2d754d8a0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766449Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689995}
-
Donn Denman authored
Adds another option to the Longpress Activation Chrome Flag to preserve Tap activation. Without it, the Tap gesture will no longer trigger Contextual Search. Also fix some minor bugs: 1) preserve the longpress selection even after the panel is closed. 2) fix a crash with Tap after a longpress selection triggered. 3) tap with existing longpress selection should not select. BUG=956277, 959040 Change-Id: I3c351a0227b55c996b645cb76e08976ce36a61e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764187Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689994}
-
Xida Chen authored
sadrul@ is already reviewing a lot of metrics related code, this CL adds him as an owner. Bug: None Change-Id: Ifc4fca00f9128f28c669f64116465087ead3b4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769053Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689993}
-
James Cook authored
It just needs some margin on the top. Before: http://screen/z71qzJj0EJH After: http://screen/Nw4HWw6FUyC Bug: 996499 Change-Id: I3eacf6e23aa59b88794ef97fa11c37dbfda7cf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769052 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60eaabde..9499165e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I15dd5f8c4ce7af6bf003586e5b34f56f0a36479c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768783Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689991}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/115cfe7a1b32..d6dc4b7e4533 git log 115cfe7a1b32..d6dc4b7e4533 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 chrisforbes@google.com Store subpass index in ExecutionState, not in RenderPass Created with: gclient setdep -r src/third_party/swiftshader@d6dc4b7e4533 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139824232 Change-Id: Id8bdaab75c9ff8d6c2f8269fc24527484302f2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769156Reviewed-by:
-
Michael Crouse authored
Change-Id: Ie668ce7703601be8f64b9cc2557404f05203fdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769219 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689989}
-
Nicolás Peña Moreno authored
This CL makes the code align with making Exposed mandatory for interfaces. See the following for more details: https://github.com/web-platform-tests/wpt/pull/18382 https://github.com/heycam/webidl/pull/423 Change-Id: I293e80cd0d953f2f47480f838eecd5f588ec6d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768918Reviewed-by:
Luke Bj <lukebjerring@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#689988}
-
Vladislav Kaznacheev authored
1. When creating AppList, delay bounds snapping until the widget has non-empty bounds 2. Add bounds snapping to AppListView::GetPreferredWidgetBoundsForState Bug: 995995 Test: manual Change-Id: I50def74367d33053fc1ce350efaf19c01f6255a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767082 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Ken Rockot authored
Renderer processes currently get all of their process-scoped interfaces through a Connector. This moves them over to the ChildProcessHost API which routes directly from the ChildThreadImpl to an IO-thread binding associated with RenderProcessHostImpl. The IO-thread BinderRegistry for RPHI is moved from ConnectionFilterImpl to the IOThreadHostImpl to support this. The few Blink callsites which use GetConnector()+GetBrowserServiceName() have been updated to use a new Platform::GetBrowserInterfaceBrokerProxy() API which returns a pointer to the new ThreadSafeBrowserInterfaceBrokerProxy type. This type looks and feels similar to BrowserInterfaceBrokerProxy, but can be used from any thread. Thread-safety is a useful feature for process-scoped interface binding, but incurs slight overhead that is not necessary for context-scoped binding requests; hence the new type. As of this CL, use of Platform::GetInterfaceProvider() is equivalent to Platform::GetThreadSafeBrowserInterfaceBrokerProxy() in terms of where the requests get routed on the browser side, so the former can be incrementally converted to the latter. All dependencies on Connector and deprecated Service Manager service names have been removed from Blink. Follow-up CLs will remove the few remaining Connector dependencies from content/renderer and other child process types, and convert all GetInterfaceProvider() callsites to use GetBrowserInterfaceBrokerProxy() instead. Bug: 977637 Change-Id: I60ec171002df812b7ad34b0d87fa972910620fa2 Tbr: yucliu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763226Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#689986}
-
Maksim Moskvitin authored
We are going to persist sync_pb::NigoriLocalData using blocking writes with ImportantFileWriter. To simplify initialization of NigoriSyncBridgeImpl for testing and testing of persistence itself, we add new interface to wrap file-related logic. Bug: 922900 Change-Id: I09d608ec45d6f4d94068f5c52ee93af24fe70da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731946 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#689985}
-
