- 30 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae7e8f53c6eb..1d5a8c686edd git log ae7e8f53c6eb..1d5a8c686edd --date=short --no-merges --format='%ad %ae %s' 2018-11-30 zhuohao@chromium.org rammus: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@1d5a8c686edd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5672ae541fee58dc393bbd21810d8a06e80b5d08 Reviewed-on: https://chromium-review.googlesource.com/c/1357340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612736}
-
Tommy C. Li authored
Bug: 908440 Change-Id: Id846e2c8d209ebe77b08fa78dab90d1362e95328 Reviewed-on: https://chromium-review.googlesource.com/c/1351277Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612735}
-
manuk authored
This allows us to 1) have smarter filtering; e.g. filtering for bookmarked properties with 'is bookmarked' (separate CL) and 2) avoid unnecessarily going through the DOM for something. Bug: 891303 Change-Id: I336096881f0fcd2e90a621ab2e54853c83e01608 Reviewed-on: https://chromium-review.googlesource.com/c/1357311Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612734}
-
Hiroshige Hayashizaki authored
TBR=sebsg@chromium.org Bug: 910627 Change-Id: I917d2e07713da009e615f8796b9ffaaed7540111 Reviewed-on: https://chromium-review.googlesource.com/c/1357081Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#612733}
-
Leonard Grey authored
Bug: 908486 Change-Id: I762b8a74fcb98fb99218cee590da7cf003dec8cf Reviewed-on: https://chromium-review.googlesource.com/c/1356870Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#612732}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7370393b9d26..199f50b66cb0 Created with: gclient setdep -r src-internal@199f50b66cb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If2bc9f97f27c08d7068a170070fee3dac0562f85 Reviewed-on: https://chromium-review.googlesource.com/c/1357339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612731}
-
Donn Denman authored
Adds histograms to track CTR and closing of the Ephemeral Tab. When the user makes the panel peek they may or may not actually expand it. We now track whether it was ever expanded in a boolean histogram, and the reason it was closed in an enumerated histogram. BUG=894619, 902122 WIP Ephemeral Tab log when activated. Change-Id: I27e6a5b36fc0efc0c84298235b51b2df915196f6 Reviewed-on: https://chromium-review.googlesource.com/c/1356033Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#612730}
-
Jeffrey Cohen authored
autofill settings on ios Before this CL, when autofilling addresses, the company name was always filled in if it was specified as part of a country's address fields. However, we want to remove the company field from autofill. This is being rolled out via a Flag and finch config. The initial CL that addressed this in https://crrev.com/c/1315536 did not change to IOS settings, but this CL updates the IOS code to filter out the company field in settings addresses based on the flag. Bug: 890972 Change-Id: I179ccfd9cf0cef9eaa9f80cd0c2b7353dd5c8f9a Reviewed-on: https://chromium-review.googlesource.com/c/1351282 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#612729}
-
Lukasz Anforowicz authored
This CL modifies PrepareFrameAndViewForPrint::CreateURLLoaderFactory method so that it delegates creation of URLLoaderFactory to the frame being printed. Bug: 891872 Change-Id: I42a87f908e18b751bf8dd1d192b4fa2e34141d09 Reviewed-on: https://chromium-review.googlesource.com/c/1356022Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#612728}
-
Dave Tapuska authored
This is a reland of 44fcad8b It was speculatively reverted for a build failure which turned out to be something else. Original change's description: > Fix Shared Buffer 64 bit truncations > > Segments are always 4k and indexed by a WTF::Vector > > BUG=879657 > > Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf > Reviewed-on: https://chromium-review.googlesource.com/c/1355884 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612659} TBR=haraken@chromium.org Bug: 879657 Change-Id: I60299fc856a6dc987c8f4460b2bf3a339bcb5837 Reviewed-on: https://chromium-review.googlesource.com/c/1357302Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612727}
-
Henrique Nakashima authored
Bug: 899225 Change-Id: I3b8a74fadcd4ae1821654e4c37bdbf7985787e72 Reviewed-on: https://chromium-review.googlesource.com/c/1340780Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b98245e3cb7..35457f076227 git log 1b98245e3cb7..35457f076227 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 jbudorick@chromium.org devil: update to build-tools 27.0.3. Created with: gclient setdep -r src/third_party/catapult@35457f076227 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892644 TBR=sullivan@chromium.org Change-Id: I58deab311d3612bfd8a623305e49f122ab46a0e6 Reviewed-on: https://chromium-review.googlesource.com/c/1356635Reviewed-by:
-
Xiaohui Chen authored
Bug: b:120240333 Test: locally compile and run on device Change-Id: Ica8be43ed03c26bbd92dca8ccce82a6560fa5427 Reviewed-on: https://chromium-review.googlesource.com/c/1356136Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612724}
-
Tom Sepez authored
Avoids making changes in both chromium and pdfium repositories as these requirements evolve. Change-Id: I83dc0c4e272d6c2be23c290b9838ebeef37269ca Reviewed-on: https://chromium-review.googlesource.com/c/1355942 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#612723}
-
Vladislav Kaznacheev authored
The current size (32dp) is too small and results in blurry shelf icons. Bug: 908968 Test: manual Change-Id: I86303b66ff433995d12389c371dd5cf24eaf6515 Reviewed-on: https://chromium-review.googlesource.com/c/1352770 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612722}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/207cb0177f05..faf8c0448d40 git log 207cb0177f05..faf8c0448d40 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 treehugger-gerrit@google.com Merge "profiling: Account for failed unwindings." 2018-11-30 primiano@google.com Merge "Add eseckler to OWNERS" 2018-11-30 lalitm@google.com Merge "trace_processor: Add idle events" Created with: gclient setdep -r src/third_party/perfetto@faf8c0448d40 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I345fe350848ee074815190bf956b0419c3e3ed16 Reviewed-on: https://chromium-review.googlesource.com/c/1356634Reviewed-by:
-
Mohamed Heikal authored
protoc the protobuf compiler now requires using a separate plugin for compiling protos for the java lite runtime. The lite java runtime is now also separate from the main java runtime and is distributed separately. This cl switches java proto compilation for lite protos to this new mode. TBR=android_webview/BUILD.gn Bug: 782237, 800281 Change-Id: I31c2d073bed51109dffeea133495679deef3186b Reviewed-on: https://chromium-review.googlesource.com/c/1340522 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612720}
-
Vlad Tsyrklevich authored
We should never reach this routine with a pointer outside of the GWP-ASan region. Bug: 896019 Change-Id: I078443f5634f03d1c7e460db16f61398c6dad999 Reviewed-on: https://chromium-review.googlesource.com/c/1356332Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612719}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2cd040b0d342..625db3890df8 git log 2cd040b0d342..625db3890df8 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 zoddicus@users.noreply.github.com Add check for QueueFamilyKHMR memory scope (#2144) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@625db3890df8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I94ba02448266bc74bf40e222f996a7215086a03f Reviewed-on: https://chromium-review.googlesource.com/c/1356638Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/016601cc2146..7ae5d7a9b12c git log 016601cc2146..7ae5d7a9b12c --date=short --no-merges --format='%ad %ae %s' 2018-11-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7ae5d7a9b12c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8282b35c12a20c6b1665d55941c1a429c5542088 Reviewed-on: https://chromium-review.googlesource.com/c/1356636Reviewed-by:
-
Yi Su authored
TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
vabr@ leaves the Chrome team and will only be hobby-contributing in the foreseeable future. Not being able to guarantee staying up to date on the currently owned code, vabr@ is therefore removing himself from all OWNERS files. Notable changes: * Adding dvadym@ to the OWNERS for password manager internals page, because he knows that code thoroughly and plans to enhance it soon. * Adding a reference to components/password_manager/OWNERS to components/test/data/password_manager/OWNERS * Adding cfroussios@ to third_party/libsecret/OWNERS, because of his work on code using this library. R=cfroussios@chromium.org, dvadym@chromium.org, vasilii@chromium.org Bug: 908813 Change-Id: Id45989e6febe523a98f2b97730b82b80c5c29200 Reviewed-on: https://chromium-review.googlesource.com/c/1354009Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612715}
-
Clifford Cheng authored
Fixed all the compile and runtime issues on Windows and enable the test on it. Bug: 898230 Change-Id: I9e92e49583893898603bffa46f6fc6bdc1ef7e20 Reviewed-on: https://chromium-review.googlesource.com/c/1339240Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612714}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ic4740c19ad445bb1974f12876732829b88148a01 Reviewed-on: https://chromium-review.googlesource.com/c/1352782Reviewed-by:
-
John Budorick authored
Bug: 892644 Change-Id: Ib888cb9f6f5db2bea89d3e300d86d0b797f8eacb Reviewed-on: https://chromium-review.googlesource.com/c/1357006Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612712}
-
erikchen authored
The Windows counterpart to WifiServiceMac calls UnIninitialize in the destructor. It appears that the Mac version is failing to call Uninitialize, which may be the source of a large notification-related memory leak. Bug: 904540 Change-Id: I718aa58d69f4f39450bbb78f05375750ce4d6735 Reviewed-on: https://chromium-review.googlesource.com/c/1342088Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612711}
-
Ian Kilpatrick authored
This appears to be a leftover from when we didn't produce fragments for inline children which were containing blocks. There should be no behaviour change. Bug: 636993 Change-Id: Idc78f232390bd58f00517df719b6c2cda6e6830a Reviewed-on: https://chromium-review.googlesource.com/c/1356259Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612710}
-
Robert Sesek authored
This brings EXPECTED_MAC_SI_COUNT back to 0, and reduces the number in Linux by 1. The SI in WelsThreadPool.cpp was removed. Bug: 893594 Change-Id: I6fc03be4b104a5f8afc4c2be1cebce36d322d116 Reviewed-on: https://chromium-review.googlesource.com/c/1356868Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612709}
-
John Z Wu authored
This was because I was overriding XMLHttpRequest's open and send functions a second time when reinjecting the scripts. The fix is to ensure those functions are only overriden once. Bug: 910284 Change-Id: I1bf203b45865275ec2cbf5e52ab388a5064de16e Reviewed-on: https://chromium-review.googlesource.com/c/1356014Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612708}
-
Robert Liao authored
This seems to work fine on Linux with --gtest_repeat=10. BUG=882338 TBR=shuchen@chromium.org Reenabling a test. Change-Id: I993856797c704a4b438402a97453d4e2b60f72f0 Reviewed-on: https://chromium-review.googlesource.com/c/1356230Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612707}
-
edchin authored
A coordinator's |-stop| should not crash if called multiple times. Bug: 910652 Change-Id: I5a2998726ad3390a8b1c98afbc753f093a4a8986 Reviewed-on: https://chromium-review.googlesource.com/c/1357001 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612706}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2f731d6ce85..7370393b9d26 Created with: gclient setdep -r src-internal@7370393b9d26 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7fd1cb9adc3d3d7e27a6d740e7e5204ad2661c0 Reviewed-on: https://chromium-review.googlesource.com/c/1356633Reviewed-by:
-
Becca Hughes authored
This CL moves any existing uses of content::MediaMetadata to the new media_session::MediaMetadata. BUG=875004 Change-Id: If4b2f889ffb2264daa2bc2f5d9403e9e18586856 Reviewed-on: https://chromium-review.googlesource.com/c/1241572 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Nicolas Pena authored
Before, we'd buffer the firstInput entry only if it happened before onload. This CL forces firstInput to always be buffered. This means EventTiming code is called more in some tests, so the event hardware timestamp is no longer guaranteed to be nonzero, and a couple of xr tests require double RAF to avoid competing with the swap promises from Event Timing. Bug: 841224, 843184 Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8 Reviewed-on: https://chromium-review.googlesource.com/c/1355880Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612703}
-
Clemens Arbesser authored
This relates to http://crrev/c/1340940 , where the class of the bottombar layout was changed in autofill_assistant_sheet.xml, but not in the corresponding cast in BottomBarAnimations.java:setBottomBarHeight(). Bug: 806868 Change-Id: Id2bd5bf41862afe7e8425188a2fc048c478726c8 Reviewed-on: https://chromium-review.googlesource.com/c/1356981Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#612702}
-
Alex Clarke authored
Currently the SequenceManager is being too restrictive for this test, so we relax our check slightly. Bug: 891670 Change-Id: I0cebd070971e0272624b7bd05165ec64404b8f1a Reviewed-on: https://chromium-review.googlesource.com/c/1357080 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#612701}
-
Steven Bennetts authored
This fixes two minor UI issues: 1. Certificate ids were not matched correctly for OpenVPN. 2. ServerCA was not correctly showing 'Do not check' for OpenVPN. Bug: 903531 Change-Id: I31502c7602b44127571f172c0c911434b171ddbb Reviewed-on: https://chromium-review.googlesource.com/c/1355537 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612700}
-
Ryan Daum authored
We no longer want to perform this operation through the WindowManager since that does software color conversion which causes a render pass (leading to issues with inversion while playing video, among other things). Color inversion on cast display devices is now performed through internal hardware-specific methods. Bug: internal b/120272088 Test: manual test on device Change-Id: I60e4b59b8fc90fc2cbfe8f847d0d99fac4606647 Reviewed-on: https://chromium-review.googlesource.com/c/1357013 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#612699}
-
Etienne Pierre-Doray authored
Under this experiment, scheduler workers are only detached if the pool is above its initial capacity (threads that are created to replace blocked threads). 2 options were considered: Option A: Detach only when over initial capacity. Option B: Detach only when over current capacity (includes currently blocked threads in capacity). This might better handle the following case: At any given time, there is at least 1 blocked thread. On top of that, some periodic work uses all worker every 30s or so. The current capacity will encompass for the blocked thread and avoid detaching it periodically. Option A was picked because it is more conservative. Initial capacity is smaller or equal to current capacity, so detaching is closer to current behavior. We want to avoid having too many threads that aren't used. Bug: 847501 Change-Id: I0b116db54095767768b158d92f5f146249720b45 Reviewed-on: https://chromium-review.googlesource.com/c/1348863 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612698}
-
Jonathan Metzman authored
Fix integer overflow in data_size caused by attacker controlled value (win_certificate->dwLength) by using CheckSub from base/numerics. The overflow causes the program to read past the end of win_certificate. The amount read is also attacker controlled and seems essentially unbounded. Change-Id: I006cb4f8ce6c64421ca0bb66df3ce49a72aba839 Bug: 910480, 910522 Reviewed-on: https://chromium-review.googlesource.com/c/1357011Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612697}
-
