GitLab

This reverts commit bba4dc0e.

Reason for revert: Breaks v8 generation script for at least
linux and linux-chromeos.

FAILED: gen/v8/include/v8-gn.h 
python3 ../../v8/tools/gen-v8-gn.py -o gen/v8/include/v8-gn.h -p V8_COMPRESS_POINTERS -p V8_31BIT_SMIS_ON_64BIT_ARCH -p V8_DEPRECATION_WARNINGS -p CPPGC_CAGED_HEAP -n V8_ENABLE_CHECKS -n V8_COMPRESS_ZONES -n V8_HEAP_SANDBOX -n V8_IMMINENT_DEPRECATION_WARNINGS -n V8_NO_ARGUMENTS_ADAPTOR -n V8_USE_PERFETTO -n CPPGC_SUPPORTS_OBJECT_NAMES -n CPPGC_YOUNG_GENERATION
Traceback (most recent call last):
  File "../../v8/tools/gen-v8-gn.py", line 80, in <module>
    main()
  File "../../v8/tools/gen-v8-gn.py", line 63, in main
    header_stream = BytesIO("")
TypeError: a bytes-like object is required, not 'str'

Original change's description:
> Reland #4 (?) of "Force Python 3 to be used in build."
>
> This reverts commit 17801e45.
>
> Reason for revert: Fixes to the internal scripts that broke
> have landed.
>
> Original change's description:
> > Revert "Reland "Force Python 3 to be used in build.""
> >
> > This reverts commit 6ea5c38d.
> >
> > Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview
> >
> > Original change's description:
> > > Reland "Force Python 3 to be used in build."
> > >
> > > This reverts commit b6172196.
> > >
> > > Reason for revert: We rolled GN to a new version with a fix for
> > > the win dev issues, so hopefully is good to go now.
> > >
> > > Original change's description:
> > > > Revert "Force Python 3 to be used in build."
> > > >
> > > > This reverts commit bb97ab9b.
> > > >
> > > > Reason for revert: Various breakages.
> > > >
> > > > Original change's description:
> > > > > Force Python 3 to be used in build.
> > > > >
> > > > > This CL makes Python 3 be the default script executable used by Ninja
> > > > > to run action() and action_foreach()'s during the build.
> > > > >
> > > > > This does *not* mean that everything works with Python3; many targets
> > > > > may still use Python 2 via the python2_action() and
> > > > > python2_action_foreach() targets or via custom logic.
> > > > >
> > > > > However, it does mean that it should prevent regressions from
> > > > > creeping in.
> > > > >
> > > > > This CL should not be taken to imply that we can start to write
> > > > > Python3-specific code that can run during the build; we should
> > > > > still be trying to ensure that everything is compatible with Python2.
> > > > >
> > > > > Also, this CL does not enable the use of vpython in actions; we should
> > > > > still avoid that because vpython is slower than direct Python
> > > > > invocations.
> > > > >
> > > > > Bug: 1112471
> > > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787
> > > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > > Cr-Commit-Position: refs/heads/master@{#836234}
> > > >
> > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> > > >
> > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 1112471
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576
> > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#836284}
> > >
> > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: 1112471
> > > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#844885}
> >
> > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1112471
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#844986}
>
> TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1112471
> Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#846193}

TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ic21ef3e38758d295dac893a02f8d206a67e49d52
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1112471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645206Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846218}

Fixed: 1169417
Change-Id: I7a27f5ab0083287ee0dbd24313717b293a742ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642786Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Auto-Submit: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846217}

R=rsoroken@chromium.org

Fixed: 1161107
Change-Id: Ib4f1b2c5ac2c7d621175548859b902cc71b742da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643257Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846216}

This feature flag has been rollout to 100%. Now we need to change the
default value to 'enabled' for GA, and extend the expiry date in case we
need to turn it off because of any unexpected reason.

Change the owner of this feature flag to bmalcolm@ because I have been
out of this area. (We may need to cleanup this flag after the feature is
fully launch.)

Bug: 1169268
Change-Id: I0473ebbb9b998d11ec7931298718ab6e8b090c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642635Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Commit-Queue: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846215}

This CL also introduces a new UMA metric,
ClearBrowsingData_SameSiteNoneData, which is used in
BrowsingDataBridgeTest.java and will also be used to track usage
of the feature once it is released.

Bug: 1166674
Change-Id: I00aebaf4b5192e187fb42e7947b52ea046bf4276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627766
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846214}

https://android.googlesource.com/platform/external/perfetto.git/+log/57144c8685d3..3232876ee47b

2021-01-22 lalitm@google.com perfetto: initial implementation of building with LUCI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:177349647
Tbr: perfetto-bugs@google.com
Change-Id: If953b3145bb3a5ba590fec6cd74e6af4bc10e04a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645026Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846213}

They are useful when we finch CompositeAfterPaint.

Bug: 1167827
Change-Id: I51fa75f3c32ecbdbff28f199cca15974bedcb4d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643273Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846212}

Previously the holding space tray did not update visibility when the
user adding screen was shown and interacting with holding space items
appeared to no-op to the user since actions were being performed behind
the login screen.

Bug: 1168059
Change-Id: I8a55e811b2eb74edeecdcae11dc811173420aff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643412Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#846211}

Disable build_with_tflite_lib on Windows on ARM as a workaround
until it is fixed generally.

Bug: chromium:1169611
Change-Id: I305a053fcf724783c31491a225eb4e4c28733ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643387Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#846210}

This CL removes WebRemoteFrameClient::WasEvicted method, then
WebFrameWidgetImpl starts calling RemoteFrame::ResendVisualProperties
directly for the evicted frame.

Bug: 1166726
Change-Id: Ibd24bf2009631deac9018ff7ee0e848f7a84a9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636823
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846209}

It seems the x86 emulator is a little bit slow or it connects to
cloud, the query response come back during the test.

This patch disable the download server in tests.

Bug: 1161326

Change-Id: I19171957ca266f8827eb14a55e017b901ea60201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633203Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846208}

Change-Id: I4d055320f6d410de25944c336da3486899479b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643331Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#846207}

The dcheck bot should be identical to the non-dcheck bot, so this adds
the same filter file that the non-dcheck bot uses.

Bug: 1113456
Change-Id: Ieab2e779f18cc84f8120efedd3108623f02a58c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643575Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846206}

Change-Id: Icd30a001d44487a7536dc75cbaeb91d4c9038f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643027Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846205}

This change converts callbacks from base::Bind and base::Callback to
Once/Repeating in //chrome/browser/chromeos/lock_screen_apps.

Bug: 1148570
Change-Id: I85b8e4e83d9f61d3cdc0da02f6650418c1ccccff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644110
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846204}

Currently, counter style updates is a phase in UpdateActiveStyles. This
patch moves it out as a standalone phase of UpdateStyleAndLayoutTree,
so that we update counter styles only when needed.

This patch also adds MarkCounterStylesNeedUpdate() to indicate whether
counter style updates are needed.

Note: After refactoring, the framework of counter style updates looks
almost identical to font updates. This is intentional. We will try to
unify them in the future.

Bug: 687225
Change-Id: If07de2878ae5faa6800644a967029a569bef566a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846203}

BUG=1168231

Change-Id: I9f46b03f3c03a50382778c8d8ae404be8714ab31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644316
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846202}

To support ANGLE, we need to create ANGLE context and surfaces from the
native EGL context and surfaces with the
EGL_ANGLE_external_context_and_surface extension. And ANGLE will save
and restore during make current or release the current context with
eglMakeCurrent() call. To do that, ScopedAppGLStateRestore will not
create gl::GLContext, save and restore GL state anymore. It only queries
stencil state with native GL binding instead of the ANGLE GL binding,
since ANGLE will not return the GL state from the native GL.
And SkiaRenderer may need the stencil state later. The ANGLE EGL context
will be created in OutputSurfaceProviderWebView, and make current in
HardwareRendererViz.

Bug: 1157501
Change-Id: Ieca9c85855df5ab529846fe2882d7451f50f51bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612925
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846201}

Since it is only used in one place, there is no reason for this
(deprecated) UI component to be in shared WebUI code.

As a result of this CL bubble_button.js/css is no longer part of the
build in non-CrOS, and in CrOS is inlined within arc_suport/main.html
as a result of the |flattenhtml| usage on that file.

Bug: None
Change-Id: I9838bc4a9a6b71370fbc212d1e189311045b0813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643091
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846200}

This CL moves the dumper to be a test target.

This CL also refactors the FrameContentAsPlainText function into a
separate header so that it can be relied on by both testing and prod
code. The prod code is moved into a new machine usage only class which
will be the focus of many upcoming changes to add missing support and
logic that caused the method to be deprecated in the first place. See
the second bug for more context and details for that effort.

Bug: 585164, 1163244
Change-Id: I02fd5c204c71e9ffc82de5267d592ad316d0cbc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610941
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846199}

When hardware acceleration was disabled, the WebRtcVideoTrackSource can
receive NV12 frames in software. This patch adds support for the NV12
frames in WebRtcVideoFrameAdapter so that the WebRtcVideoTrackSource can
pass those frames safely.

with hardware acceleration off and confirmed that it worked. I also
confirmed that the NV12 frames in software are used as expected from
WebRTC, as they would be if they were from a GMB.

Test: https://webrtc.github.io/samples/src/content/peerconnection/pc1/
Bug: 1168948
Change-Id: I5b78ec01fe6ef1c4a4a047bb3fda908ad6813e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645084
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#846198}

This will help test team to verify if the feature is enabled or not.

Bug: 1169367
Change-Id: I1d731b00c30080a9f3d37ddce36ab642140990c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643705Reviewed-by: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846197}

The role changes internally, but the object was not reserialized.

Bug: 1167459
Change-Id: I2fcb36a359481e88211397bcc0ddba8a448b2754
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644859Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846196}

Almost always a renderer is either using the request or response side of
the federated auth service. Having two mojo interfaces for each one is
cleaner, more flexible, and more efficient as it also avoids wasting
resource by keeping unused state around.

Test: manually using existing demo
      `./chrome  --enable-features=WebID https://webid-demo.glitch.me`

Bug: 1141125
Change-Id: I2a41cd57022775ef5348e74991650dd5be90fa3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636946Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846195}

This CL adds support for EGL_ANGLE_external_context_and_surface.
With this extension, it wraps a native EGL context to an ANGLE EGL
context, so we can use ANGLE on a native EGL context. And call ANGLE
eglMakeCurrent() with this ANGLE context, will not change the native
EGL current context.
And if this external ANGLE context is created with
EGL_EXTERNAL_CONTEXT_SAVE_STATE_ANGLE. ANGLE will save GL state of
the native GL when this ANGLE context is made current. And ANGLE will
restore the saved GL state of the native context, when this ANGLE
context is released with eglMakeCurrent(EGL_NO_SURFACE, EGL_NO_CONTEXT).

Bug: 1157501
Change-Id: If7bb23dda18f09866fe33d185ef0f21a78a6ba1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638194
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846194}

This reverts commit 17801e45.

Reason for revert: Fixes to the internal scripts that broke
have landed.

Original change's description:
> Revert "Reland "Force Python 3 to be used in build.""
>
> This reverts commit 6ea5c38d.
>
> Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview
>
> Original change's description:
> > Reland "Force Python 3 to be used in build."
> >
> > This reverts commit b6172196.
> >
> > Reason for revert: We rolled GN to a new version with a fix for
> > the win dev issues, so hopefully is good to go now.
> >
> > Original change's description:
> > > Revert "Force Python 3 to be used in build."
> > >
> > > This reverts commit bb97ab9b.
> > >
> > > Reason for revert: Various breakages.
> > >
> > > Original change's description:
> > > > Force Python 3 to be used in build.
> > > >
> > > > This CL makes Python 3 be the default script executable used by Ninja
> > > > to run action() and action_foreach()'s during the build.
> > > >
> > > > This does *not* mean that everything works with Python3; many targets
> > > > may still use Python 2 via the python2_action() and
> > > > python2_action_foreach() targets or via custom logic.
> > > >
> > > > However, it does mean that it should prevent regressions from
> > > > creeping in.
> > > >
> > > > This CL should not be taken to imply that we can start to write
> > > > Python3-specific code that can run during the build; we should
> > > > still be trying to ensure that everything is compatible with Python2.
> > > >
> > > > Also, this CL does not enable the use of vpython in actions; we should
> > > > still avoid that because vpython is slower than direct Python
> > > > invocations.
> > > >
> > > > Bug: 1112471
> > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787
> > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#836234}
> > >
> > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> > >
> > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1112471
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#836284}
> >
> > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1112471
> > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#844885}
>
> TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1112471
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#844986}

TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1112471
Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#846193}

When AsyncInitializationActivity is destroyed, modalDialogManagerSupplier
offers a null object, which cause the mediator a NPE.

Bug: 1169413, 1163300
Change-Id: I858ffc2aab2fcedabb792087780072808789f76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644064Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#846192}

Bug: 1169366
Change-Id: I98a1d5270cdff58884958e837ab001e56d6eee90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643029Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#846191}

ChromeExtensionsRendererClient::CreateBrowserPluginDelegate is not
called. This method has the only ctors for ExtensionGuestViewContainer
and MimeHandlerViewContainer classes, so those classes can be deleted.

GuestViewMsg_GuestAttached and ExtensionsGuestViewHostMsg_ResizeGuest
are IPC messages that are only sent/received by those classes so those
messages can also be removed.

BUG=533069

Change-Id: Ie904cfdd01db9980a4286be6a79e94e2eb83374f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635797
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846190}

Backings require re-implementing of traits. Split the files off instead
of relying on the macro to split the implementation of each trait.

Bug: 1056170
Change-Id: I43a005119986ec51c05a34f76dca25614a6f1196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642340
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846189}

The NativeThemeGtk instance is able to detect high contrast changes
in the system by reading the GTK theme name. NativeThemeAura is not
capable of doing this however, and is never aware of the true state of
high contrast in the system. With this change, NativeThemeGtk will
update NativeThemeAura when high contrast changes.

Bug: 1157686
Change-Id: I6f0407dd639a1d61d1d7f99fccd2122cb0fdc669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586068
Commit-Queue: Andres Pico <anpico@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846188}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/21b394fcfab2..170343fcf165

2021-01-22 vapier@chromium.org cros_update: convert to python3 only
2021-01-21 yueherngl@google.com octopus: add firmware-octopus-11297.196.B branch builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I0d730b3b9c9333068985f57e384ed86722674342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645047Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846187}

This reverts commit 9a823ced.

Reason for revert: Need to make another modification to the string.

Original change's description:
> [Live Caption] Update Live Caption subtitle string based on UX feedback.
>
> Bug: 1055150, 1167349
> Change-Id: I4c321cdfa6e00c3a8002cbea02e89fc2689e3ecd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633375
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Abigail Klein <abigailbklein@google.com>
> Cr-Commit-Position: refs/heads/master@{#844972}

TBR=avi@chromium.org,abigailbklein@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1055150
Bug: 1167349
Change-Id: If426b45462ab0b25bbe9cd68e51c42d22cda2358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643491Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#846186}

For a nested class use BEGIN_NESTED_METADATA(outer_class, class_name, parent_class_name)

The use of the other macros remain the same.

Bug: 1166802
Change-Id: I125dce952969d529e0277559ab739ef89bae9afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631607Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846185}

Create separate CSS module which will hold specific vars to change
style of oobe elements.

Bug: 1151292
Change-Id: Ic9afa104672325d2330fcf08550f0b5b0d251623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580884
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846184}

A macOS notification is identified with the tuple
{notificationId, profileId, incognito} and we have to pass these down to
the XPC service to close the correct notification. The same applies to
the notification id used in the UNNotification API where we need to
include the incognito flag in the id. Also updates some method names to
be more consistent.

Bug: None
Change-Id: Ie45cb74eab182e0b495560110d8e6e32367c4bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642275Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846183}

This reverts commit bbc76b3b.

Reason for revert: This flakiness was caused by crrev.com/b53ca149, which was reverted in crrev.com/7cf9ce83.

Original change's description:
> Disable ExtensionServiceTest.ExternalInstallClickToRemove on Win
>
> It is flaky 
>
> Change-Id: I0a1f011768ddef79c16bd0945231fe3b96dd7146
> BUG: 1168464
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640037
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#846046}

TBR=rdevlin.cronin@chromium.org,cfroussios@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,cfroussios@google.com

Change-Id: Id3941aa4683d0fd7f54b734faa0d60f472a344b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644379Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846182}

Bug: b/175311081
Change-Id: Ibfce2d6df8033426fe54afee3ca511bcca13e948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642373
Commit-Queue: Michele Mancina <micantox@google.com>
Reviewed-by: Luca Hunkeler <hluca@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846181}

The flag is nop now.

Bug: 1142713
Change-Id: Iff9287d2d317fce85c06ba43cfaabf2fc66efbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643000
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846180}

We've decided to remove V8's behavior of filtering the import assertions
to only those expected by the embedder.  The interop guarantees provided
by doing the filtering in V8 are probably not worth the added
complexity. Going forward, hosts will no longer need to provide a list
of supported assertions, and they will be expected to ignore unknown
assertions received from V8.

The Blink code is already written such that unexpected assertions are
ignored, so the only thing that needs to be done on this side is to
remove the DCHECK that expects at most one assertion.

Once the V8-side changes are made to remove the filtering, Blink can
then stop setting
v8::Isolate::CreateParams::supported_import_assertions.

Change-Id: I40578c40ff4c97cd64b6bb0840b72163e9c5a2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643059Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#846179}