- 13 Nov, 2018 40 commits
-
-
Stephane Zermatten authored
https://chromium-review.googlesource.com/c/1331401 introduced a bug that made the page visible temporarily between the time the overlay is switched off and the time a touchable element appears. This was due to an over-eager early abort in updateTouchableArea, which would not update anything unless the touchable area changed - regardless of whether enabled changed. This patch fixes the problem by decoupling the update of "enabled" from the update of the touchable area. Bug: 806868 Change-Id: I3ee78489cb538d6fd06e24d15fcb47a456b1f079 Reviewed-on: https://chromium-review.googlesource.com/c/1333754Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607630}
-
Lukasz Suder authored
The details and statusMessage were moved to controller. If the details from parameters differ from details coming from Action, Autofill Assistant is closed. Bug: 806868 Change-Id: Icb7da81fa7eca0bf4894632f4ca0c3a68b16ae1c Reviewed-on: https://chromium-review.googlesource.com/c/1332192 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607629}
-
Fredrik Söderquist authored
filter-contrast-003.html Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just over 0.25 and can after filtering and rounding end up above 0. (0x3f / 255) on the other hand is just below 0.25 and the result will be clamped to zero. filter-external-001-test.html filter-external-002-test.html Change the hue-rotate parameter in the external file from 120 to 150. Move the file to support/ and remove lint entry. Make both filters operate in sRGB to make computing the reference easier. Use rgb(...) notation with percentage values in reference. fecolormatrix-type.html Add color-interpolation-filters=sRGB to the filter to make it easier to reason about what the result should be. Use rgba(...) notation in the ref using percentage notation. filters-test-brightness-003.html Add 'filter: brightness(0)' before 'filter: brightness()' to properly test if the "no argument" notation is considered valid by the parser. filter-grayscale-001.html filter-grayscale-002.html filter-grayscale-003.html filter-grayscale-004.html filter-grayscale-005.html Remove the " (and not blue)" text from the reference and update the 001,004 and 005 tests accordingly. css-filters-animation-saturate.html Interpolate the argument from 4900% rather than 5000% to end at the ref's 2500% (25). css-filters-animation-hue-rotate.html Sample the animation at .5 to match the expectation. css-filters-animation-drop-shadow.html Use explicit rgba(...) in the ref rather than the keyword 'gray'. We're interpolating the color of the drop-shadow from 'black' (rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's better and more accurate to describe the color as "semi-transparent black" (rgba(0, 0, 0, 0.5)). css-filters-animation-combined-001.html Initial value for animation for 'opacity(...)' is '1' - not zero. Change test to interpolate from 0 -> 1 (rather than 1 -> 1) Bug: 903383 Change-Id: I4d0113989414616494b98c22fbac817f007cd762 Reviewed-on: https://chromium-review.googlesource.com/c/1333816Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#607628}
-
Steve Anton authored
A ByteBufferQueue is internally a queue of byte buffers. Clients can append entire byte buffers then copy data out across buffer boundaries. Bug: 874296 Change-Id: I64e8a7e9f080aa73e818a81c1a42241ac9ac4e26 Reviewed-on: https://chromium-review.googlesource.com/c/1289152 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607627}
-
Corentin Wallez authored
A lot of expectations were removed but some of them were still necessary, this adds them back. TBR=kbr@chromium.org BUG=chromium:693135 BUG=chromium:772651 BUG=chromium:798117 BUG=chromium:874620 BUG=chromium:887241 Change-Id: Ib3bccdf2ff48a28a8f0a3ce428239980a58c5266 Reviewed-on: https://chromium-review.googlesource.com/c/1333650Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607626}
-
Dan Harrington authored
The Google c++ style guide removed this rule in 2014. There was support on cxx for removing this rule from the Chromium style guide. Change-Id: I6434b2c2112638cfe96e8c42b59e20889d19aa9f Reviewed-on: https://chromium-review.googlesource.com/c/1330935Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#607625}
-
Fabio Tirelo authored
This is another step to generalize the data sent to the front end for the accessory sheet, to enable sending data for profiles and credit cards. Please check the linked bug for the desired final state as well as the steps of this refactoring to be sent in follow-up CLs. Bug: 902425 Change-Id: I240da77100748a337b889bff7b4be0a7c82404f4 Reviewed-on: https://chromium-review.googlesource.com/c/1330694 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607624}
-
Moe Ahmadi authored
SaveCardInfoBarView's constraints break while the parent view animates. This CL fixes that problem by lowering the priority of the constraints on the SaveCardInfoBarView's bottom anchor while setting up subviews and restoring it once SaveCardInfoBarView has moved to its superview. This CL also: -adds a11y identifiers to subviews for easier debugging. -sets translatesAutoresizingMaskIntoConstraints to NO where missing. -removes unnecessary constraints. Bug: 904521 Change-Id: I99dabdbc83614b881c6af4eaad22c29cc4fd8c08 Reviewed-on: https://chromium-review.googlesource.com/c/1331910 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607623}
-
Christopher Thompson authored
This adds the custom malloc/free functions from the old libpng_read_fuzzer to the upstream fuzzer to prevent clusterfuzz running into OOM. Bug: 904054 Change-Id: Ibb824beb191cb5657687c55ee2db8c7783547bad Reviewed-on: https://chromium-review.googlesource.com/c/1330936 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607622}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd47a379f960..0864a7ac638c git log cd47a379f960..0864a7ac638c --date=short --no-merges --format='%ad %ae %s' 2018-11-13 syoussefi@chromium.org Vulkan: Enable end2end tests for ES2_VULKAN everywhere Created with: gclient setdep -r src/third_party/angle@0864a7ac638c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I15f68178f76b7927f5f059c7124c23256173dde2 Reviewed-on: https://chromium-review.googlesource.com/c/1333853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607621}
-
Fredrik Söderquist authored
This replaces a Vector<std::pair<..., ...>> with a new SVGEnumerationMap class that wraps a list of entries (also "pairs".) The setup of the map is however not done runtime but rather compile time, saving a bunch of code footprint in the process. Change-Id: If2c77f1ebcf15dcf8fc75d6a25cacebf42401287 Reviewed-on: https://chromium-review.googlesource.com/c/1329974Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#607620}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: Iae8ac063b497ba4a74244d73927bc093cb42b57e Reviewed-on: https://chromium-review.googlesource.com/c/1333387Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607619}
-
Marc Treib authored
Bug: 884159 Change-Id: Idb63eef4c7e6786ac589fc39bd637478c8b7ff8b Reviewed-on: https://chromium-review.googlesource.com/c/1333370Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607618}
-
Marc Treib authored
Bug: none Change-Id: I41edddb7fd8555c8ef513a714cb4540b0b2d2718 Reviewed-on: https://chromium-review.googlesource.com/c/1333749Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607617}
-
Nicolas Ouellet-payeur authored
Bug: 904840 Change-Id: I49876ee13a190b0b257197d31cd93230778a0e08 Reviewed-on: https://chromium-review.googlesource.com/c/1311079 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607616}
-
Aaron Leventhal authored
Bug: 904433 Change-Id: Ida5f3e93ede1f26cbf98a8e0b786a7f9ef2334f1 Reviewed-on: https://chromium-review.googlesource.com/c/1331727 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607615}
-
Mario Sanchez Prada authored
Move away from SigninManagerBase::GetAuthenticatedAccountId() and AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager. Bug: 903835 Change-Id: Ia9b3f6251ad93b9cd6e042b54283b56fb0610bc8 Reviewed-on: https://chromium-review.googlesource.com/c/1333447Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#607614}
-
Sylvain Defresne authored
This reverts commit 8bd3e513. Reason for revert: identified as likely cause for flakyness of PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation by FindIt Original change's description: > Integrate Lite Page Server Previews with the Previews Stack > > Adds Lite Page Server Previews to DetermineAllowedPreviews and > DetermineCommitted. For now, the preview is always allowed if the > feature is enabled and is committed if the URL matches. > > This intentionally leaves an open question about whether more logic > in the NavigationThrottle can/should be moved into the DeciderImpl. > > The biggest part of this change is moving the URL checking logic to > the previews component and adding additional helper functions there. > > Bug: 898557 > Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9 > Reviewed-on: https://chromium-review.googlesource.com/c/1323800 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607427} TBR=dougarnett@chromium.org,robertogden@chromium.org Change-Id: Iaa200e39f10086d95654bc7fb7485c66d3f53ed0 No-Presubmit: true No-Tree-Checks: true Bug: 898557,904830 Reviewed-on: https://chromium-review.googlesource.com/c/1333814Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607613}
-
Alexander Timin authored
It assumes a specific ordering between immediate and delayed tasks that is not guaranteed by the SequencedTaskRunner API which only states that : // - Given two tasks T2 and T1, T2 will start after T1 starts if: // // * T2 is posted after T1; and // * T2 has equal or higher delay than T1; and // * T2 is non-nestable or T1 is nestable. This property is already verified by MessageLoopTypedTest.PostDelayedTask_InPostOrder_3 and recursive post task ordering is verified by MessageLoopTypedTest.RecursiveDenial1. R=gab@chromium.org BUG=891670 Change-Id: Ic340df17dcd3529565564dff3c18c64f48bd1d2d Reviewed-on: https://chromium-review.googlesource.com/c/1333772Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607612}
-
Scott Violet authored
as it is flaky BUG=904841 TEST=test only change TBR=antrim@chromium.org Change-Id: If14a89ef3e6488867860601b9191e55381245547 Reviewed-on: https://chromium-review.googlesource.com/c/1333757Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607611}
-
Scott Violet authored
This reverts commit 2687587b. Reason for revert: This triggers a use of initialized value on the msan bots. I believe you forgot to initialize is_removing_imm_entry_ https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929963931985091872/+/steps/unit_tests/0/logs/ArcInputMethodManagerServiceTest.EnableIme/0 ==14387==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5638655272d9 in arc::ArcInputMethodManagerService::ImeMenuListChanged() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc:394:7 #1 0x56385b307d20 in arc::ArcInputMethodManagerServiceTest_EnableIme_Test::TestBody() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc:313:14 #2 0x56385dbb3cb2 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #3 0x56385dbb3cb2 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2522:0 #4 0x56385dbb7a6b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2698:11 #5 0x56385dbb9559 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #6 0x56385dbf2614 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5182:43 #7 0x56385dbf0ee7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #8 0x56385dbf0ee7 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4791:0 #9 0x56386b81af20 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2333:46 #10 0x56386b81af20 in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #11 0x56386b822e8a in Run ./../../base/callback.h:99:12 #12 0x56386b822e8a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #13 0x56386b822607 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10 #14 0x56386b7e9154 in main ./../../chrome/test/base/run_all_unittests.cc:30:10 #15 0x7fd6f88f4f44 in __libc_start_main ??:0:0 #16 0x5638521e2b09 in _start ??:0:0 Original change's description: > Disable Android IMEs according to given ImeInfo. > > Android IMEs can be disabled in Android side by using 'ime' command. > This CL ensures that disabled IMEs are also disabled in Chrome OS's > InputMethodManager. > > Bug: b/119274469 > Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2 > Reviewed-on: https://chromium-review.googlesource.com/c/1331294 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607473} TBR=yusukes@chromium.org,yhanada@chromium.org Change-Id: I5fd93607e711cd90edc4eb0ccf656b4c82ad5555 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/119274469 Reviewed-on: https://chromium-review.googlesource.com/c/1333892Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607610}
-
Jun Choi authored
WebAuthN UI modal should only show Bluetooth security keys in device selection modal if the security key is in pairing mode and not already paired. As so, plumb FidoAuthenticator::IsPaired() to WebAuthN Chrome embedder layer. Bug: 877344 Change-Id: I214ef45b833cbf3c9258be10b4a83b43f4b51167 Reviewed-on: https://chromium-review.googlesource.com/c/1319631 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607609}
-
Elly Fong-Jones authored
IconLabelBubbleView is a Button and should use Button::GetAccessibleNodeData, not Label::GetAccessibleNodeData. Setting its button text causes the right behavior here. Before: "This site is using your location." After: "This site is using your location. Button." Maybe ideally: "This site is using your location. Manage location access. Button." ... but that requires new strings. Bug: 879014 Change-Id: I7b4840e17ea70eede41ee0b3095a8a2de288c6ea Reviewed-on: https://chromium-review.googlesource.com/c/1331668 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607608}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d6eeae28d72..a20b35ec2dc1 Created with: gclient setdep -r src-internal@a20b35ec2dc1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I99fb2333987a8240bb457e8ff95037878b43502d Reviewed-on: https://chromium-review.googlesource.com/c/1333851Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607607}
-
Daniel Bratell authored
There is a kSymbolKey in the public API and due to the new enum shadow warnings, jumbo builds might combine the code in such an order that the public blink::WebInputEvent::kSymbolKey shadows the blink::{anonymous namespace}::kSymbolKey. Note, there is no bug, just an unfortunate false warning and one that only appears in rare jumbo builds. Change-Id: Id575b2aef3b3f1be46d3722ed79454212bcf650e Reviewed-on: https://chromium-review.googlesource.com/c/1333649 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#607606}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e3109c99ea5..60b6bc3c2950 git log 9e3109c99ea5..60b6bc3c2950 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Use WriteVertexData in GrTessellator, remove all DefaultGeoProc structs Created with: gclient setdep -r src/third_party/skia@60b6bc3c2950 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I664b7d784a81890fb6b086bfaf56519d79f3fdc6 Reviewed-on: https://chromium-review.googlesource.com/c/1333852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607605}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fc18984..0e317c5c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9b0c537a35e63f24742ebbb5b0c7fe351d432b83 Reviewed-on: https://chromium-review.googlesource.com/c/1333729Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607604}
-
Guido Urdaneta authored
Bug: 860311 Change-Id: I64a96abec0161200fb55f78c5492e20970fa9c3b Reviewed-on: https://chromium-review.googlesource.com/c/1333369Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#607603}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4afdd6426477..0b46de2db691 git log 4afdd6426477..0b46de2db691 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 primiano@google.com Merge "Deflake TracingServiceImplTest.WriteIntoFileAndStopOnMaxSize." Created with: gclient setdep -r src/third_party/perfetto@0b46de2db691 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I90135bd3fee0e58dc88cf6100472381a732d0786 Reviewed-on: https://chromium-review.googlesource.com/c/1333847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607602}
-
Daniel Bratell authored
In jumbo build experiments, two cc files both defined interface_name<PPB_InputEvent_1_0>() which clashed since in jumbo builds many cc files are compiled in the same translation unit. This moves the shared code to a shared file. Bug: 898475 Change-Id: I9ce58e837d663cb5c15ba2596c22812a41def4c0 Reviewed-on: https://chromium-review.googlesource.com/c/1297148Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#607601}
-
Greg Thompson authored
Previously, downgrades were only possible via master_preferences (for use by the enterprise wrapper). This change makes downgrades possible via the command line. BUG=607592 R=zmin@chromium.org Change-Id: I5885fe9eb1b2f2ba477958a9d06797da6e9d4acc Reviewed-on: https://chromium-review.googlesource.com/c/1333811Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1ff631c9f6c..c59d48ec1594 git log f1ff631c9f6c..c59d48ec1594 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 dgarrett@google.com manifest_version: Add resolution helpers for buildspecs. Created with: gclient setdep -r src/third_party/chromite@c59d48ec1594 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc7c3cccd04799b23d4a10ec7b89153778e6b5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1333850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607599}
-
Francois Doray authored
Change-Id: Ic6f6d7b29443395105c8a3619b74bac9f464666e Reviewed-on: https://chromium-review.googlesource.com/c/1330062Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607598}
-
Yi Gu authored
Currently there is a call to rAF inside step_func_done which means the test will actually complete before the rAF fires and so the assert_true will never run. Bug: 887659 Change-Id: Ic3d017cb106994507cba995ccf41133902c0d101 Reviewed-on: https://chromium-review.googlesource.com/c/1333887 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607597}
-
Raphael Kubo da Costa authored
https://gn-review.googlesource.com/c/gn/+/3200 removed the --no-sysroot option from gen.py and moved to only use a sysroot in the GN bots, so the options here no longer have any effect. Bug: 904350 Change-Id: Ieddc71a4f8f802c2d050de1c69ca3a9ec788ee88 Reviewed-on: https://chromium-review.googlesource.com/c/1333391Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#607596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c6f6e21. With Chromium commits locally applied on WPT: 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I89e3faebc7872e892ad5ec43b0b3bcd8fd514021 Reviewed-on: https://chromium-review.googlesource.com/c/1333728 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607595}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f343a1576406..2b1f6b373ca9 git log f343a1576406..2b1f6b373ca9 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 sheredom@gmail.com Validate that VertexId and InstanceId are not allowed in Vulkan. (#2036) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2b1f6b373ca9 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibf1eb4d5be24102a7c77f0ecf9e92f735ee0cb16 Reviewed-on: https://chromium-review.googlesource.com/c/1333848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607594}
-
Egor Pasko authored
Because of expecting '.' in every orderfile entry the current compare_orderiles.py observes zero symbols in recent orderfiles. Add a separate (simpler) path to parse the new orderfiles (with symbols only). Also add an option to keep the downloaded orderfiles in /tmp for further inspection. Tested with orderfile commits: new: 03cc43767b83b9b3460461dc5636be1ce1e74e51 old: a4b93acc41d5e19e4cbfb86d802f442dce10e38f One new worry is that for newer orderfiles the 'average fractional distance' is usually about 4.50% while for the old orderfiles it used to be less than 0.5%. There are 1.4x more symbols now than there were back then. Bug: 893981 Change-Id: I1c812d4d67f68e0ee0fc31273104a2145fbebaa9 Reviewed-on: https://chromium-review.googlesource.com/c/1333648Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607593}
-
Jean-denis Muys authored
The new story is named cct:no_warmup:bbc Bug: 760498 Change-Id: I11a1d2e0b9b4a9dbfb4c4f31f039c4ca3bbe75c6 Reviewed-on: https://chromium-review.googlesource.com/c/1301914 Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607592}
-
David Bokan authored
https://codereview.chromium.org/2860663006/ forgot to update the kTypeLast. Change-Id: Ieae9b0711c841a00357dfd3190c6ed9e1c5c86a6 Reviewed-on: https://chromium-review.googlesource.com/c/1331045Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607591}
-