GitLab

This is needed so that the network conditions can be visibile to
GenericURLRequestJob in headless/public/util. We need to store
it in the HeadlessBrowserContextImpl, since GenericURLRequestJob
does not reuse the network stack (e.g. DevToolsNetworkTransaction,
etc).

Bug: 
Change-Id: I531acda73bffad2e504efbfbaa4fd8df2ef4b23e
Reviewed-on: https://chromium-review.googlesource.com/696887
Commit-Queue: Iris Uy <irisu@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506980}

This CL adds FrameServiceBase which is a base class for mojo interface
implementations that is tied to the lifetime of a document.

Also updates MediaDrmStorageImpl, OutputProtectionImpl and
PlatformVerificationImpl to use the new FrameServiceBase class.

TBR=halliwell@chromium.org,mnissler@chromium.org
BUG=707335
TEST=New unit tests for FrameServiceBase

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7f69f70a3da24c784267ecc1d49fd681bbf1a71a
Reviewed-on: https://chromium-review.googlesource.com/678438
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506979}

This patch makes |LayoutSelectionTest.FirstLetterClearSeletion| simpler for
improving code health.

Change-Id: I316057bc63acb597cc2a2575a9416ae8b0eaf927
Reviewed-on: https://chromium-review.googlesource.com/702195
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506978}

This fixes a bug in which the focus ring could remain on the screen
if the user released the 'search' key before letting go of the
mouse button.

Bug: 770881
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I11dd444aaa03e7e7fff08d77ed6e18ac79c8b895
Reviewed-on: https://chromium-review.googlesource.com/696188
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506977}

This reverts commit 81ed4437.

Create a separate thread for the compositor. Use the thread the GpuMain
instance is created on as the thread for the GpuService. This allows
using it in content (in GpuChildThread), where the main thread is used
for the gpu service.

For the mus window server, until the gpu process-split happens, create
a separate thread for the gpu service from the DefaultGpuHost. After
the process split, the main thread of the new process can be used for
the gpu service (like GpuChildThread in content).

BUG=730213
TBR=kylechar@chromium.org,fsamuel@chromium.org

Change-Id: I96b5dc9e74e1c14db62659c686e537a3c131e2d7
Reviewed-on: https://chromium-review.googlesource.com/704158Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506976}

Add test cases for
- moving cursor on same text node.
- content editable button.
- clear selection.
- svg text.

This patch is a preparation for solid SelectionState marking:
https://chromium-review.googlesource.com/c/chromium/src/+/689274

Bug: 739062
Change-Id: Iaba1e30d7de3868fb61abb1f8042a5e65316c066
Reviewed-on: https://chromium-review.googlesource.com/701906
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506975}

https://skia.googlesource.com/skia.git/+log/ded7aa82afa9..b3255260eff5

$ git log ded7aa82a..b3255260e --date=short --no-merges --format='%ad %ae %s'
2017-10-05 angle-deps-roller Roll skia/third_party/externals/angle2/ af143feff..e159717d4 (1 commit)
2017-10-05 reed remove legacy fontmgr flag from flutter
2017-10-05 angle-deps-roller Roll skia/third_party/externals/angle2/ 000dab88d..af143feff (1 commit)
2017-10-05 egdaniel When mip mapping, do YUV mip generation on CPU then upload to GPU.
2017-10-05 reed experiments to speed up drawing 32bit images into 565

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ie21e266aeda09730a22740d7ddc9b2ee757ae026
Reviewed-on: https://chromium-review.googlesource.com/704271Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506974}

This makes builds slightly more position-independent and
should improve goma caching. This is a reland of
r486793 now that the issues have hopefully been addressed.

R=pcc@chromium.org, thakis@chromium.org, manojgupta@chromium.org
BUG=712797

Change-Id: Ief5392b2f64b6c4bc5192f65ac2cdda65733fe9b
Reviewed-on: https://chromium-review.googlesource.com/701464
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506973}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f5b136ee..5e463cff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I19f0ca56d256d5f87e0920c365d132e327aa127e
Reviewed-on: https://chromium-review.googlesource.com/703759Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506972}

This patch refines selection-repaint-with-gaps.html
It tests selection painting and invalidation.
It used to output layout tree into DOM and confirm its text
dump.
However it also output pixel result so output png was
 strange: it contained painted layer tree text dump.
This patch refines the test to dump:
- *.txt for layer tree
- *.png for paint result only contains selected text.


Bug: 739062
Change-Id: I60e9b16f2061a77d50e5a65fd287981f63518dc8
Reviewed-on: https://chromium-review.googlesource.com/701938
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506971}

The long-term plan is to remove base::NullableString16 and just use
base::Optional<base::string16> directly.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I43b994de70262326b0ca148d888b4424f9d4a795
Reviewed-on: https://chromium-review.googlesource.com/699860
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Patrick Noland <pnoland@google.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506970}

Bug: 735662
Change-Id: I44d121a5109f7c76667630303200ba30329f7341
Reviewed-on: https://chromium-review.googlesource.com/704035Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506969}

https://chromium.googlesource.com/catapult.git/+log/aeaf34ca03f8..778430a2f76b

$ git log aeaf34ca0..778430a2f --date=short --no-merges --format='%ad %ae %s'
2017-10-05 oysteine trace-viewer: Let the gzip_importer use Pako directly instead of JSZip
2017-10-05 simonhatch Dashboard - Generate same tir_label for /add_histograms as chartjson.
2017-10-05 achuith Copy set so its size doesn't change.

Created with:
  roll-dep src/third_party/catapult
BUG=771421


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5a36807411db3f0d4b44275cf2c517f1e78bb986
Reviewed-on: https://chromium-review.googlesource.com/704261
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506968}

This places it next to the other accessibility code. Move the test
delegate there as well to be consistent with other ash test delegates.

Bug: none
Test: compiles
TBR=reveman@chromium.org for exo

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I276b231c23ffa4241d1cb08782886c4e43d762e6
Reviewed-on: https://chromium-review.googlesource.com/703434
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506967}

Extract lock screen profile creation out of
lock_screen_apps::StateController into a separate,
LockScreenProfileCreator class.

Primary motivation is to delay lock screen profile creation until
lock screen note taking is enabled (i.e. to avoid profile creation
if the user does not have lock screen note taking apps).

AppManager requires lock screen apps profile (as it installs the
note taking app to the profile). Instead of providing the profile
to the AppManager directly, the interface is changed to accept
LockScreenProfileCreator, which can be used to get the lock screen
profile.

LockScreenProfileCreator will observe lock screen note taking
availability, and if it detects lock screen enabled note taking app,
it will create the lock screen apps profile.
If the profile is not created by the time AppManager needs it (i.e.
the screen is locked and the user has a lock screen note taking app
set), the AppManager will be able to use AddProfileCreatedCallback
API added to LockScreenProfileCreator to observe profile state.
When the profile is created, and initialized, the AppManager will
be able to proceed to set up the note taking app.

CL also adds FakeLockScreenProfileCreator that can be used in
unittests to create lock screen (testing) profile and simulate lock
screen profile creator state changes, and adds unittests covering
lock screen apps profile creation.

BUG=765029

Change-Id: I33fdf3a91ea4817a3576b66c950570fc76b3c9c9
Reviewed-on: https://chromium-review.googlesource.com/662403
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506966}

We require every time Chromium talks to the network to be explainable.
In order to do this, we annotation functions that call out to the network.
This CL adds the tooling to ensure that all of the functions are correctly
annotated and that the annotations are syntactically correct and
semantically complete.

Bug: 690323
Bug: 656607
Change-Id: I3e5a8a3d753b70768dd42ad4aa880087a089b61d
Reviewed-on: https://chromium-review.googlesource.com/592721
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506965}

It is unnecessary since all tests did load chrome://extensions as
|browsePreload| anyway, but most importantly this causes the extensions
page to load twice during optimized builds, which leads to runtime errors.

This is in preparation of turning on optimize_webui for MD Extensions.

Bug: 764126
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5e8b903bd4b5589af26fea6b3a25290d56188a7a
Reviewed-on: https://chromium-review.googlesource.com/703861
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506964}

This implements our current behaviour for 'auto' sized FCs within a BFC.

We need to perform layout twice under two scenarios:
 1. 'auto' inline size child. In this case we need to perform layout
    once, and if the child doesn't fit, we perform layout a second time
    with an "open" layout opportunity, so we can guarantee it will fit.

 2. Non-adjoining margin strut and unpositioned floats/current layout.
    In this case we need to perform a relayout as the BFCOffset where
    floats will be positioned will change. This happens if the child
    doesn't fit on the "top" of the exclusion space.

This also adds more TODOs everywhere which we can handle later.
I kept this as small as possible to keep sanity. :)

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I499dc9722fac47f43694f35c507e9d2742d317db
Reviewed-on: https://chromium-review.googlesource.com/680176
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506963}

Reverted because it broke Cronet tests, the reason was CookieStoreIOSClient
used to get IO Taskrunner is not initialized on Cronet Initialization.

[NEW]
* Create CronetCookieStoreIOSClient and set it up with Cronet Network IO
 TaskRunner
* In Cronet initialization Set CookieStoreClient to CronetCookieStoreIOSClient.

[OLD]
* Converts SystemCookieStore to Async
* Add Async functions to NSHTTPSystemCookieStore and keep the synchronous
functions.
* Move creation time management to systemCookieStore.
* Update cookie_store_ios_presistent_unittest &
cookie_store_ios_unittests to account for SystemCookieStore changes
* (As CookieStoreIOS is using systemCookieStore internally).

Another CL is in progress to add WKSystemCookieStore & unit_tests for
systemCookieStore (to handle async methods) with template for both
NSHTTP & WK systemCookieStore.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5c56a7b88868ad24d34dd7109273f2cdc5880d91
Reviewed-on: https://chromium-review.googlesource.com/704014
Commit-Queue: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506962}

The WithBaseSyncPrimitives() trait is deprecated.

ScopedAllowBaseSyncPrimitives(ForTesting|OutsideBlockingScope)
should be used instead.

Bug: 766678
Change-Id: Ib782e9904ddb14ec0c56973abf0324695383451f
Reviewed-on: https://chromium-review.googlesource.com/702655
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506961}

As discussed in email and here, removing dominicc@ and cpu@,
adding scottmg@ and dcheng@.

Change-Id: I37ed0e49209f84668ac4b5b04f659e008b604515
Reviewed-on: https://chromium-review.googlesource.com/696744
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506960}

TBR=amineer@chromium.org

Change-Id: I0b53a125fccf3376bdb30c7702f92de6bcfda930
Reviewed-on: https://chromium-review.googlesource.com/704161Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506959}

This reverts commit 6c1f5306.

Reason for revert:
Speculative revert for build failures on the Mac bot
https://build.chromium.org/p/chromium/builders/Mac/builds/33456

Original change's description:
> egl: Use khronos version of __APPLE__ section in eglplatform.h
> 
> Bug: 769415
> Change-Id: I8e16a2a35286144eaa2d97b4d5f7cf239a00a8e5
> Reviewed-on: https://chromium-review.googlesource.com/703739
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Brian Anderson <brianderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506957}

TBR=brianderson@chromium.org,kbr@chromium.org,cwallez@chromium.org

Change-Id: Ia96b247a9080be24a8c53dca6a7033aed43eb40f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769415
Reviewed-on: https://chromium-review.googlesource.com/704334Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506958}

Bug: 769415
Change-Id: I8e16a2a35286144eaa2d97b4d5f7cf239a00a8e5
Reviewed-on: https://chromium-review.googlesource.com/703739Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506957}

Our PM wants to make the font color of the non-selected language
finch-able to figure out a path forward with making the font darker.
Group 1 will be the default color and group 2 will be the 87% black.

I created the params with our feature TranslateCompactUI and tested by
'--force-fieldtrials=TranslateCompactUI/Enabled --force-fieldtrial-params
=TranslateCompactUI.Enabled:translate_tab_default_text_color/1'

Bug: 771835
Change-Id: I0d2d4eea3707685b45b83e5d7d4079fa855deecd
Reviewed-on: https://chromium-review.googlesource.com/701994Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506956}

In this case, we don't want to serve a preview.

Bug: 772175
Change-Id: I320d6ad26cb7cf51dba9797447e388816115df91
Reviewed-on: https://chromium-review.googlesource.com/703859Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506955}

Bug: 769415
Test: Trace events that use this extension look good.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3f051d4f86894f9029774e73b1327262c514fd53
Reviewed-on: https://chromium-review.googlesource.com/685402
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506954}

TBR=wjmaclean

Bug: 772196
Change-Id: I4ea0411a8ab5a5e88ac1098cabe4103a0761ceb0
Reviewed-on: https://chromium-review.googlesource.com/703860Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506953}

This should increase coverage by allowing the fuzz to produce test
cases in quirks mode too. HTMLQuirksMode has it's own issues in our
code base and getting fuzzer to run these tests would be great.

Change-Id: I0ea188d480d7bc605e0ddf62b665ba88ffde9b45
Reviewed-on: https://chromium-review.googlesource.com/701855Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506952}

for snake_case.

Bug: 770603
Change-Id: Id07cbd58c190cac0ccbc9fcbf92747d83705be64
Reviewed-on: https://chromium-review.googlesource.com/701879Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506951}

for snake_case.

Bug: 770603
Change-Id: Ic158606ea9eb5f6cdf78e1fed72fefaa3ec613c5
Reviewed-on: https://chromium-review.googlesource.com/702200Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506950}

This patch removes obsolete values from InfoBarIdentifier, and labels
all removed values with "(Obsolete)" in enums.xml so it's more obvious
when looking at UMA data.

Change-Id: I4f463462d52954066a5ce38726d4694ed0f2f924
Reviewed-on: https://chromium-review.googlesource.com/702177Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506949}

Bug: 737802
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I19a1edacd4cda27c06f4df631bea9a0b2f9e6a2c
Reviewed-on: https://chromium-review.googlesource.com/690626
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506948}

IsErrored() and HasInstantiated() are to be removed because they are
removed from the HTML spec in
https://github.com/whatwg/html/pull/2991.

This CL
- Replaces IsErrored() calls in unit tests with checks for Instantiate()
  results or with HasEmptyRecord(), depending on whether instantiation errors
  or parse errors are tested, and
- Removes EXPECT_FALSE(HasInstantiated()) from ModuleMapTest.cpp, because
  instantiation is already prohibited by NOTREACHED() in
  DummyModulator::InstantiateModule().

Bug: 763597
Change-Id: I272a03f3d5ce8ddf6ea645a3d0d1a1ae7543f2be
Reviewed-on: https://chromium-review.googlesource.com/703483Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506947}

Right now the MakeSubset and MakeStatic are the only mutating PaintImage
functions. This patch moves those to the PaintImageBuilder and allows
users to use either the full copy or just the properties of a given
PaintImage. This also makes it simpler to add mutations to the PaintImage
via the builder if no builder is initially available.

R=khushalsagar@chromium.org, chrishtr@chromium.org
TBR=dalecurtis@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic766cef20e77dcd3b34fc5abc9373177e5b94eba
Reviewed-on: https://chromium-review.googlesource.com/702646
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506946}

This patch gets rid of redundant argument |VP_DEFAULT_AFFINITY| for
|CreateVisiblePosition()| for improving code health.

This patch is a preparation of renaming |VP_DEFAULT_AFFINITY| to
|TextAffinity::kDefault|.

Bug: 657237
Change-Id: I16e8af4d874afc5059c09f2401cb1f1dc9c98f67
Reviewed-on: https://chromium-review.googlesource.com/701902Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506945}

This patch makes |LayoutSelectionTest.CommitAppearanceIfNeededNotCrash| simpler
for improving code health.

Change-Id: I3f0c930c31870968432c326207ec930a15eecbb1
Reviewed-on: https://chromium-review.googlesource.com/702118Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506944}

This patch gets rid of unused parameter |TextAffinity| from
|TrailingWhitespacePosition()| for improving code health.

This patch is a preparation of renaming |VP_DEFAULT_AFFINITY| to
|TextAffinity::kDefault|.

Bug: 657237
Change-Id: I0c354cbbbe09afc757d23c23db0c8df244c6b09a
Reviewed-on: https://chromium-review.googlesource.com/701904Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506943}

changes:
(1) Since |tablet_controller_| is created OnAccelerometerUpdate, itself
is enough to represent ShouldHandlePowerButtonEvents().
(2) Remove IsTabletModeSupported() in PowerButtonDisplayController. It
is used on stylus removed. Nowadays, stylus is configured on convertible
only. Even for clamshell device with stylus, SetDisplayForcedOff(false)
should be OK since it will be a no-op because of early return.

TEST=covered by tests

Bug: none
Change-Id: I0dd883d9bf97e1c24c1b9acd5e1856b630f97fec
Reviewed-on: https://chromium-review.googlesource.com/702919Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506942}

Previously the FeatureState was recorded as Tether was being
destroyed. However, this was failing to reach the metrics 
dashboard, likely because there are no guarantees that the
metrics pipeline can persist a log when the machine is 
shutting down. There's no need to do this recording at tear 
down, so this CL simply moves when the call is made. 

Bug: 772078
Change-Id: Ib002fb41ae1c5df814fc9cefc6772c1141df8307
Reviewed-on: https://chromium-review.googlesource.com/703915Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506941}