- 22 Jul, 2020 40 commits
-
-
Philip Pfaffe authored
Test expectation updated after landing CL 2245146. Bug: chromium:1083146, chromium:1107339 Change-Id: Ide9338ee0f34234270b0264c38f0b41274ca6502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306254Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#790811}
-
Maksim Ivanov authored
Refactor the code of form "CHECK(base::PathService::Get(...))" with the alias function base::PathService::CheckedGet(). This is a pure refactoring CL - no change of functionality is expected. Bug: none Change-Id: Ia4a04a51fd6f3c7ec4fca0a9bf5cb27224dfc5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288631 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#790810}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. |mProfile| instance variable stores the profile coming from constructor and this CL passes |mProfile| to IdentityServicesProvider class. Since IdentityServicesProvider return null for off-the-record profile, there is an additional null check for identity manager. Bug: 1041781, 1075562 Change-Id: I9966e7177e81d2e0bb45b5b8c93e29e8715b7747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307235Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790809}
-
Olesia Marukhno authored
Bug: 1098660 Change-Id: I3036489ce3b939d9668c6fa374c465caf8f98a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292290 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790808}
-
Victor Hugo Vianna Silva authored
Bug: 1060128 Change-Id: I9a5a117b84ae6913942dfba1dd438b6ad501a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312476 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790807}
-
dizg authored
Bug: 1105865 Change-Id: I0f1091e2068e4a1cfff0e6eee9b2898a74e4a945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308416 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#790806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..9165cbb4f40d 2020-07-22 johnkslang@users.noreply.github.com Merge pull request #2354 from ben-clayton/limit-visibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I6a9ef911894db468a2ccff97f1d71a5e331c20c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790805}
-
Olesia Marukhno authored
Accelerators are processed on MacOS without doing the manual redirect to bubble's anchor widget so this code doesn't need to be included in Mac. I exclude it here because it appears that it breaks processing accelerators by the bubble (ex. copy text). Bug: 1106654 Change-Id: I4837d6aec4175dd170632678047755b62c5e1b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303720Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15011595..97471695 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0e6ce2e3d5146e9497413a4855f3adbdcb8829af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311538Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790803}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib7824eca25aa23cb949d3d998d410d09db93ef60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306110 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9dd9a4b88264..6651f11ef8de 2020-07-22 szuend@chromium.org Migrate 'front_end/browser_sdk' to 'devtools_entrypoint' 2020-07-22 szuend@chromium.org Migrate 'front_end/dom_extension' to 'devtools_entrypoint' 2020-07-22 jacktfranklin@chromium.org Fix bad border colour on computed styles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I204cf0441473ec429690d3897830cffc81fe9df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311953Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since back up is only available in regular mode, it is safe to pass always regular profile to IdentityServicesProvider functions. Note: This CL does not make any behaviour change. Bug: 1041781, 1075562 Change-Id: Iced1c7c721491e8e24eb747c5e6a65cadc64801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307290Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790800}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14ddd018d942..53a32034a451 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817 Tbr: orphis@google.com Change-Id: I8c8ff6f08ee22e8fb50b5801f66e0e6c3310428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311952Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790799}
-
Boris Sazonov authored
Fixes an ANR that happens on Chrome startup. Now, if the list of accounts is not available when launchSigninPromoIfNeeded is invoked, the promo is suppressed. Bug: b/160838338 Change-Id: Ibbdbfc2f0adc7ae40fe22568f5607c2c4a9f42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303443Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790798}
-
Maksim Ivanov authored
* Add "onCertificatesUpdateRequested" event, to supersede the "onCertificatesRequested" event. * Add "onSignatureRequested" event, to supersede the "onSignDigestRequested" event. * Add "reportSignature" method, to supersede the old way of responding to the callback passed with the "onSignDigestRequested" event. * Add "Algorithm" enum, to supersede the old "Hash" enum. * Add "Error" enum. * Change data structure to anticipate passing certificate chains instead of only leaf client certificate. Main goals behind those changes: * Avoid nested callback-in-event APIs that required custom binding code. * Switch to the generic term "algorithm" that is more appropriate than "hash" for newer schemes like RSA-PSS. * Pass unhashed data instead of prehashed, in order to be compatible with newer schemes like Ed25519. * Pave the way for providing more data from the middleware, like certificate chains or error codes. Bug: 1078761 Change-Id: Ie004974a578baafb13424b570920645d112b612d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246682 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790797}
-
Yuki Shiino authored
base::CheckedPtr<T> should behave as if it's a raw pointer. When an implicit conversion from U* to T* is allowed, similarly an implicit conversion from CheckedPtr<U> to CheckedPtr<T> should be allowed, too. This patch supports such an upcast of CheckedPtr<T>. Bug: 1073933 Change-Id: I0b93c95f44cf27849a96ea14c2025fd3f4a5b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303409Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790796}
-
Saurabh Nijhara authored
This CL fixes the following bugs as per UI feedback :- 1) Makes notification warning level as critical if time remaining is equal to less than one week in case of auto update expiration because the device would be blocked for further use post that. 2) Displays warning time (in the notification) in weeks. The logic of when to show time is weeks is kept simple at the moment. As discussed with UX need to show warning in weeks if number of day remaining is a multiple of 7. Bug: 1106768 Change-Id: I8d8049a69117b4c13c76dcff51c7248b64350c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302760 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790795}
-
Rakina Zata Amni authored
Moves WebPreferences from RenderViewHost to WebContents, as it should have the same value for all RenderViewHosts in a WebContents. This CL also moves GetWebkitPreferences and UpdateWebkitPreferences to WebContents. Other functions will be moved in future CLs. AX-Relnotes: n/a See https://docs.google.com/document/d/1qgSZU3RtIrniypgBhi-4Xyfjd1bor-SNqFbMCyqb5C8/edit?usp=sharing and https://docs.google.com/document/d/1oZvhCfYg0osf1S6T_4CcBv3OTZHfCVu4-gs4H6ZqMto/edit?usp=sharing Bug: 1085003 Change-Id: Ie2948bff2921df57b024a5020577fd41aaecaf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263635 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#790794}
-
Ehimare Okoyomon authored
Reuse SingleWebsiteSettings as a fragment for the permissions subpage of page info. Will fix UI and reset functionality in a separate CL. Screenshot: https://screenshot.googleplex.com/FyTQETNXefz.png Bug: 1077766 Change-Id: I9f47ae80bcfdbd92c1399670948f5cdfea6f4e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252183Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790793}
-
Omar Morsi authored
This CL refactors platform keys services such that an enumerated status is returned for every service operation signaling the success of the operation or the type of the error. That will be easier and more error prone for service consumers to code against. Bug: 1073512 Change-Id: I4225a273c8afe97df387b5cdfc81c47be5ec67de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292293Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#790792}
-
Antonio Sartori authored
I recently (https://crrev.com/c/2220053) extended the network CSP parser adding support for almost all missing directives so that it can be used for CSP: Embedded Enforcement (https://crbug.com/1094909). I did not add a few directives which are ignored for CSPEE at the moment. However, with https://crrev.com/c/2279976 they will generate a warning, which we do not want. This CL adds support for the missing directives in the network CSP parser. Although the values of the directives are not being parsed, they are recognized as being valid directives ad will not generate any warning. Bug: 1094909 Change-Id: I2c4b74ede0ca56b4b7582db9cc3eb809b36ce19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300300Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#790791}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aac1fd95. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I864efce9c23395831be6ff4d013357078b8dea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311857Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790790}
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: Ia75170ea791b5c8ffff100f58af1a7f65497b882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283037 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Timothy Loh authored
Change-Id: I521b491d49647c8b3eca789aa7568da1dc2f7ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311604 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#790788}
-
Viviane Yang authored
In base/values.h, Value::GetStringWithoutPathExpansion is deprecated. Call Value::FindStringKey(key) instead. Change-Id: I037894b4dc52602e55cd60351c4163c4009ad9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310436Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#790787}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6659b3df028..62b67239f59e 2020-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7cc0ead05174 to d92ddcef72ef (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I854cf9c7a7548a1195e58c6d2cc1b9da0fc38766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311950Reviewed-by:
-
Clemens Arbesser authored
We used to have a test like this, but it was disabled some time ago due to hard-to-reproduce issues on devices with older API levels. This is a more focused test specifically for vector graphics. I have tried this on a variety of (emulated) devices and API levels and could not reproduce, so I'm going ahead and submit this test. Tested on: - Generic phone 21 - Nexus 5x 23 - Nexus 5x 25 - Nexus 5x 26 - Pixel 3 XL 28 - Pixel 3 30 Bug: b/145043394 Change-Id: I6d27eeda3e2ef7c2e29d5364838349664a83eb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310991 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790785}
-
Boris Sazonov authored
No behavior change - remove redundant ChromeSigninController.java entry from components/signin/public/android/DEPS. Bug: 1046412 Change-Id: Iebceb3d52477755d28a6379d20a6998931b0941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310534 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/492e4daa3747..6e1eb168a544 2020-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 20eb9be55299 to f6659b3df028 (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1107884 Tbr: robertphillips@google.com Change-Id: I881b5dc9e893dd90fe3541d76aacdd9c36fb8bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311626Reviewed-by:
-
Boris Sazonov authored
Cleans up GoogleServicesManager to simplify upcoming changes to this class. No behavior change. Bug: 1107942 Change-Id: I586ec4a9e8edffef6c4f50a39f541c562c9f90fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310669 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Pâris MEULEMAN authored
This adds the support for report-only COOP triggered Browsing context group switches. During navigation, besides computing whether COOP triggers a BCG switch, this also computes if any of the report-only policies would also trigger a switch if they were effective, the resulting values are stored in booleans within |CrossOriginOpenerPolicyStatus|. This booleans are then used to trigger the navigation reports, and in a follow up to trigger access reports. Explainer [WIP]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md Specification [WIP]: https://github.com/whatwg/html/pull/5518 Bug: 1099208 Change-Id: I2cb66ec5cdcd9d5b4658c28f0608bc6b52d0da6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241529 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790781}
-
Jason Lin authored
Terminal cannot start up if the user block cookies for all sites. This cl will exempt terminal from it. Bug: 1101060 Change-Id: I6c75dad423f5df9de4ac9d6e19469acc433f9fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310024Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#790780}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2675d65f6664..9dd9a4b88264 2020-07-22 jobay@google.com Roll Puppeteer from v4.0.0 to v5.2.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2fabeeb2a85312896d58366c03ba54c1e022ef42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311948Reviewed-by:
-
Mikel Astiz authored
TBR=dmurph@chromium.org Change-Id: I5e2e85f79906bd37fabab55b04c437adf03fcfbf Bug: 1108172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310336 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790778}
-
Victor Hugo Vianna Silva authored
The check is redundant as it's already implied by IsEngineInitialized(). It's also misleading since the introduction of TransportState::PAUSED in crrev.com/c/2302149. Bug: None Change-Id: I18325269b0a4eee8b011e63588d95e41b404a978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310335Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 5fec4b13. Reason for revert: Still crashing. Same bug. Original change's description: > [Paint Preview] Re-enable flaky test > > This re-enables PaintPreviewPlayerTest#overscrollRefreshTest. > The failure cannot be reproduces locally and the bot on which this test > was flaking has been killed recently [1]. > > [1]: https://chromium-swarm.appspot.com/bot?id=luci-chromium-ci-xenial-us-central1-b-8-76-mhb1 > > Bug: 1093083 > Change-Id: Ifacf72e3373fbcfa513d5f8bc87afec03c0c086e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252578 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779899} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093083 Change-Id: I840c3767fd305fb677824456834bfa2a2e506a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311580Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790776}
-
Mohamed Amir Yosef authored
This CL make sure that for account storage users, CredentialManagerPendingPreventSilentAccessTask runs against both the profile and account stores. It also introduced unit testing. Bug: 1093286 Change-Id: Id75bab28bad0b132470eaf4de53e472566dc9027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308422 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790775}
-
Yuki Shiino authored
In order to fill the gap between the old and new bindings generator, implements IDL sequence<enumeration> as Vector<V8GeneratedEnumClass> (was: Vector<String>). Bug: 839389 Change-Id: I3071406a8df088c70973b4069a778f8bdfa27660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068402 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790774}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id27998f08de4b128b3390642fe3b02d57ffe6464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311066Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790773}
-
Maria Kazinova authored
needed. When pending credentials for newly added credentials are created, some elements of a parsed PasswordForm structure must be reset. And they are reset, but the corresponding unique_renderer_id is not cleared, making it hard to rely on unqiue_renderer_id in some logic. Change-Id: I6881ed83410db9dc2ac6850e0c0317003a31647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308717Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790772}
-
