- 05 Jan, 2021 40 commits
-
-
Robbie Gibson authored
This crash only appears when certain other flags are disabled and the thumb strip is enabled (I didn't go through to find out exactly which ones). The root cause is that with these flags disabled, the thumb strip is created before the BVC's view is loaded, so the tab strip view has not been created yet either. Bug: 1094335 Change-Id: If70a670f366145514998ca5e1713a18c7770f58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608832Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840169}
-
Jan Wilken Dörrie authored
This change modifies tools/boilerplate.py to also support no compile tests. This effectively generates the same code as it does for Cpp implementation files, but also adds the following no compile explanation: // This is a "No Compile Test" suite. // https://dev.chromium.org/developers/testing/no-compile-tests Bug: None Change-Id: I913d8e4673fdb4986f7d7e87a6fef15aae835daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595533 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840168}
-
Monica Basta authored
Initially profiles will be ordered alphabetically on the picker's main view. The order will be frozen to the initial order, profiles created will be added at the end of the list, profiles deleted will be moved out of the list. Any update to the profile local name/gaia name will not affect the order of profiles. Bug: 1161528 Change-Id: Ieaa6374a056ed353c35568409bf1cae631431ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601744Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#840167}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101050600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zfJMXSQTHiC63-8t2rDhq9Yzbr3EuSa6iu8LG7TeCO8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/174201860,b/174513972,b/175281316 Tbr: media-app@grotations.appspotmail.com Change-Id: I0478f2068075a998ec3e8cc5f80dda6b33f21cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840166}
-
cfredric authored
Change-Id: I949eb8b83207b689b8d516391a86a5e0cbd03b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607555 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#840165}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..bc804095bcad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e2c52be940cab649d78be836fe95725f5ea7ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840164}
-
Yunke Zhou authored
is_user_creation_enabled needs to reset to false on cancel action. Bug: 1163033 Change-Id: I1b1bd5643bb2829ba2af9a84eaaec6f5fee70d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610089Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#840163}
-
Sahel Sharify authored
This reverts commit 075822e5. Reason for revert: SingleClientTypedUrlsSyncTest.TwoVisits is still flaky on Android after the fix landed in crbug.com/1159404 Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWgsSBUZsYWtlIk9jaHJvbWl1bUBhbmRyb2lkX3N5bmNfaW50ZWdyYXRpb25fdGVzdHNAU2luZ2xlQ2xpZW50VHlwZWRVcmxzU3luY1Rlc3QuVHdvVmlzaXRzDA Original change's description: > Revert "Disabled flaky SingleClientTypedUrlsSyncTest tests on Android" > > This reverts commit a23b68c3. > > Reason for revert: Tests are fixed in crbug.com/1159404 > > Original change's description: > > Disabled flaky SingleClientTypedUrlsSyncTest tests on Android > > > > This CL disabled the following tests on Android. > > > > * SingleClientTypedUrlsSyncTest.DeleteNonTyped > > * SingleClientTypedUrlsSyncTest.TwoVisits > > * SingleClientTypedUrlsSyncTest.DeleteTyped > > * SingleClientTypedUrlsSyncTest.Sanity > > > > TBR=mastiz@chromium.org > > > > Bug: 1159479 > > Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119 > > Reviewed-by: Salvador Guerrero <salg@google.com> > > Commit-Queue: Salvador Guerrero <salg@google.com> > > Cr-Commit-Position: refs/heads/master@{#837747} > > TBR=mastiz@chromium.org,salg@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I24bcdac6b58843f9ca7a1909f9720152d43845be > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1159479 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597744 > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Reviewed-by: Salvador Guerrero <salg@google.com> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838969} TBR=mastiz@chromium.org,salg@google.com,svenzheng@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1159479 Change-Id: I8c67dbd430b00805a5b6fac702aaf1c6400d151a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608930 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840162}
-
David Bokan authored
This feature has been enabled for many milestones and the flag has expired so remove both. Bug: 993629 Change-Id: I514c2bf842838b6708f3b17de4b3e905037922c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605880Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840161}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c6ff2556c8e6..74f1b6be4a91 2021-01-05 apodtele@gmail.com [builds/windows] Add SDF to VC2010 project. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5fd4c9aa1e3fcdb43ca6a27149b79b068e49e4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610466Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840160}
-
Elizabeth Popova authored
Some websites use a single field for an address with the expected address components listed in the label. Parsing of such field might fail if the name of the field is ambiguous. Added en, tr and ru regexes, which help to identify address line 1 or street address if the label contains street and at least one other address component, in any order. Bug: 1154727 Change-Id: I82d51ce285e3112ba554ae45332e2f710cdd6b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601370Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#840159}
-
Stephen McGruer authored
This is a manual version of an initial automated import, with the changes to tools/ reverted due to bug 1161210 Using wpt-import in Chromium 3b0fb4d8. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=foolip@google.com Bug: 1161210 No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I25233bc2843949971b5a280b2d9b35f48354482d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610595Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840158}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c120b02dbe14..200941c79751 2021-01-05 enga@chromium.org dawn_wire: Return early in callbacks after the server is destroyed 2021-01-05 enga@chromium.org Use a common helper for std::nothrow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1147416,chromium:1161943 Tbr: enga@google.com Change-Id: Ieca735f8f5f5ddf478ec35a7d8ad6570e8426dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610805Reviewed-by:
-
Evan Stade authored
Bug: 1160320 Change-Id: I49f31f5a6044024d0c36bea0eb4caf8251440210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598331 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840156}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee8ca5255488..88ee6a6370c5 2021-01-05 primiano@google.com UI: Fix GA code for Firefox If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0a7b627c11d166b4bf8cc8b4e7326928cb3d5a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610809Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/90b6613019de..1fe7f95b0ecc 2021-01-05 tvanderlippe@chromium.org Add eslint-plugin-lit-a11y to manage_node_deps 2021-01-05 changhaohan@chromium.org Move CSSAngleRegex to CSSAngleUtils and remove unnecessary file 2021-01-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-05 tvanderlippe@chromium.org [module.json extensions] console 2021-01-05 tvanderlippe@chromium.org [module.json extensions] Security If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126178,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If13d1ed3e870569954ac4e2018a63d376c667a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610807Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..bc804095bcad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id8772bc2b68d22db404320bd7bb38156d1f987b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609599Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609821402-6004c61fe423c51f3b6973d79ebe11baae0b7161.profdata to chrome-win32-master-1609837154-532701be902ffaddff8f4f0b9fc00b7f3e25a5e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8032eb3f5a2008bcca775961730a969536d449dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609881Reviewed-by:
-
Xi Han authored
Change-Id: Ie50161dc0c70440fb0fa420d484dbd7279dcd996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610067Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840151}
-
Vidhan authored
Change-Id: I9639a8de500fc3aa12e95a9fdade8dfdab1cd4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610098Reviewed-by:
-
Christoph Schwering authored
Looks like the tests fail due to an expired certificate. Tbr: mattm@chromium.org Bug: 1163045 Change-Id: I9f8d2fd656a8d0d4dc9fc75d6f18bd3230befa3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610099 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#840149}
-
Adithya Srinivasan authored
This reverts commit 2a2699ae. Reason for revert: Reverting https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159599 Original change's description: > Portals: Add regression test for console duplication > > Fix was landed in https://crrev.com/c/2159599. > > Bug: 1069487 > Change-Id: I88088ea07b76014e2cdb8c01ca0385f39470de10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388480 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804997} TBR=adithyas@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069487 Change-Id: I64c27b50153c607925e806540af7f12e1e177f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595249Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#840148}
-
Alex Ilin authored
Creating a new profile under the force signin enterprise policy should be allowed even if `signInProfileCreationFlowSupported` is false. Bug: 1156096 Change-Id: Ie722cbe6cd186d61ce6672fa717649ba90b15d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597552Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840147}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e17fd0f0e9bd..7adb896f3ba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC schwering@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: schwering@google.com Change-Id: If29be127a4b74eebc36c849524828e4b89e68ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606642Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609821402-1a521f5068c0d6782637fa5e747428dbb99c8286.profdata to chrome-mac-master-1609847937-8a3dc54f6d6b8008f835ccf1ed36d98d27bfc95a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If573644eae7f1f18b6c704882ac44eae48189806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610806Reviewed-by:
-
Alice Wang authored
This CL moves account picker MVC to signin.ui target Bug: 1150324 Change-Id: I5bf79154509797ed3464180a599f1788a0818a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597303 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#840144}
-
Robbie Gibson authored
The text zoom experiment is going on longer than expected, so the flags are still necessary. Fixed: 1159090, 1143362, 1143361 Change-Id: Ibd5f7aed10b774218ee1aebe7e010c7ece5cf2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598847Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609821402-4ffa353dbb439d0e8adf0e53cbe86a4c4b758321.profdata to chrome-linux-master-1609847937-af9ee8d51bc6a0aba5c9a2202bd2fb2e3011ef58.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie7e66a9e8bdd114b85648a002639fc056d54b3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609882Reviewed-by:
-
Xida Chen authored
I believe that these layout tests were fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2579949 Now there is only one test that needs investigation. Bug: 1150468 Change-Id: I4ea59de2068fa13890a4578450ec061c28b40cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605482Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840141}
-
Eric Willigers authored
NavigatorSocket is a ExecutionContextLifecycleStateObserver, and thus UpdateStateIfNeeded() should be called after a NavigatorSocket is constructed. Without this call, a check fails during NavigatorSocket destruction. We also add a test for closing a TCP socket. Bug: 905818 Change-Id: Ib272e0630699ab50b3863aed740e310735862ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610408Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840140}
-
Alice Wang authored
This CL cleans up the ProfileDataSource#getProfileDataMap usage, as this method is not needed when we migrate to OneGoogle source for profile data. Bug: 1136452 Change-Id: I5fe3c13f478786a4b92755eaa989756035a80965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602426 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840139}
-
Mirko Bonadei authored
The usrsctp library has a mechanism to enforce invariants (similar to CHECK or RTC_CHECK). In order to enable these checks, the macro INVARIANTS needs to be defined on all the usrsctp translation units. Maybe, this macro should be renamed into USRSCTP_ENABLE_CHECKS or at least into something with USRSCTP_ as prefix. This CL enables these runtime checks in debug builds and when the build is explicitly asking for them (dcheck_always_on=true). Bug: None Change-Id: Id63d78200ae2a762b86a4dc0c70d1a04e7d94350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600903Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#840138}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609821402-aadb54447d521b648e35bdaecfd53290f25cbd03.profdata to chrome-win64-master-1609837154-ace0713e1aa3951abed358afe7726a9f9d3a73a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I92ee2c4f37327c54f853fa89f0eaa31695f6f902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606001Reviewed-by:
-
Mihai Sardarescu authored
UrlKeyedAnonymizedDataCollectionEnabled is enabled by the sync consent UI when the user opts in to sync. The tests rules should mirror this behavior and only enable sync when the sync is enabled (and not when sign-in is enabled). This CL removes enabling URL-keyed anonymized data collection on sign-in. Bug: None. Change-Id: I7cf437874d97359d033e71d17122daf8d927c59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598903 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Bug: b/173104767 Change-Id: Id500736a6c130a6f81368080980d1dffe9a1bf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610096 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840135}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bc804095bcad..ee8ca5255488 2021-01-05 primiano@google.com Merge "Update CHANGELOG for v11.0" 2021-01-05 treehugger-gerrit@google.com Merge "Minimal edits to heap_profile.h comments" 2021-01-05 fmayer@google.com Merge "Enable new clang-tidy checks & resolve for src/profiling." 2021-01-05 fmayer@google.com Merge changes I174d77b5,I114d9aa1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia68950e961fa95d0944e44cc852cd3686857ced7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609876Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53386e30..3abec731 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65faeedf3db0b60791cf2aba807f1f4310f3cee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610470Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840133}
-
arthursonzogni authored
Make sure sandbox flags are properly inherited when the initiator of the navigation isn't the parent. This checks both sandbox flags defined by the frame and by the HTTP response. Bug: 1041376 Change-Id: I3c0b808ef9ec3ebefde40ec7609a36a1f5edaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607790Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840132}
-
dpapad authored
This is necessary so that up/down arrow keys trigger scrolling of the PDF document after exiting Presentation mode. Bug: 1148478 Change-Id: Ie64d1e3deb5763a43ef4dc7f094065992b5eb4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597770 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a46fbf8fc541..90b6613019de 2021-01-05 jacktfranklin@chromium.org Reland "Add header context menu to data grid" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150793 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia2900946e70b59db31b33a14691368911cb41a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606002Reviewed-by:
-
