GitLab

An external eglcontext may be current on android webview. GetCurrent() is better than eglGetCurrentContext() here.

BUG=

Review-Url: https://codereview.chromium.org/2276873002
Cr-Commit-Position: refs/heads/master@{#414297}

This adds a trace event that is logged every time the provisional
FirstMeaningfulPaint timestamp is updated.

Trace-based implementations can find FirstMeaningfulPaint for the page
load by looking for the last event in the trace.

BUG=638124
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2276573003
Cr-Commit-Position: refs/heads/master@{#414296}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d09641f4..b4f9789f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2274363002
Cr-Commit-Position: refs/heads/master@{#414295}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/355a52109ec78c1bda63274fadaa2f83462b604d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/38954ea2aea645d40d933ec08fa9300978745851 Make syzygy recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/e10345ca9ae54bb82c86679d2e107dabb92a04bc Make v8 recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/1841f028ff591483facb7ada955e1e6eb942f343 Make dart recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/4fe7d03aee971b7daadc70b69dcf0f43eb1a59a5 Add stip@ to chromium.py OWNERS. (stip@chromium.org)
  https://crrev.com/32a901e0ee458a3b063f995ab461d38096ba80fd Make iOS recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/6ae64c302a5ae3bfc0df6d520b4945dfbd05c9ec Make android recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/6679485ce287924084b369b20fab59c1f6ef8122 Enable swarming for iOS try bots (smut@google.com)
depot_tools:
  https://crrev.com/f14eaff8148de420c63c87bd67678bf86837641a Remove --base_url from git cl and upload.py (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=598405,638750,640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2274173004
Cr-Commit-Position: refs/heads/master@{#414294}

BUG=

Review-Url: https://codereview.chromium.org/2275163002
Cr-Commit-Position: refs/heads/master@{#414293}

We set compositor view background to white while there are no
frames and onSwapBufferCompleted swap it back to null. On N
this creates a black flash on some cold starts where there is
still a frame that is drawn before the frame is actually completed.

BUG=640758

Review-Url: https://codereview.chromium.org/2271393003
Cr-Commit-Position: refs/heads/master@{#414292}

External Clear Key should be an external "Clear Key" key system which
behaves the same as "Clear Key" but is hosted externally (e.g. in a
separate process). It could support decrypt-and-decode by incorporating
codecs, or only support decrypt-only (same as default Clear Key
implementation in Chromium).

This will help us enable External Clear Key tests on multiple platforms,
e.g. on Android.

To do this, we need to move non-standard "Clear Key" features out of
the default External Clear Key test. This CL moves "renewal" test to a
new key system name: org.chromium.externalclearkey.renewal.

BUG=581893
TEST=This CL splits a curent test into two tests.

Review-Url: https://codereview.chromium.org/2267283002
Cr-Commit-Position: refs/heads/master@{#414291}

This is another step toward eliminating ash::Shelf.

* Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
* Remove dead code (especially shelf_navigator.*)
* Make icon activation functions static

BUG=615502
TEST=ash_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2274333002
Cr-Commit-Position: refs/heads/master@{#414290}

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2230123002
Cr-Commit-Position: refs/heads/master@{#414289}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2268993003
Cr-Commit-Position: refs/heads/master@{#414288}

Cr-Commit-Position: refs/heads/master@{#414287}

There are several comments and FIXMEs about concern about NULL
unescaping.

The FIXMEs have been there since the commit for upstreaming
KURLGoogle.cpp which is
http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708.

But the commit
http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already
removed the special care for NULL character. The internal bug b/1350291
was just mentioning WebKit bug 20559.

We still have a warning comment about brettw@'s concern in KURL.h, so,
clean up the others.

As a bonus, this CL adds a test to check that the method decodes UTF-8.

R=brettw
BUG=none

Review-Url: https://codereview.chromium.org/2270373002
Cr-Commit-Position: refs/heads/master@{#414286}

Previously VideoRendererImpl waited for the VideoFrameStream::Reset() to
complete before invalidating its frame callback weak pointers, which
meant that it could receive frames that it didn't want between Flush()
and OnVideoFrameStreamResetDone(). For simplicity, now the weak pointers
are invalidated at the same time that Reset() is called, so it's
guaranteed that no frames will be received after Flush().

Also included in this change is reordering the deletion of the video
frame queue and resetting of the VideoFrameStream to save VDAs doing
wasted work.

BUG=640800

Review-Url: https://codereview.chromium.org/2273033003
Cr-Commit-Position: refs/heads/master@{#414285}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- management
- metrics_private
- system_private
- networking_private
- power

BUG=634140

Review-Url: https://codereview.chromium.org/2261313002
Cr-Commit-Position: refs/heads/master@{#414284}

It is not only useless in the latest version, but is even harmful
for some advanced apps that take the liberty of splitting these
two events.

This change itself should not change any observable behavior yet,
but will be necessary to enable coming Android-side change to
make this split effective.

BUG=640816
BUG=b/31001453
TEST=ArcImeServiceTest
TEST=Tested manually with some ARC apps (Settings, PlayStore)

Review-Url: https://codereview.chromium.org/2280503002
Cr-Commit-Position: refs/heads/master@{#414283}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5bcf2c70f4dd..06af1137071d

$ git log 5bcf2c70f..06af11370 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 benjhayden Fix composition-span colors.
2016-08-24 benjhayden Modernize RelatedEventSet to use ES6 classes.
2016-08-24 ssid TracingMetric: Calculate average MemoryDumpProvider overhead over OnMemoryDump invocations
2016-08-24 benjhayden Migrate metric_registry_test from ScalarNumeric
2016-08-24 alexandermont Overhaul unit conversions in trace viewer.
2016-08-24 ssid MemoryMetric: add total and peak resident set size values
2016-08-24 oysteine Trace processor: Fixes after perf_insights got nuked

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2275123003
Cr-Commit-Position: refs/heads/master@{#414282}

Fullscreen overlays have been enabled on minnie.
Unfortunately there are some issues in HardwareDisplayPlaneManager::
AssignOverlayPlanes with RGBX buffers.

This patch disables the overlay optimization for those buffers
while we work on a fix.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2278803003
Cr-Commit-Position: refs/heads/master@{#414281}

https://codereview.chromium.org/2241213002/ split SCT_STATUS_INVALID
into two new enum values to record the different reasons that an SCT
might be invalid. However, we didn't realize that SCT_STATUS_INVALID
might still be present in disk cache entries, resulting in renderer
kills when the browser tries to deserialize SSLStatus objects containing
these cached SCT_STATUS_INVALID values.

This CL brings back SCT_STATUS_INVALID and documents it as deprecated,
but still existent for the sake of cache entries.

BUG=640296

Review-Url: https://codereview.chromium.org/2277653002
Cr-Commit-Position: refs/heads/master@{#414280}

The main trick here is to get hand-written tests to trampoline through
the _RunGpuTest harness, which is where test expectations are
implemented.

This is done by adopting a convention that the "real" test, like
"_GPUProcessCrashesExactlyOnce", is prefixed with an underscore. This
is implemented in self-contained fashion in
ContextLostIntegrationTest.GenerateGpuTests. If necessary, this will
be generalized further into a base class.

The waterfalls will be switched to run the new version of the test in
a follow-on CL.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2271543002
Cr-Commit-Position: refs/heads/master@{#414279}

This patch converts "editing/execCommand/remove-list-item-1.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2276563003
Cr-Commit-Position: refs/heads/master@{#414278}

Current Arc package sync implemetation does not support stop sync and re-enable
sync without rebooting. So user control of arc package sync is not achievable.
This patch re-implement sync stop and enable proper user control of arc package
sync using apps checkbox in advanced sync settings.

BUG= http://b/31034323, http://b/30640291, http://b/30980543
TEST=Pass sync integration test.
TEST=Manual test1. Turn on apps sync settings. Enable Arc and install package.
Nuke Arc then enable arc. Package restored.
TEST=Manual test2. Turn on apps sync settings. Enable Arc and install package.
Turn off apps sync settings and then nuke Arc. Then enable arc. Package not
restored. Then turn on apps sync settings. Package restored.

Review-Url: https://codereview.chromium.org/2277593002
Cr-Commit-Position: refs/heads/master@{#414277}

Rather than greying out externally deleted items, delete
the files and remove the entry from history.

BUG=616324

Review-Url: https://codereview.chromium.org/2271913002
Cr-Commit-Position: refs/heads/master@{#414276}

This is completely safe because this recipe isn't
used for anything.

TBR=iannucci@chromium.org
BUG=640251

Review URL: https://codereview.chromium.org/2276033004 .

Cr-Commit-Position: refs/heads/master@{#414275}

Currently various StreamParsers return output buffers via 3 separate
collections: a queue for audio, a queue for video and a map of queues
keyed by the track id for text tracks. Now that all stream parsers
properly assign track id to each buffer we can unify all those 3
collections into a single BufferQueueMap keyed by track ids.

BUG=341581

Review-Url: https://codereview.chromium.org/2254093002
Cr-Commit-Position: refs/heads/master@{#414274}

This CL fixes an issue where the overlay scrollbar would allow Chrome to
scroll to the right to show the space covered by the vertical scrollbar.
This has been fixed by reverting to overflow:auto.

BUG=638527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2273523002
Cr-Commit-Position: refs/heads/master@{#414273}

Has the expected visual treatment, but doesn't currently do anything functionally.
Also no one is currently launching the infobar.

BUG=639497

Review-Url: https://codereview.chromium.org/2267463002
Cr-Commit-Position: refs/heads/master@{#414272}

BUG=639545

Review-Url: https://codereview.chromium.org/2268863003
Cr-Commit-Position: refs/heads/master@{#414271}

R=dschuyler@chromium.org
BUG=637068

Review-Url: https://codereview.chromium.org/2265553003
Cr-Commit-Position: refs/heads/master@{#414270}

WebUI URLRequest source data is (on desktop) backed by a memory-mapped
file. Copying that data in CompleteRead can trigger jankiness due to
potential file IO caused by the read.

This CL moves the memcpy on the file thread. It is also a re-land of
https://codereview.chromium.org/2158123003/ with minor changes to fix a
crash.

R=dbeam@chromium.org, mmenke@chromium.org, dproy@chromium.org
BUG=455423

Review-Url: https://codereview.chromium.org/2268653002
Cr-Commit-Position: refs/heads/master@{#414269}

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.

Review-Url: https://codereview.chromium.org/2277723003
Cr-Commit-Position: refs/heads/master@{#414268}

During recent reviews there have been several nits reported. This
change fixes a few of them.

BUG=442566
TEST=updated tests pass

Review-Url: https://codereview.chromium.org/2169713002
Cr-Commit-Position: refs/heads/master@{#414267}

This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition|
objects since its call site is only one for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2278463002
Cr-Commit-Position: refs/heads/master@{#414266}

This isn't implemented yet, but will be provide the Mojo service that will provide blink an access point to the BackgroundBudgetService.

This also adds a mock and a layout test to check the mojo service.

BUG=617971

Review-Url: https://codereview.chromium.org/2231873002
Cr-Commit-Position: refs/heads/master@{#414265}

Mainly for proguard and build rules changes.

Review-Url: https://codereview.chromium.org/2271343002
Cr-Commit-Position: refs/heads/master@{#414264}

Continuation from https://codereview.chromium.org/2132343002/

In HTML imports, custom elements should be created or
upgraded.

BUG=594918

Review-Url: https://codereview.chromium.org/2242743002
Cr-Commit-Position: refs/heads/master@{#414263}

This patch converts "editing/execCommand/hilitecolor.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2270693007
Cr-Commit-Position: refs/heads/master@{#414262}

Also changes NOTIMPLEMENTED policies a bit.

BUG=640773
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2269383004
Cr-Commit-Position: refs/heads/master@{#414261}

This CL removes DispatchToMethod usage in ObserverListThreadSafe, which
is the only user of DispatchToMethod that depends on base::internal::Unwrap.

Review-Url: https://codereview.chromium.org/2268283002
Cr-Commit-Position: refs/heads/master@{#414260}

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions.

BUG=638093

Review-Url: https://codereview.chromium.org/2259723003
Cr-Commit-Position: refs/heads/master@{#414259}

BUG=610521

Review-Url: https://codereview.chromium.org/2277663003
Cr-Commit-Position: refs/heads/master@{#414258}