- 05 Aug, 2020 40 commits
-
-
Mustafa Emre Acer authored
This CL enables SafeBrowsingDelayedWarnings feature in tests by default. It also disables the feature on a few tests on Android. The reason for this is that the feature has good test coverage on desktop, and writing new tests for Android will be a significant time investment. Bug: 1077426 Change-Id: Ia5b04dc74893d513a13a72bc92ad1f1537b6691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327550Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795071}
-
Nate Fischer authored
This puts the flag UI's warning text into the ListView so it can scroll off screen as the user scrolls down the list of flags. This adds some complexity because the ListView now supports two different types of layouts. This swaps the order of the warning text and the "reset all" button. This is in order to pin the "reset all" button to the top of the Fragment. Fixed: 1059881 Test: Manual - verify the warning text scrolls as expected Change-Id: Id7afd2b256051d6d7bf5cee18c73592021444194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330042 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#795070}
-
Devlin authored
This reverts commit 4702a75d. Reason for revert: Suspected for causing MSAN failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20123? Sample failure: ==7998==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5562f862015e in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:22)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:932:5 #1 0x5562f862015e in base::ObserverList<arc::ArcSessionManagerObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(arc::ArcSessionManagerObserver const*) ./../../base/observer_list.h:283:9 #2 0x5562f9398e52 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::RemoveAll() ./../../base/scoped_observer.h:67:7 #3 0x5562f9396de0 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::~ScopedObserver() ./../../base/scoped_observer.h:48:5 #4 0x5562f9396d2a in policy::LockToSingleUserManager::~LockToSingleUserManager() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager.cc:79:1 #5 0x5562efbc5122 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #6 0x5562efbc5122 in std::__1::unique_ptr<policy::LockToSingleUserManager, std::__1::default_delete<policy::LockToSingleUserManager> >::reset(policy::LockToSingleUserManager*) ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #7 0x5562efbc46de in policy::LockToSingleUserManagerTest::TearDown() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager_unittest.cc:75:34 #8 0x5562f0ae795a in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5562f0ae9cac in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 Original change's description: > ARCVM SharePath() to use correct seneschal port > > During the processing of ARCVM SharePath() request, it was retrieving > the seneschal port via some Crostini functions. This was incorrect and > would trigger a Crostini restart. This change will properly fix this > by retrieving the correct seneschal port from ArcSessionManagerVmObserver. > > BUG=b:147618164 > TEST=tast run <DUT> arc.Drivefs.vm > > Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 > Commit-Queue: Cherie Cheung <cherieccy@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794973} TBR=hashimoto@chromium.org,yusukes@chromium.org,vasilii@chromium.org,hidehiko@chromium.org,treib@chromium.org,joelhockey@chromium.org,cherieccy@chromium.org Change-Id: I4e35fd26a70f3f74588fb77f1c9e2a210bb19371 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:147618164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339579Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795069}
-
Bella Bah authored
This generator uses grouping.xml and annotations.tsv to generate a Google Docs sheet for sys-admin clients. Refer to the README for additional guidance. Bug: 1107860 Change-Id: Ia9350fdc049e0e4b0ac2830968d9e60309bc3c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283487 Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#795068}
-
John Delaney authored
Reland of https://crrev.com/c/2314843 Change was reverte due to browser test flakes on Linux Asan bots on https://crrev.com/c/2326796 The browsertest flakes seem to have been the result of a race condition caused by logging UseCounters while navigating the main frame cross origin. In these cases, browser-side PLM code received the feature usage updates after the main frame had already begun navigating, causing us to ignore the update. This is unexpected, and is summarized on https://crbug.com/1111524 This change fixes the issue by using an impression tag that targets a new window, so that we can guarantee the feature is received prior to flushing metrics for the page with the impression. TBR=japhet@chromium.org Bug: 1109079 Change-Id: Ie80a9156fb9e90d9891b02e0bdc44dc6cd0fe266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330300Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795067}
-
Daniel McArdle authored
net_backoff_entry_serializer_fuzzer found an input that contains a very large failure_count. BackoffEntrySerializer::DeserializeFromValue loops |failure_count| times to initialize the BackoffEntry. In the worst case, we could wind up looping MAX_INT times. This CL modifies BackoffEntrySerializer::DeserializeFromValue to cap the failure_count to a maximum value. Bug: 1112132 Change-Id: Ifb7b6bf02161348b6f237b23b016f9fb0fee7fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336853 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#795066}
-
Daniel Clark authored
Through either a mistake of my own or an issue with the tool, after running rebaseline-cl for https://chromium-review.googlesource.com/c/chromium/src/+/2337099 I ended up with an image baseline for mac-retina that matches the expectation prior to that change. So, the test on that platform is still failing. This test didn't previously require a separate mac-retina baseline, so I'll just delete it to fix the issue. Bug: 1112111 Change-Id: I461cc2839451b9d0385d4732aca39f4ca8b80f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339377Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795065}
-
Peter Kotwicz authored
https://chromium-review.googlesource.com/c/chromium/src/+/2284205 added usage of ObservableSupplierImpl in CompositorViewHolder. This causes threading issues with the off-UI-thread UI inflation done by WebAPKs. This CL temporarily disables the WebAPK off-UI-thread inflation as a simple fix which can be merged back to M85 BUG=1102650 Change-Id: Id6141567e026eae095ea47ea04d803c48b2eadb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336282Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
David Grogan authored
These don't seem to flake anymore https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=external%2Fwpt%2Fcss%2Fcss-flexbox%2Fflex-minimum-width-flex-items-001.xht%2C%20external%2Fwpt%2Fcss%2Fcss-flexbox%2Fflexbox_flex-natural-mixed-basis-auto.html%2C%20external%2Fwpt%2Fcss%2Fcss-flexbox%2Falign-items-004.htm Bug: 715718 Change-Id: Id5894cef39174667dc094536fc0749472fbb3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336539 Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795063}
-
Peter Wen authored
Fix lint errors/warnings for all downstream files. This paves the way for upstream and downstream monochrome bundle targets to generate the same baseline.xml file. Add support to ignore @VisibleForTesting(otherwise = ...) annotations in presubmit and fix a few presubmit errors along the way. Tbr: No functional changes in components/ and net/ Bug: 1111363 Change-Id: Ia3752c9a775a5ad0dedc10d415376c264d2575fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330332 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#795062}
-
Avi Drissman authored
GetFontWeightFromNSFont() uses a table of CoreText float values to look up corresponding Font::Weight values. The testing of the float values was broken; fix it. Bug: 1112998 Change-Id: Ia3346c2964e3c74cb855b701227a662aa281de8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337734Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795061}
-
Carlos IL authored
This fixes the URL elision and animation logic when the UI is RTL. This does not yet address RTL URLs, just fixes the logic when Chrome itself is in RTL mode, but only works with LTR URLs. Gradient mask is not currently functional if UI is RTL, so this disables it in that case. Bug: 1101472 Change-Id: Ib89ebb6eb21882aa83ec923ec1720f25468bc6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333293 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#795060}
-
Omer Katz authored
1) Traces show that it can take a relatively long time before Oilpan starts flushing v8 references (e.g. ~10 steps spent just on the bailout worklist). This CL moves v8 references flushing before processing of the bailout worklist. 2) Traces also show that a shorter duration for the first marking step can suffice. Bug: 986235 Change-Id: If7bad026e91f1fdf1899035bda049834e7bffab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339356 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#795059}
-
Egor Pasko authored
These pollute 'git status' the most. The newly ignored directories are pulled as external repos via .gclient, the toplevel .git should not know about them. Bug: None Change-Id: Icfae8489f043f7c6247183cdf3677932b7d30ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327673 Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795058}
-
John Lee authored
Bug: 1084620 Change-Id: Ie5d96aa87c1e80c6900687105ea3bfd674af0df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335753 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795057}
-
Elly Fong-Jones authored
This change removes the legacy close behavior of DialogDelegate, which was as follows: if a dialog was closed without either accepting or cancelling, if the dialog had only an ok button, the Accept() method would be called; otherwise, the Cancel() method would be called. This behavior was only depended on by a single dialog - the collected cookies dialog - so this change migrates the collected cookies dialog over to the new callback system. This change will allow for introducing a useful invariant: that the DialogDelegate::Close() callback always runs after WidgetObservers observe that the dialog has begun to close. Bug: 1085949 Change-Id: I214140a9cab687be4c36fc3961089d231f3cf1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337342 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795056}
-
Siye Liu authored
Composition is started and ended in same edit session during emoji insertion. Selection should also be set during |SetCompositionText| in the above scenario so that |TextInputClient| such as |TextField| can have updated cached selection. Bug: 1111523 Change-Id: Ie2b1dc1365a1a778ea9cc5367f82bd2086cc0b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331291Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795055}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596606694-35c6f8535b14ce15b4839555c5550c892d549ecc.profdata to chrome-win64-master-1596628771-86348d2a61736525bb253851ce1433e67dea13ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I1a61c24d74eda3e493a7f8c1c0cb7929b9dd4f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795054}
-
Takuto Ikuta authored
This is revert of https://crrev.com/c/2337833 , but remove unused import too. Bug: 1112996 Change-Id: Id0370a6e321b861a27e6415702934eb5f24d1ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336323 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#795053}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1JFK-SPk-TANPt1g1i8wpIJc8nPsu8wzT/view?usp=sharing Bug: 1063856 Change-Id: Ibe3f9c5086384dc7187fdd43d5eaea952e639b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332709Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#795052}
-
Ben Mason authored
This reverts commit 54c22ea1. Reason for revert: IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE_PASSWORD_CHANGE.png.sha1 needs to be a sha1 not a PNG file Original change's description: > [Autofill Assistant] Add custom onboarding informational text for password change intents > > Design mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_56 > > Bug: 1110309 > > Change-Id: Id0e4316e71d57b80271c0a596cd4de505dc1e54b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332164 > Reviewed-by: Marian Fechete <marianfe@google.com> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Commit-Queue: Milica Selakovic <selakovic@google.com> > Cr-Commit-Position: refs/heads/master@{#794544} TBR=kolos@chromium.org,arbesser@google.com,marianfe@google.com,selakovic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110309 Change-Id: Iab189bf597780556cb4e49984da57a7058e4173b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339596Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#795051}
-
Haiyang Pan authored
According to estimation, 2000 bots are needed to support full CQ traffic. Currently there are 200 bots in the fleet pool. So it should be suffcient to support 2% traffic. Bug: 997376 Change-Id: Ic7976aeb95646f8b92e2f66f5f5c4d41461ce87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333822Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#795050}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596621162-a1892525031f11bea0534e52833cec57e313f57e.profdata to chrome-win32-master-1596628771-e32af535197a262fe54680b0a1a803a0983bdd0a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4b4bf7c746de9d20b8f396cc0c9dfe145acef415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339574Reviewed-by:
-
Adlai Holler authored
This unblocks removing the old API. Bug: skia:104662 Change-Id: I6abe863ee1d74dddef9cfaa6e61c4ee3602d7d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335640 Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795048}
-
Nate Fischer authored
No change to logic. This adjusts padding and margins for consistency with the crash UI (most stuff should be 8dp now). This also splits the warning message into its own layout file. This will be necessary for a follow-up change to move the warning text into the ListView so it can be scrolled off screen. Bug: 1111172 Test: Manual Change-Id: I8bf87c633ec6fc8cc0aa85f581e9825c6a9dff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330291Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce4c3060..1e0d126c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icae20850a058c13899b26477adb77496542c93c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339215Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795046}
-
David Schinazi authored
This information was incorrectly missing. R=nharper@chromium.org Bug: 1112925 Change-Id: I17643ebaeee02eb9d5e63f0630bce66939a3e536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337542 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795045}
-
Liquan (Max) Gu authored
Change: * Move createShippingSection and rename it createShippingSectionForPaymentRequestUI to be explicit that it's for PR UI. * Move PaymentAppComparator into the ui package because it only serves for the ui purpose. Bug: 1102522 Change-Id: Ibde545ce1a6447abf7240d9bdbee32496e26bb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331743Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795044}
-
Hans Wennborg authored
Bug: 1112506 Change-Id: Ice8b1deeabb449c8cedf0f59f8688d9ac0b4a073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339455 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Roman Sorokin authored
It's been enabled for a long time Bug: 935613 Change-Id: I5aef1f2f797859fa855756276139a0d94bb82397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339336 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2052b3bd9a5..011b0075cd53 2020-08-05 mathias@chromium.org Adopt new CheckAuthorizedAuthor parameter name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6aecfef5596c3208d10f4bc31f692c1801acf92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339436Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f68444a445f7..9a43f48ed4cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia498a0d6fb1daa5824b737ae7b132722e6212e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339206Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/23c5b63d1c68..9a43f48ed4cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I05fc53a24ff13997f3ceb94c8be5e25b19c6448a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339208Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8b3601324fde..f9f6adb625c4 2020-08-05 apodtele@gmail.com [truetype] Retain OVERLAP_SIMPLE and OVERLAP_COMPOUND. 2020-08-05 apodtele@gmail.com * src/truetype/ttgload.c (TT_Load_Glyph): More tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I444d5bb5b85b05e6df710eae878987eac42018d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339196 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#795038}
-
Daniel Murphy authored
The new error pathway populated the manifest pointer as a nullptr. The code can assume that this is never a nullptr, so instead just create a dummy empty manifest on the stack and send a pointer to that. Bug: 1110771 Change-Id: If358b4d7251b0a6a858cf91e511dda60ba02ee89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327277Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#795037}
-
Aaron Leventhal authored
Newer screen readers such as JAWS 2021 use selection events on the Omnibox suggestions rather than value changes from the Omnibox. This change improves the accessible names of the suggestions. - Include additional messaging, e.g. tab switch button is available - Do not include "n of m" positional info in the name, since this is now made available semantically via the accessibility API. Also adds more tests to ensure that important pieces of text are included in the Omnibox friendly values and the suggestion names. AX-Relnotes: friendlier Omnibox announcements with JAWS 2021 Bug: 1109780 Change-Id: Ie0f5073df0114e5ceed105e9e87e53f79264f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337400 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is necessary to allow DFMs to call native code correctly. This will be helpful in experimenting with making WebLayer a DFM. Bug: 1105096 Change-Id: Ibd8e3b25f9a18e8dc26337cd3f2a4b550066c19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337288 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#795035}
-
Adam Langley authored
This change adds desktop-side, disabled-by-default, preliminary support for communicating with phones over USB so that they can act as a security key. This requires phone-side changes too that are forthcoming. Android supports an “accessory” mode[1] that allows USB communication with apps on the phone. This involves sending vendor commands to the device to request that it switch into this mode and then watching the USB bus for the device to reappear in the new configuration. Once that's complete, data can be exchanged. There's no good way, however, of knowing which USB devices are phones. And it seems unwise to blast vendor commands at every attached USB device each time we start a WebAuthn transaction. Therefore this is only attempted for devices that are connected during the transaction. We do, however, remember which accessory devices we previously configured and can use them immediately if still connected. In the future, the UI could plausibly allow the user to select the device from a list rather than connect it. Although I'm unsure whether that's actually useful. [1] https://source.android.com/devices/accessories/aoa BUG=1002262 Change-Id: Ia58632d89c83a60559b59146d69bd2638a597f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310193 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#795034}
-
Dan Harrington authored
Bug: 1111806 Change-Id: I7662de6b7117a5434417a7b430b54bc042817175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333995Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#795033}
-
Josh Nohle authored
Bug: b/157685298 Change-Id: I502eb7923a4620e0dfbc4edde178e4cc3f2d043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332869 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795032}
-
