GitLab

Found during testing:
- scale(sx) should be the same as scale(sx, sx)
spec here: https://drafts.csswg.org/css-transforms/#valdef-transform-scale

Bug: 545318
Change-Id: Icfb150ecc83e55b142d6d6ea21e00caf28b117ad
Reviewed-on: https://chromium-review.googlesource.com/554634
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487439}

ACTION_VIEW intents should contain a Uri as data, but in some cases they
might not (explicit intent incorrectly set, for instance). Don't crash
in this case.

For instance,
adb shell am start -a android.intent.action.VIEW -n org.chromium.chrome/com.google.android.apps.chrome.Main
would crash, this fixes it.

BUG=742294

Change-Id: Ic44d7cb656d193449363ef63506e0d9852a6e782
Reviewed-on: https://chromium-review.googlesource.com/569964
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487438}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c2021812..b7509b51

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ief104a8ee32420a11766c8f121e3e4e422b0b8a7
Reviewed-on: https://chromium-review.googlesource.com/575688Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487437}

This CL migrates ArcIntentHelperBridge.

BUG=672829
TEST=Ran try. Ran on DUT.

Change-Id: Ic7bba1bdd95dc5c41c7789d4081f9abb3fc9ad12
Reviewed-on: https://chromium-review.googlesource.com/571384Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487436}

This CL removes all contextual search code from the BVC. Almost all of
the logic contained in the BVC is ported to a new wrangler class.

Any object wishing to use contextual search (without further refactoring)
will need to furnish a provider object as defined in the wrangler class
header, which at this stage just encapsulates all of the interfaces into
the BVC that the contextual search code used to use.

Bug: 
Change-Id: I23ffe787b26ead87c9c50e4730851f6b992c95a4
Reviewed-on: https://chromium-review.googlesource.com/574534
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487435}

This CL removes -resetAllWebviews, which no longer has any call sites.

This CL also removes -ensureViewCreated, which is just our implementation
of [UIViewController loadViewIfNeeded], which has been available since
iOS9. 

Bug: 
Change-Id: Ia2adab95a7a5726114a7e81ce784aaa4e40aa676
Reviewed-on: https://chromium-review.googlesource.com/570019
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487434}

TBR=nednguyen@google.com

Bug: 742475
Change-Id: I5c4e2e05c45c835e9163cfd5f2e47ee958298064
Reviewed-on: https://chromium-review.googlesource.com/574916Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487433}

Bug: 594639
Change-Id: Iabb2f3780d21c0f896073e6cad6178deced61e83
Reviewed-on: https://chromium-review.googlesource.com/575797Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487432}

In the current state we skip preconnect even if prefetch is disabled because the
check is inside MaybeAddPrefetch() method. We have prefetch data even if
prefetching is disabled because LoadingPredictor uses common LEARNING mode.

Bug: 699080
Change-Id: I48aef431bf0771e5c7e74b0b0dd164b77aab493c
Reviewed-on: https://chromium-review.googlesource.com/570421Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487431}

https://chromium-review.googlesource.com/c/566806 showed that the
WebRtcRtpBrowserTest.AddAndRemoveTracks* tests would reliably crash
if the garbage collector was invoked between addTrack and getSenders.
Tracks that were added using addTrack would have their track adapters
(glue between blink and webrtc) kept alive only by the blink layer
sender holding on to a reference, since these were not kept alive by
any "local streams" holding a reference.

The blink::RTCPeerConnection now holds a strong reference to senders
and receivers to prevent GC while in-use, with TODOs to remove ones
no longer used when addStream/removeStream is implemented using
addTrack/removeTrack.

Furthermore the content::RTCPeerConnectionHandler holds on to the
content layer representation of senders so that their associated set
of streams are not forgotten between addTrack and getSenders.

Having the handler keep track of senders is good practice, this gets
rid of the assumption that blink layer senders have to be kept alive.
A TODO was added to do the same for receivers (not yet required because
blink layer receivers are kept alive).

With this change, the AddAndRemoveTracks* tests pass and are
re-enabled.

Bug: 740650
Change-Id: Iec3a39a994bef31904f2969d791125867ec1e398
Reviewed-on: https://chromium-review.googlesource.com/567184Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487430}

Conflict between crrev.com/c/559001 and crrev.com/c/559101

Bug: 661794
Change-Id: Ia7601ba8f334adad8a33fb1cbd744fb050382856
Reviewed-on: https://chromium-review.googlesource.com/574236
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487429}

This CL makes several changes to AuthException and its users:
1. Add second constructor that accepts message that can be used to report info
   about context that caused auth failure.
2. Use newly-added constructor to report authTokenScope that caused
   GoogleAuthException.
3. Add AuthException.TRANSIENT and AuthException.NONTRANSIENT constants to use
   in AuthException constructors.

Bug: 741883
Change-Id: I6448ef2e4ecc66a885a0d3dc21f8665f678689ca
Reviewed-on: https://chromium-review.googlesource.com/574541Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487428}

The new images have the proper size for display on the NTP. This should
make them look a bit less blurry.

Fun fact: These images were last updated in 2011 [1]. Somewhat
surprisingly, the web pages haven't changed much since then.

Before: https://screenshot.googleplex.com/Wn7Sb6UyjdN
After:  https://screenshot.googleplex.com/ef7zJfGcE0Q

optimize-png-files.sh was run on the new images.

[1] https://codereview.chromium.org/8820002

Bug: 734038
Change-Id: Id9c9fb5b771fe2df973830e7b6392a555dfcda5c
Reviewed-on: https://chromium-review.googlesource.com/574230Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487427}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/beaccf9..2048bc4

$ git log beaccf9..2048bc4 --date=short --no-merges --format=%ad %ae %s
2017-07-17 zstein@webrtc.org Remove default implementation of PeerConnectionInterface::SetBitrate.
2017-07-17 steveanton@webrtc.org Android bindings for ice_regather_interval_range RTCConfiguration option
2017-07-13 zijiehe@google.com Expose IsCurrentSessionSupported() from ScreenCapturerWinDirectx
2017-07-17 minyue@webrtc.org Revert "Prefer external video codecs over internal in SDP"
2017-07-17 tschumim@webrtc.org Don't run NoBandwidthDropAfterDtx test on andriod because it's flaky.
2017-07-17 tschumim@webrtc.org Reimplemeted "Test and fix for huge bwe drop after alr state"
2017-07-16 eladalon@webrtc.org nit: Avoid pointer-to-unique_ptr in RtcEventLogImpl
2017-07-15 tommi@webrtc.org Fix incorrect DCHECK in generic_decoder.cc. When ownership is not external, the decoder pointer should be valid.
2017-07-14 jtteh@webrtc.org Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ )
2017-07-14 steveanton@webrtc.org Reinstate "iOS - Add iceRegatherIntervalRange."
2017-07-14 steveanton@webrtc.org Reinstate "Add additional check when setting RTCConfiguration"
2017-07-14 steveanton@webrtc.org Reinstate "API for periodically regathering ICE candidates"
2017-07-14 mbonadei@webrtc.org Disabling test on iOS64 debug bot
2017-07-14 tommi@webrtc.org Reland of Make the default ctor of rtc::Thread, protected
2017-07-14 zstein@webrtc.org SignalPacketReceived should pass packet as a pointer instead of a non-const reference.
2017-07-14 zstein@webrtc.org Adding stats that can be used to compute output audio levels as described here https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-totalaudioenergy.
2017-07-14 magjed@webrtc.org Prefer external video codecs over internal in SDP

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: Ic042ed27f7e9d91532f3cbf2b979b76f1b853448
Reviewed-on: https://chromium-review.googlesource.com/575987Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487426}

This CL migrates ArcBootPhaseMonitorBridge.

BUG=672829
TEST=Ran try.

Change-Id: I2a6988e5867092de9b8a981a253f7b1993a9eebc
Reviewed-on: https://chromium-review.googlesource.com/575287Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487425}

This is a replacement for CaptureThumbnailOnLoadFinished, which was
reverted due to perf regressions (see
https://chromium-review.googlesource.com/c/570218/).

Bug: 718413
Change-Id: I399507f5791b5ca1fc7779331b82bb9782a27268
Reviewed-on: https://chromium-review.googlesource.com/571223Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487424}

Bug: 670539
Change-Id: I74b063b3c25e9917194206b3754310d9cdf3d311
Reviewed-on: https://chromium-review.googlesource.com/575740Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#487423}

This CL migrates GpuArcVideoServiceHost.

BUG=672829
TEST=Ran try.

Change-Id: I1b1643d953081559b81364ee7275cc640f5bee48
Reviewed-on: https://chromium-review.googlesource.com/574513
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487422}

Following https://crrev.com/c/567940, this patch greatly simplifies the
interface to PermissionPrompt as follows:
- Object creation and showing a prompt are now tied. Move Show() and
  SetDelegate() logic into the ctor.
- Hiding only happens by object destruction. Remove HidesAutomatically()
  and move Hide() logic ino the dtor.

This patch also cleans up MockPermissionPrompt{,Factory} accordingly,
moving some logic previously from MockPermissionPrompt::Show() to the
factory.

Change-Id: I7868d645df6dbba8ea5706a8d9e7e59cfe1b157f
Reviewed-on: https://chromium-review.googlesource.com/572894
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487421}

git cl presubmit rule violated:
```
if, for, while, and do require curly braces unless they are single-line
statements."
```

Bug: None
Change-Id: Ie2b060f2f5f4a82d626d3bceb7c1829c6867868c
Reviewed-on: https://chromium-review.googlesource.com/574588Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487420}

HAR files can now be exported and imported from the network panel. This
can be done by dragging a HAR file and dropping it in the Network Log
View.

R=caseq
TBR=dgozman
BUG=374557

Change-Id: Ibb451fc0a2a4d34739e596c320e99fb8866c6cac
Reviewed-on: https://chromium-review.googlesource.com/557995
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487419}

SK_SUPPORT_LEGACY_BILERP, for https://skia-review.googlesource.com/24126.

TBR=reed@google.com
NOTRY=true

Change-Id: I1e40b554567a567f2b329c635494a7948fb21110
Reviewed-on: https://chromium-review.googlesource.com/575272Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487418}

After user edits the username;
 - Losing focus by pressing enter or tab will keep the new username
 - Losing focus by pressing esc will discard the change and keep the old username

Clicking the save button will save the form with the edited username (if the changes were not discarded).

Bug: 734965
Change-Id: I35301f57ebb11d58b4545e1f31a272e7bff9ea65
Reviewed-on: https://chromium-review.googlesource.com/563672
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487417}

When trying to get Semibold font using cocoa's convertWeight it somehow becomes
Italic.
It looks like there is a problem in cocoa. I have tried the following test
(which follows the steps to get Semibold font in platform_font_mac.mm) and it
fails on the last line:

  NSFont* ns_font = [NSFont systemFontOfSize:13];
  NSFontManager* font_manager = [NSFontManager sharedFontManager];

  ns_font = [font_manager convertFont:ns_font toHaveTrait:NSBoldFontMask];
  {
    NSFontTraitMask traits = [font_manager traitsOfFont:ns_font];
    EXPECT_FALSE(traits & NSItalicFontMask);
  }

  ns_font = [font_manager convertWeight:NO ofFont:ns_font];
  {
    NSFontTraitMask traits = [font_manager traitsOfFont:ns_font];
    EXPECT_FALSE(traits & NSItalicFontMask);
  }

So we should better apply NSFontTraitMask to the derived font unconditionally.

BUG=742261

Change-Id: If7d6c93cd95a3afce0909d65a8668f7a111eb429
Reviewed-on: https://chromium-review.googlesource.com/570041Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487416}

This CL migrates ArcWallpaperService.

BUG=672829
TEST=Ran try.

Change-Id: I2ba4846b223acab81a128097c688d5a100f5a366
Reviewed-on: https://chromium-review.googlesource.com/574512
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487415}

See https://skia-review.googlesource.com/c/24260/

Bug: 
Change-Id: I82348c8d51e810a6519fe48f79a55ce3407fc76b
Reviewed-on: https://chromium-review.googlesource.com/575831
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487414}

Bug: 735808
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9449bca20368229dbe9c6e4860ad2ba0467fd0d8
Reviewed-on: https://chromium-review.googlesource.com/567898Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487413}

These changes are to bring Chrome's XHR implementation
in greater agreement with the XHR specs (see links).
This change makes it so that setting the content type
as defined in the XHR response behavior for blobs
is no longer dependent on a non-blank file path,
which is more consistent with the specs.

https://xhr.spec.whatwg.org/#the-overridemimetype()-method
https://xhr.spec.whatwg.org/#response-body

A change to the overridemimetype-blob test is added
based on communication with a spec editor (see link).
This is due to an inconsistency between two specs:
the MIME-sniffing standard and RFC-2045 (see links).

http://logs.glob.uno/?c=freenode%23whatwg&s=6+Jul+2017&e=6+Jul+2017
(see comments by yhirano, annevk, and GPHemsley)
https://mimesniff.spec.whatwg.org/#parsing-a-mime-type
https://tools.ietf.org/html/rfc2045#page-12

This change fixed four test failures on the WPT test,
but created one test failure (xhr-response-blob.html).
I changed the expectations file related to this test
to accommodate the change.

There are two 'FIXME' comments relevant to this test:
XMLHttpRequest.cpp, lines 1428-1429 and lines 1593-1595.
I don't think that they're necessary, and would consider
removing them, but I don't know best practice for that.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=699085
Change-Id: I77919178b725792e914d6984cc3f5ebde654e5af
Reviewed-on: https://chromium-review.googlesource.com/563139Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#487412}

This is needed to keep CORS handling in DocumentThredableLoader consistent
with that in ResourceLoader.

Bug: 702845
Change-Id: Iee73902e0941fb234aca3c60d996f9c75634222d
Reviewed-on: https://chromium-review.googlesource.com/571343Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487411}

For LayoutNG inline to compute visual overflow, ShapingLineBreaker needs
to compute glyph bounding box. This is currently set to empty.

To implement:
1. ShapeResult::CopyRange() should copy adjusted glyph bounding box
   when copying start/end edge of the source.
2. When start/end is safe-to-break, ShapingLineBreaker subsets
   ShapeResult, but unable to compute glyph bounding box.

This patch implements #1. How to solve #2 is to be discussed.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Change-Id: Ic239c8531bb2e5f09e2e80d7ea7e0e25c6aaa847
Reviewed-on: https://chromium-review.googlesource.com/574508
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487410}

When TPM/chaps is not fully initialized, the method returns -1 and Chrome should
attempt a retry later. The existing implementation overwrote the slot id always
by 0 and as a result disabled the retry, leading to a failure on establishing
the device ownership on certain cases.

BUG=b/37259691
TEST=`cros flash ssh://dut xbuddy://remote/samus/R61-9693.0.0/test;
 test_that --args="value='samus-release/R61-9694.0.0'" provision_AutoUpdate;
 test_that cheets_StartAndroid` > "Manage other people" setting is modifiable.

Change-Id: I9ebb731ba8004a61a9d868f3e586fe32d1979ab9
Reviewed-on: https://chromium-review.googlesource.com/558528Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487409}

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//media/capture and //services/video_capture start using base::OnceCallback
instead of base::Callback on its return value handling.

Bug: 714018
Change-Id: I0fcf6bfb2511332f53f1a1b01e269ebce4629a71
Reviewed-on: https://chromium-review.googlesource.com/567842
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487408}

Bug: 739069
Change-Id: I358d67e6842d5fd4dc4d51098736647107f9e113
Reviewed-on: https://chromium-review.googlesource.com/570118
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487407}

Bug: 719905
Test: try
Change-Id: I58915c60e7ca582bae77a19e54b9ba5ac6fadf84
Reviewed-on: https://chromium-review.googlesource.com/558165
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487406}

This should not cause any user visible changes.
It is a follow up to the refctoring in crrev.com/c/567789/.

Makes the visibility and initialization of menu items in Custom Tab
guarded on the same variables. This makes the flow of the code easier
to follow and skips unnecessary initialization when particular items
would not end up being shown.

Bug: 
Change-Id: I98a59f25380db8e91e4d01ebb4b95666d81ce586
Reviewed-on: https://chromium-review.googlesource.com/574895Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487405}

This is 6th patch of script streaming project split off from
https://chromium-review.googlesource.com/c/538477.

This patch:
 - Moves where OnScriptLoaded() is called to after calling
   InstalledScriptsManager::GetScriptData when script streaming is enabled.
 - Changes to use StringBuilder in ServiceWorker in
   ServiceWorkerInstalledScriptsManager.

The script streaming TRACE_EVENT is broken by this patch. I'll fix it in the
following patch (https://crrev.com/c/566783).

Bug: 683037
Change-Id: Ice19b90bf32d007c8a25993b207f6eb5088047a7
Reviewed-on: https://chromium-review.googlesource.com/566781Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487404}

kErrorDomainBlinkInternal is now not needed because we can use the net
error directly.

Bug: None
Change-Id: I2a1cce8c2802a03bc56a39c899d9a4cf066fd96c
Reviewed-on: https://chromium-review.googlesource.com/575732
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487403}

This reverts commit 9a7108cd.

Reason for revert:
Regress Loading.Desktop TTFMP
https://bugs.chromium.org/p/chromium/issues/detail?id=744676

Original change's description:
> Remove Document::execute_scripts_waiting_for_resources_task_handle_
> 
> The task handle is never cancelled, so it can be replaced w/ a simple PostTask.
> The task lifetime is managed by weakPersistent anyways.
> 
> Bug: None
> Change-Id: I191c9cad4982c42ba5d0177d1464d32b31bc2354
> Reviewed-on: https://chromium-review.googlesource.com/571110
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486726}

TBR=kinuko@chromium.org,haraken@chromium.org,kouhei@chromium.org,tkent@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I9506014338f85a0190539d9ab19927819c0a8372
Reviewed-on: https://chromium-review.googlesource.com/574989Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487402}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8f9bc2f6..c2021812

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Id6fc750e530bab417b52c13b38a81360c05c18d4
Reviewed-on: https://chromium-review.googlesource.com/575214Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487401}

The following tests are added to network traffic annotation auditor and its
unittest:
ReservedUniqueIDs are correctly checked.
Unique ids do not have invalid characters.
Functions that should be annotated and are not annotated are reported.

Bug: 656607
Bug: 690323
Change-Id: I98271fef6032ce58d4b94d85f9d72dd75c9aeff4
Reviewed-on: https://chromium-review.googlesource.com/571707
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487400}