- 24 Mar, 2020 40 commits
-
-
Mark Cogan authored
This CL creates a browser agent to manage device sharing, and updates the device sharing system to consistently support multi-window. There are two fundamental changes involved. First, the device sharing service now has the notion of an "active" browser. All calls to update or clear the active URL for the service are issued in the context of a browser, and if that browser isn't the active one, no change is made to the shared URL. Second, all of the logic in BrowserViewWrangler to track which URL is active is moved to the new browser agent. The active URL is updated when new web states are activated in the browser, or when the active web state completes a navigation. BrowserAgents for incognito browsers always clear the active URL when it would be updated. Every browser has a device sharing browser agent created; the device sharing manager then regulates which updates are propagated to the single handoff manager for the browser state, based on preference settings and which browser is active. BrowserViewWrangler's only responsibility for device sharing is now to, when an interface is marked as the current interface, mark that as the current interface. Once a more robust scene lifecycle is available in SceneController, that responsibility can move to the appropriate event hook. (Currently, just switching focus between scenes will not update the shared URL). Change-Id: I117778789aea88c6625f06576f6fa04cbdb38b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115479 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752820}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f021bbb3a0e9..98583637e9c4 git log f021bbb3a0e9..98583637e9c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 tvanderlippe@chromium.org Add README for end-to-end tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@98583637e9c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If2c02a5587d18c46d03691c4a39a7498962feab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752819}
-
Monica Basta authored
This CL removes 'Sync_NavigateToSyncAdvancedPage' user action. As navigation to chrome settings routes are recorded in 'WebUI.Settings.PathVisited' histogram. Bug: 1050070 Change-Id: Iea2dfc812a78df6c1ad7cb733b972d75d57f0ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115470Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#752818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ecfc8d921d5..cb8c88a27f5b Created with: gclient setdep -r src-internal@cb8c88a27f5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7a2c0a46ac41e2660eed28b4e2e47a196e2333fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117992Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752817}
-
Roman Aleksandrov authored
Bug: 1063706 Change-Id: I0d41c8b29e523db24e4994bb28bb0afb93898b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114172Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#752816}
-
Stephen Nusko authored
As requested in a code review we should call out that the enum needs to be updated whenever the C++ enum has new fields added. Change-Id: I1cacc4f4c6fb19a54b23c99a47cc412ca9d724d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102551 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#752815}
-
Anqing Zhao authored
anqing@ need to get sign-off permission to review Kiosk code changes. Change-Id: I69c4101f987334a7bd69ce48b259e1ec1e110cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116431Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#752814}
-
Elly Fong-Jones authored
Fixed: 1059652 Change-Id: Ifef9249335ce99da2adb5453b2a831755392bbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115752Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752813}
-
Fredrik Söderqvist authored
When |is_local_| was true we'd extract the fragment "manually" from the relative URL string. Always get the fragment from the resolved/absolute URL instead to make behavior is consistent w.r.t trimming whitespace. This requires making sure that base URLs are provided/set up properly in a few more cases, so do that. Drop the |is_local_| check from ReResolveUrl() because we now rely on the absolute URL in that case too. This matches the behavior of SVGURLReferenceResolver's FragmentIdentifier() which is used for non-CSS URL resolving for SVG element references. Add test for the case of an invalid base URL. Also add some tests for various non-CSS uses. Bug: 949135, 1063694 Change-Id: I2ffb30677b196d650ddaf2a712d82ac6c20b50fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115650 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752812}
-
Anqing Zhao authored
Previously, this status is only reported in Kiosk session. Now, the related functionality is extended to other sessions for new requirement. The status is considered as up-to-date if the update engine is idle. This approach is not 100% accurate but acceptable according to current APIs. Bug: 1061122 Change-Id: Ibd4505824dfb27f984b18cbcb219402a1db36557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111300Reviewed-by:
-
Yuki Shiino authored
It turned out that we need to respect the receiver object's active document, thus we cannot use ${execution_context}. This patch makes changes on the new bindings generator, which is not yet shipped. No prod change. Bug: 839389 Change-Id: Ia8ce3c68a8dbdfc1aff791b89922782788b212ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117559Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#752810}
-
Javier Ernesto Flores Robles authored
Bug: n/a Change-Id: Ieb23f3a9d83e5037c1f5ba32c5429dd1e8635b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116077 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752809}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I5c08bc26946cc202376e4e0a6b5e6c108708f56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117845Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8e8a1cc7. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." fcc0941b "MixedContent: Add static-import from dedicated/shared workers WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/encoding external/wpt/resources meade@chromium.org: external/wpt/web-animations mlamouri@chromium.org: external/wpt/mediasession panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing rego@igalia.com: external/wpt/css/css-grid yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3b5226f78e4a7855474f13010a326d3c121f1abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117890Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752807}
-
Mathias Carlen authored
The autofill assistant api is behind a compile time flag pending a build bot to actually exercise some of this code. Password manager is a newer dependency and was restricted to Android only, which does not work for the desktop only extension API. R=arbesser@google.com Bug: b/143736397 Change-Id: If37cd31e7ba839881d3625ea91e3723236db5a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117751Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752806}
-
Aaron Leventhal authored
Bug: None Change-Id: I0cd6e824620cddd39c55a79b22cb67b8817c6ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113682 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#752805}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60104cd97446..1346dd5de119 git log 60104cd97446..1346dd5de119 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 alanbaker@google.com Disallow phis of images, samplers and sampled images (#3246) 2020-03-23 jaebaek@google.com Add data structure for DebugScope, DebugDeclare in spirv-opt (#3183) 2020-03-23 ehsannas@gmail.com Whitelist SPV_KHR_ray_tracing (#3241) 2020-03-23 arnfranke@yahoo.com Make file formatting comply with POSIX standards (#3242) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1346dd5de119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Icfe6dfe3e58c0f8a5a7e93bcee6ef2918b8c1e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117481Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82dd375715f3..643201ce76ac git log 82dd375715f3..643201ce76ac --date=short --first-parent --format='%ad %ae %s' 2020-03-24 treehugger-gerrit@google.com Merge "traced_perf: delay proc-fd signal by 50ms; best-effort execve race mitigation" Created with: gclient setdep -r src/third_party/perfetto@643201ce76ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icfbea4282db5aec0f655aab9216616e458514e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117991Reviewed-by:
-
Rohit Agarwal authored
We currently don't have extensive tests on java side which checks any leakage of data across activities. This CL adds browser tests to check permission leaks. Bug: 1035770 Change-Id: If5148dead41c8dbda7b1885f48acaf16b8fe90a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111095 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#752802}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1f0fcbe5a30f..393c564ae0b4 git log 1f0fcbe5a30f..393c564ae0b4 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 johnkslang@users.noreply.github.com Merge pull request #2149 from kainino0x/web-fix-cmake2.8 Created with: gclient setdep -r src/third_party/glslang/src@393c564ae0b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7bc47289f13bd1874b30b8f42a3663bfff678876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117990Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3decd1af6bde..540bdf92531d git log 3decd1af6bde..540bdf92531d --date=short --first-parent --format='%ad %ae %s' 2020-03-24 bclayton@google.com Regres: Add new run_testlist flags Created with: gclient setdep -r src/third_party/swiftshader@540bdf92531d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ied18b3424f272a80515b320d23657c7c92d636b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117489Reviewed-by:
-
Nohemi Fernandez authored
Due to the sign-in architecture migration that extracts sign-in logic into the mediator it is now possible to test this logic of the code. Bug: 971989 Change-Id: I9a8279007bc219d3a7415a7b404c981073f9024d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098383 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752799}
-
Gauthier Ambard authored
In some cases, when the items are created to match the existing WKBackForwardItem, the are not linked to any existing items and they don't inherit their user agent. This only happens when the back/forward navigation is happening before the beginning of the navigation. In that case, the URL of the WKWebView isn't linked to the URL of the current BackForwardItem. In is possible to find the actual item by checking if the URL of the back item or the forward item match the URL of the WebView. If it is the case, the UserAgent of this item can be inherited in the newly created item. It also updates the navigation manager unit tests, replacing the expectations by stub as the expectations weren't checked. This CL is also doing the same thing when getting push state: the new items has its UserAgent set to the previous item user agent. Fixed: 1043633, 1049094 Change-Id: If95d419ef02f6e786fee43de1e401fc4727284bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109700 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#752798}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py a1762f9ceb9549b781b7418c7dbe23fe620648f6`. Bug: 1064198 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Id001edfdd985b7d1f0532107e0a9aa0f87ad084a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113689Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#752797}
-
Viktor Semeniuk authored
This is a reland of 39bb3cd1 Original change's description: > [Passwords] No result view fix in password check > > This CL changes the way visibility of 'No result view' is calculated. > The label will be shown only if: > - user had successful check with 0 compromised passwords found > - user is signed in > - breach detection is turned on in settings > > Bug: 1061496 > Change-Id: I9f1e4b5f7aef51749b970964c2b701ee2193ba53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108501 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751674} Bug: 1061496 Change-Id: I838b9383f5a45733aac7dba34875fffc4e12355a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111177Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#752796}
-
Rayan Kanso authored
This will allow eventually moving the URL to the AppHooksImpl in a downnstream CL, then removing the URL completely. Bug: 1045009 Change-Id: I3ed7398f238a77a93802dd086091544f1508029e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109763 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#752795}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12954138..afbcf655 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8b70d49d5141aac22c61ff6b98eeaa7772bf81a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752794}
-
Stephen McGruer authored
Replaced with promise_rejects_js and promise_rejects_dom. Bug: 1051932 Change-Id: I5452a5237b476255a8f24e7b9ccddd41f5b30798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116562Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752793}
-
Stephen McGruer authored
Replaced with promise_rejects_js and promise_rejects_dom. Bug: 1051932 Change-Id: I7a7b213a58dfb15eb2dea1325f904ea68e25e18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116192Reviewed-by:
-
Trent Apted authored
To test our sandboxed guest, we inject code into its frame when we detect it loading. However, we were not guaranteeing a particular load state when that injection occurred. This CL makes the injected test code more robust to load state, but also exposed a problem: our _integration_ tests (in chrome/browser/ chromeos/web_applications/media_app_integration_browsertest.cc) use content::WaitForLoadStop() before doing the injection in PrepareAppForTest(). This meant'DOMContentLoaded' would never fire in those situations and the event handler was dead code in that context. In reality, our integration tests do not use tasks tied to this handler anyway, so split out the parts of the injected JS that the integration tests actually use into a separate file. To support injecting multiple files, update SandboxedWebUiAppTestBase to initialize with a vector of files to inject rather than just one. Bug: 996088 Change-Id: Idec6c62ffa6c2d71c08ecddd3d69fd0684930e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112032 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752791}
-
Stephen McGruer authored
Replaced with promise_rejects_js and promise_rejects_dom. Bug: 1051932 Change-Id: Ib6884f2caf4276cc94ed24c1e0a392d27fafa80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116329Reviewed-by:
-
Stephen McGruer authored
NOTRY=true TBR=robertma@chromium.org Bug: 1062984 Change-Id: Ic71cac577c53f1d94be17819a0e501ac9d56ee32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117973Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752789}
-
Rune Lillesveen authored
This is the implementation of phase 2 of [1]. When collecting rules from StyleSheetContents into a RuleSet, push refptrs to each @media or @import media query along with its current evaluation into a vector on the RuleSet. When a media feature value or the media type changes, mark stylesheet collections which has media queries for active stylesheet update, but no longer clear their current RuleSet. Instead evaluate the media query sets in the RuleSets during active stylesheet and clear the RuleSet if the media query evaluation changed. This should avoid clearing RuleSets, hence cause less invalidation on changing media query affecting values. [1] https://docs.google.com/document/d/1TMqAq4k3aTHNH1m2sYoj-5QAndNmEXLI1QeD-oQ7jWE/edit#heading=h.vxytkk66ckr2 Bug: 1014920, 589083 Change-Id: I6ef9ffdfb2d94987796db15ebb8c39669e7cf96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117110Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752788}
-
Marc Treib authored
- Remove fields that were never used - Mark no-longer-used fields as deprecated - Remove proto-to-value conversions for deprecated fields - Remove/update some comments Bug: none Change-Id: I906857a2d1f7b5e2fcc6df9b242f1744eb37fdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098670 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752787}
-
Marc Treib authored
Adds a DCHECK to ProcessorEntityTracker::UpdateOrOverrideStorageKey Bug: none Change-Id: Ie1379add4a6ac5e5fa024f7a6ce55140234cc78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115472 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#752786}
-
Antonio Gomes authored
Relevant links: - original WK patch and fix: [1] and [2]. - W3 discussion that led to both WK and Blink to diverge from the spec temporarily (until it got fixed) and match other engine's behaviors (eg, Opera, Firefox): [3] [1] https://bugs.webkit.org/show_bug.cgi?id=116107 [2] http://trac.webkit.org/changeset/150087 [3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#752785}
-
Rune Lillesveen authored
Without this CL, every media-query-affecting value change clears RuleSet synchronously for all active stylesheets which have @media rules. Here we mark scopes for an active stylesheet update without clearing the RuleSet, but instead evaluate the size-dependent media queries when updating the active stylesheets. If a sheet had a RuleSet, and the media query result evaluation changed, clear the RuleSet and re-create it. The new behavior is implemented for MediaValueChange::kSize. The current behavior is kept for other media query changes than viewport and device dependent media value changes. That behavior is implemented behind MediaValueChange::kOther. This CL corresponds to phase 1 in [1]. Since this makes sure previously non-active sheets gets their media query evaluations checked when re-added as active sheets, this fixes issues 1014920 and 589083. [1] https://docs.google.com/document/d/1TMqAq4k3aTHNH1m2sYoj-5QAndNmEXLI1QeD-oQ7jWE/ Bug: 1014920, 589083 Change-Id: I089721a8736487b27c9ce019d1a389ee6521808a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113472Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6fead3754375..20983e35b3f9 git log 6fead3754375..20983e35b3f9 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 22d73d15e778..6c11cf2ad9ca (5 commits) Created with: gclient setdep -r src/third_party/angle@20983e35b3f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I30b485e412fdbf4c4fe25e1a7beb271408d6c869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117488Reviewed-by:
-
Vasilii Sukhanov authored
There was an experiment running with 3 different images shown in the header in the password bubble. This CL stops the experiment and fully launches save_password2.png picture. Bug: 1016814 Change-Id: If6231326b1b8c606682d119019ca67eb45c13483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116174Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#752782}
-
Donna Wu authored
Suspend/Resume NFC usage in browser process instead to prevent a compromised renderer from using NFC in background. TBR=kinuko@chromium.org Bug: 520391 Change-Id: I24bfc42fe95882bbfd37a12718602d96bac5fe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109464 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#752781}
-
