- 20 Aug, 2020 40 commits
-
-
Mohsen Izadi authored
TBR=solomonkinard@chromium.org,rdevlin.cronin@chromium.org Bug: 1119846 Change-Id: I7075bd76983f165fb0588d4ed22cd7caffa0d1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367874Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800334}
-
Tanya Gupta authored
simplify the addition of a new feature. Change-Id: Ie0fdde88c4e48af19d4679d19eb3c11807382a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343218 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800333}
-
Russ Hamilton authored
Add a "SurfaceTracker" to IdentifiabilityStudyState to keep track of surfaces that have been previously reported for each source. This is used for deduplication and to limit the number of metrics sent in each UKM report. Bug: 1112787 Change-Id: I00eb2360849ea6772fbfdcc9b1cf91680f8c6173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363398Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#800332}
-
Omar Morsi authored
This CL does the following. 1) Renames KeyPermissions to KeyPermissionsManager and 2) Creates KeyPermissionsManagerUserService which is a keyed-service. Bug: 1117010 Change-Id: I9cfaa94a29cf934cc2b9d9a91e3633908c37ffce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362729 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#800331}
-
Guillaume Jenkins authored
Enables CBCM at 100% on Beta on iOS (in addition to the existing command-line switch, which can enable CBCM in any channel). To paraphrase the comment in the code, CBCM must either be enabled at 100% or 0% because the Finch infrastructure isn't ready by the time CBCM must decide whether to initialize. Because of additional requirements explained in the following 1-pager (Google only), CBCM is required on Beta, which means CBCM will be enabled at 100% on Beta and 0% on all other channels: go/ios-cbcm-rollout-1pager. Bug: 1066495 Change-Id: I1449f5314ea592297d79ec7acbbb0991d31bed5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364912 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800330}
-
Peter Wen authored
And one SupportAnnotationUsage misplaced annotation. Tbr: Just removing/moving annotations to be more correct. Bug: 1116130 Change-Id: I88c2e0df485a8fc263ac4958cc72ee171741fa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367636 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#800329}
-
Yu Han authored
This previously had no use counter. I'm adding NOTRY here because branch day seems to be an impossible day to land changes to enums.xml. Hopefully this sails through. Feel free to revert if this breaks something. NOTRY=true Bug: 869308 Change-Id: Ic81d9620f34b8fe0998f8f6e7cb9d209b028e6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367474 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#800328}
-
Anastasia Helfinstein authored
A recent change to TrayBubbleView caused the Switch Access back button to no longer display. This happened because the back button is explicitly drawn in OnPaint(). This change restores the previous behavior of the back button. TBR=jennyz@chromium.org AX-Relnotes: n/a. Bug: 1118201 Change-Id: Iae5e43ed1714997b062406a6bc9a8ac0a473bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367787 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#800327}
-
Adam Langley authored
The QR standard says that the mask should be auto-selected, not fixed to three, and specifies a fitness function for choosing the best mask for each QR code. This change adds support for that and lets the caller specify a mask if it really wants … say if it wanted to cycle through a series of QR codes for the same data with a dancing dinosaur on top. Change-Id: Ief4dedce236aa2ae13cc94b2248a17a0488f88ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365222 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#800326}
-
Emily Stark authored
Localhost URLs are highly unlikely to be phishing/social engineering, and it's especially useful for developers using localhost to be able to see port and path by default. Bug: 1112816 Change-Id: I245cbb5cacffebdb04cbb7840629c0ab68702883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367802Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#800325}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Ia9fcf42d6394755cf1042e0d51f4352185e8a972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366593 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800324}
-
Daniel Rubery authored
This CL finishes preparing the V4 database code for the upcoming split of Safe Browsing NetworkContexts by profile. It starts using the browser-wide network contexts for all requests, and removes cookies from the V4UpdateProtocolManager. Bug: 1049833 Change-Id: I3f1c9819846ed35497a8c0d3ec32a8254c92fa0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365296 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800323}
-
Matt Menard authored
This complements the existing user policy and adds print servers defined by device policy. The device policy has its own corresponding whitelist and if there is existing print servers in user policy also in device policy, then the user policy print servers take precedence (which is only for the purpose of the print server names currently). Also changed to using shared url loader factory since the SystemNetworkContext is non-unit-testable. Bug: 1100777 Change-Id: I0e45597437b59b5eb940c4fbf5fb63596b8504dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293178Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#800322}
-
Ethan Jimenez authored
1. https://chromium-review.googlesource.com/2171436 introduced a change to how `AXPlatformNodeBase::IsLeaf` works; previously, a node would start by querying `AXPlatformNodeBase::GetChildCount` (which relies on `BrowserAccessibility::PlatformChildCount`) to check whether the node has no children (which would make it a leaf by definition). After CL 2171436, `AXPlatformNodeBase::IsLeaf` is delegated to `BrowserAccessibility::PlatformIsLeaf`, but the case of an '<iframe>' is mishandled since now we don't check if the node has a child tree. Fixing `BrowserAccessibility::IsLeaf` to check for the child tree of a node; this will allow several `BrowserAccessibilityPosition`'s methods to correctly traverse into '<iframe>' elements. 2. Introducing a content browser test to validate that methods from `BrowserAccessibilityPosition` can navigate into iframes. 3. Rebaselining `DumpAccessibilityTreeTest.AccessibilityIframe` which incorrectly expected '<iframe>' nodes to be treated as leaves. Bug: 1101480 Change-Id: Ib364ee78a39ef6b7854fc41985bd059dfced8a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364049Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#800321}
-
Juliet Levesque authored
Updated variable names in ShareTargetDiscoveryCallback and TransferUpdateCallback to be consistent with C++ style guide. Change-Id: I92d7994630dfee0d80f78ebeddbcb2d6d627b145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361844 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800320}
-
mhasank authored
In order to better understand the feedback reports, adding logging in key events of arc provisioning process. BUG=b:162221783 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ie6cd8a4dd9b89353a0a3fa1dcc656496f62bfb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365997Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#800319}
-
Miguel Casas authored
Just adding a DCHECK and using a stringify function in a log. No functionality change intended. Bug: b:162962069 Change-Id: Ie7f7520fe769405342bc21a15c810bb9c35eef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367444 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800318}
-
Elly Fong-Jones authored
This is a reland of 4e425ce4 Original change's description: > mac: introduce system infobar > > This infobar will be used (via field trials) to display updated info > about current OS support and provide users with a link to more info. > The infobar receives both activation info (which configs to show for) > and the actual strings to display via field trials, so it can be updated > for deployed Chrome instances without an update cycle. > > This change adds: > * The infobar itself > * A feature MacSystemInfobar that controls whether the feature is > enabled and if so which configs (Arm or Rosetta) it's enabled in > * A switch --force-mac-system-infobar which causes the infobar to act as > though it was running on a specified system, for both manual and > automatic tests > * A variety of IDS_MAC_SYSTEM_INFOBAR_* constants to customize the > infobar's message, link, and link text > * Unit tests for the logic to interpret the feature and the > enable/disable configs > > Bug: 1116578 > Change-Id: Ie7fd6e772a0112a17e794d1b8fcb009c57ebed4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360479 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799615} Bug: 1116578 Change-Id: Ie98bc3a18fc4f952819b3ee40a1c49953e8c63ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364893 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800317}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie36b7fb24ee930592df6dfe1b94ff2428d4e3f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800316}
-
Andres Calderon Jaramillo authored
This CL renews the "enable-vaapi-jpeg-image-decode-acceleration" and "enable-vaapi-webp-image-decode-acceleration" flags which are still useful to experiment with the JPEG and WebP hardware decode path in Chrome OS (not launched yet). Bug: None. Test: None. Change-Id: Id314de274805667c05c5d340a58c0e0ad254be25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367733Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800315}
-
Lan Wei authored
We have replaced ContinuousMouseScrollBy with gpubenchmarking.smoothscrollbyXY to simulate scroll actions, now we can remove it from eventsender. Bug: 1047176 Change-Id: I770c2ba9a8a79f875d46be379ceec533b65e837d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361184Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800314}
-
Russ Hamilton authored
Instrument RTCIceCandidate.{address,candidate,port,relatedAddress,relatedPort} for web Identifiability study. Bug: 973801 Change-Id: If0783bc203c996cf7603b47395e1f628905ac9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359735 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#800313}
-
Avi Drissman authored
The "Manage People" window is not correctly labeled in the Task Manager. Do so. Bug: 1115850 Change-Id: Ib749091a49c34e5666b2b82d14c7852f40a2e829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364954Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800312}
-
Clark DuVall authored
Incognito mode should not automatically grant DSE permissions. Bug: 1119910 Change-Id: I387ade23bdc654b7b4ab0337522a09a62e6268e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367634Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800311}
-
Caitlin Fischer authored
The feature is disabled by default. Also, rename two existing IDCollectionKeys. This change paves the way for limiting the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Bug: 1094303 Change-Id: Ib535b0b8657aeb82570c552b31d722bd30168019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363467 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#800310}
-
James Cook authored
Bug: none Change-Id: Id2b6ccc6985b92d8c22ecf20fb8ae3edc3bac9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367031 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800309}
-
adamta authored
Adds URL for 'Learn More' item in the NTP' Discover feed header menu. Bug: 1111837, 1085419 Change-Id: If0bd7519f213cfb0667fe67c962d6d9ceef1d62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367732Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#800308}
-
David Bienvenu authored
Also remove base/compiler_specific.h includes and other cleanup. No functional changes. Bug: 1010217 Change-Id: I29bcb79a46b7ee4dbb1bf92e59f55d13599a98cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365752 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#800307}
-
Mei Liang authored
This CL also avoids MobileTabReturnedToCurrentTab being logged twice when using back button to leave GTS. Bug: 1025111, 1119414 Change-Id: Ie0839f27481b9b6033e4f8547ec85f7790207a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366032Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800306}
-
Alex Ilin authored
New colored avatars use person_filled material design icon instead of person_outline. It also has two variants of the icon with different padding. The larger icon has bigger padding. See mocks in the attached bug for the reference. Bug: 1100835 Change-Id: I563ed52b9176a0bbed2abcf3e32cd8209e8da315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362898Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800305}
-
Mei Liang authored
IncognitoTabSnapshotController sets FLAG_SECURE when viewing incognito tabs. The AssistStatusHandler is no longer needed. This CL deletes the AssistStatusHandler and TabbedAssistStatusHandler. In addition, this CL deletes the #addOverviewModeObserverPreNative in ChromeTabbedActivity, and renames #addOverviewModeObserverPostNative() to #initJourneyManager(). Change-Id: I0a729e78089f48a810710b944af92cebeeb79ceb Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337496 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#800304}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597838234-9c863d7c9dc15ae374a8358c943ba78053f4a35c.profdata to chrome-mac-master-1597946202-cb1005c445d83fc8c9db9d03ba0a749f78675139.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I979c9f55d04ca2f0d7fd5218afbaae963a892e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800303}
-
Chris Harrelson authored
There are already hit tests and animations entirely in the impl thread for such scrollbars. Bug: 1116800 Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800302}
-
Elaine Chien authored
Bug: 1057764 Change-Id: I0a585d6b98a0a6323a50220b16a90d004f2af24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363306 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800301}
-
Olesia Marukhno authored
Fixed a11y for remove suggestion button and buttons in dedicated row (set role to be list box option and set correct accessible name). Fixed selection event not being triggered for dedicated row buttons (GetSecondaryButton wasn't returning buttons from dedicated row). Fixed value changed event triggering extra time when switching selection from button to button. Bug: 1104264 Change-Id: If5fc4692ac4e86f50e1a1d1b754feec795b76c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366758 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800300}
-
Justin Donnelly authored
Follow up to https://crrev.com/c/2363852, which added Omnibox.SuggestionUsed.Pedal. Tested manually with chrome://histograms. Bug: 893183, 1117634 Change-Id: I9033ea200d820f74cb2d5fd0162383496128bd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367472Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#800299}
-
Sven Zheng authored
First adds the target with one test file in it. Now it can compile and run on device, and fails. I will get the target pass in the following work. Bug: 1117345 Change-Id: If3acc03e002a5ec23f1bcac5bff0ff7b1e3403a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360598 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#800298}
-
Joanmarie Diggs authored
AXSelection::Select has logic meant to handle selection within an native text field. But when the selection is being set, the base and extent may be the static text descendant of the AXObject associated with the field. In this instance, the logic for text fields is not being used. Fix this by retrieving the native text control ancestor AXObject. Then, to ensure there is no behavior change, set focus on the element after the selection range was successfully set. Bug: 1113650 AX-Relnotes: N/A Change-Id: I5b1db3dcf7d01baf971d5858c936a4e5d168543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352898 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800297}
-
Thomas Guilbert authored
This CL changes the behavior of VideoEncoder to make an internal copy of frames passed in through encode(), before destroying the passed frame. This means that users don't need to call destroy() after passing frames to encode(), which could result in a frame being invalidated before we send it to the internal encoder. It also means we can destroy the frame internally when we no longer need it without risking that it might still be in use by the user. Users that which to keep their frames alive after giving them to the encoder can send a cloned copy instead. Bug: 1108023 Change-Id: Ie5cd98d688a53314ac16a6a3ac7afe2a65d742f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363863 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800296}
-
Yao Xiao authored
When the feature is enabled: the 1st floc computation condition will not only be first-sync-enabled-seen, but would also require first-blocklist-loaded-seen, as both conditions are likely to occur after a while after browser start. When floc is computed from history, invalidate it if it's in the blocklist; invalidate any floc when the blocklist is not yet loaded / has error in loading. Bug: 1062736 Change-Id: I81dcfc27b0d2a7023ba1559d30131de41d5842ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365396Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#800295}
-