- 15 Mar, 2018 40 commits
-
-
Charles Harrison authored
This patch also fixes up some missing dependencies to get components_perftests building + passing on all targets. Bug: 648992 Change-Id: I911bdea5ba946e58037f40a4bfa0d534486be761 Reviewed-on: https://chromium-review.googlesource.com/957224 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543348}
-
Benoit Lize authored
Bug: 819228 Change-Id: I5813d2c77c04d7dd00303a874ba6bd2a09acf946 Reviewed-on: https://chromium-review.googlesource.com/952967Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543347}
-
https://skia.googlesource.com/skia.git/+log/30ce2a3620ff..945ac788d85d $ git log 30ce2a362..945ac788d --date=short --no-merges --format='%ad %ae %s' 2018-03-15 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5eaddbd01..0b0dcbc1c (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I13b75da8cfa3f9354c7b22788bb9436c04613daa Reviewed-on: https://chromium-review.googlesource.com/963712Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543346}
-
Vitaliy Rebrov authored
Fixed typical problem with unit tests and global variables. If unit test modifies global variables then it can affect other tests which are runned in the same process. Added reseting of the global variables to avoid this. Change-Id: I2045700473ac074209f4d48a6cedbd3dad24ccd5 Reviewed-on: https://chromium-review.googlesource.com/952905 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543345}
-
https://chromium.googlesource.com/angle/angle.git/+log/5eaddbd018ea..0b0dcbc1cffa $ git log 5eaddbd01..0b0dcbc1c --date=short --no-merges --format='%ad %ae %s' 2018-03-14 oetuaho Prune empty cases and switch statements Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iabd3eef196468911f4846edc1e2d3a987d3d5e52 Reviewed-on: https://chromium-review.googlesource.com/963705Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543344}
-
Yuki Shiino authored
ActiveScriptWrappable is designed to be inherited. The ctor should be protected:. Also all classes that support virtual member functions should have the virtual dtor. Change-Id: I1eaa60b45607b5404868e0d293a150e1b98dfc5b Reviewed-on: https://chromium-review.googlesource.com/964068Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#543343}
-
Yuhong Sha authored
Currently whitespaces can not be shown in the built-in XML Viewer. It is proper to remove trim in text node creation for whitespaces show. Bug: 736690 Signed-off-by:
Yuhong Sha <yuhong.sha@samsung.com> Change-Id: I55ca0f61d76f3a45a9dabdd0b5805a2e895e1fc2 Reviewed-on: https://chromium-review.googlesource.com/950489 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#543342}
-
stkhapugin@chromium.org authored
Allows using Cmd+C/Cmd+V/Cmd+X when the textfield is in pre-edit state. Allows using arrow-left and arrow-right keys to go to the start/end of the string and exit pre-edit, like on desktop. Bug: 136291 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe71f4d2b6adba3df310051edf4ffa42832217c2 Reviewed-on: https://chromium-review.googlesource.com/951783 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543341}
-
Hiroki Nakagawa authored
This is a preparation CL for implementing module loading on workers. WorkerOrWorkletModuleFetchCoordinator (strictly speaking, WorkletModuleResponsesMap) is a key class for module loading on worklets. It's primarily owned by Worklet class on the main thread, and its reference is passed to the WorkletGlobalScope on the worklet context thread before module loading happens. Before this CL, the reference is passed from Worklet to WorkletGlobalScope when worklet.addModule() is called in the JS context. This path is specific for worklets and not called for workers. To pass the reference in a common way, this CL passes the reference with GlobalScopeCreationParams struct that is commonly used for creating a new global scope. Design doc: https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn Bug: 680046 Change-Id: I6dde98ef83c5fb6ae7898c63bdbecd3ebfbd36dd Reviewed-on: https://chromium-review.googlesource.com/961747 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ia34819a0518e339ed2d310361452355207346801 Reviewed-on: https://chromium-review.googlesource.com/956165Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#543339}
-
Ramin Halavati authored
Traffic annotation auditor new executables are rolled for Linux and Windows. Bug: 690323 Change-Id: Ibbfa8868736b4cbe6fd101ecf93fbf15626832f0 Reviewed-on: https://chromium-review.googlesource.com/963323Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543338}
-
Rob Buis authored
In order to make this work, because comments are already stripped by the time ParseRGBParameters/ParseHSLParameters is reached, relax the strictness and simply require the color components to be there. This works since although the comment is stripped out, the effect is that it still acts as a separator and will preserve numeric tokens: 1/* comment */2 -> NumericToken(1) + NumericToken(2) Behavior matches Firefox. Bug: 808888 Change-Id: I43ae53a0d7630b8229745a347c5fb914f8949589 Reviewed-on: https://chromium-review.googlesource.com/962989Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Erik Språng authored
Bug: webrtc:9012 Change-Id: Ib83fa7046c2e7517e0051e0fdb433487ad636ceb Reviewed-on: https://chromium-review.googlesource.com/962784Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#543336}
-
Daniel Bratell authored
pch makes jumbo builds slower instead of faster since each pch file will only be used 1-3 times instead of many times, and in Blink the pch files contain a lot of code so creating them takes a long time. This saves about 20% of the Blink build time on Windows. Bug: 809010 Change-Id: Ia512646110572e4939e8e3cc1a9cd946b780cb97 Reviewed-on: https://chromium-review.googlesource.com/962785Reviewed-by:
-
Friedrich Horschig authored
If the screen space doesn't suffice for multiple action bar icons, the help icon will be pushed to the Overflow menu which is what happens when a search is triggered. Even after the search is closed, the item wasn't moved back but stayed in the overflow menu. With this CL, we ensure that the help icon stays in the action bar if sufficient space is available. Bug: 821687 Change-Id: Icb438f9988f9114f563e920ddc95f27ebdac5434 Reviewed-on: https://chromium-review.googlesource.com/962425Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543334}
-
Fredrik Söderquist authored
Combine all the fields that make up a <paint> into a class: SVGPaint. Move the bulk of the style builder function for <paint> from the template to StyleBuilderConverter. This should make future work on <paint> resolution easier. Also split the existing setters on {SVG,}ComputedStyle to avoid having bools to indicate if the "visited" portion should be set or not. The new way more closely resemble other color properties. Add accessors to SVGPaint to both make code easier to read, and reduce the dependence on SVGPaintType. Bug: 769774 Change-Id: Ifad043c9e423f0fc7aa79fef78e635b2abb4636c Reviewed-on: https://chromium-review.googlesource.com/961062Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#543333}
-
Devlin Cronin authored
APIBindingBridge calls back into JS to allow custom JS bindings to register any hooks needed. Check context validity before executing JS, and gracefully throw an error if the context is invalid. Add unittests for the same. Bug: 819968 Change-Id: Ibb724537c4bf3d320a6f4a80b9f19fe413e00840 Reviewed-on: https://chromium-review.googlesource.com/958296Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543332}
-
Ramin Halavati authored
Updating annotations.xml is requested before landing any CL that changes an annotation. To do the tests fast on trybots, only .mm and .cc files are checked. Also the tests do not cover ChromeOS and ios specifc code. This annotation has been moved to ChromeOS specific code by a build file change, hence gone unnoticed by the trybots. This is a typical case that the FYI bot gets the problem and fires an error for manual update of annotations.xml Annotation is marked deprecated as we still do not support ChromeOS in annotations.xml. Bug: 690323 Change-Id: Iab001e8916c3da7e97f68e9dfc67b42017d4f658 Reviewed-on: https://chromium-review.googlesource.com/962764Reviewed-by:
-
Zhuoyu Qian authored
Use Editor::ExecuteCommand() instead of Editor::CreateCommand().Execute() to avoid the dependence of Editor::Command in SelectionController.cpp Signed-off-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543330}
-
Yoshifumi Inoue authored
This patch replaces test files "extend-selection-{character,home-end,word}.html" by "extend_selection_${sampleId}_${dir}_${direction}_${granularity}" - sampleId = 1 to 22 - dir = ltr, rtl - direction = backward, forward, left, right - granularity = character, lineboundary, word to utilize |selection_test()| for ease of maintenance and avoid test execution timeout on slow bots. We have 24=2×4×3 files for each file and total 528=24×22 files. Note: These files are generated by scripts in http://crrev.com/c/620331 Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0fc047175a016c5861f338e76af921a0c8a3cd9a Reviewed-on: https://chromium-review.googlesource.com/960181Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543329}
-
Alexander Semashko authored
These events can happen when another test starts or finishes and cause frame/widget focus state changes, breaking some tests. Bug: 695054 Change-Id: I9ab6b3887c00421d4c6f96dd508e912b23706176 Reviewed-on: https://chromium-review.googlesource.com/926368Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#543328}
-
Han Leon authored
This CL - mojofies the legacy IPC ServiceWorkerHostMsg_PostMessageToClient, which is the last one service worker legacy IPC sent from the renderer process to the browser process. - eliminates some infra codes sending service worker legacy IPCs in renderer-side. - eliminates some infra codes receiving service worker legacy IPCs in browser-side. - modifies some related tests. BUG=772793 Change-Id: I81652b2f5c2693eef731faca0a09fd1aa5ad7404 Reviewed-on: https://chromium-review.googlesource.com/947804Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#543327}
-
Koji Ishii authored
Following bot results are included. 4218 4221 4224 4227 4229 4230 4232 4235 4236 4237 11 lines were removed and 30 lines were deflaked by consecutive results since 4191. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic59fca5fcef70eb4a19049502ee9e5a8f4ec3a0b Reviewed-on: https://chromium-review.googlesource.com/961827 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543326}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I80a0355183de2b2dc9bb80d83ce52309a6381907 Reviewed-on: https://chromium-review.googlesource.com/963981 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543325}
-
Kent Tamura authored
This CL renames: * html/HTMLAttributeNames.json5 -> html/html_attribute_names.json5 * html/HTMLTagNames.json5 -> html/html_tag_names.json5 * html/parser/MathMLAttributeNames.json5 -> html/parser/mathml_attribute_names.json5 * html/parser/MathMLTagNames.json5 -> html/parser/mathml_tag_names.json5 * svg/SVGAttributeNames.json5 -> svg/svg_attribute_names.json5 * svg/SVGTagNames.json5 -> svg/svg_tag_names.json5 * svg/xlinkattrs.json5 -> svg/xlink_attribute_names.json5 * xml/xmlattrs.json5 -> xml/xml_attribute_names.json5 * xml/xmlnsattrs.json5 -> xml/xmlns_attribute_names.json5 This CL has no behavior changes. Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I45c157f187258bd04090b8e2c9557368f97575f9 Reviewed-on: https://chromium-review.googlesource.com/963863Reviewed-by: -
edchin authored
Dynamic type is now used in the: - grid cell title - toolbar text buttons - empty state texts The dynamic type used in the grid cell title and the empty state text do not adhere to spec because they are not semi-bolded. Bug: 819667 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie8ccccc68ec783ce6277c1cb57a26ba5895de8fd Reviewed-on: https://chromium-review.googlesource.com/963180 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#543323}
-
Jan Krcal authored
Bug: 782237 Change-Id: I030322a93c71eec70fc4a53a4cb21458c63678ee Reviewed-on: https://chromium-review.googlesource.com/856796Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543322}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: I2632e971a0105ccfcabe8921d59e6b72d1831982 Reviewed-on: https://chromium-review.googlesource.com/961568 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Emily Hanley authored
Bug: 757933 Change-Id: I20f5b6f70d125fc9aa6c5d7f541d378454a33445 Reviewed-on: https://chromium-review.googlesource.com/960935 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#543320}
-
Jan Krcal authored
Bug: 782237 Change-Id: Ieb698518c15a84a5759d1c3cf99cff8a40f8f663 Reviewed-on: https://chromium-review.googlesource.com/854053Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543319}
-
Jan Krcal authored
Bug: 782237 Change-Id: Id89fbfdd30c769fc1dc272d81b1a2fffdb7903fd Reviewed-on: https://chromium-review.googlesource.com/809017Reviewed-by:
-
Jan Krcal authored
This is the first CL in a sequence that converts all java protobuf uses from nano to lite. It disables one proguard optimization that breaks with lite-generated code. Bug: 782237 Change-Id: Ifed32f216dacad69c1f32e903d8d30070070404b Reviewed-on: https://chromium-review.googlesource.com/808684Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543317}
-
https://skia.googlesource.com/skia.git/+log/34417a5b0d20..30ce2a3620ff $ git log 34417a5b0..30ce2a362 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 csmartdalton ccpr: Unblacklist vulkan Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ib144029580f967c8ad2c34bbc7a1563b35298736 Reviewed-on: https://chromium-review.googlesource.com/962840 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/2ce1e749a898..ee205f5bbae6 $ git log 2ce1e749a..ee205f5bb --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I14e0996a4450129cb509546627f37f2492e14355 Reviewed-on: https://chromium-review.googlesource.com/963847Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543315}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f5e91fee. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13847 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I4c00551079ee1d0bda075439b2941a356fb31717 Reviewed-on: https://chromium-review.googlesource.com/963765 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543314}
-
Darren Shen authored
This patch: - Creates separate test file for CSSKeywordValue.value. - Make code style consistent. Bug: 774887 Change-Id: I46322556d4f39fd33cffd91bfad82f5a001e48b5 Reviewed-on: https://chromium-review.googlesource.com/954563Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#543313}
-
Yoichi Osato authored
This patch adds test that confirm |selection.modify('move', 'right', 'character')| behavior on various DOM tree including RTL characters. This patch is a extraction from editing/selection/move-left-right.html which tests move right/left inside style=rtl/ltr. Bug: 679977 Change-Id: Iae6a445422999daf6d1da39d8361ecc08ea6c8ec Reviewed-on: https://chromium-review.googlesource.com/955864Reviewed-by: -
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/941264 Further cleanup of WithBaseSyncPrimitives() is done in https://chromium-review.googlesource.com/c/chromium/src/+/961455 as that may have side-effects that risk a revert. Bug: 815225, 689520 Change-Id: I8ba8bb6709b7d8cc88e07e0f915c3c00d0a80cc2 Reviewed-on: https://chromium-review.googlesource.com/961451 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#543311}
-
Kent Tamura authored
According to existing data members and a script name, 'CSSOMFoo' should be converted to 'cssom_foo', not 'css_om_foo'. This CL has no behavior changes. Bug: 770603 Change-Id: Iec7bfac69600c0f5f962cfa089c7bf07b8c16d73 Reviewed-on: https://chromium-review.googlesource.com/963159Reviewed-by:
-
Kent Tamura authored
instead of css_om_foo. This CL has no behavior changes. Bug: 578345 Change-Id: I54e26c53291c7d95611ad6afdff59d49be57d66e Reviewed-on: https://chromium-review.googlesource.com/963866Reviewed-by:
-
