GitLab

Bug: 1026217, 1026760
Change-Id: I9bed765c6cb16ba52d0f28eef28434cae3540dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927169Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720646}

This will allow enforcing chump detection without preventing submits due to
chromium_presubmit not being in a good state.

Bug: 1024637
Change-Id: Ic80d65f6e6a9442c66e6d92a4b3626f3c5c02dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946857
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720645}

In order to ensure homogeneous fleets, we need to have more specific
dimension values when looking for bots. This set of CLs updated some
existing dimensions, and added the synthetic_product_name values for
dimensions if appropriate.

This CL updated the dimensions for:
 - mac-10_12_laptop_low_end-perf
    - Added synthetic product name 'MacBookAir7,2_x86-64-i5-5350U_Intel Broadwell HD Graphics 6000_8192_APPLE SSD SM0128G'
    - Updated OS from 'Mac-10.12' to 'Mac-10.12.6'
   Link for the available bots based on the old/new dimensions:
   https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=status&c=synthetic_product_name&d=asc&f=pool%3Achrome.tests.perf&f=gpu%3A8086%3A1626&f=os%3AMac-10.12&k=os&s=synthetic_product_name
 - mac-10_13_laptop_high_end-perf
    - Updated synthetic product name from 'synthetic_product_name': 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_1_475936.0' to 'synthetic_product_name': 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_APPLE SSD SM0512G'
   Link for the available bots based on the old/new dimensions:
   https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=status&c=synthetic_product_name&d=asc&f=pool%3Achrome.tests.perf&f=os%3AMac-10.13.3&f=gpu%3A1002%3A6821-4.0.20-3.2.8&k=gpu&s=synthetic_product_name

Bug: chromium:1019916
Change-Id: I67faf23b277f1fc4db5b5d960808aec8066b98bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941190Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#720644}

This enables the fetching of CRLSets on Chrome for Android. While Android
is not yet using the CertVerifierBuiltin, which enables CRLSets during
path building, it does support CRLSets for known MITM detection and
disclosure.

This ports the existing CRLSet tests (which hang off SSLUITest but are
really browser tests) into platform-agnostic browser_tests, running on
either android_browsertests or browsertests, respectively.

Bug: 1025424
Change-Id: I89b066dfd539b287f35a20bea54d5cb5cb739501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930051Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720643}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..a9771748c0c2


Created with:
  gclient setdep -r src-internal@a9771748c0c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1017165
Tbr: jbudorick@google.com
Change-Id: I43ccf9ae85647651302c034510f25fbb6bbd1565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946887Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720642}

Bug: 421413
Change-Id: I810f8d8bce517e1de82e347d92bcc0204deedacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943445Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720641}

Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with
CollectDebugData, which is functionally identical but the name is more
descriptive of what it actually does.

TBR=crouleau@chromium.org

Bug: 1025034
Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720640}

The new version has information about progressive web apps.
It also has details about migrating specific APIs.

Change-Id: I8ee02283cd8fcc859bce221a53c408aac0596e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935235Reviewed-by: Meggin Kearney <mkearney@chromium.org>
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Auto-Submit: Meggin Kearney <mkearney@chromium.org>
Commit-Queue: Anthony LaForge <laforge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720639}

Running with --test-path seems to no longer be supported. This CL updates the
documentation to use story-filter.

Change-Id: I9e202ef4a4b8474acbf1d8af4f81d44c1ffaf85a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946429
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720638}

-The subtext variable/location on the CUPS printer page is intended to
 hold supplementary information for printers show on screen, but right
 now it is unused. Therefore, having aria-describedby="printerSubtext"
 gives no further context while unintentionally stopping the tooltip
 from being read by ChromeVox. So I will remove these references now
 then revisit these ARIA labels once we understand what the printer
 subtext will be.

Fixed: 1014145
Change-Id: I481a018a5d7e75f4f8ac28e6c60262fefa9805a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930695Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720637}

This CL refactors build/config/locales.gni but makes no actual
changes to what locales are used.

The primary change is to remove android_chrome_omitted_locales
and replace it with android_non_bundle_locales.
This list should be used directly instead of subtracting omitted
locales from locales.

Additionally the list all_chrome_locales was added as the superset
of all supported locales.  Platform specific lists are made by
subtracting from this list.

No changes were made to the iOS and Mac locale lists names.

Bug: 812837
Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720636}

Test: run_simpleperf_test.py:testStackAddressInterpreter covers this
Bug: 1015236
Change-Id: Iedc680d8b484556044cfc1ae04576b5b4fb0907c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946932Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720635}

Binding repaint callback used for WebMediaStreamVideoRenderer to
a "Repeating" callback because the repaint callbacks are called
multiple more than once.

Bug: 1007835
Change-Id: Ic6b9a64d9b35b2e3d08e97c4286edb078f6609a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912539
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720634}

On some bots getting the server command line is failing, so change
DVLOGs to WARNINGS so that the actual error can be seen.

Bug: 976083
Test: compiles
Change-Id: I654d3857806b48015ecda97431d8e264a8924ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946929
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720633}

Using wpt-import in Chromium beabaf9d.
With Chromium commits locally applied on WPT:
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"
a75430aa "Fix appcache tests."
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I609b6d80f5204b077587551b2303c16786e8887a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946628Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720632}

TBR=rsleevi@chromium.org

Change-Id: I77752dd385065bd71b8d9ae522170d580b2010e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945892Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720631}

Change-Id: I09d017033b1a6a93dcc4dd1f22de7a304ef5bb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937696
Auto-Submit: Jeremy Apthorp <jeremya@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720630}

These tests don't work on Mac - it's possible that they never did, or
they may have broken recently. Unfortunately the entire suite is
disabled (see issue 899286). This change marks these two tests
explicitly disabled pending a real fix.

Bug: 1029882, 1028239
Change-Id: I3a11ae61470850fd55ad95353c7eacd4ac516169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946394Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720629}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=kmackay@chromium.org

Bug: 891670
Change-Id: Ic1325bfe89d1731134cb01a69b120d74eec119ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944149
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720628}

Also fixing CSS related PRESUBMIT errors:
1) removing usage of -webkit-box, which seems to have no effect
2) converting padding/margin CSS properties to use logical start/end
   instead of left/right

This is in preparation of migrating this page to JS modules.

Bug: 1028829
Change-Id: I33019772455cc870e49ebadf11b4c98650eeeb8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941270
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720627}

Bug: 1007725
Change-Id: Ie9ce62d0775094cba94261d95853e4fe9dc19376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935649
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720626}

Now that the CRD Chrome app has been removed, we have no need
for the NaCl plugin code.  AFAICT nothing else in remoting
relies on it so it is safe to remove.

Change-Id: Ic977bc8b7d921e6b2bed2cfc8ea0bd40c24acec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933132Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720625}

It is possible to create a credential on an authenticator that supports
user verification but doesn't have it configured.

If the user then tries to authenticate using that credential, and the
relying party sets UV=required, the message returned says that no
credential exists. This could be confusing for developers trying to
debug problems.

This patch changes the error to indicate that UV is not available.

Fixed: 1029285
Change-Id: Id70960d0a3830854decfa9d02464cd51c1c8f52a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943386
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720624}

Note that removed resources were reported as unused.

Bug: 1024945
Change-Id: Ifc1189a905cf0f12d49ef08dbe34022d62f165ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941048Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720623}

62f10f30bad9 Fix 'make distcheck'
f6fe7cc55ab9 mac processor: Add mapping for
             EXC_BAD_ACCESS/KERN_CODESIGN_ERROR
1f1d950d6a4b Fix compilation of http_upload.cc with Windows gcc
47cd498384fd dump_syms: handle forward reference DWARF attributes

Change-Id: I337887b046d45f7d27b7ccfe9ad20c85fc589169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943543Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720622}

This CL implements regex substitution. A new key called 'regexSubstitution' is
added to the Redirect dictionary. Rules using the 'regexFilter' can specify the
'regexSubstitution' key to use regex based redirects with capture groups.

BUG=974391
Doc=https://docs.google.com/document/d/1mRErUMII_gSSPaHmxyn31UOYWUaZLj0xOaezekxD2-Y/edit?usp=sharing (Internal only)

Change-Id: I7302e1641d257029d67f189ef427823704fccdf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929577Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720621}

net/if.h can conflict in confusing ways with linux/if.h (discovered in
the process of some out-of-tree jumbo experiments), but thankfully we
don't need the net/if.h include here.

Change-Id: Ic9784c5d56cf896a56b8c1b989888607d09a3289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944847Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#720620}

Report animation smoothness for the transition into the hotseat in the
HomeLauncher.

The original change caused use-of-uninitialized-value flaky tests. This
is a possible fix for the issue by explicitly resetting the
|animation_metrics_reporter_|

Bug: 1022178, 1022177, 1028255
Change-Id: I9abe9532e4f8b8cbc8c3700b21db48144f76f767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940562Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720619}

Bug: 984550
Change-Id: Ieb35138ec94f70d3e8e3064fc013f8266ef09a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885218Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720618}

https://skia.googlesource.com/skia.git/+log/b97a24a009a1..2e3be5648a9f

git log b97a24a009a1..2e3be5648a9f --date=short --first-parent --format='%ad %ae %s'
2019-12-02 reed@google.com Reland "fix sense of ifdef for deprecated method"

Created with:
  gclient setdep -r src/third_party/skia@2e3be5648a9f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: I460c2bfc02aec683c5c7711ab50b0ede38178b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720617}

Bug: 1027426
Change-Id: I22940610369f88a933c85860dcd6aa97defcb8cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941191Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720616}

This function is dead since r715492.

Bug: None
Change-Id: I22fef49eed2d5e084630b7e94cbbf57056635462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945921
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720615}

Bug: 1007716
Change-Id: I89645eb8831a0f28a762c84e092b866e96bea1fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939846Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720614}

The |tabs_used_in_bg_| field wasn't properly set for the (rare) cases
where the site data reader is available synchronously.

Change-Id: Ida586be452cff80e74088df6d081bfc79899b26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943535
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720613}

Change-Id: If92e2b949ae2792b1cde8b56bd394654897b76e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945956
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720612}

This change fixes a bug in the extension error bubble in which that
bubble shows two "Details" buttons.

This was ultimately caused by the fact that
GlobalErrorWithStandardBubble defined this method:

  virtual bool ShouldUseExtraView();

When this method returned true, GlobalErrorBubbleView was supposed to:

1) Not have a Cancel button, even if there was Cancel button text
2) Add a button in the extra view slot whose text was the Cancel button
   text
3) Call the GlobalErrorWithStandardBubble back via the cancel pressed
   method when that extra button was pressed

This was used to add a "Details" button to extension errors.
Unfortunately, the condition in (1) led to code like this:

  if (!ShouldUseExtraView() && has_cancel_text)
    AddCancelButton();

which looks like a bug, and so in 74eb4979 I "corrected" it in the
obvious manner. That led to there being two cancel buttons in this
instance. :(

This change:
1) Adds first-class support to GlobalErrorWithStandardBubble for a
   "details" button slot, independent of the cancel & accept buttons
2) Migrates ExtensionErrorUIDefault to use that mechanism
3) Removes GlobalErrorWithStandardBubble::ShouldUseExtraView

Bug: 1024995
Change-Id: I31fe6a7a1d64f0bca2d7abd524650954b4579286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933205Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720611}

https://android.googlesource.com/platform/external/perfetto.git/+log/27076e27131f..7724a9414f89

git log 27076e27131f..7724a9414f89 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 zakerinasab@google.com Merge "Add Vulkan memory tracker config to trace config"

Created with:
  gclient setdep -r src/third_party/perfetto@7724a9414f89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If02c245ccb8fa4132b651fc0a982f78dad061b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720610}

We now only define shard_num and shard map location
in bot_platforms.py.

Bug: 902089
Change-Id: I101743f3a4aaa2291d2dba03d7338d9dbe03798c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941273
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720609}

Bug: 1012203
Change-Id: I5f10793d64cc6a5b64908387dab26e722abf275e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943236Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720608}

Bug: 1007749
Change-Id: Ifd172b7913f2f50c5513c446db7e14731f965039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941055Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720607}