GitLab

When Chrome is in forced tablet mode (--force-tablet-mode=touch_view)
and display rotation is set through setDisplayProperties(),
ScreenOrientationController::GetCurrentOrientation() keeps returning
landscape-primary regardless of the rotation. It prevented some tests
from working as intended.

TEST=tast run eve-DUT arc.SoftInputMode
BUG=1032881

Change-Id: I2b40db9fea2af4a066a0fb8f4d37a870b87d603b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032693Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738398}

Removed usage of deprecated methods.

Merge-With: eureka-internal/358999

Bug: Internal b/148628557
Test: bindings_manager_cast_browsertest, unittests.
Change-Id: I435e9cf0e5a5a19e178c10d4cf99eef5ce4b36b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037028Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738397}

Reland "[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key."

This is a reland of 2292ef33

This change addresses the bug in which the color picker selection
ring gets placed in the top left corner after closing a color picker
with (255,255,255) is selected.

Bug: 1046648
Change-Id: I78e0fd3175ad1b1cfac9226dc451062ec9e14b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036346
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738396}

Currently, popup tabstrip doesn't update when user uses swipe gesture
to switch between tabs. This CL fixes this issue and adds some tests.

Bug: 1048732
Change-Id: I967769ccec7dc7220a7528b72c628e0f76fc1cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037835Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738395}

WebLayer was crashing in Monochrome because BundleUtils.setIsBundle()
was never called.

This looks like it was caused by http://crrev.com/c/1989243.

Bug: 901465
Change-Id: I6f2220b3def3d1783677f8a48b5b4555fd896bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036267
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738394}

Sync.EncryptEverythingWhenCryptographerNotReady has a better
alternative - filtering by passphrase type.

HasAccessToken* histograms are buggy and replaced by
NigoriConfigurationWithInvalidatedCredentials histogram.

Bug: 1036875, 1037330
Change-Id: Ic4b590b7a6b8d7f5ecf19607b3a2c5852fd0e0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035978Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#738393}

In the popup TabStrip used by Duet-TabStrip integration, there is a
crash in RecycleView when user very intensively clicks on the TabStrip
favicon to close multiple tabs. The stack indicates that the
recyclerView is trying to remove the same ViewHolder in two consecutive
remove operations, and the second call would crash. The fix introduced
in this CL is to early end the animation if we know for sure that this
item is going to be removed. This should help with better identifying
the ViewHolder to remove.

This fix is inspired by the discussion here:
https://b.corp.google.com/issues/34184109
and the CL here:
https://critique.corp.google.com/#review/188055979/depot/google3/java/com/google/android/apps/play/music/app/ui/common/MediaListRecyclerFragment.java
Even though we early end the animation, there should be no visible
animation change from the UI perspective.

Bug: 1045944
Change-Id: I0d8a7b098e17cdc86c4ae3227cd9dc1ba37b2adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036874
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738392}

Currently, when user uses swipe gesture to switch from a single tab to
a tab in tab group, the tab strip doesn't show up. This is due to this
tab selection doesn't fire a reset tab strip event. This CL fixes this
issue and adds tests.

Bug: 1048824
Change-Id: I05ad51709eb6274afc41f4fc6ddbd8ce396640a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037844Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738391}

PS1 is the original reland, PS2 is the re-reland, including:

 1. A fix for the original problem in structured_metrics_provider.cc
 2. A test covering that case into s_m_p_unittest.cc
 3. A deleted include that's no longer necessary after another CL.

This is a reland of 4b79ed37

Original change's description:
> Reland "[Structured metrics] Add metric collection and upload logic."
>
> This is a reland of 2fe77415
>
> Original change's description:
> > [Structured metrics] Add metric collection and upload logic.
> >
> > This is the final CL for the core of the structured metrics system. It
> > ties together the KeyData class (for managing keys and computing hashes)
> > with the metrics provider, and implements logic to:
> >
> >  1. Hash and store incoming structured metrics events.
> >  2. Provide stored metrics events for upload.
> >
> > It also adds integration tests for the system, checking that an event
> > created through the public API is correctly prepared for upload.
> >
> > Other misc changes:
> >
> >  - Some minor refactoring of event_base.{h,cc} and equivalent changes
> >    to events_template.py, to fix some bad style.
> >  - Added a missing RemoveObserver call to the metrics provider dtor.
> >
> > Bug: 1016655
> > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386
> > Commit-Queue: Tony Yeoman <tby@chromium.org>
> > Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735748}
>
> Bug: 1016655
> Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913
> Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> Commit-Queue: Tony Yeoman <tby@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736590}

Bug: 1016655
Change-Id: I54b06543c5ac3075cd1256d651d3232e6739c7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034387
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738390}

The API docs mention that this flag should be added to buffers destined
for HardwareComposer. It was inadvertantly removed in:
https://chromium-review.googlesource.com/c/chromium/src/+/2036374

R=liberato@chromium.org,vikassoni@chromium.org

Bug: 1021007
Change-Id: If8e3b8f8fad7219829d8866fead24b844baef9df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036486
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738389}

Bug: 1034046
Change-Id: Id471b00549b34887039dcddb3d4c22a6d7f0a9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033428
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738388}

Adds few missing mirrored x transformations for app list folder view:
*    folder_item_icon_bounds_, which is intended to be in the folder
     view's coordinates, were calculated from apps container bounds
     without adjustments for RTL (messing up folder show/hide animation
     original/target bounds)
*    reparent drag location was transformed from folder item coordinates
     in container view to container view coordinates to root apps grid
     view coordinates, both steps without RTL adjustments.

BUG=1048841

Change-Id: I7a158858e6e9067b2711a3b2d53a1f452ad5dd14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037645
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738387}

When calling AXPlatformNodeBase::FindTextBoundary, it would attempt to
get the hypertext of the node, but this was returning an empty string
for UI controls causing ui::FindAccessibleTextBoundary to fail.

This CL merges AXPlatformNodeWin::TextForIAccessibleText into
AXPlatformNodeWin::GetHypertext so that it can handle UI controls.

Bug: 1047906
Change-Id: I84f0f5d1241e9b634b481dbbc49fdefc7c706d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036363Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738386}

The layout test results viewer shows tests that have different results
then the expected results specified in the non flag specific test
expectation files. The results viewer uses the flag and base
expectations per test fields to find these tests. We need to re add
these per test fields.

Bug: 1047602
Bug: 986447
Change-Id: I0bf603b13672e6b97a3840275c8670a13679e830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036359
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738385}

Make CachedMetrics during initialization have 50% chance to have all
histogram samples bypass it's cache and immediately forward metrics to
RecordHistogram (which now uses CachingUmaRecorder).

The state of the bypass is reported with a synthetic field trial:
 -  AndroidCachedMetrics.Control
 -  AndroidCachedMetrics.HistogramsBypassCache

Bug: 1046181
Change-Id: I7fe1d9d4edf6ccf8a6b2dde0348324aaf797f032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031443
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738384}

This replaces the indefinite blocking during pulse::InitPulse() with a
timed wait of 5 seconds. We will now fall back to ALSA if we fail to
connect to pulse within that time.

I suspect this has the same root cause as issue 986021, but the fix
for those hangs disabled the audio process, which makes the browser
process now hang on startup.

R=jrummell

Bug: 986021, 1047655
Test: Local tests with manual shutdown of Pulse fall back to ALSA.
Change-Id: I337ef88bd953f56ef0bd9969a42f190200520a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037817
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738383}

What: This relands http://crrev/c/1993140 that was reverted in
http://crrev/c/2035374. The diff:
in OverlayInterstitialAdDetector::MaybeFireDetection, switch to
main_frame->ContentLayoutObject()->HitTestNoLifecycleUpdate for the hit
test.

Why: We don't need LocalFrameView::UpdateAllLifecyclePhasesExceptPaint
as we don't need to recurse into child document. Forcing the update
would change the document lifecycle state, that would break the test
expectations of FrameThrottlingTest.ThrottledLifecycleUpdate and would
introduce flakes for AccessibilityActionBrowserTest.ImgElementGetImage.


Bug: 1047921
Change-Id: Ic99420e125788d446bb11202848634ddc6e07841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034054
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738382}

This change makes UpgradeDetector an observer of the process's
BuildState, removing its own detection. It instead creates an instance
of either an InstalledVersionPoller (for desktop Chrome) or an
InstalledVersionUpdater (for Chrome OS) to do the actual detection work.

BUG=1043624

Change-Id: Ib04b0f588a3d035f2ce0300561ed86d9024c7b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017352
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738381}

FeatureUtilities is not accurate anymore, as this shouldn't contain
code for specific features anymore, and it is (and has been) a
stateful class.

The responsibility of this class is to cache feature flags for use
without native being loaded.

This is CL 3/5 for renaming FeatureUtilities.

Bug: 1012975
Change-Id: I8b4c72a65361379ec34272bdff55edf416d35b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028111
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738380}

This patch introduces variants of:
Resolve{Main,Min,Max}{Inline,Block}Length

With a callback function to provide the MinMaxSize, or IntrinsicBlockSize
as needed.

This in instead of logic used by other algorithms via. NeedMinMaxSize
et. al.

There are pros/cons to this approach:
Pro - Much more precise (and easier to maintain) calls to
      NGBlockNode::ComputeMinMaxSize and NGBlockNode::Layout.
Con - Duplicate logic for Resolve*Length.

I tried moving Resolve*InlineLength to all being callback based but some
other refactoring needs to occur first (mainly an additional ng cache).

An alternate version of this patch would be either:
1) A NeedsMinMaxSize / NeedsIntrinsicBlockSize similar to other callers
   of these functions.
2) Adding the branch before the Resolve*Length calls to check if we
   need to provide the appropriate argument.

Bug: 845235
Change-Id: I8e26e0171adc60a7e3d244af3cb21e119b2653f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027075Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738379}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a3ade44d9f4..cecc4d627631


Created with:
  gclient setdep -r src-internal@cecc4d627631

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I1d0910de3a5a395180e1a6b1953c5aa838b415a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037696Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738378}

This reverts commit 919ba484.

Reason for revert: New test PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported is consistently failing on linux-chromeos-chrome.  First failing build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2687.

Test output (CRASH):
[ RUN      ] PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported
[1:1:0204/141234.652201:WARNING:hugepage_text.cc(182)] The ordering seems incorrect, fall back to small page
[7821:7821:0204/141234.715769:WARNING:audio_manager_linux.cc(52)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
[7821:7884:0204/141234.746168:ERROR:arc_property_util.cc(224)] arc-build-properties is not found
[7821:7884:0204/141234.746216:ERROR:arc_property_util.cc(276)] Failed to read /usr/share/arc/properties/default.prop: No such file or directory (2)
[7821:7884:0204/141234.746237:ERROR:arc_property_util.cc(295)] Failed to expand /usr/share/arc/properties/default.prop
[7821:7821:0204/141234.760051:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.761643:ERROR:proximity_auth_profile_pref_manager.cc(189)] Failed to find local state prefs for current user.
[7821:7821:0204/141234.816422:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.824119:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.827132:WARNING:remote_commands_service.cc(40)] Client is not registered.
[7821:7821:0204/141234.831227:WARNING:wallpaper_controller_client.cc(370)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[7821:7821:0204/141234.872150:ERROR:account_manager_migrator.cc(256)] Could not find a refresh token for the Device Account.
[7821:7821:0204/141234.876165:WARNING:drivefs_session.cc(62)] DriveFs mount failed with error: 3
[7821:7908:0204/141234.954453:WARNING:google_brand_chromeos.cc(39)] Brand code file missing: /opt/oem/etc/BRAND_CODE
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x55a6a7352149 base::debug::CollectStackTrace()
#1 0x55a6a72c17b3 base::debug::StackTrace::StackTrace()
#2 0x55a6a782e765 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f81d61164b0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354af)
#4 0x55a6a7a68a22 net::test_server::EmbeddedTestServer::DoAcceptLoop()
#5 0x55a6a730574f base::TaskAnnotator::RunTask()
#6 0x55a6a731511a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#7 0x55a6a7314eb7 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()
#8 0x55a6a736d6a9 base::MessagePumpLibevent::Run()
#9 0x55a6a73159c8 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#10 0x55a6a72efb57 base::RunLoop::Run()
#11 0x55a6a7328939 base::Thread::ThreadMain()
#12 0x55a6a735f3ce base::(anonymous namespace)::ThreadFunc()
#13 0x7f81d9fbf6ba start_thread
#14 0x7f81d61e841d clone


Original change's description:
> Reland "[Payments]Don't show "add card" button when basic card is not requested."
> 
> This is a reland of 08e5b730. The cl
> got reverted because of the added test failing on ChromeOS_Chrome_Linux
> build.
> 
> Original change's description:
> > [Payments]Don't show "add card" button when basic card is not requested.
> >
> > This is a Desktop only change to ensure that the "add card" button is
> > shown in payment method window only when the "basic card" method is
> > supported.
> >
> > Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923
> > Commit-Queue: Sahel Sharify <sahel@chromium.org>
> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735978}
> 
> TBR=rouslan@chromium.org
> 
> Change-Id: I90d4febb944d48cfe009c0c0e1511f9d493d1762
> Bug: 1046514
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037639
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738334}

TBR=rouslan@chromium.org,sahel@chromium.org

Change-Id: Idfe37889ed1bc2effd9bec6ae075559c293a0fcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037828Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738377}

AppServiceAppItem is used to replace InternalAppItem. Update the unit
test to use AppServiceAppItem.

BUG=1016159

Change-Id: I659cd43fea543578ab4b6d7df6c1e7f57941cbdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037175Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738376}

A similar DCHECK was removed in
http://crrev.com/0a0c3a85f4eeb668acc87dbc575405c6026971a1

The check is unnecessary, and is a no-op in release builds. The host
is meant to run as root for the login screen when curtain-mode is not
enabled.

Bug: 1020739
Change-Id: I5f764611b745ce58c47353b63678fbbadb3a68f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037466
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738375}

The affected targets are:
* components/send_tab_to_self/proto:send_tab_to_self_proto
* chrome/browser/web_applications/proto

Various sync .proto file imports were updated by running:
find components/sync/protocol/ | grep "\.proto$" | xargs sed -i 's/import \"/import \"components\/sync\/protocol\//g'

Bug: 1039009
Change-Id: I56bfae1ae47608bc3c4c4d27ea14f8cd13e8f43c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988862
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738374}

Using wpt-import in Chromium 56f7e59b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ib3ad10069334748afcea611f447e090827436963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037507Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738373}

The assistant service runs in the browser process on the UI thread.
There aren't any plans to move it out of process. Instead of using
the identity service, inject a pointer to the C++ IdentityManager
and use it to look up access tokens.

This reduces the number of customers of the identity service from
2 to 1.

Bug: none
Change-Id: I6a5155306f8ad433c4805fa6acd83f7606ca7412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033572
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738372}

No change to logic. This exposes chrome_public_manifest_package as a GN
arg to support WebView developers who wish to compile
monochrome_public_apk. This updates WebView docs to mention the new GN
arg.

Bug: 1048327
Test: gn args out/Default --list=chrome_public_manifest_package
Test: out/Default/bin/monochrome_public_apk package-info
Test: tools/md_browser/md_browser.py android_webview/docs/build-instructions.md
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Iba14d6eae3bdde7cde8f7be1c0df29cd8674d8d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036381Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738371}

Reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2032049
with fixes so avoid failing ChromeCustomTabsConnectionTest
(crbug.com/1048438).

Instead of runNowOrAfterNativeInitialization(), the method should
enqueue tasks to run when full browser starts, and not when native is
started. There is a distinction - reduced mode means native is started but full browser, which includes Profiles, isn't.

This fixes a crash when transitioning from reduced mode to full browser if a task that uses Profile was scheduled with
runNowOrAfterNativeInitialization(). Now, it will only run after the
transition, rather than immediately.

Also change hasNativeInitializationCompleted() to
isFullBrowserInitialized() and update clients. All but DownloadMetrics are meant to run in full browser, so that should actually revert their behavior back to what it was before reduced mode was introduced.

DownloadMetrics still checks if native was loaded, which includes in
reduced mode.

Bug: 1045945, 1014098, 1048438
Change-Id: If99179a5720d7e550ee5653a8625021f58fc262e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037818Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738370}

Also to be consistent with dm_api.proto which is used on DMServer:
cl/293161272.

The field is not yet used anywhere, so it's safe to rename.

Change-Id: Ib348ae4c0504a71cfebf0df516b26afecfb971e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035988Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Cr-Commit-Position: refs/heads/master@{#738369}

Test: manual
Change-Id: Id3142bbe89caa2aa002f0b41f846bb885f6b56a2
Fixed: 1048315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037715Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738368}

The |kAutofillAssistantDirectActionsName| constant is only declared for
OS_ANDROID in flag_descriptions.h, but is defined for all platforms in
flag_descriptions.cc. This did not trigger a compiler warning because
the definition has an erroneous extern keyword. Remove the extern
keyword and move the constant to the right spot. Do the same for
|kAutofillAssistantDirectActionsDescription|.

Change-Id: I0a8b174a2a27a360a97d0ffa7f5e69c110d2f970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025248Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738367}

This CL fixes the bug where extensions remain disabled with reason
custodianApprovalRequired even after supervision is removed. This CL
accomplishes this by removing supervised user related disable reasons
on startup if the logged in profile is not a child account.

Bug: 1045625
Change-Id: I35491e240610334aa9665cddc0c9f4fa0ea00037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026172Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738366}

- Changed the path to the simulator shared resources directory, where
the app also write rights, and won't be deleted after app is killed.
- Added "%m" to the file name, so that on-line profile merging is
enabled.
- Added a generated UUID to the file name, so that there won't be a
conflict when multiple apps are launched in one test suite.

Please see ios code coverage design doc for rationales of those changes:
go/bling-code-coverage-doc.

Bug: 1043273
Change-Id: I21b2c8f4018036fdd13eecbe7e1362c926886eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031673
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738365}

This code is complicating changing the feature, so time to remove it!

Bug: 1048736
Change-Id: Ia410d07f5ae16db540159a2d4b46aaec1731e15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037814Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738364}

Updating the Pixel Wrangler docs section on extending the rotation. Making them
more general for modifying the rotation. With a portion about swapping.

Change-Id: Ief4c3ffc86f87fe924e94900c16b017f38e9ed80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037327Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738363}

This CL makes sure that a correct request_initiator_site_lock is used
when a URLLoaderFactory is pushed to a renderer process
during a ReadyToCommit->DidCommit transition window.  In particular,
during that window it is incorrect to use |last_committed_origin_|
(see the bug for details).

Bug: 1047436
Change-Id: If696a326f162585f42ab0a0ecbe8f8f42f07f5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026168
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738362}

The CL https://crrev.com/737514 fixes an issue with the PDF viewer
extension not loading if another extension injects an additional iframe
into the top-level HTML document for the PDF.

Not caught in the bug description is the fact that PostMessaging support
is also broken; that was discovered (and fixed) while writing the
accompanying test.

Bug: 1046795
Change-Id: I650518162e24e5d961e45b471bfb1518e9b7531c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037343
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738361}

For GAIA password pings, it is currently gated by SB
for >=M79 versions. However, since we are not showing warnings
to the users, these pings should instead be gated by SBER.

Bug: 1048440
Change-Id: I248b78388cb2aff093c67e774e31ee0c711c3499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036286
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738360}

Need this to ensure the quick settings widget is always activated
when focus is transferred from the message center widget.

Bug: 1048127
Change-Id: I6d142ea37bf270712d609024a0d0e09bd5a5d295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036274
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738359}