- 19 Dec, 2016 40 commits
-
-
mlamouri authored
This is temporarily using ::reset() to guarantee backward compatibility and reduce chances of breakage for now. BUG=662761 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2589873002 Cr-Commit-Position: refs/heads/master@{#439503}
-
staraz authored
Fixed typo in color_space.typemap Added color_space.typemap to typemaps.gni BUG=670364 Review-Url: https://codereview.chromium.org/2585213004 Cr-Commit-Position: refs/heads/master@{#439502}
-
xunjieli authored
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester R=mef@chromium.org Review-Url: https://codereview.chromium.org/2587573002 Cr-Commit-Position: refs/heads/master@{#439501}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/879bdc9b40e6..efa9d34ccbde $ git log 879bdc9b4..efa9d34cc --date=short --no-merges --format='%ad %ae %s' 2016-12-16 bungeman Explicit ownership of data in SkBlockMemoryStream. 2016-12-19 scroggo Allow running gn_to_bp.py from another script 2016-12-16 scroggo GIF: Avoid copying/storing data when possible 2016-12-19 msarett Move existing writeICC() code into SkICC Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2588803002 Cr-Commit-Position: refs/heads/master@{#439500}
-
wjmaclean authored
As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= Review-Url: https://codereview.chromium.org/2578873004 Cr-Commit-Position: refs/heads/master@{#439499}
-
blundell authored
This CL enables connections to Mojo services from Blink; more specifically, from //third_party/WebKit/Source/modules, where dependencies on Chromium code are in general undesired (including on Mojo services' client libraries). To enable connecting to services without using the Service Manager's client library, this CL does the following: (1) Adds a method to Platform that exposes the connection to the ServiceManager as a service_manager::mojom::blink::ConnectorPtr. (2) Builds a bare-bones ServiceConnector around this ConnectorPtr that supports connecting to Mojo services by name from Blink. (3) Ports TimeZoneMonitor to be hosted in the Device Service as an example of connecting to an interface that is hosted in a service other than //content/browser from Blink. ServiceConnector being "bare-bones" includes the facts that: - Unlike blink::InterfaceProvider, blink::ServiceConnector is currently thread-hostile. This should be easy to relax using similar mechanisms as InterfaceProviderImpl. - There is currently no API for obtaining an InterfaceProvider for a given service (or a thread-safe wrapper, per the above comment). Again, this should be easy to add. This CL also moves the definition of the device service name to mojom instead of C++ in order to facilitate using this constant from Blink. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. Review-Url: https://codereview.chromium.org/2460723003 Cr-Commit-Position: refs/heads/master@{#439498}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f394e56d2888..2c95066149e8 $ git log f394e56d2..2c9506614 --date=short --no-merges --format='%ad %ae %s' 2016-12-19 jbudorick [py_utils] Add empty and optional context managers. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2587053002 Cr-Commit-Position: refs/heads/master@{#439497}
-
dougarnett authored
Adds api to Coordinator. Does not yet add Java bridge api support. Also, cleans up some terminology wrt immediate*callback when not necessarily immediate mode only. BUG=672584 Review-Url: https://codereview.chromium.org/2570433007 Cr-Commit-Position: refs/heads/master@{#439496}
-
poromov authored
When Kiosk app is just installed from Play, "OnAppRegistered()" is called, but ArcKioskAppService didn't know about Kiosk app id. Now it retrieves app id if not know yet. BUG=674776 Review-Url: https://codereview.chromium.org/2584813002 Cr-Commit-Position: refs/heads/master@{#439495}
-
alexilin authored
Before this we only had tests for filling predictor database. This CL adds test that prefills database and then activates prefetching on the same web page. Then it checks that cache actually has been populated by prefetched resources. BUG=650253 Review-Url: https://codereview.chromium.org/2553083002 Cr-Commit-Position: refs/heads/master@{#439494}
-
sdefresne authored
Revert of Upstream Chrome on iOS source code [11/11]. (patchset #1 id:1 of https://codereview.chromium.org/2589843002/ ) Reason for revert: Fail compilation on the waterfall. Original issue's description: > Upstream Chrome on iOS source code [11/11]. > > Upstream all BUILD.gn changes to enable compilation of the code > that has been upstreamed by the previous ten CLs and changes to > browser_state_keyed_service_factories.mm to use the new factory. > > Update the default provider factory to use chromium provider (it > will be merged with ChromeBrowserProvider eventually). > > BUG=653086 > R=pinkerton@chromium.org, rohitrao@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277eaf132dce4831 TBR=rohitrao@chromium.org,pinkerton@chromium.org,agrieve@chromium.org,markusheintz@chromium.org,blundell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653086 Review-Url: https://codereview.chromium.org/2589883002 Cr-Commit-Position: refs/heads/master@{#439493}
-
Sylvain Defresne authored
Upstream all BUILD.gn changes to enable compilation of the code that has been upstreamed by the previous ten CLs and changes to browser_state_keyed_service_factories.mm to use the new factory. Update the default provider factory to use chromium provider (it will be merged with ChromeBrowserProvider eventually). BUG=653086 R=pinkerton@chromium.org, rohitrao@chromium.org Review-Url: https://codereview.chromium.org/2589843002 . Cr-Commit-Position: refs/heads/master@{#439492}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/746cc0b92290..879bdc9b40e6 $ git log 746cc0b92..879bdc9b4 --date=short --no-merges --format='%ad %ae %s' 2016-12-19 egdaniel Temorarily remove Vulkan NexusPlayer bots till we can fix them 2016-12-19 borenet Roll Recipe DEPS Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2583203002 Cr-Commit-Position: refs/heads/master@{#439491}
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium 82befc59. Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7834 TBR=qyearsley@chromium.org NOEXPORT=true Review-Url: https://codereview.chromium.org/2588723002 Cr-Commit-Position: refs/heads/master@{#439490}
-
dgn authored
Unties Node construction with the initialisation of their parent and children. This allows controlling when the notifications about child modifications are propagated, and simplifies the initialisation order. The InnerNode#setParent() call is now what enables the notifications and is done as the last step of the NewTabPageAdapter constructor. ChildNode and InnerNode share almost all of the logic related to managing the tree and their implementations make use of that without specific modifications. This also fixes some bugs related to resetting the section list. BUG=616090,674023 Review-Url: https://codereview.chromium.org/2573173002 Cr-Commit-Position: refs/heads/master@{#439489}
-
zqzhang authored
Previously, MediaSessionImpl uses the metadata and controls to determine whether a page uses the MediaSession API. However there comes an issues that we need to update the routed MediaSession every time when a service is created/destroyed or its metadata/controls changed, which is a lot of maintainance work. This CL simplifies the MediaSessionService routing strategy. It only checks whether a service is created for a given frame. The rationale is that a MediaSessionService is created when and only when anything passes through mojo, which is enough for indicating whether a frame uses MediaSession API. BUG=670319 Review-Url: https://codereview.chromium.org/2585243002 Cr-Commit-Position: refs/heads/master@{#439488}
-
wjmaclean authored
Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (patchset #6 id:140001 of https://codereview.chromium.org/2551223003/ ) Reason for revert: Seems like a likely cause for failures on: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Faccelerometer.html&testType=webkit_tests Original issue's description: > [Sensors] Align sensor reading updates and 'onchange' notification with rAF. > > For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption. > > Before this change a timers were used and this could unnecessarily drain CPU and battery. > > BUG=668052 > BUG=606766 > > Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb > Cr-Commit-Position: refs/heads/master@{#439467} TBR=reillyg@chromium.org,alexander.shalamov@intel.com,haraken@chromium.org,foolip@chromium.org,mikhail.pozdnyakov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668052 Review-Url: https://codereview.chromium.org/2590513002 Cr-Commit-Position: refs/heads/master@{#439487}
-
rouslan authored
PaymentRequest.canMakePayment() should return true if user has a payment app with an instrument or a credit card with valid name and number. BUG=674926 Review-Url: https://codereview.chromium.org/2558993003 Cr-Commit-Position: refs/heads/master@{#439486}
-
mlopatkin authored
R.java and R.txt files for an AAR were generated by extracting all resources from the AAR and its dependencies and running aapt on these resources. This approach turned out to be problematic for AARs of GMS (Play Services). GMS is shipped as a bunch of AARs with dependencies between them. However the way it deals with resources is rather unusual. GMS code references all resources via com.google.android.gms.R class that corresponds to the "basement" AAR. This AAR has R.txt with entries for all resources of the GMS but contains only a small subset of the resources. All other resources are provided by other AARs: they have different packages and no R.txt files though. The consumer of the GMS must generate com.google.android.gms.R class with entries for all resources provided by used GMS AARs. Entries for resources that belong to the unused AARs may be ommited. This is what Gradle plugin for Android does. However AAR support in Chromium discarded R.txt from "basement" then generated very small com.google.android.gms.R without essential entries and this caused crashes in runtime. This CL changes processing of the AARs resources. If R.txt is present in AAR then aapt-generated R.txt is discared. The one from AAR is used to generate R.java for java dependencies of the AAR target and to generate final R.java file during APK build which is compiled and included into the final APK. During obfuscation Proguard checks that all entries that are referenced in code were in fact generated. This check cannot be done during resource processing because "basement"'s R.txt lists resources that aren't included in Chromium and this is because code that uses these resources isn't included either. BUG=670368 R=agrieve@chromium.org,dgn@chromium.org Review-Url: https://codereview.chromium.org/2570313002 Cr-Commit-Position: refs/heads/master@{#439485}
-
primiano authored
Partition Alloc, which has been recently moved to base/, has tests that rely on the ability to successfully make large (512 MB) allocations. Turns out this is not possible on small devices like ChromeCast, that seem to either have little overcommit margins or a heavily fragmented address space. This CL skips those tests on devices that have < 2 GiB of physical memory. For the same reason, it lowers down the chunk size of the RepeatedReturnNullDirect test. The rationale of the test is to check that repeated failures are handled consistently when performing directly mapped allocations. The chunk size is irrelevant as long as it is big enough to hit the directly-mmap codepaths (current threshold = 1 MB). BUG=675255 Review-Url: https://codereview.chromium.org/2589813002 Cr-Commit-Position: refs/heads/master@{#439484}
-
rune authored
The media controls are (at least sometimes) painted twice. The second time after figuring out how many buttons fit into the available width. At least one of the fullscreen tests were flaky because the first paint was dumped instead of the second one. Adding a layoutAndPaintAsyncThen in the full-screen-test.js framework seems to fix the issue. Although the issue was filed after landing changes for issue 567021, the flakiness is also seen locally without those changes running the test with --repeat-each=30 in debug. R=fs@opera.com TEST=virtual/android/fullscreen/full-screen-stacking-context.html BUG=675055 Review-Url: https://codereview.chromium.org/2586243002 Cr-Commit-Position: refs/heads/master@{#439483}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4fc181694898..f394e56d2888 $ git log 4fc181694..f394e56d2 --date=short --no-merges --format='%ad %ae %s' 2016-12-19 jbudorick [py_utils] Add temporary directory context manager. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2590503002 Cr-Commit-Position: refs/heads/master@{#439482}
-
fdoray authored
This will allow code to be reused to initialize TaskScheduler based on variation params in renderers. To avoid breaking ios-internal, this CL keeps existing components/task_scheduler_util APIs. Code in ChromeContentBrowserClient and ios-internal will be migrated to the new APIs in separate CLs. Then, old components/task_scheduler_util APIs will be deleted. TBR=blundell@chromium.org BUG=664996 Review-Url: https://codereview.chromium.org/2565013002 Cr-Commit-Position: refs/heads/master@{#439481}
-
pilgrim authored
As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/core/events/, fetch/, fileapi/, and frame/. There are too many references to change them all at once, so this CL is part 6 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2585283002 Cr-Commit-Position: refs/heads/master@{#439480}
-
simon.hosie authored
Fixes compilation failure introduced by c3ac4fc0. fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and gives the result as an int. If char is unsigned it's impossible for EOF to match, and this results in a compilation error. If char is signed then potentially valid input could match EOF. BUG=674765 R=altimin@chromium.org, skyostil@chromium.org Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec Review-Url: https://codereview.chromium.org/2579773003 Cr-Commit-Position: refs/heads/master@{#439479}
-
pavely authored
Recent change caused passphrase dialog to show "On - sync everything" instead of "Signed in as <email>" on Passphrase dialog on android. I'm reverting this behavior. R=maxbogue@chromium.org BUG=674733 Review-Url: https://codereview.chromium.org/2584973002 Cr-Commit-Position: refs/heads/master@{#439478}
-
xunjieli authored
Use use_partition_alloc=false GN arg in Cronet BUG=674570 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2577173002 Cr-Commit-Position: refs/heads/master@{#439477}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/a8b1e6d0688c..746cc0b92290 $ git log a8b1e6d06..746cc0b92 --date=short --no-merges --format='%ad %ae %s' 2016-12-18 update-skps Update SKP version 2016-12-17 reed simplify generatescaledpixels Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2580393002 Cr-Commit-Position: refs/heads/master@{#439476}
-
sdefresne authored
Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Review-Url: https://codereview.chromium.org/2580333003 Cr-Commit-Position: refs/heads/master@{#439475}
-
fs authored
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so make sure to convert the float FEMorphology stores avoiding overflow. BUG=675164 Review-Url: https://codereview.chromium.org/2585233002 Cr-Commit-Position: refs/heads/master@{#439474}
-
sdefresne authored
Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Review-Url: https://codereview.chromium.org/2588733002 Cr-Commit-Position: refs/heads/master@{#439473}
-
robertphillips authored
This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL) The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016. BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2573803002 Cr-Commit-Position: refs/heads/master@{#439472}
-
sdefresne authored
Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Review-Url: https://codereview.chromium.org/2587023002 Cr-Commit-Position: refs/heads/master@{#439471}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c4767f..af5c10c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2587913003 Cr-Commit-Position: refs/heads/master@{#439470}
-
sdefresne authored
Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Review-Url: https://codereview.chromium.org/2589583003 Cr-Commit-Position: refs/heads/master@{#439469}
-
mlamouri authored
Instead of having a 2 seconds timeout, using a combination of setTimeout of 0 and requestAnimationFrame. BUG=513398 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2586223002 Cr-Commit-Position: refs/heads/master@{#439468}
-
mikhail.pozdnyakov authored
For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption. Before this change a timers were used and this could unnecessarily drain CPU and battery. BUG=668052 BUG=606766 Review-Url: https://codereview.chromium.org/2551223003 Cr-Commit-Position: refs/heads/master@{#439467}
-
sdefresne authored
Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Review-Url: https://codereview.chromium.org/2589803002 Cr-Commit-Position: refs/heads/master@{#439466}
-
skyostil authored
This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 Review-Url: https://codereview.chromium.org/2584513002 Cr-Commit-Position: refs/heads/master@{#439465}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/64b70b096ac2..a8b1e6d0688c $ git log 64b70b096..a8b1e6d06 --date=short --no-merges --format='%ad %ae %s' 2016-12-19 rmistry Revert of Generate Signed Distance Field directly from vector path (patchset #23 id:440001 of https://codereview.chromium.org/1643143002/ ) Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2586983002 Cr-Commit-Position: refs/heads/master@{#439464}
-