- 23 Sep, 2020 40 commits
-
-
Caitlin Fischer authored
This implements the new GOOGLE_WEB_PROPERTIES_FIRST_PARTY and GOOGLE_WEB_PROPERTIES_TRIGGER_FIRST_PARTY variations types, which allow us to limit the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Adding support for this involved sending a map of headers rather than a single header to the renderer. A map is used because the request context is unknown until the process of sending the request has started. So, the renderer needs to know the appropriate headers to send in first- and third-party contexts. Bug: 1094303 Change-Id: I447219b1cc80b0dc8552b440e6ad07b2fdb15d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411489Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#809756}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when |Navigator.javaEnabled| is called. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I5d6c24996680d9776a34300ed765a614a9518fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423585Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#809755}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: Id621eb8c0c4cd388c09f30cf7ea4937fc566eadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424511Reviewed-by:
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Change-Id: I25fddca92048669e25674070b0f619368270346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424073Reviewed-by:
-
Sigurd Schneider authored
This allows to expose certain methods only on the impl, not on the public interface. Bug: chromium:1069378 Change-Id: I3623aadb5f9d9ebb7f2dae4c78cb830ee74f55b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426043Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#809752}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/edd7f9e94d43..aac41bd6780a 2020-09-23 sprang@webrtc.org Removes dead fallback code from rtcp::CompoundPacket. 2020-09-23 titovartem@google.com Introduce debug network stats 2020-09-23 kron@webrtc.org Add field trial to force outgoing video playout delay 2020-09-23 alessiob@webrtc.org AGC2 saturation protector: simplify interface and impl 2020-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f294a94c..590f451b (808500:809630) 2020-09-22 hta@webrtc.org Revert "Remove stopped transceivers at both local and remote SetDescription" 2020-09-22 alessiob@webrtc.org AGC2 Saturation Protector: switch to ring buffer 2020-09-22 ilnik@webrtc.org Make VP9 correctly accept middle-layer singlecast 2020-09-22 sprang@webrtc.org Reland: Wires up WebrtcKeyValueBasedConfig in media engines. 2020-09-22 kwiberg@webrtc.org RTC_LOG: Fix bug introduced in a recent CL 2020-09-22 handellm@webrtc.org common_video/h264: Make ssilkin@webrtc.org owner. 2020-09-22 chunbo.hua@intel.com Strip AUD NALUs from H.264 bitstream 2020-09-22 nisse@webrtc.org Delete video source proxying in WebRtcVideoSendStream 2020-09-22 hta@webrtc.org Remove stopped transceivers at both local and remote SetDescription 2020-09-22 kwiberg@webrtc.org RTC_LOG: Internally, pass logging severity as template argument 2020-09-22 kwiberg@webrtc.org RTC_LOG: Remove unnecessary optimization 2020-09-22 kwiberg@webrtc.org RTC_LOG: Mark a trivial function with `constexpr` 2020-09-22 asapersson@webrtc.org Make LibvpxVp8Encoder::GetCpuSpeed() to always read from CpuSpeedExperiment for arm. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia2e5e6d7813b3c7c2c629b531fd9418e28fba9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809751}
-
Christian Dullweber authored
Show amount of used storage in cookies page in PageInfo. Fix cookie deletion by using a populated website object. Screenshot: https://crbug.com/1077766#c46 Bug: 1077766 Change-Id: Ifce703ba4af9bdd14da8403516871b7c8001eb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416371 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809750}
-
Monica Basta authored
This CL adds a cr-customize-themes element to chrome://settings/manageProfile page behind a feature flag. This CL focuses on the native side and it doesn't include necessary style changes which will be included in future CLs. When the UI is ready, this element will be put under the "NewProfilePicker" feature. In order to use a cr-customize-themes component in WebUI, a WebUIController class must enable mojo bindings and implement customize_themes::mojom::CustomizeThemesHandlerFactory interface. This CL applies these necessary changes to SettingsUI. Screenshot with the feature flag enabled: https://drive.google.com/file/d/1W1NITMHGbzHRzq1LeClp96Mh98B2MNGv/view?usp=sharing Bug: 1129186 Change-Id: I18ead20f57e3bb0486e4821a946ea4e0aff3a242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414301 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809749}
-
Maksim Sisov authored
We got some reports that include log where we could see that chrome used a format which doesn't support scanout. However, it's unclear what exactly happens. Thus, this patch adds additional information that will include the buffer format the chrome tries to use. Bug: 1128997 Change-Id: I09774bd506d624d4db05acc92c6a20884b664e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424198 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809748}
-
David Grogan authored
Without a specified height, the rects should have received a 0 height. It appears these tests passed in Chrome because of a Blink SVG bug that gave the rects a height. These tests didn't pass in Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1666643 Change-Id: I13053947e343572426f4e584d68bc52191482f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425723 Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809747}
-
Nohemi Fernandez authored
Bug: 1131027 Change-Id: I02a1824f34d25c29d4a67f66b362514d63963236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424163 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#809746}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600840405-46e4cd70bd3de973a171c7f611770f78487d203a.profdata to chrome-linux-master-1600861496-aa5ced2b846bf1462377e76f5270436b4108dec5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ie6b83afd0777afc19e1f57e4118a85e8ca42c987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426283Reviewed-by:
-
Egor Pasko authored
This reverts commit f889004d. Reason for revert: http://crbug.com/1130358#c13 Original change's description: > Reland: PR_SET_DUMPABLE 1 briefly if opening pagemap fails > > This is often necessary on Android to read /proc/self/pagemap. Without > prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on > Canary. This potentially leads to bias in reporting > MappedAndResidentMemoryFootprint2. > > What happened since it last landed as http://crrev.com/808298: > * Setting the process back to non-dumpable was often returning an error > and hitting a (P)CHECK > * In crash dumps logcat started right at the failure, so it is not > possible to see whether prctl(PR_SET_DUMPABLE, 1) succeeded prior to > the failure, my guess is that it failed too > * In the reland, avoid prctl(SET_DUMPABLE, 0) if prctl(SET_DUMPABLE, 1) > failed before that > > Bug: 1070618 > Change-Id: Ic9bfbdad6c72a1388eb80c3b6c9e6c772c8e431c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421730 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809373} TBR=pasko@chromium.org,ssid@chromium.org,rsesek@chromium.org Change-Id: I3ae4695cca87eb4e878a195f84352fd5f19889d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425053Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809744}
-
Fabio Tirelo authored
The tests for URLBlocklist and URLAllowlist already exist, but they are not enabled on Android. Enabling them to prevent future regressions. Bug: 1131160 Change-Id: I6c4139ee2e3b65d7405a256dbeaf562bdf0854c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424493Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809743}
-
Tim Schumann authored
This reverts commit d1e1c165. Reason for revert: Suspected to break NearbyOnboardingPageTest.All on linux-chromeos-dbg Original change's description: > [Nearby] Add onboarding to receive dialog > > This converts the onboarding and visibility pages to use the > nearby-template-page and hosts them in receive dialog. If the user > attempts to enter high visibility mode and nearby is not enabled, we > force onboarding to be run first. > > Screenshot of onboarding running from settings: > http://screen/xnm86ZduzQ6bGEr.png > > Bug: b:154866951 > Change-Id: I195fa803762635f0a19d58d7d4db919c825b8ffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420770 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809599} TBR=khorimoto@chromium.org,vecore@google.com Change-Id: I7b078ac34fedb3b1d4c96c01623c2f35d23286e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:154866951, 1131390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424094Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#809742}
-
Jan Wilken Dörrie authored
This change adds a PasswordForm alias to the password_manager namespace and drops last references to PasswordForm in the autofill component. Bug: 1067347 Change-Id: I1afc94f08fa4e18859baf9f233890f1a392148f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424304Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
Currently, a fetch event for navigation can be dispatched without waiting for an ACK message of StartWorker. That resulted in recording the time for PerformanceResourceTiming#fetchStart and requestStart before the worker becomes ready to get a fetch event. This CL changes the time used for them. Before this CL, these time were recorded when the worker becomes ready and just before sending a message to fire a FetchEvent. After this CL, fetchStart and requestStart uses the time when the fetch event is actually dispatched on the worker thread. As a result, we can measure the time spent for starting the worker thread by fetchStart - workerStart. Explainer: https://docs.google.com/document/d/1m3Mnuq7N9pLzFC8vu19ngxzUU1n3Lt_phzyK3u_UQ6M/edit?usp=sharing Bug: 1128786 Change-Id: I9e2277d546b07dff99341b8fa37f2b71139c8392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413651 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809740}
-
Tanmoy Mollik authored
Use account_management_account_row layout for the preferences with icons so that the icons are aligned. Screenshot: https://crbug.com/1124668#c3 Bug: 1124668 Change-Id: I31429941f3153f4ef8f9d18e06d7d6572afac025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395495 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809739}
-
James Vecore authored
The last_incoming_metadata/last_outgoing_metadata was not ever getting cleared on a successful transfer. This would cause a share target to show up in discovery right away, but it would be a dead target that would fail if you tried to use it. Change-Id: I9679a6200fd948d0016484fee645c24db6f2ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425745 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809738}
-
Andrei-Laurențiu Olteanu authored
Change NVME to NVMe. Bug: b:168687888 Change-Id: I9fc8cab36ff4c6b43bc7e33a7908ef094be4c913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422944Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#809737}
-
Saurabh Nijhara authored
The data members were earlier marked protected when they were part of a test fixture class defined in a .cc file. Now that they have been moved to a .h file, it is preferred to mark them as private. Bug: 1086430 Change-Id: I405115dd30330e7b4be90ce43c31eb06ee965b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421500 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809736}
-
Tanmoy Mollik authored
If MOBILE_IDENTITY_CONSISTENCY feature flag is enabled, this screen will use the same icon as the one AccountPickerDialog is using. Screenshot: https://crbug.com/1107423#c9 Bug: 1107423 Change-Id: I796f8df61e2eba707e83b43c00a45e84b02d5d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390906 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809735}
-
Nohemi Fernandez authored
The global variable 'ShouldUseGaiaAuthFetcherIOS' is no longer used following the launch of NSURLSessionBridge. Bug: 1101748 Change-Id: I8c20303ec98811afd6f8b83dc19f8caa6ec27805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425823Reviewed-by:
-
Francois Doray authored
This CL splits timers with nesting level >5 and <= 5 into two different TaskTypes. This CL should not affect behavior because the two TaskTypes funnel into the same TaskQueue. In a separate CL, the TaskTypes will be associated with different TaskQueues, which will make it possible to disable intensive throttling for timer tasks with a low nesting level. Discussion: https://groups.google.com/a/chromium.org/g/scheduler-dev/c/EWKYCZlWjpc Bug: 1075553 Change-Id: I0f45c413b24e01e9687f109d0643bd1e46412075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416854Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#809733}
-
Noel Gordon authored
For files that are known to be text: convert them to a UTF-8 blob, and use it to source the <webview src="params.contentUrl"> to convince the <webview> to render UTF-8 (issue 1064855). A follow-up change will add test coverage. Files that are not known to be text (issue 772600): continue to render as before (no UTF-8 support), using the default "browsable" code. This code is already covered by our test system. Store task verb in a local variable to aid debugging. Remove local |browsable| variable. Bug: 1064855 No-try: true Change-Id: Ic2cb580a97d25d2c90d95a72a954b6aa33b4c6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425551 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#809732}
-
Irina Fedorova authored
This CL updates PasswordManagerProxy and adds basic properties to the PasswordCheckBehavior to provide the ability to use passwords check for weakness in the frontend. It also updates password_check a bit to verify that basic logic works. Bug: 1119752 Change-Id: I95133f63094fafa7ac105ebba3c1df357cb7bf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421372Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#809731}
-
Azhara Assanova authored
Hiding a crash sets a boolean field in the JSON log file. When this file is not found, the method used to do nothing. Now it creates the JSON log file and writes to it. run_webview_instrumentation_test_apk -f *CrashReceiverServiceTest* Bug: 1122058 Test: run_webview_instrumentation_test_apk -f *WebViewCrashInfoCollectorTest* Change-Id: I3175f09839254b98c0b051873320253103675d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405584Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Azhara Assanova <azharaa@google.com> Auto-Submit: Azhara Assanova <azharaa@google.com> Cr-Commit-Position: refs/heads/master@{#809730}
-
Wojciech Dzierżanowski authored
This reverts https://chromium-review.googlesource.com/c/chromium/src/+/1685372, which has been obsoleted by https://chromium-review.googlesource.com/c/chromium/src/+/2332703. The profile directory is now guaranteed to outlive both TestingProfile and TaskEnvironment. The revert introduced a failure in TabManagerTest.IsTabRestoredInForeground: PathDeleterOnTestEnd was not able to delete the profile directory on Windows. This is fixed here by getting rid of TestMockTimeTaskRunner in favor of using the MOCK_TIME trait for TaskEnvironment. This is the preferred way of mocking time and it makes the test simpler. Bug: 978442 Change-Id: I3810d2ae57911f5b2d3337f954be5f5f360d7d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416354Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#809729}
-
Koji Ishii authored
The purpose of this test is to ensure |NeedsCollectInlines| is not set by `text-decoration-line`, because it is one of the most expensive operations, and the property is often changed dynamically (e.g., hover on links.) r807433 crrev.com/c/2411300 changed it to test `text-decoration-color` instead, because it changed `text-decoration-line` to invalidate visual overflow, and because crbug.com/1043927 added a workaround to |SetNeedsLayoutAndIntrinsicWidthsRecalc| when |NeedsRecomputeVisualOverflow| for NG inline objects. This patch changes the test to: * Change to test `text-decoration-line` property. * Change to expect |NeedsLayout| is set, with TODO comment. * Add `outline` property, another property commonly changed dynamically (e.g., focus ring.) Bug: 1128199, 1043927 Change-Id: I879582916d45a9374fada4e8d42f5baca95adabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423766Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809728}
-
François Beaufort authored
This reverts commit 1e32efc6. Reason for revert: Some tests used to fail in WebRTC Chromium Mac Tester bot. Since macOS now supports detecting PTZ-capable cameras with this patch, it is no longer correct to assume that pan_tilt_zoom_supported() will be false for every enumerated camera, so let's remove the test named VideoCaptureDeviceFactoryMacTest.ListDevicesWithNoPanTiltZoomSupport Original change's description: > Revert "[PTZ] Add macOS support" > > This reverts commit 6fc7c32c. > > Reason for revert: crbug.com/1128470 > > Original change's description: > > [PTZ] Add macOS support > > > > This CL makes sure a USB Webcam device on macOS properly advertises its > > PTZ support. When supported, the pan, tilt, and zoom controls (ranges > > and values) are available to websites that user has granted access to. > > > > Bug: 934063 > > Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596 > > Reviewed-by: François Beaufort <beaufort.francois@gmail.com> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/master@{#807387} > > TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934063 > Change-Id: I88b1a41d28f5ad34f149f489b22eae6753e051dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418577 > Reviewed-by: Markus Handell <handellm@google.com> > Commit-Queue: Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/master@{#808384} TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org,handellm@google.com # Not skipping CQ checks because this is a reland. Bug: 934063 Change-Id: I82b757e1b5d3e6e62f520982ac5e4ef216849550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420031Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#809727}
-
Christian Dullweber authored
Change-Id: If3ec764097f8a52b4b144fa69bd1009711db95fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424159 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809726}
-
Christopher Cameron authored
Add a AVFoundationCaptureV2ZeroCopy feature flag to control exporting IOSurfaces directly out of VideoCaptureDeviceAVFoundation. This flag will do nothing unless AVFoundationCaptureV2 is also specified. Bug: 1125879 Change-Id: If18c797ad2cdb6abab73679df7ef9b150fc39f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425084Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600819087-f018447afe1bff252e1e84ad0f3e21a12934b752.profdata to chrome-linux-master-1600840405-46e4cd70bd3de973a171c7f611770f78487d203a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: If52beaa97510384bb399211a094b8618d71e27e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425359Reviewed-by:
-
Tim Schumann authored
This reverts commit 0d88901a. Reason for revert: Introduced a heap user after free in TabSearchButtonBrowserTest.TestBubbleVisible. [my hunch is, it's just missing a call to tab_search_button()->bubble_for_testing()->Close()] Original change's description: > Tab Search: Update TabSearchButton tests > > This CL creates a new file for TabSearchButton browser tests. These > tests run for both the fixed and regular entrypoints. > > Existing tests for the TabSearchButton have been moved from the tab > strip into the TabSearchButton browser tests. > > Bug: 1099917 > Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730 > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809376} TBR=sky@chromium.org,tluk@chromium.org Change-Id: I7b90eff0efbd7a807c0f085496f75139b1961909 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917,1131399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424288Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600819087-f4efc7f723c6812144192ebd4eb5f53f5a4e9534.profdata to chrome-mac-master-1600840405-f4d8e4031cebaee3fd15a03b0f21d18ea0743d9a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6aaf4f46f5e1c185984503aaeb3986a694a10f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425360Reviewed-by:
-
Tim Schumann authored
This reverts commit 5aa92900. Reason for revert: Suspicious of introducing a heap use after free. Original change's description: > Rough in support for multiple selection in holding space. > > Holding space needs to support selection of multiple holding space items > to perform bulk context menu and drag/drop operations on them at a time. > > This CL refactors HoldingSpaceItemContextMenu into a shared > HoldingSpaceItemViewDelegate to facilitate these requirements. > > Note that this CL does not change any existing behavior, just lays the > groundwork for supporting multiple selection. > > Bug: 1129981 > Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809625} TBR=dmblack@google.com,amehfooz@chromium.org Change-Id: I6c0ea6374b87d7d2f673f80e97781b1036604a14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129981,1131382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425048Reviewed-by:
-
Tim Schumann authored
This reverts commit a5d3ad0f. Reason for revert: Suspected to break NearbyOnboardingPageTest.All on linux-chromeos-dbg Original change's description: > [Nearby] Trigger onboarding when first enabling Nearby > > This CL adds a pref to track if onboarding was run by this user before. > If it has not, when enabling for the first time, onboarding is run first > by navigating to the subpage and showing in a dialog. Once onboarding > has been done once, the user can freely toggle on/off without > triggering onboarding. However, onboarding will still run if the user > triggers the pod button and the feature is disabled. This matches the > Android behavior. > > Additionally, this CL fixes a bug with the premature closing of the > shared receiveManager which needs to stay alive and connected after the > dialog closes otherwise getReceiveManager returns a remote with a closed > pipe. > > Bug: b/154866951 > Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#809623} TBR=khorimoto@chromium.org,vecore@google.com Change-Id: I4bd779c4a17b7ef0560078cefd00287810dab796 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/154866951, 1131390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424160Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If1a1ecb542c2e8a72f24d967d52b211c8faf9a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425349Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the correct trait collection is used when checking if the NTP is displaying one or two toolbars. With multiwindow, it is not possible to directly check the key window. Fixed: 1128527 Change-Id: I79a441b1a186c755b7cc979f527e807f10aa3a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422955 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809718}
-
Tim Schumann authored
This reverts commit 821323c7. Reason for revert: Breaks RenderProcessHostUnitTest.ReuseCommittedSite on linux-bfcache-rel builders. Original change's description: > Add Render Process for Site Instance Assignment to content API > > This CL adds an enum, SiteInstanceProcessAssignment, which > describes all the ways a SiteInstance may be assigned a render > process. This is exposed in the content API to allow embedders to > record this usage. > > See design doc in bug and/or chained CL for more info. > > Bug: 1129505 > Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809620} TBR=alexmos@chromium.org,robertogden@chromium.org Change-Id: I89a7d068b8897c520a3d02645222c9cd91220c19 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129505,1131378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424314Reviewed-by:
-
