GitLab

Without the fix, the modified unittest fails with:
"GNError: Expected an identifier"

With the fix, the unittest passes.

Bug: 1091082, 937821
Change-Id: I32591c64945dd918dfc341c8327fd530058b90ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231286Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775299}

This reverts commit 60f4f958.

Reason for revert: crbug.com/1091140

Original change's description:
> Add async accessibility hit testing API
> 
> Previously, in order to do a hit test for accessibility we'd
> send an action to the renderer with the x,y coordinates, and
> the renderer would fire an accessibility event on the matching
> node.
> 
> It'd be more flexible if we had an API that could do a hit
> test and call a callback function with the result. That
> eliminates the need for keeping track of requests and matching
> them up with events.
> 
> This patch refactors the way hit testing works so that a
> hit testing request may contain a request for an accessibility
> event to fire, or a callback function to call, or both.
> 
> Existing tests are extended to cover both mechanisms.
> 
> Bug: 1083834
> 
> 
> Change-Id: Idb4c1f302361a0eb6d6344bcee9da7f086caf3c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209630
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#774697}

TBR=dmazzoni@chromium.org,acolwell@chromium.org,estark@chromium.org,aleventhal@chromium.org,arthursonzogni@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1083834
Change-Id: I2454cf5f36e09a3a902960e936f39d5c443cab65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231581Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775298}

AwDebug.dumpWithoutCrashing was added to diagnose a suspected renderer
hang; it's only accessible by reflection and has not been used to debug
an issue for a long time. It no longer provides very useful output since
it only dumps the current process and WebView is now multiprocess in the
majority of cases.

Therefore, just disable the API entirely rather than making it more
complex to support multiprocess - if there's a similar need in future it
would be more useful to support capturing a trace than a minidump, which
did not prove valuable. We keep it around so that any hypothetical
clients won't see exceptions during reflection (though they should be
handling those exceptions) - it just always returns false to indicate
the dump was not generated.

AwDebugTest relied on dumpWithoutCrashing to test the crash key
filtering mechanism, but the tests have been disabled for some time and
maintaining this just for a test doesn't seem worth it; just remove
those disabled tests entirely.

Fixed: 568825
Fixed: 913515
Change-Id: I2b5b242388d6aaac14508f554e58c3eabbc4ae5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231658Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775297}

Before this patch, payment handlers were implemented in two different
places: ServiceWorkerPaymentApp.java and service_worker_payment_app.cc.
This also resulted in differences of behavior, such as Android returning
"true" for hasEnrolledInstrument() of JIT installable payment handlers,
whereas desktop platforms returned "false".

This patch replaces ServiceWorkerPaymentApp.java with JniPaymentApp.java
that wraps service_worker_payment_app.cc.

After this patch, JniPaymentApp.java can wrap arbitrary C++ payment
apps and there're fewer differences in behavior between Android and
desktop platforms:
 (1) All platforms now return "false" for hasEnrolledInstrument() of JIT
     installable payment handlers.
 (2) All platforms now return "false" for hasEnrolledInstrument() of
     payment handlers that support only standardized payment method
     identifiers, such as "basic-card".
 (3) JIT installed payment handlers now can be aborted on both desktop
     and Android.

Design: https://bit.ly/cross-platform-pay-app-factory

Bug: 1022512
Change-Id: I03e6bc856f1bce662a68a95513c2f097784a2e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198918Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775296}

I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4kMGCyCUIao/5vjPk4tuAQAJ

Change-Id: I9969f0c6d65a7afce14b5058c6719599c72dad80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225546
Commit-Queue: Luis Garcia <luisggarcia@google.com>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775295}

They were removed long ago.

Bug: 1088769, 1088770
Change-Id: Ic12d7290e192f3a31ff9aea711ac81a353f7005c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229239Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775294}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5f07cbd7440cafb3d629e0cc90fbfb3d0cdc199b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775293}

This reverts commit 94c64b41.

After the revert, we no longer have crbug.com/1086968 crashes.
The root cause of the crash is still unclear, but crrev.com/c/2226924
changed the class hierarchy of LayoutCustomScrollbarPart which may
affect the issue. Reland the CL tentatively to see if the crash still
occurs.

Original change's description:
> Revert "Fix layer/phase violation of custom scrollbar painting"
> 
> This reverts commit 64bcb13d.
> 
> Reason for revert: Tentative for crbug.com/1086968.
> 
> Original change's description:
> > Fix layer/phase violation of custom scrollbar painting
> > 
> > TL;DR, with this CL:
> > - We no longer update custom scrollbar part position during paint;
> > - We avoid unnecessary ScheduleAnimation when painting custom
> >   scrollbars;
> > - CustomScrollbar::*Rect() methods no longer have side effects;
> > - Some FIXMEs are fixed.
> > 
> > Details:
> > 
> > Previously LayoutCustomScrollbarPart::FrameRect() stored different
> > values at different document lifecycle stages:
> > 
> > - Before paint, its location was always zero, and the size was not the
> > actual size for some parts, but the minimum size calculated from the
> > style, not based on layout, though updated in UpdateLayout().
> > UpdateLayout() was called not during layout (as a scrollbar part is
> > not in the layout tree), but anytime we wanted the minimum size from
> > const methods of CustomScrollbar.
> > 
> > - During paint, as the FrameRect() calculated during UpdateLayout was
> > not the real frame rect, we updated the frame rect to make sure they
> > would be painted correctly. This caused unnecessary
> > SetShouldCheckForPaintInvalidation when the FrameRect changed and
> > unnecessary ScheduleAnimation().
> > 
> > This CL contains the following changes:
> > - Removes LayoutCustomScrollbarPart::UpdateLayout().
> >   Adds ComputeThickness() and ComputeLength(), and lets Margin*() get
> >   style directly, to replace the original UpdateLayout() (which called
> >   SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of
> >   CustomScrollbar. This removes the dependency of the const methods
> >   on the temporary incorrect FrameRect().
> > 
> > - Adds CustomScrollbar::PositionScrollbarParts() to set the correct
> >   FrameRect() for scrollbar parts. It's called from several places that
> >   position of scrollbar parts can change. This replaces the Set* called
> >   from CustomScrollbarTheme::Paint*.
> > 
> > Bug: 856802
> > Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#771890}
> 
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 856802, 1086968
> Change-Id: If1703dcda1d4cb6a53a132557b34867090f397ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225222
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773772}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 856802, 1086968
Change-Id: I7108a82ed453c32a87ca1aad689cf8a1c157f8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231458Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775292}

In order to unblock document policy violation report deduplication
implementation, it is necessary to separate subtests for font-display
wpt test into subframes so that their violation reports do not
interfere with each other.

Bug: 1087277
Change-Id: I79ece4fbaae2b28b40b85ca0a0df4daffd54bca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227863Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#775291}

This change implements the BluetoothDevice.watchAdvertisements() API to
enable sites to detect when devices come into range of the Bluetooth
radio.

Design doc:
https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM

Bug: 654897
Change-Id: Id160188f7a3932819db5e140c41a9dcfdbca321a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112966
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775290}

Bug: 1090252
Change-Id: I9041b0653c4a8b9207d964e244a2cfafd28b30e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229429Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775289}

Responsibility for defining snackbar durations will belong to FeedStreamSurface.

Bug: 1044139
Change-Id: Ifd007e0014fb46e5c81eb6e7ad6d78ed4a23eb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231540
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775288}

This CL
1 - Adds TileUmaLogger to omnibox which was missing earlier.
2 - Fixes a bug in TileUmaLogger which wasn't recording top level tiles correctly.
3 - Added tests for TileUmaLogger.

Bug: 1091130
Change-Id: Ie556640c6b301cb26915462973d26c373667ab16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230318Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775287}

testIncognitoPlusRegular fails flakily depending on
the order in which it is run relative to other test
cases. It also fails when it is the first test run
after app launch, which means that if it fails once
in a given run, it won't even pass on retry.

Here's an example run where this happens on a change
that is a no-op other than adding a new empty test:
https://chromium-swarm.appspot.com/task?id=4c998d1e469f0110

This CL disables this flaky test.

BUG=1033726

Change-Id: I77949094e448c26a5db176f4b18c60a783aefc8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231447
Commit-Queue: Ali Juma <ajuma@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775286}

Fix one comment to not mention non-existing methods, and change a
parameter from a non-const reference to a const reference, as I
assume it was supposed to be.

Bug: None
Change-Id: I38d6cef800958dc0c4cf22af16e2cb2a9e4f58ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231543
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775285}

If the text scale change delta is too small (e.g. 100% to 105% compared to 100% to 150%), Windows only sends a text scale change message. If the delta is large (e.g. 100% to 150%), Windows sends a text scale and window resize message.

Here's the new behavior: https://i.imgur.com/PAjwJSt.gif

Bug: 1087626
Change-Id: I5b6d86a6219d3e27128a5b221d401bcf001443ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223123
Commit-Queue: John Pham <johnp@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775284}

Updates expiration to M92 for current MediaRouter.* histograms, and obsoletes
some old histograms that are not being collected.

Bug: 1088926,1088925,1088923,1088909,1088673
Change-Id: Ib4ab0bfd6649935e08c6100e17bf652a6676e127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225633Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775283}

Bug: 1090998
Change-Id: Ib0d787b38e484d15965209f880d8cb8af3ecdc72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230925
Commit-Queue: Matt Mueller <mattm@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775282}

https://skia.googlesource.com/skia.git/+log/5a2a7b3096d0..4926b07217f0

2020-06-04 michaelludwig@google.com Revert "Improve scissor state tracking in GrRTC"
2020-06-04 michaelludwig@google.com Improve scissor state tracking in GrRTC
2020-06-04 mtklein@google.com refine __chkstk_darwin() workaround
2020-06-04 mtklein@google.com remove templates from SkSwizzler_opts
2020-06-04 herb@google.com Make vertex structs private
2020-06-04 herb@google.com Remove unused vertex filler
2020-06-04 johnstiles@google.com Update GrFragmentProcessor::SwizzleOutput to use a child FP.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tdenniston@google.com
Change-Id: I74a1eda69a59a9aee58d9d2cb86cb34c3ff7c3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231598Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775281}

https://android.googlesource.com/platform/external/perfetto.git/+log/7835859ea8de..4a3f9b801b02

2020-06-04 lalitm@google.com Merge "benchmark: update googlebenchmark to v1.5.0"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I81758e42cca1c1d296485c1077c6fc13307c347c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775280}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c461b6d69583..14793b02f904

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: yigu@google.com,tbansal@google.com
Change-Id: I5b2693c454ba56ca64bbe616de34b005be905acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231013Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775279}

This patch splits the BottomSheetController into 3 pieces:
  - BottomSheetController: This interface is intended to be the public
    interface for anyone trying to use the bottom sheet and should
    freely be passed around in features.
  - BottomSheetControllerInternal: This interface specifies methods
    that are necessary for "glue" code to effectively manage the
    sheet. When the sheet has its own component, the only code allowed
    to depend on it will be glue.
  - BottomSheetControllerImpl: This is the implementation of the above
    interfaces and will eventually be private (or just internal to the
    bottom sheet widget).

This patch also replaces most of the test-exclusive methods using
various alternatives in tests outside of the bottom sheet's package.

Bug: 1002277
Change-Id: Ic84ae52fab3554ef38d84ee32734340c224d8872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225845
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775278}

Bug: 898348
Change-Id: I3abe58863f85f5ca3abf0a5bb00bb969d775ad22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225928
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775277}

Most TODOs are assigned to the linked bugs. TODOs related to GroupEffect
are outdated so they are removed.

Bug: None
Change-Id: I7b413773904efd93c6b6959545c5d74f7d4760ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227299
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775276}

AppType 2 is for the test application, but we're using that ID for
now. If you use 3, the server responds with no content.

Change-Id: Idf4cf0e2df21546d0a644f7502d837225d38ef2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231580
Auto-Submit: Dan H <harringtond@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775275}

To facilitate calling dark mode filter at raster time, dark mode filter
module will be moved to cc/paint. This change replaces blink::Color by
SkColor.

Bug: 1091095

Change-Id: I65d888ab5df454592ac0df004b0bbe48e9a093d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167804Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#775274}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: If0cc371d15135d1634d20706b1c74e504457a8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231086Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775273}

This change simply allows a valid Handle to be duplicated after
ChildProcessSecurityPolicyImpl::Remove() has been called for the process
associated with the Handle. Handles are intended to keep security state
alive beyond the process lifetime and some Handles are duplicated so
they can be passed down into lower level code. This change fixes a bug
where Duplicate() would generate invalid Handle objects if it was
called after CPSPI::Remove() was called. These calls can happen because
of Mojo message queuing and no ordering constraints between different
Mojo interfaces.

Bug: 977169, 1086306
Change-Id: Icacaf06b049ba88ae7152f5c7307312d73134824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226156Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775272}

This is necessary for HTML imports, but other cases appear to break.
Add a special-case in HTMLImportLoader

Bug: 1090440
Change-Id: I85f8e8f9c3846e3e616efd983b4c037ca741122f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229152
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775271}

Removes shadow before closing from close button, otherwise the scaling
animation will leave behind the shadow, which gives a transparent ring
look. This isn't need for swipe to close as there is no scaling
animation.

Test: ash_unittests OverviewSessionTest.CloseAnimationShadow
Bug: 981509
Change-Id: I724343e29bcda4663c2a58e02ad7ed833525db9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228125
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775270}

https://crrev.com/c/2180959 added a histogram to track the success
rate of a mount namespace created in the Chrome OS's session manager.
Track this on the Chromium side to see them in UMA.

BUG=1072160
TEST=validate_format, pretty_print.

Change-Id: Ia446d40eb6f3e76785ee3489b3356e905681319f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227855
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775269}

Change-Id: I7848f077a6b67623c2d3d6eb48090f7447dfce5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230329Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775268}

Suspect the crash is because an animation observer of a child
layer deletes the parent/child when stopping the BOUNDS animation
in the Remove call.

Also changes a simillar situation in SwitchToLayer.

Bug: 1088432
Change-Id: Id9bacb230a9d0a6fa390ae3bc1a0410c983fb049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224031
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775267}

With this change, it is no longer possible to use Windows native spell
checking without ALSO using Hunspell as a fallback for unsupported
languages. While it technically hasn't been possible for some time due
to how the spell check code has evolved, this now makes it explicit.

- Removes the kWinUseHybridSpellChecker feature flag
  - This was initially introduced so other Chromium projects could rely
    only on the native spell checker if they didn't want to also use
    Hunspell. However, there is no obvious need for that right now, so
    it is easier to remove the flag than to fix it.
  - Code using this flag now instead uses the kWinUseBrowserSpellChecker
    feature flag.
- Removes the USE_WIN_HYBRID_SPELLCHECKER build flag
  - Similarly, this build flag was used to compile out the Hunspell
    fallback logic. Since the fallback logic is now mandatory, this
    build flag can be removed.
  - Code using this build flag now instead uses a combination of the
    OS_WIN and USE_BROWSER_SPELLCHECKER build flags.

Bug: 1074450
Change-Id: I471a704901ac12d573ba2e5e42a5ef4f19a9cc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226307Reviewed-by: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#775266}

TBR=govind@chromium.org

Change-Id: I3ff912a7c22faac3e58f061807213fe89bc3deee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231448Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775265}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1e9759c011a..b674ea36ab2f

2020-06-04 zhin@chromium.org [codemirror] Update CodeMirror to 5.54.0.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4d0a36a88a713a4818c025e9d67e5661bcaa21df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775264}

When a style resolve is a cache hit, we don't go through the normal
process of applying declarations via StyleBuilder::ApplyProperty.
We then also don't set the ChildHasExplicitInheritance flag on the
parent style for cache hits. This wasn't a problem a before, since
any style with a parent with this flag set could not enter the MPC.

However, with MPCDependencies enabled, such styles can now enter the
cache, and cache hits for those entries will then fail to set the flag
on the parent style.

To fix this, this CL adds a new flag HasExplicitInheritance, which
pertains to the _current_ ComputedStyle being computed (not the
parent). This way we can get the information we need into the MPC,
and perform the necessary propagation to the parent style when we
need to.

TEST=external/wpt/css/css-transitions/inherit-height-transition.html

Bug: 1057072
Change-Id: Ic03cdc6377ab5e58d6fe08a6fef2bd7505064f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228535
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775263}

If the default search provider was overridden by an extension, we show aprompt to the user confirming it was intentional. This customizes that
prompt in different scenarios:
- If Google was the old search provider, use "Back to Google" language.
- If another search provider from the default list was used, use
  "Back to <other search provider>" language.
- In all other cases, use the generic "Did you mean to change your
  search provider" language.

This requires some fun plumbing in order to determine what the search
engine would be, if the extension weren't enabled. In particular,
finding the "secondary" search engine from the TemplateURLService.
For this, introduce TemplateURLService::GetDefaultSearchIgnoringSource()
and DefaultSearchManager::GetDefaultSearchIgnoringSource(), which allow
querying for the default engine ignoring any from a specified source.
Using this and ignoring the extension source, we should be able to find
the "secondary" search engine.

Add browser tests and UI tests for each of the dialog options (back to
google, back to <other>, and the generic version).

Bug: 1079364
Change-Id: I00fec35a7b3e3442fbe89c276513023e9ca12a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218805
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775262}

Speculative fix for the linked bug. Was unable to repro manually, but
created a test case that is plausible that has a similar stack trace.

Test: TabletModeOverviewSessionTest.DestroyWindowDuringNudge
Bug: 997335
Change-Id: Ib580740b4c059aa30e44af57e895c27b610f1650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225587Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775261}

Bug: 1045266
Change-Id: I634f70491987144d505f75bc93aa6b5b6734754b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225341
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775260}