GitLab

To perform the permissions check on NaCl, we mmap() a shared memory region as
writable and check the return value to know if map failed. It's expected that
the call would fail if the region has read-only permissions.

Unfortunately, NaCl doesn't handle failure cases gracefully and crashes
instead of returning error value [1], [2].

This means, that an attempt to check permissions on a read-only shared memory
region always leads to a crash. This CL removes the check altogether to allow
the NaCl processes to use read-only shared memory.

[1] Posix: https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/sys_memory.c?rcl=f701a90597fc85979319447c0cd44c3b52201c78&l=868
[2] Win: https://cs.chromium.org/chromium/src/native_client/src/shared/imc/win/nacl_shm.cc?rcl=f701a90597fc85979319447c0cd44c3b52201c78&l=112

Bug: 901646
Change-Id: I1f0cee4f7edae0390701320f5061470d62240186
Reviewed-on: https://chromium-review.googlesource.com/c/1352312Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611630}

This patch renames the metric names for the "two posting threads"
variants in sequence_manager_perftest. This ensures they don't conflict
with the ones from the one posting thread variants.

Bug: 891670
Change-Id: I79ad75d6a0cf6a84fb376108ee92a822ffcc290c
Reviewed-on: https://chromium-review.googlesource.com/c/1352261Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611629}

TBR=kojii@chromium.org

Change-Id: I6e3be1211140e28f38f8a10e1e7697c4bebf7737
Reviewed-on: https://chromium-review.googlesource.com/c/1352351Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611628}

We need submission indicator for metrics and for uploads. This CL
implements handling it in new Password Manager architecture:

1.Setting it in the renderer process in FormData
2.Passing it over MOJO to the browser process
3.Setting it in FormParser to resulting PasswordForm.

Bug: 831123
Change-Id: Ia1fe6e29f031706c91073d6209ae9d841c348929
Reviewed-on: https://chromium-review.googlesource.com/c/1350968Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611627}

Bug: 905654,905656
Change-Id: I331e96047e3c88e812247e7dab6a2181894f760b
Reviewed-on: https://chromium-review.googlesource.com/c/1341517
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611626}

Some requests, e.g. requests for service worker updates, are not
associated with a WebContents. In these cases Clear-Site-Data returns
early and doesn't mark its task as finished, which leads to hanging
requests.
This CL fixes the hanging requests but does not actually perform the
site data deletion. That will be fixed in a followup CL.

Bug: 898465
Change-Id: I99bbf4339f7b123d4a46552e9f117d4d95b7ec67
Reviewed-on: https://chromium-review.googlesource.com/c/1346468
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611625}

Remove this method from both BrowserAccessibilityDelegate and from
RenderWidgetHostViewBase.

This method has only one caller, -[BrowserAccessibilityCocoa
pointInScreen], which can implement the functionality using the existing
AccessibilityGetViewBounds method. While in the neighborhood, convert
pointInScreen to rectInScreen, because
- that's what all of the callers but one want
- there already exist helper functions for that method
- it maintains the rule that "gfx::* structures are in gfx coordinates
  while NS* structures are in NS coordinates"

Bug: 900846
Change-Id: Idd62dc256e5d05e946f9a47fa61b8479fbc8be56
Reviewed-on: https://chromium-review.googlesource.com/c/1351580
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611624}

This cl enables adding cookie site exceptions. The "+ ADD SITE
EXCEPTION" is added in the Cookies Category.


Bug: 468586
Change-Id: I4c78f5960b4dd92abe7e20f15f5bbaf287f33684
Reviewed-on: https://chromium-review.googlesource.com/c/1299088Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Cr-Commit-Position: refs/heads/master@{#611623}

Additionally, change the signature of the method to return a bool
so that we can report failure (i.g. hasn't got a primary account)
or success and provide new unit tests to check the effect of passing
different values of PrimaryAccountMutator::ClearAccountsAction.

Bug: 906056
Change-Id: I3c77e05334f8a5d7e12e7788b36d7a2895b905b1
Reviewed-on: https://chromium-review.googlesource.com/c/1348451
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611622}

The bug was fixed, the directives are no longer needed.

Bug: 821377
Change-Id: Ieb92e60118dc5bc519154db60957b06319471a5f
Reviewed-on: https://chromium-review.googlesource.com/c/1352359Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611621}

This is necessary for full-blown USS.

Bug: 902349
Change-Id: I1de4a3ac610151feb236c2f1696ba22b9f047568
Reviewed-on: https://chromium-review.googlesource.com/c/1336129
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611620}

When decideing whether a YUV format should be used for swapchain creation,
check the current protected video type instead of the one from the previous
swap chain creation.

Bug: 903552
Change-Id: I028b32dcbcd66763ac8f4220f79fc6674f28bcdf
Reviewed-on: https://chromium-review.googlesource.com/c/1352431
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611619}

Since LayoutSVGShape::NodeAtPointInternal is now only called from
LayoutSVGShape::NodeAtPoint, we can make it private. Rename it to
something more helper-like - HitTestShape.

Move the check of 'visibility' to LayoutSVGShape::NodeAtPoint from
HitTestShape, to better match other similar methods.

Change-Id: If251b8b9258b754bfc94044739d6a8c41f1b04e7
Reviewed-on: https://chromium-review.googlesource.com/c/1352253Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#611618}

The UI implementation of the consent bump on Desktop
is removed.

The backend code and the consent bump flag will be
removed in a follow-up CL.

Bug: 906026
Change-Id: Ib10b0aaa692f5417c1ba1b1f7219d6e6e89457fc
Reviewed-on: https://chromium-review.googlesource.com/c/1349691
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611617}

test_chrome_with_chromedriver.py sometimes fails to delete the user data
dir because lingering chrome.exe processes (e.g., the crashpad handler)
are still working in it. This change causes the test to wait for all
Chrome procs to exit before searching for crash reports and cleaning up.

BUG=907979

Change-Id: I6500973a906a7b71b36d44aae4c1ca50d42f2001
Reviewed-on: https://chromium-review.googlesource.com/c/1352177
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611616}

A test is added to DiceTurnOnSyncHelperTest to check whether
DiceTurnOnSyncHelper enables all Google services tied to unified
consent.

The implementation uses the ChromeUnifiedConsentServiceClient
instead of FakeUnifiedConsentServiceClient.

Bug: 908111
Change-Id: Ib86721eb69e9bb6e213c610cd70451f515284765
Reviewed-on: https://chromium-review.googlesource.com/c/1350176
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611615}

This change splits the server payload into a global and a script
payload. The global payload is meant to contain the memory, the script
payload the script execution state.

Global payloads are forwarded from GetNextActions RPC to RPC, regardless
of which script these actions are for. Server payloads are forwarded
from GetNextActions RPC to RPC, for a given script.

With this new definition, memory can be shared between scripts, even in
the case where script execution is interleaved, like when running
interrupts.

Before this change, interrupts could not make changes to the memory that
would be visible to the main script. With this change, and upcoming
changes on the server to support global payloads, interrupts and main
scripts share the memory.

This change also make sure that the payloads are overwritten by each
requests, whether the payloads are set or not. This is going to be
useful while the servers transition to the new type of payloads.

This change preserves the current behavior of forwarding script payload
for the last main script response to the next script initial request, so
memory sharing works as it does now until the server is modified. As a
result, this change should have no effect until the server is modified.

Bug: 806868
Change-Id: I953dfa4cdc898093946948fe9990d01c0551dcb2
Reviewed-on: https://chromium-review.googlesource.com/c/1350632Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611614}

Creating a mojo data pipe can fail due to insufficient resources. This
CL handles this case.

Bug: 905779
Change-Id: Iffd9e768689cce9e8ec51f307388ec8e63c7d9b2
Reviewed-on: https://chromium-review.googlesource.com/c/1352309Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611613}

Using wpt-import in Chromium 380c427f.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ia249916817c711e6675f3763126c252f59aa1042
Reviewed-on: https://chromium-review.googlesource.com/c/1352977
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611612}

This patch makes |Element#innerText| to utilize |NGInlineNode::
GetOffsetMapping()| to collect characters from |Text| node using
|NGOffsetMapping| for both legacy layout tree and LayoutNG.

In this way, |Element#innerText| is no longer needed to handling collapsed
white spaces, this patch also gets rid of code related to collapsing white
space.

The |NGOffsetMapping::GetMappingUnitsForNode()| is introduced for calculating
starting offset of remaining part of ::first-letter.

This patch also changes |ElementInnerTextTest| to run on both legacy and
LayoutNG layout tree for helping LayoutNG release.

Bug: 854889, 873957
Change-Id: Ifc8dd54a426dc6b4962b01d59bc70359fbb7d6e5
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1350443
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611611}

At the V8 Extras implementation of WritableStream serialization, as well
as the C++ wrappers.

No user-visible behaviour changes.

BUG=894838

Change-Id: Iae828b0f5b67508ab1b9ea7099a24635968888c4
Reviewed-on: https://chromium-review.googlesource.com/c/1352114Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611610}

It has been replaced by SyncUserSettings::SetSyncRequested(true).
Note that *Profile*SyncService::RequestStart still exists for now
(it's used by SyncUserSettings). This will be changed in a later CL.

Bug: 884159
Change-Id: Ie96e6a999ae6060fd3bbe444e4471ba9327edef8
Reviewed-on: https://chromium-review.googlesource.com/c/1350907Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611609}

It was using the SigninManager API to the set authenticated (primary)
account. It was also using an ad-hoc TestingProfile. From now on the
profile is created using IdentityTestEnvironmentProfileAdaptor and the
IdentityTestEnvironment owned by the adaptor is used to set the
primary account.

Bug: 903865
Change-Id: I1313f11fbbe1121afb755c1723c8a822747dea6c
Reviewed-on: https://chromium-review.googlesource.com/c/1349697Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611608}

Change-Id: Ifee51301e6fc6c28246f91807a9e9243ed72d106
Reviewed-on: https://chromium-review.googlesource.com/c/1352164
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611607}

Change-Id: I8f41c0cf8947aa771ceb1bf8ffc27091f72922be
Reviewed-on: https://chromium-review.googlesource.com/c/1341247
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611606}

This adds myself as an owner of settings. As I already did a lot of
refactoring in the folder, I think it makes sense.
Most of the refactoring CL can be tracked in crbug.com/894791.

Bug: none
Change-Id: I7426aacab7a055f75433246ec5a79b04be636da7
Reviewed-on: https://chromium-review.googlesource.com/c/1350893Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611605}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80a54408f352..047cf0724025


Created with:
  gclient setdep -r src-internal@047cf0724025

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I880110f797d5bb121e171e1484c7e0cd4d535fb0
Reviewed-on: https://chromium-review.googlesource.com/c/1352993Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611604}

This patch makes mojom::CorsOriginPattern use CorsORiginAccessMatchMode
and allows network::cors::OriginAccessList to create equivalent
mojom::CorsOriginAccessPatterns array.

Also this patch enforces not to rely on cors_origin_patterns.mojom.h
indirectly from Blink platform.

Bug: 908324, 908756
Change-Id: If059a460b424025376b2e4d4433ba6ec17523357
Reviewed-on: https://chromium-review.googlesource.com/c/1350689
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611603}

This reverts commit 63dd5d45.

Reason for revert: Causes flakes in the following tests:
virtual/video-surface-layer/media/track/track-cue-rendering-position-auto.html

virtual/video-surface-layer/media/controls/volumechange-stopimmediatepropagation.html

Bug: 909586

Original change's description:
> Remove synchronous blocking from PipelineImpl::Stop() - take 2.
> 
> We should be able to avoid this with careful use of a trampoline
> through the media thread after PipelineImpl::Stop() completes.
> 
> This is an updated version of the last CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1336659
> 
> The difference is we now also preserve the RendererFactorySelector
> until after renderer shutdown. This passes all the failing tests
> I could find locally.
> 
> BUG=521176, 905506
> TEST=passes cq.
> R=​sandersd
> 
> Change-Id: I86c4814a91ee6c41f20f6bb8a05859ac44171d7e
> Reviewed-on: https://chromium-review.googlesource.com/c/1351791
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611305}

TBR=dalecurtis@chromium.org,sandersd@chromium.org

Change-Id: I8d70751211f938756bf5b98e86b298f4fe921617
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 521176, 905506
Reviewed-on: https://chromium-review.googlesource.com/c/1352326Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611602}

This allows the previews decision logic to run again.

This is tested by checking the existance of server_lite_page_info which
is not persisted across reloads. Note: forward/back navigations also
do not persist server_lite_page_info.

Bug: 864665
Change-Id: Ibe5d1b698a0f790474992967561ecdd81ac348f4
Reviewed-on: https://chromium-review.googlesource.com/c/1352823Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611601}

This CL adds histograms to monitor the API call jitter that is observed
in AEC3 in WebRTC.

The WebRTC CL for adding the histograms is
https://webrtc-review.googlesource.com/c/src/+/111580

The metrics for the API call jitter is the minimum and maximum
calls API calls in a row (in units blocks of 8ms) observed for
capture and render.

Bug: chromium:907234
Change-Id: I7f6d45b9f5826f6f7706a6ec3644ec0c35a3da00
Reviewed-on: https://chromium-review.googlesource.com/c/1345012
Commit-Queue: Per Åhgren <peah@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611600}

The result of ContentClient::GetUserAgent is known to be incorrect in
the renderer process, so get the value in the browser and pass it via
IPC.

Bug: 818450
Change-Id: Ia1af4c237b9d63059c634cd0bbb41ab53436b8cd
Reviewed-on: https://chromium-review.googlesource.com/c/1352119Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611599}

This fixes the build with libstdc++ after c416f80a ("Refactor
base::FuzzedDataProvider and fix the calling sites"):

* CHAR_BIT is part of limits.h (or <climits>), not the C++ <limits> header
* std::memcpy() needs <cstring>

Bug: 819294
Change-Id: I71439bd56c68fb7600a816ce03a71711ccfb00db
Reviewed-on: https://chromium-review.googlesource.com/c/1352320Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611598}

GCC is stricter than clang when it comes to class members' names and how
they can change the meaning of a previously existing symbol with the same
name:

    In file included from ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:5:
    ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.h:102:35: error: declaration of ‘blink::CallSetupState blink::CallSetupStateTracker::CallSetupState() const’ [-fpermissive]
       CallSetupState CallSetupState() const;
                                       ^~~~~
    ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.h:79:12: error: changes meaning of ‘CallSetupState’ from ‘enum class blink::CallSetupState’ [-fpermissive]
     enum class CallSetupState {
                ^~~~~~~~~~~~~~

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer
explanation, but essentially having a |CallSetupState()| method can change
the meaning of references to the |CallSetupState| enum in the code depending
on where it is declared, which contradicts the C++ standard.

Fix it by renaming the method to |GetCallSetupState()| after commit
7b1a3d2d ("CallSetupStateTracker::CallSetupState() added").

Bug: 819294
Change-Id: I5660c7c39d107343567452a5575205090c23cae8
Reviewed-on: https://chromium-review.googlesource.com/c/1352354Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611597}

This fixes the libstdc++ build after 86293fce ("IndexedDB: Move
content/renderer/indexed_db/ to Blink, take 2"):

    In file included from /usr/include/c++/8/memory:80,
                     from ../../third_party/googletest/src/googlemock/include/gmock/gmock-actions.h:45,
                     from ../../third_party/googletest/src/googlemock/include/gmock/gmock.h:59,
                     from ../../testing/gmock/include/gmock/gmock.h:10,
                     from ../../third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h:9,
                     from ../../third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc:5:
    /usr/include/c++/8/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = blink::IDBKey]’:
    /usr/include/c++/8/bits/unique_ptr.h:274:17:   required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = blink::IDBKey; _Dp = std::default_delete<blink::IDBKey>]’
    ../../third_party/blink/public/platform/modules/indexeddb/web_idb_key.h:165:30:   required from here
    /usr/include/c++/8/bits/unique_ptr.h:79:16: error: invalid application of ‘sizeof’ to incomplete type ‘blink::IDBKey’
      static_assert(sizeof(_Tp)>0,
                    ^~~~~~~~~~~

libstdc++'s std::unique_ptr implementation has a few static_asserts in the
destructor, one of which requires that the type passed to unique_ptr is
fully declared at the time.

mock_web_idb_callbacks.cc is now in Blink, and it ends up indirectly
including web_idb_key.h, and now WebIDBKey::ReleaseIdbKey()'s call to
std::move() triggers that assert.

Move the implementation to the web_idb_key.cc to fix the issue.

Bug: 819294
Change-Id: Ia02ed14d4b53b3e75cad46ef8dadba8017c64d02
Reviewed-on: https://chromium-review.googlesource.com/c/1352184Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611596}

This bug has already been fixed by r583483.

Bug: 804682
Change-Id: Ica4adb5b8f390a14c721f644afa69a2d394e3a69
TBR: bashi
Reviewed-on: https://chromium-review.googlesource.com/c/1353054Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611595}

This reverts commit 843847fc.

Reason for revert: VDA unittest on eve is broken.

Original change's description:
> ozone: drm: Re-set cursor when GPU process connects
> 
> When the GPU process restarts we need to re-send the cursor bitmap since
> all GPU process display state is lost.
> 
> It looks like it may have been broken all the way back to d818104f
> ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a
> different issue but also caused the message that was intended to restore
> the cursor (in CommitBoundsChange) to not get delivered.
> 
> Bug: 908682
> Test: kill $(pgrep -f type=gpu-process), cursor restored
> 
> Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc
> Reviewed-on: https://chromium-review.googlesource.com/c/1351903
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611166}

TBR=spang@chromium.org,dnicoara@chromium.org

Change-Id: I6b69290c0d193190a0bcecc56819b3c59872eff8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908682
Reviewed-on: https://chromium-review.googlesource.com/c/1353038Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611594}

This fixes the GCC build after 65be571f ("Add DNS histograms for private DNS
usage, perf, and auto-upgradability").

Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having
base::NoDestructor<T<U>> and passing an initializer list of Us does not
work if this is not done explicitly, as GCC incorrectly fails to determine
which constructor overload to use:

    ../../net/dns/host_resolver_impl.cc: In function ‘bool net::{anonymous}::DnsServerSupportsDoh(const net::IPAddress&)’:
    ../../net/dns/host_resolver_impl.cc:525:8: error: call of overloaded ‘NoDestructor(<brace-enclosed initializer list>)’ is ambiguous
           });
            ^
    In file included from ../../net/dns/host_resolver_impl.cc:42:
    ../../base/no_destructor.h:62:3: note: candidate: ‘base::NoDestructor<T>::NoDestructor(const base::NoDestructor<T>&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’ <deleted>
       NoDestructor(const NoDestructor&) = delete;
       ^~~~~~~~~~~~
    ../../base/no_destructor.h:60:12: note: candidate: ‘base::NoDestructor<T>::NoDestructor(T&&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’
       explicit NoDestructor(T&& x) { new (storage_) T(std::move(x)); }
                ^~~~~~~~~~~~
    ../../base/no_destructor.h:59:12: note: candidate: ‘base::NoDestructor<T>::NoDestructor(const T&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’
       explicit NoDestructor(const T& x) { new (storage_) T(x); }
                ^~~~~~~~~~~~

See also: https://chromium-review.googlesource.com/c/chromium/src/+/1170905

Bug: 819294
Change-Id: I821c5215bf39c9c3caf50c614710dba551b0a19a
Reviewed-on: https://chromium-review.googlesource.com/c/1352353Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611593}

This will add jar library for android 4.1.2 (API level 16).

Bug: webrtc:9955
Change-Id: I2428a7b65fbd83553deddd12ca655e8242ebf234
Reviewed-on: https://chromium-review.googlesource.com/c/1348044
Commit-Queue: Artem Titarenko <artit@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611592}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a1201f66f4b..80a54408f352


Created with:
  gclient setdep -r src-internal@80a54408f352

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6755d12b337b60a9228f71a518a46876660c5470
Reviewed-on: https://chromium-review.googlesource.com/c/1352992Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611591}