- 19 Mar, 2020 40 commits
-
-
Simon Zünd authored
Two of the tests need a new baseline due to timing changes. The rest can simply be re-enabled. We will keep an eye on the flakiness dashboard to ensure that the timing is stable for the re-baselined tests. R=petermarshall@chromium.org Bug: chromium:1032016 Change-Id: I9dc199d74e1cedcaa42722483c5d3abb8c75bbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109770Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#751642}
-
Fredrik Söderqvist authored
This restructures SVGMaskPainter to use a RAII-structure similar to that of ClipPathClipper. ScopedSVGPaintState is adjusted, and simplified, accordingly. Change-Id: Ib783f77d487fdae8bec842ed7e9dfc6a2c4a9686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107491Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751641}
-
Kyle Horimoto authored
Previously, it was part of search.mojom, but this was confusing since it's not fully related to search. Actual search functionality is added in follow-up CL https://chromium-review.googlesource.com/c/chromium/src/+/2103523/. Bug: 1059099 Change-Id: I1bb14f678a56aef6025bb53485f9e72021557b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109236Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#751640}
-
Koji Ishii authored
Following bot results are included. 1743 1744 1748 1749 1750 1751 1752 1754 1758 1761 1762 1763 1764 1765 1766 1767 1768 9 lines were removed and 6 lines were deflaked by consecutive results since 1744. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I657be3b5b84b6ddf6a56b8b27d2b36453a8bbd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106703Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751639}
-
Kei Nakashima authored
Implemented |HeapNewLinkedHashSet|, which inherits from NewLinkedHashSet. Along with this change, added allocator to template parameter of NewLinkedHashSet and VectorBackedLinkedList. Also added a test for it. Change-Id: I277b8542924d52c1fa4eb7815f2feac0074ed4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105667 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751638}
-
Yoshifumi Inoue authored
This patch changes |NGInlineFragmentTraversalTest| to ignore when NGFragmentItem runtime feature enabled because NGFragmentItem doesn't use it. Bug: 982194 Change-Id: I2fc93d85a41813d61ee0e7f6a2000dd968dc4e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108459 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#751637}
-
Anders Hartvoll Ruud authored
We currently have a (WPT-enforced) bug where custom properties that reference guaranteed-invalid values [1] behave themselves as guaranteed- invalid. This is not correct per spec, which requires the custom property to behave as 'unset' in this case. This was clarified in [2], although the spec has described this behavior long before that. Unfortunately Firefox has the same issue. Safari on the other hand, does implement it correctly. [1] https://drafts.csswg.org/css-variables/#guaranteed-invalid [2] https://github.com/w3c/csswg-drafts/issues/4075 Bug: 980930 Change-Id: I84a0da3aad6b72b574009d560eb868632769098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108026 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751636}
-
Javier Ernesto Flores Robles authored
Bug: 1045452 Change-Id: I30fb363cef256a2622beebbf64330f0b3cfc57b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106845 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#751635}
-
Maggie Chen authored
This reverts commit 34ad7c1a. Reason for revert: <This is not one which breaks the GPU FYI bots> Original change's description: > Revert "Fix WebGL PushFrame crash when GetDrawingBuffer returns NULL" > > This reverts commit 3b813a2b. > > Reason for revert: <This is the suspected CL that breaks 12 GPU FYI bots on webgl2_conformance_validating_tests, webgl2_conformance_gl_passthrough_tests, webgl2_conformance_tests, webgl_conformance_d3d9_passthrough_tests and webgl_conformance_vulkan_passthrough_tests. Will come back to check the FYI results to decide if reland is needed.> > > Original change's description: > > Fix WebGL PushFrame crash when GetDrawingBuffer returns NULL > > > > Bug: 1059491 > > Change-Id: I6df4870cb8ece3986a2ad0fecd28b50593ae2e8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108874 > > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: Shrek Shao <shrekshao@google.com> > > Cr-Commit-Position: refs/heads/master@{#751547} > > TBR=kbr@chromium.org,kainino@chromium.org,shrekshao@google.com > > Change-Id: I1b88f2e4f36b69c6a4daf07d0fc4ee21830ebe1c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1059491 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109460 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751623} TBR=kbr@chromium.org,kainino@chromium.org,magchen@chromium.org,shrekshao@google.com Change-Id: I2a74f8f550378381ae4a0af7f54fe42979147768 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106998Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751634}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeTest| to work with both |NGFragmentItem| and |NGPaintFragment| for migrating |NGFragmentItem|: - CreateLineBidiIsolate: removed because it is covered by another test and hard to adapt to |NGFragmentItem|, for ease of - CollectInlinesShouldNotClearFirstInlineFragment: NGFramentItem doesn't implement first inline fragment yet. - ClearFirstInlineFragmentOnSplitFlow: utilize |NGInlineCursor| Bug: 982194 Change-Id: I2d25ef09f1982593d67b1cdffebe925bb7ebe282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109572 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/2096165. This CL simplifies the code by removing Vector and base::Optional that are no longer needed. This CL doesn't change the behavior. Bug: 848607 Change-Id: I6a76b240a02c01b712702a594d403547d40b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108206Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#751632}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d65a790d71e8..d99b64678d6a git log d65a790d71e8..d99b64678d6a --date=short --first-parent --format='%ad %ae %s' 2020-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 21cbc653..05edc003 (738 commits) 2020-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d24752e63ae4..dadeffa315e7 (16 commits) Created with: gclient setdep -r src/third_party/skia@d99b64678d6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ia402e53e8a277b9329d44047150f8f1c6f2990e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751631}
-
Frank Tang authored
The code record the metrics is in https://chromium-review.googlesource.com/c/chromium/src/+/2079299 Bug: 1056846 Change-Id: I70eb1b715aad8162d2762abd90c0e8ebcefa4b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092942 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751630}
-
Mike West authored
This reverts commit 5c44b2a9. Reason for revert: cros_browser_sanity_test failures beginning in https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/361. Only the ThinLTO bot is failing, which make me suspicious of this change. Original change's description: > compiler: remove `!is_android` from CrOS thinlto checks > > This was originally added for linux-chromeos builds. Now that we have > is_chromeos_device here, it's redundant, and it unintentionally disables > ThinLTO/CFI for ARC pieces of non-linux CrOS builds. > > Bug: 1062713, 1050199 > Change-Id: I27022ed72597a90ae7d2bb385729550fa8d772e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108822 > Reviewed-by: Bob Haarman <inglorion@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751505} TBR=thakis@chromium.org,gbiv@chromium.org,bpastene@chromium.org,inglorion@chromium.org Change-Id: I57aafeaa0e4f6bb60c22f8ea0b085282869fffd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062713, 1050199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109752Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#751629}
-
Anders Hartvoll Ruud authored
The spec does not say that a whitespace is required here, yet Blink requires it. This aligns us with Firefox, Safari and spec. Bug: 1053910 Change-Id: I7b1d00e6b6c5003039601765eaf3a738e59f52dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107487Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96f5a877f9c0..53a925b3221a Created with: gclient setdep -r src-internal@53a925b3221a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I845c604d6166c87e4d768132cba53cca27da2f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751627}
-
Luciano Pacheco authored
Change the search box to not hide until mouse up event, when focus is moved due to a user click. This fixes the issue where user clicks in a button and the search box is hiding, which can cause the click event to not be dispatched to the button that user intended. Bug: 1061894 Change-Id: I3dc1fb1eb2a3d4bcc6c55de7470f065dfd3b7a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108411Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#751626}
-
Mike West authored
This reverts commit 0fac3886. Reason for revert: `virtual/controls-refresh/color/color-picker-from-color-suggestion-picker.html` test failures beginning in https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/9370. Original change's description: > Fixed color-picker style when opened from datalist via Other button. > > The issue was caused by the fact that the color-picker style wasn't added > when constructing the color-suggestion-picker popup. > > Added a test to validate the change and prevent future regressions. > > Bug: 1062501 > Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751610} TBR=tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com Change-Id: I8f55d4ca75cf35bea0da47ba9f79a422ee87bd9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107845Reviewed-by:
-
Ye Kuang authored
* luci-go's `isolate archive` requires `-isolate` flag. * we also enable `-dump-json`, which dumps a JSON file that contains the SHA1 hash of the isolated file. Tested on the following command: ``` tools/mb/mb.py run -s --no-default-dimensions -d pool chromium.tests -d device_os KTU84P -d device_type hammerhead out/Release/ base_unittests -- --test-filter FakeClass#fakeTest ``` It runs successfully. Bug: 1062881 Change-Id: I46af6679e43d3af6bfed797485cb485b39235733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105272Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#751624}
-
Maggie Chen authored
This reverts commit 3b813a2b. Reason for revert: <This is the suspected CL that breaks 12 GPU FYI bots on webgl2_conformance_validating_tests, webgl2_conformance_gl_passthrough_tests, webgl2_conformance_tests, webgl_conformance_d3d9_passthrough_tests and webgl_conformance_vulkan_passthrough_tests. Will come back to check the FYI results to decide if reland is needed.> Original change's description: > Fix WebGL PushFrame crash when GetDrawingBuffer returns NULL > > Bug: 1059491 > Change-Id: I6df4870cb8ece3986a2ad0fecd28b50593ae2e8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108874 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#751547} TBR=kbr@chromium.org,kainino@chromium.org,shrekshao@google.com Change-Id: I1b88f2e4f36b69c6a4daf07d0fc4ee21830ebe1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109460Reviewed-by:
-
Gyuyoung Kim authored
Null crashes and flakiness test failures have taken place after converting WebTestHostMsg_InitiateCaptureDump and BlinkTestHostMsg_PrintMessage. The flakiness happened when a message came from different frames almost simultaneously. But, existing implementation was implemented by using Remote instead of AssociatedRemote. So, a race condition happened. Clusterfuzz has reported crashes that happened in BlinkTestController. The crashes happened in case of when BlinkTestClientImpl called functions of BlinkTestController even after BlinkTestController was destroyed. So, this CL makes BlinkTestController inherit BlinkTestClient interface directly in order to completely eliminate the possibility of the crash. Bug: 1059322, 1059474, 1061180, 1061328, 1061441 Change-Id: Icd499c76e812565e24afd1d7ebf54b82202cf88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104567 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Maggie Cai authored
Currently the storage of preferred app takes up too much space. This CL introduce an optimized storage data structure. Start with the add and find functionality. This CL also ports in the relevant unittests from the original data structure to ensure the test still passed. More unit tests will be added in follow up CL. BUG=853604 Change-Id: I88e57033dde98275a638e64496e0fe86a15e880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108302 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#751621}
-
arthursonzogni authored
[Note to sheriff] Feel free to immediately revert this CL if this test is failing in the next 3 days. This test was marked flaky 2 years ago, but nobody was assigned or CC. As a result, it hasn't been properly investigated. This patch enables it again. If it works, great. If it doesn't work we will get useful data about it. R=mkwst@chromium.org Bug: 745887 Change-Id: I0c50d61992dd56a13aee891e4eedfd14c43bc9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108144 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9f2f702a988..96f5a877f9c0 Created with: gclient setdep -r src-internal@96f5a877f9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If18251ce726129f14630f08001a1400927e880c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109611Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3b92b910ce0..d65a790d71e8 git log d3b92b910ce0..d65a790d71e8 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 440fc9959f06..bc98fbeec99b (3 commits) Created with: gclient setdep -r src/third_party/skia@d65a790d71e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I1a4b12d463849bbda875e6d003d0940547327025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109610Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL modifies generated files affected by https://chromium-review.googlesource.com/c/chromium/src/+/2109570 Bug: 906850 Change-Id: I4891492ed2fe88a8dbf24cbdb3b1a9d27c317309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109511 Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751617}
-
Eriko Kurimoto authored
This CL changes the WorkerGlobalScope's SecurityOrigin for workers constructed in chrome-extension. Previously, workers didn't inherit the origin from their parents but create security origin from their url. SecurityOrigin::Create(creation_params->script_url); Usually, the result of this is the same with inheriting the parent origin since workers are same-origin only. However, in chrome-extension, it is allowed to construct a cross-origin worker if the script url has the permission. In this case, we should inherit the origin with 'chrome-extention://example/' so that the |request_initiator| matches to what the browser can see. This CL also adds the test for subresource fetch from dedicated workers and shared workers constructed in chrome-extension. This test covers the case that worker's script url is cross-origin to chrome-extension but included in permitted urls by chrome-extension. The worker should allow same-origin and cross-origin fetch unless the script url is not permitted by chrome-extension. Bug: 1059218 Change-Id: I498399275d3b4c2c3085e26a8e37145aa74f1d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091327Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#751616}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/33997f3d931a..64e0899efa07 git log 33997f3d931a..64e0899efa07 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 mjackson@microsoft.com Avoid automatically reloading DevTools on Theme change 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@64e0899efa07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1001549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia73dc166bc529a025c7dc85cb87e3ed887c1b3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109612Reviewed-by:
-
Alan Screen authored
The print compositor is now able to concurrently generate the print document while compositing the individual pages for preview. When this is happening we can improve the renderer by not collecting and capturing a full document object. Testing: On Windows platform watching the "Peak Private Bytes" in Process Explorer, observed an increase of renderer process memory of only 59MB, roughly about the size of one page's worth of metadata. This is much less than the hundreds of megabytes that it used to grow by when the renderer would still create the full document metafile. This was observed for the testcase [1] (taken from prior issue 872935). [1] https://www.gmbinder.com/share/-LFhhtssjN-teWCOregn Bug: 1026968 Change-Id: I697ebd4129722c63e4847d54a65d75a4b3e9f1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068936 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751614}
-
Joel Hockey authored
System Web Apps use a domain such as chrome-untrusted://terminal which should not be shown to users. The concept of a domain for System Web Apps is not so useful, and should not be required for users to identify or differentiate between tabs in a System Web App browser. Bug: 1060863 Change-Id: Ib0fe04b6d6d982162c89d6599522da8669d2553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108218 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751613}
-
nancy authored
Add "Learn more" link for the PWAs unisntall dialog per UX deck: https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g6e0ab3bcaa_0_0 https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g7d0934dbfa_0_0 Mock dialog: https://photos.app.goo.gl/AtQfZr9RYKH5HsMi9 Move OnDialogCancelled and OnDialogAccepted to keep the consistent order as the definition in *.h file. BUG=1010303 Change-Id: I5c955940643c3753e68fca6aa9a3d07aed226615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106986 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f955fb455585..dadeffa315e7 git log f955fb455585..dadeffa315e7 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 jmadill@chromium.org Capture/Replay: Fix stride in compressed texture caching. Created with: gclient setdep -r src/third_party/angle@dadeffa315e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I715e200fe27e3d8d5d20e5e819444a84862f6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109265Reviewed-by:
-
Ionel Popescu authored
The issue was caused by the fact that the color-picker style wasn't added when constructing the color-suggestion-picker popup. Added a test to validate the change and prevent future regressions. Bug: 1062501 Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
-
Alan Cutter authored
Bug: 1007786 Change-Id: Idd730b35e0cead74b10ff758c1339f18c5a6e754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105187 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751609}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43f82417b9f711be4d69560cb6c15c8766d51b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109211Reviewed-by:
-
Karandeep Bhatia authored
Currently the single static indexed ruleset for an extension is stored at $extension_path/_metadata/generated_indexed_ruleset. Since we plan to support multiple static rulesets, we need to store multiple indexed rulesets. This CL changes the static indexed ruleset location to $extension_path/_metadata/generated_indexed_rulesets/_ruleset$ruleset_id. This helps us move the code away from the assumption of a single static ruleset. As a result of this existing extensions with a DNR ruleset will initially fail to load the DNR ruleset. However the re-indexing logic should step in and ensure the extension works seamlessly. A side-effect for these extensions is that the old indexed ruleset will remain on disk. However this is ok since the API is still on beta and doesn't have significant usage yet. Furthermore, we do periodically clean up extension folders after extension updates. BUG=754526 Change-Id: Id3bd6c1e25fde4ceb1a34f9f84c67bfa340790ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094626 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds a constructor of MainScriptResponse which takes URLResponseHead. Tests and ServiceWorkerNewScriptLoader use the new constructor to reduce HttpResponseInfo use in service worker codebase. Bug: 1060076 Change-Id: I884efa7c1e15789ef46fdab0998136c0f9695d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105183 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751606}
-
Yury Semikhatsky authored
When browser shutdown started pipe file descriptors are closed on the UI thread while there may be outstanding reads and writes on parallel threads. If such read/write operations fail error messages will only be written to the console if pipe shutdown has not begun yet. Bug: none Change-Id: I57e9b6c7f2921335cc2bb1f5289bd9347bba1f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108825Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#751605}
-
https://crbug.com/1006814Fergal Daly authored
Record whether we are currently in the middle of dispatching handlers for process-death as this is a stronger contender for how this is occurring. Bug: 1006814 Change-Id: I0d269c250a870c25088e92c4b207e7fa647f0bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106987Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751604}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1574c49c4f09..33997f3d931a git log 1574c49c4f09..33997f3d931a --date=short --first-parent --format='%ad %ae %s' 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@33997f3d931a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a625cd533f41470a171f9027adbb58d9af9c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108499Reviewed-by:
-
