- 13 Nov, 2018 18 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4e5c96a85d0f2d2fbd3128fa45e23d44e3241450 Reviewed-on: https://chromium-review.googlesource.com/c/1332827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607395}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I99aaf539ac5fcf25402e62266d2eb97328ab4550 Reviewed-on: https://chromium-review.googlesource.com/c/1332808Reviewed-by:
-
Lily Chen authored
This reverts commit 668af6e3. Reason for revert: Bug in RespectLimits where a ConnectJob with the IGNORE_LIMITS flag set is associated with a Request that does not have that flag set. Original change's description: > Add reprioritization to TransportConnectJobs > > This change makes it possible to reprioritize socket pool ConnectJobs > to match their corresponding Requests. For TransportConnectJobs that are > reprioritized while undergoing host resolution, the corresponding host > resolver request is also reprioritized to match the connect job. > > Bug: 166689 > Change-Id: Icaed423c6f363fa15e9e379aa135a3b98330d1a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1320210 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606129} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689 Change-Id: I02f58f99a9391871962b0c96df643e2a85403330 Reviewed-on: https://chromium-review.googlesource.com/c/1331141Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#607393}
-
Nektarios Paisios authored
Handles list markers (including NG) when finding the containing DOM node of an AXLayoutObject that has no associated node We need to have a generic function that given an AXLayoutObject will return either the associate DOM Node, or if the layout object has no node attached, the containing DOM node. This functionality is required in cases such as the following: 1. An accessibility selection has one of its endpoints at a list marker and the user asks us to select the closest DOM selection possible. We need to move the endpoint that is on the list marker to an object that has a DOM node attached, e.g. the containing DOM node of the AXLayoutObject representing the list marker. 2. A user wants to know if a layout object is editable. We need to find if the attached or containing block node is editable. R=aboxhall@chromium.org, dmazzoni@chromium.org Change-Id: I4572b7b024f61518b7da61a61e6916c623d4d3dc Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/1331131 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607392}
-
Alex Newcomer authored
When the tablet mode transition was added to Apps.AppListShowSource, the enum was not updated. Just add a third enum entry. Bug: 904131 Change-Id: Icaee0f359b42621381c19f8d5cfe9a62ef2cd51d Reviewed-on: https://chromium-review.googlesource.com/c/1331034Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607391}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4169b31..1147fc2 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I793c8f0c4613fc7080991c082b6e8190765f7f25 Reviewed-on: https://chromium-review.googlesource.com/c/1331947Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607390}
-
siyua authored
Uploaded screenshots in the bug (comment#16) Bug: 897998 Change-Id: I83aaf75efaf49ed2adda3a4773aacdc10caedb32 Reviewed-on: https://chromium-review.googlesource.com/c/1330756Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#607389}
-
David Black authored
Previously the URLs for Assistant Settings/Reminders were not asserted, only their presence was checked. That is now fixed. Also added a helper method for creating a localized GURL. Bug: b:119280255 Change-Id: Id01594919940fc96f90892d6adbc91ebf7e1cd29 Reviewed-on: https://chromium-review.googlesource.com/c/1328221 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#607388}
-
Ahmed Fakhry authored
Temporarily disable Feedback in the login screen until we're able to delete the signin profile once logged in. See more details on the bug. BUG=899092 Change-Id: Ib1045d3e460ab39391e2da8dd9cbb5afea056ace Reviewed-on: https://chromium-review.googlesource.com/c/1332264 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#607387}
-
Eugene But authored
Now SadTabCoordinator will be used instead SadTabLegacyCoordinator for SadTab UI presentation. SadTabLegacyCoordinator does not use view controller and presents SadTab UI with WebState::ShowTransientView, which is misuse of WebState API. SadTabCoordinator is disabled by default and can be enabled via kPresentSadTabInViewController feature flag. Bug: 901563 Change-Id: I34dd6ae99255e5fe0b3ef100265c78169d619a50 Reviewed-on: https://chromium-review.googlesource.com/c/1329924 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607386}
-
David Roger authored
Remove whitespace at end of lines. Vertically align the columns. Change-Id: I6dbcb667c82c58f26a25c0d07d3ba3eeb8f2ad12 Reviewed-on: https://chromium-review.googlesource.com/c/1331390Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607385}
-
Philip Rogers authored
This patch fixes a typo where kTouchStartOrMoveEventBlocking was used instead of kTouchStartOrMoveEventBlockingLowLatency. Change-Id: I33e739c95755514517b4107b0f4fc662ffdcb4ac Reviewed-on: https://chromium-review.googlesource.com/c/1332388Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cb830a07e835..7f1ac04ec34e git log cb830a07e835..7f1ac04ec34e --date=short --no-merges --format='%ad %ae %s' 2018-11-12 shapiroc@chromium.org chromite: Make most release hwtests async Created with: gclient setdep -r src/third_party/chromite@7f1ac04ec34e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icc47bba8ac063c5d52866a6cb4a7913b303c308b Reviewed-on: https://chromium-review.googlesource.com/c/1331582Reviewed-by:
-
Wenzhao Zang authored
Bug: None Change-Id: Iea33829fefcc53f868d0021e1e9b3786b2285329 Reviewed-on: https://chromium-review.googlesource.com/c/1332416Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6521150ae99..6374fa323c0e Created with: gclient setdep -r src-internal@6374fa323c0e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1c86d93caa52dbf400a7a27114312cd83c0e8cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1332348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607381}
-
Olivier Robin authored
Chrome iOS stopped supporting ios10. Bug: 904393 Change-Id: I89e9cfe5cc27e8ef94feb5e8b404e1fc8d8264d7 Reviewed-on: https://chromium-review.googlesource.com/c/1329968 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607380}
-
Charlie Harrison authored
There was way too much nesting in ContentSettingBlockedImageModel. This CL tries to tease apart some of the logic, and reduce nesting via early-return pattern. Bug: None Change-Id: Ida0acf144bf4b6d1217541feb7b7e304e89fc12c Reviewed-on: https://chromium-review.googlesource.com/c/1330346 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#607379}
-
Justin Cohen authored
This test is getting close to 30 minutes. There are 6 test cases, so sharding it to 2 tests cases per will use 3 machines, and bring test runs closer to ten minutes. This also renames the test cases to end in TestCase, which is how sharding does it's math. Change-Id: I7c4f58e89534b1d526fbfc026cbecb76c61a745e Reviewed-on: https://chromium-review.googlesource.com/c/1331130Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607378}
-
- 12 Nov, 2018 22 commits
-
-
Maggie Chen authored
The histogram GPU.GPUProcessSoftwareRendering recorded in GpuProcessHost::LaunchGpuProcess() does not have a correct software rendering status. GpuInit::InitializeAndStartSandbox() is where we check if we are doing software rendering. A new histogram GPU.GLImplementation is added to record all GL modes. If the GPU.GLImplementation mode is kGLImplementationSwiftShaderGL, the GPU process is running with software rendering. Bug:899361 Change-Id: Ie2ef9b84c4055a2407128c3f4f27fbd802445485 Reviewed-on: https://chromium-review.googlesource.com/c/1317923Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
John Budorick authored
No-Try: true Tbr: nednguyen@google.com,sergeyberezin@chromium.org Bug: 903849 Change-Id: Ib6ca07f44fcb27a9f2b6cb665fbc856539d91698 Reviewed-on: https://chromium-review.googlesource.com/c/1331875 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607376}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 766678 Change-Id: I51f5ca1c02138ff83229148f833f53bf1c0a1c8e Reviewed-on: https://chromium-review.googlesource.com/c/1325208Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#607375}
-
Doug Arnett authored
With NoScript and OptimizationHints launch, the ALLOWED_WITHOUT_OPTIMIZATION_HINTS case is no longer needed so this CL cleans up the bloat for it. Bug: 895581 Change-Id: Id32bd5f462f646275029021238b3ea291d6eccb1 Reviewed-on: https://chromium-review.googlesource.com/c/1323707 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#607374}
-
Danan S authored
This change adds a message bubble to the login screen and generates a system notification on login for Supervised Users, both of which indicate that the Supervised User feature is to be deprecated. Bug: 899017 Change-Id: I05b684f183a47b6275442caf8e7a4820bda0374e Reviewed-on: https://chromium-review.googlesource.com/c/1324310 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607373}
-
Hiroshi Ichikawa authored
This reverts commit 87db0e76. Reason for revert: The original CL was reverted as a culprit of a flaky crash. But it turned out to be innocent per discussion in https://crrev.com/c/1329972. Original change's description: > Revert "Add more information to |error| of -didFailFavigationWithSSLError:." > > This reverts commit af760c91. > > Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. > > Original change's description: > > Add more information to |error| of -didFailFavigationWithSSLError:. > > > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > > > Bug: 898037 > > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > > Reviewed-by: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#607127} > > TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org > > Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 898037, 904345 > Reviewed-on: https://chromium-review.googlesource.com/c/1329972 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607205} TBR=phoglund@chromium.org,eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: I4ac81df8f2c1386acc0683c0a03e5d022a826b95 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037, 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1332967Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#607372}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1e9fc1aac107..f343a1576406 git log 1e9fc1aac107..f343a1576406 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 dj2@everburning.com Add missing overrides (#2041) 2018-11-12 dj2@everburning.com Remove asserts around environment determination. (#2040) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f343a1576406 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I09c5ee6001663cac53d06954a0d726d8d5641d11 Reviewed-on: https://chromium-review.googlesource.com/c/1332087Reviewed-by:
-
Ken Rockot authored
ServiceFilter will replace usage of Identity in APIs which take or require only a partial Identity. This CL adds the mojom and C++ type (with type-mapping) and updates Connector's mojom to use ServiceFilter instead of Identity where appropriate. Implementations of Connector are updated accordingly. Follow-up CLs will transition callers to explicit use of ServiceFilter and then finally change Identity to no longer have optional fields so that all uses refer to concrete service instance identities. Bug: 902590 Change-Id: I8587f2c7ba15a68d5d873f207ec8fa99dc0e7312 Reviewed-on: https://chromium-review.googlesource.com/c/1330895 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607370}
-
Shawn Gallea authored
An incomplete implementation of the fullscreen shell protocol, separated from server.cc to allow selective compilation for different platforms that support EXO. The rest of the protocols within server.cc will be refactored in future CLs. Bug: 896710 Test: Compiled on ChromeOS, works with fullscreen client Change-Id: Idda3b73c97c72e5efd16dfe1f7c79831587c8066 Reviewed-on: https://chromium-review.googlesource.com/c/1299838 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#607369}
-
liberato@chromium.org authored
Adds a RandomTree that splits on features by decreasing entropy improvement. It does not select a random subset of features when deciding on each split. It also does not stop growing the tree when no improvement is found, including pure leaves. Bug: 902857 Change-Id: I742f64c71fd535bd7acc20b02b6478b20d9dae24 Reviewed-on: https://chromium-review.googlesource.com/c/1324130 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#607368}
-
James Darpinian authored
Many of these are leftover failure expectations from fixed bugs. Some were fixed on some platforms but not others. There are some new failures that were hidden by previous broad suppressions. Also some tests are only failing because we haven't updated the drivers on the bots (http://crbug.com/887241). Bug: 757097, 838133, 672380, 625738, angleproject:2325 Bug: 534697, 849572, 625738, 703779, angleproject:2142 Bug: 757098, 644740, 705865, 602688, angleproject:2103 Bug: 903903, 740769, 662644, 680720, angleproject:1932 Bug: 709874, 887241, 625365, angleproject:2952 Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00 Reviewed-on: https://chromium-review.googlesource.com/c/1325197 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Evan Stade authored
It doesn't appear to flake on desktop Linux or Chrome OS (ash or mash). Bug: 69475 Change-Id: I6bebb08d7dd1bca61cc952eb58105eab0d67a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/1327148 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607366}
-
liberato@chromium.org authored
Rather than sending (Instance, TargetValue), just bundle it up into TrainingExample. Change-Id: I145dd136af2fec8e2d1177ad8c9fc42dd2e79cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1318389Reviewed-by:
-
Joe Mason authored
R=proberge@chromium.org Bug: 830892 Change-Id: Ib22499d88a2fdb160a083eeb904e17e24a96edfc Reviewed-on: https://chromium-review.googlesource.com/c/1331876Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#607364}
-
Charlie Harrison authored
The image model for the popup setting is currently a ContentSettingBlockedImageModel. This CL makes it inherit from ContentSettingSimpleImageModel in order to make policy changes easier to make moving forward, including making the image visible in non-blocked cases (e.g. an ambient UX). This CL has no intended behavior change. Bug: 82362 Change-Id: Ib49c5c0d428017ef566b465cb4cb1fb8a0ab79e1 Reviewed-on: https://chromium-review.googlesource.com/c/1331908Reviewed-by:
-
Qiyu Hu authored
On each LE advertisement event, we forward the event along with the EIR such that it's closer to the behavior in Android. Please review along with ag/5453291 Bug: chromium:887029,b:118334521 Test: CtsVerifier Change-Id: I4f56ef5e30087768acb7e897c5345380ffb7a633 Reviewed-on: https://chromium-review.googlesource.com/c/1321581Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#607362}
-
Kristi Park authored
Bug: 903265 Change-Id: Id36168aa8b5db879e2ea63a7e22bc4b1492053da Reviewed-on: https://chromium-review.googlesource.com/c/1331581Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607361}
-
S. Ganesh authored
IElevator is registered with unique IIDs for the various flavors of Chrome and Chromium. This allows the different flavors of Chrome/Chromium to co-exist without side effects. Bug: 833687 Change-Id: Icbba17012165cc9e3c04a47590a78b54bec761e7 Reviewed-on: https://chromium-review.googlesource.com/c/1327352 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607360}
-
Findit authored
This reverts commit 4cde6da1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607282 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGNkZTZkYTFiNmM4NTM0YjEyZGJlOGNlZDc2NTY1MTE2NWYyYmNlMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/72883 Sample Failed Step: sync_integration_tests Sample Flaky Test: USS/TwoClientWalletSyncTest.UpdateCreditCardMetadata/1 Original change's description: > [AF] Add integration tests for wallet metadata > > This CL creates the first integration tests for the autofill wallet > metadata model type. > > Bug: 894001 > Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23 > Reviewed-on: https://chromium-review.googlesource.com/c/1306357 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607282} Change-Id: I6021aa4d092acfeb62f635bc04c76b7c11738101 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894001, 904577 Reviewed-on: https://chromium-review.googlesource.com/c/1332393 Cr-Commit-Position: refs/heads/master@{#607359}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4b94156. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" 395cf32d "Preparation of moving LayoutTests to web_tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Idd4c64b8b5158fac5d75aa0c13783bde42017fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1331616 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607358}
-
Pavel Feldman authored
Change-Id: I5aaebd553669d9b6594105edd4ba18f6b4701d20 Reviewed-on: https://chromium-review.googlesource.com/c/1331037 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607357}
-
Orin Jaworski authored
Pedal suggestions are styled like new answers and entities with this CL. The logic for deciding layout is also clarified. Bug: 893183 Change-Id: Id7f4ad9e8a0d6aeffcbe623db65f29107aa79b52 Reviewed-on: https://chromium-review.googlesource.com/c/1330709Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607356}
-
