GitLab

This CL is part of the Mojo Video Capture work.
Design doc for dev work [1].

Before this CL, the ServiceVideoCaptureProvider had to be uninitialized manually
by its client, in our case VideoCaptureManager, in order to close the connection
to the video capture service and, in turn, allow the service to shut down.
VideoCaptureManager only called Uninitialize() at the end of a video capture
session. But it would not call it after enumeration-only use of the service.
This would lead to the service potentially staying alive indefinitely after
enumeration-only usage that is not followed-up by a capture session. Usage logs
indicate that this actually happens quite frequently.

After this CL, ServiceVideoCaptureProvider uninitializes the service connection
automatically as soon as there is no active usage.

Bug: 584797

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Change-Id: Ia33507f4fe0a36b804b2636c41af6d807fab8c0d
Reviewed-on: https://chromium-review.googlesource.com/578558Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488726}

TBR=benjhayden@chromium.org
BUG=689520

Review-Url: https://codereview.chromium.org/2890853002
Cr-Commit-Position: refs/heads/master@{#488725}

Revert "Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"""

This reverts commit 724ac890.

Reason for revert: Still flakes net_unittests on some bots.

BUG=747424,705029

Original change's description:
> Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager""
> 
> This is a reland of 9c083706
> Original change's description:
> > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"
> > 
> > This is a reland of a66ebc8a
> > Original change's description:
> > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager
> > > 
> > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
> > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.
> > > 
> > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.
> > > 
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> > > 
> > > BUG=705029
> > > 
> > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
> > > Reviewed-on: https://chromium-review.googlesource.com/562604
> > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: Yixin Wang <wangyix@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#486519}
> > 
> > Bug: 705029
> > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> > Reviewed-on: https://chromium-review.googlesource.com/571044
> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: Yixin Wang <wangyix@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#487342}
> 
> Bug: 705029
> Change-Id: Iefb798a8c4d54263e5e8f47bc5d1c63c04d72f77
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/576349
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Commit-Queue: Yixin Wang <wangyix@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487990}

TBR=mpearson@chromium.org,rch@chromium.org,zhongyi@chromium.org,wangyix@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 705029
Change-Id: Icadb2cc56c2e83f2dfdf5dfb327c5d0544bad3d3
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/581627Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488724}

Change-Id: Ibc7e908d7d0ae3805d5b3edeb59d9933fe5b6620
Reviewed-on: https://chromium-review.googlesource.com/581739Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488723}

Bug: 737271
Change-Id: Ic87eed4db221b93d4aca8d7bead66a4208b4b53f
Reviewed-on: https://chromium-review.googlesource.com/571174
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488722}

Tries to deal with the most egregious bugs reported by VFO that have to do with selection.
R=dmazzoni@chromium.org
TESTED=Layout tests, manually with Jaws

Bug: 747452
Change-Id: I5806087e4c9871150fc33dd423641d61fadee1e3
Reviewed-on: https://chromium-review.googlesource.com/580541
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488721}

Current version of Fuchsia SDK doesn't include netstack, which will be
required to run many tests. Updated the SDK instructions to include the
following packages in the SDK:
 - netstack: netstack service.
 - runtime-config: bootstrap configs to run netstack.

I'll update test_runner.py to start bootstrap and netstack after the
SDK is updated with these packages.

Bug: 731302
Change-Id: Ida1870f2135a878ad9e036ac4e1858fc7039d1c4
Reviewed-on: https://chromium-review.googlesource.com/581947
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488720}

The CL add the AwVariationsSeedFetchService which is a JobService to fetch Finch
seed data from the Finch Server. It reuse some of the code from the
VariationsSeedFetcher, so I refactory the class to expose some reusable
function. The download is triggered by AwVariationsConfigurationService which is
a bound Service to managing the Finch seed data system-wide. The fetched seed
data is going to store in the local directory belongs to the Android WebView.
This is just a prototype of the Variations Seed Fetch Service which is one part
of the work of adding Finch to Android WebView, so there will be another CL
related to the AwVariationsConfigurationService.

BUG=733857

Review-Url: https://codereview.chromium.org/2975693002
Cr-Commit-Position: refs/heads/master@{#488719}

This relands "Make showcase home screen not translucent.".

Original change's description:
> Make showcase home screen not translucent.
>
> EarlGrey 1.10.1 has a bug that the scrollToTop action hangs
> indefinitely if the UITableView's navigation bar is translucent. Given
> that it makes no difference whether the view is translucent or not,
> this CL makes it not translucent to unblock rolling EarlGrey to 1.10.

Bug: 747116
Change-Id: I9c3af1633aac27439734925c142f8a684eeb9658
Reviewed-on: https://chromium-review.googlesource.com/580341Reviewed-by: Ed Chin <edchin@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488718}

10 shards with 20 min timeout. Sample shard:
https://chromium-swarm.appspot.com/task?id=377545056869e810

Bug: 670879
Change-Id: I8886aa6a2442532edeb8ad6bb1e0480938346ca3
Reviewed-on: https://chromium-review.googlesource.com/578447Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488717}

This changes two main things.  First, and most significantly, the
way we resolve a PpdReference is unified -- instead of trying
a make-and-model string or trying usb ids, now we have a single
function to which you supply everything you know about the printer
and it gives you back a PpdReference or a failure.

Second, the way we support UI make, model listings changes.  When
the user asks for a list of supported printers from a manufacturer,
instead of getting back just the names, now the api returns the
names paired with the corresponding PpdReference.  Before, the
user had to call back into the ppd provider to get the reference, which
meant we had a weird "have to call this before that" sort of constraint
which this removes.

All callsites and tests updated as well.

Bug: 744996
Change-Id: Ied385c087e4c3d6c1b21b924fcea772c786074c5
Reviewed-on: https://chromium-review.googlesource.com/580007
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488716}

There may be live streams still using it, causing crashes. As far as I
can see, this is the only dependency of audio streams which might be
used this way.

BUG=745676
R=dalecurtis

Change-Id: I70dfe49331de863a707cf6c2945e06c83b87c5b4
Reviewed-on: https://chromium-review.googlesource.com/579198Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488715}

This was merely a documentation issue; the actual CA was included within
the //net/data/ssl/symantec/excluded directory, and properly excluded by
//net/http/transport_security_state_ct_policies.inc, but the README file
unintentionally omitted it.

BUG=none
R=davidben@chromium.org

Change-Id: I62426618cfa58ad392a94999c4db71f22f70b1c3
Reviewed-on: https://chromium-review.googlesource.com/569003
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488714}

R=kbr@chromium.org

BUG=710673

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I323c5c020f62e4d388a5cae547b93887fc375640
Reviewed-on: https://chromium-review.googlesource.com/581348Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488713}

Now that the flags protecting jamessynge@'s HTTP2FrameDecoder have been
deprecated, we can begin cleaning up the old code.

Next step is probably to try to start sorting out the adapters.

This CL lands server change 162220378 by dahollings.

BUG=488484

Change-Id: I875f5a6448dc9c0bc765f62a5b6424510dc6ff6a
Reviewed-on: https://chromium-review.googlesource.com/581389Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488712}

Add i18n support for the host setup view. Also add missing strings in the
settings menu.

Bug: 747091
Change-Id: Ideea85dc2d0d9933e39bfe9c6e9a1b00a190291c
Reviewed-on: https://chromium-review.googlesource.com/580729Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488711}

Create a MetricsRecorder protocol that allows implementors to record
a metric for a given NSInvocation. Objects implementing this protocol
will be able to register with the dispatcher to be called when a
relevant selector is invoked on the dispatcher.

Bug: none
Change-Id: Icb0074f6d3857ea9b7c0043c052e5e35dc6598ec
Reviewed-on: https://chromium-review.googlesource.com/578305Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488710}

minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING
implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer.

GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE.
BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE.

TEST=run chrome on amd64-generic
BUG=683347

Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668
Reviewed-on: https://chromium-review.googlesource.com/549095Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488709}

The animation machinery in cc/animation currently makes unfortunate
assumptions about the meaning of the animations it processes. For
example, if you're animating an SkColor, it must be the background
color. You couldn't also animate your foreground color. This coupling
also prevents the system from being extended for use with things like
custom properties.

With this change, the animation machinery only treats interpolated
types (eg, SkColor, FilterOperations, etc) distictly, and lets the
target property be a generic annotation that is the business of
client of the animation system.

Bug: 747185
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idb3baf159c3da8531d75c7c8ba0a159fac197d48
Reviewed-on: https://chromium-review.googlesource.com/580608
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488708}

Adds a compiler warning that works in all compilation modes on
Clang/GCC, and in Prefast on MSVC. The rationale is all other
value-extracting CheckedNumeric<> functions already prevent the
caller from ignoring the validity state, but without this change
calling AssignIfValid() could silently ignore an invalid state.

Change-Id: I7e16f3cf7f026151ef39215bfe01c05e7c58b32f
Reviewed-on: https://chromium-review.googlesource.com/580296Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488707}

This reverts commit bb3210d3.

Speculative revert for crbug/744550

Bug: 744550
Change-Id: I0b8a2464c2932d00349d3fd9a80ba7595c929ff7

TBR=mark,rsesek

Change-Id: I0b8a2464c2932d00349d3fd9a80ba7595c929ff7
Reviewed-on: https://chromium-review.googlesource.com/580639Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488706}

This prevents appearing default Play Store icon on the shelf for AOSP
images.

Test: Unit test + manually
Bug: b/36133646
Change-Id: I90d05513d98c57a7ec514b66a8b468255434e841
Reviewed-on: https://chromium-review.googlesource.com/580646Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#488705}

Add timeout to force load the next background tab after the timer expires.

Bug: 730098
Change-Id: I6cbb26288a02fdd61ece85e42c3106fa8e20a33b
Reviewed-on: https://chromium-review.googlesource.com/580188Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488704}

Since M56, all Chrome build types that include proprietary codecs and
use the unified media pipeline have been able to demux and decode
FLAC-in-MP4, but canPlayType() hasn't been updated yet.

Further motivation to update that, a prerequisite for supporting
FLAC-in-MP4 with MSE in Chrome is that canPlayType('{audio,video}/mp4,
"flac"') needs to return "probably".

This change updates canPlayType() to indicate FLAC-in-MP4 is supported,
and includes new tests for src= FLAC-in-MP4.

A further complication is that MP4's AudioSampleEntry samplerate field
is fixed point 16.16 bits, so lacks range to handle bitrates above
65535Hz. The FLAC-in-MP4 spec [1] guides how to encode the correct
sample rate when it is outside this scale, and this change includes test
files at both 44.1kHz and 192kHz to verify FFmpegDemuxer extracts the
correct samplerate information.

Also, based on investigation leading to https://crbug.com/747050#c3,
this change includes a comment indicating lack of decode support for
*encrypted* FLAC (in any container) on Android (which would need FLAC
decode support directly in MediaCodec, rather than in MediaExtractor as
some devices appear to do). In the future, perhaps more refined logic
can be used to identify cases where encrypted FLAC-in-MP4 on Android is
supported by the device.

BUG=666000,747050
TEST=Added sfx-flac.mp4 FFmpeg AudioDecoderTest cases, basic media
playback browsertests for bear-flac.mp4 and bear-flac-192kHz.mp4,
FFmpegDemuxerTests, PipelineIntegrationPerfTests, and a
PipelineIntegrationTest; Updated MediaCanPlayTypeTests and
MimeUtilTest.ParseAudioCodecString;

Change-Id: I04df11c34aa539c53dd2c8868257f7ef9608ddc7
Reviewed-on: https://chromium-review.googlesource.com/580575Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488703}

Add some more code from ServiceWorkerContextRequestHandler to
ScriptURLLoaderFactory.  Also added small cleanup around IsInstalled.

Re-land of:
https://chromium-review.googlesource.com/544720 and
https://chromium-review.googlesource.com/547160

Bug: 715640
Change-Id: Iae432fb2619d1a3b05ba26cbce7563b93e86339d
Reviewed-on: https://chromium-review.googlesource.com/579030
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488702}

https://chromium.googlesource.com/external/gyp.git/+log/eb296f67da07..d61a9397e668

$ git log eb296f67d..d61a9397e --date=short --no-merges --format='%ad %ae %s'
2017-06-27 mblsha mac_tool.py: Handle non-zero ibtool return code.
2017-04-25 refack win: mkdir even when copying directory
2017-04-24 mark win ninja/make: Always use a native compiler executable with MSVS 2017
2017-04-24 mark Fix MSVC++ 32-on-32 builds after b62d04ff85e6
2017-04-24 dpranke Disable flaky test/copies/gyptest-all under msvs.
2017-04-24 refack win,ninja: ninja generator better on windows
2017-04-24 dpranke Clean up gyptest.py.
2017-04-21 dpranke Disable a bunch of tests on Mac.
2017-04-18 dpranke Update test/no-cpp/gyptest-no-cpp.

In order to support building clang with a locally installed copy of VC++
2017 using gn we need the latest version of tools\gyp.

BUG=683729

Change-Id: Id3420b00667f89b7eb33aa2227f2e8fdb8de180d
Reviewed-on: https://chromium-review.googlesource.com/579892
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488701}

Bug: 740257
Change-Id: Ib4b52311d30a663695f18ca6140b74531cb0d583
Reviewed-on: https://chromium-review.googlesource.com/581734Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488700}

Bug: none
Change-Id: I862fc5904a46ec51dcabe0df403b2e5c07169060
Reviewed-on: https://chromium-review.googlesource.com/574680
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488699}

This will help Linux distro packagers use system toolchain.

See included README file for context.

Bug: none
Change-Id: I82a5d34ab179b5f1ab1e0cbd12c51c3871ae876c
Reviewed-on: https://chromium-review.googlesource.com/575984Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488698}

Voice queries just simply close the launcher. We don't need
voice queries for Play Store app search.

Bug=736027

Change-Id: Ic34c45ad105c20598b6fc4bcb345883f55ccc012
Reviewed-on: https://chromium-review.googlesource.com/579958Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#488697}

Adds methods to SnapshotController and SnapshotController::Client for
the renovation framework. Also adds basic implementations to all
SnapshotController::Client implementors. This doesn't change the
behavior of the SnapshotController yet.

Design doc:
https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU

Bug: 736933
Change-Id: Iee15c54fa4524b1c09a87f6e6c43a8df8ea630ee
Reviewed-on: https://chromium-review.googlesource.com/580692Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Collin Baker <collinbaker@google.com>
Cr-Commit-Position: refs/heads/master@{#488696}

Native CUPS has been turned on since M59 and it has settled well.
The flag to turn it off is being removed.  Also clean up code that is
now extraneous.

Bug: 733793
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I351790c7f8f0a486743e190355af7922b0105676
Reviewed-on: https://chromium-review.googlesource.com/575829Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488695}

Implemented the webui protobuf that will collect information about the database status
as size, update, stores, and more.


Bug: 734667
Change-Id: If920b7c3d90b7e6dfd24c0256b3042900737d7a5
Reviewed-on: https://chromium-review.googlesource.com/578384
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488694}

Bug: 
Change-Id: I70fd0185bdf539a8e624bde60feb2df2ee1e02ed
Reviewed-on: https://chromium-review.googlesource.com/550870Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nick Ward <npward@google.com>
Cr-Commit-Position: refs/heads/master@{#488693}

This results reading "blank" in some cases, when in fact the line contains text.
R=dmazzoni@chromium.org
TESTED=Manually using Jaws, existing unit tests

Bug: 731067
Change-Id: I3c74e7c42a5178b5900df12e361e61cce318f0dc
Reviewed-on: https://chromium-review.googlesource.com/575684
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488692}

R=robliao@chromium.org
TBR=thakis@chromium.org

Change-Id: I7e4c530b89f6c21f0197b7b7db2ec3046b45732b
Reviewed-on: https://chromium-review.googlesource.com/581736
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488691}

The "PROP" pattern match checks and other checks except for "TREE"
are currently broken and it's somewhat difficult to make them workable.
It would be easier to check AST nodes directly. This CL drops "PROP"
checks and adds some unittests. Follow-up CLs will remove other checks
except for "TREE".

BUG=617899

Change-Id: Ifb7041ab971fc584b0a43e8ce465e2e30905f9d4
Reviewed-on: https://chromium-review.googlesource.com/581129Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488690}

To plumb RendererSettings through between browser and viz, we need
struct traits for it and its members. ResourceSettings is a member of
RendererSettings.

This CL adds struct traits for ResourceSettings and a unit test for
the struct traits.

Bug: 732825
Change-Id: I03010130b3614cc316f6fc234dea4b5bfbf3fbf5
Reviewed-on: https://chromium-review.googlesource.com/575209Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488689}

Add a new "highlighter" tool using the same fast
rendering method as laser pointer (CL extracting
the common base class is to follow).

Bug: b:63142451
Change-Id: Id848b77f08ae95c167c527a07aec6ccdf79f49f4
Reviewed-on: https://chromium-review.googlesource.com/558467
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488688}

Bug: 741478
Change-Id: I7b576273b0e7ec08af24291115db1c8e8f9b3da8
Reviewed-on: https://chromium-review.googlesource.com/581232Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martin <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488687}