- 30 Sep, 2020 40 commits
-
-
Andrei-Laurențiu Olteanu authored
Introduce missing battery charge routine to getAvailableRoutines. Bug: b:162051831 Change-Id: I761175fe72d87d477e9e030696f44e624a6f5d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436738Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#811957}
-
Aaron Leventhal authored
- In content browser tests, clusterfuzz, and ASAN, crash immediately and do not attempt to recover/reset. - In crashes, provide the collected error information as a crash key. Note: these crash stacks are only now consistently correct as a result of CL:2432760 which disabled code folding in the fatal error handling. This will help get to the bottom of our serialization errors. NOTRY, in order to get past last timed out build due to clogged CQ. NOTRY: true Bug: 1094848,1131848 Change-Id: Ie46722a69b21baf3f5e638ffee074ca63a06a639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435810 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811956}
-
Mirko Bonadei authored
This reverts commit 78399a99. Reason for revert: Looks like this was not the culprit. Original change's description: > Skip VideoCaptureDeviceTest.OpenInvalidDevice on macOS. > > Speculative disable these tests since the failure seems similar > to crbug.com/1069608 on ChromeOS. > > Bug: 1129807, 1128470 > Change-Id: I33eb4db810b57ddb46f1c6982ced26b45f59fcb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429263 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810279} TBR=guidou@chromium.org,mbonadei@chromium.org,handellm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Try: True Bug: 1129807 Bug: 1128470 Change-Id: I03f1449fb0be73a30d9c0017bb36c75d65d9ec62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431947 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811955}
-
Luca Hunkeler authored
Before this cl if you wanted a callback to trigger when any of a list of events happened, you'd have to add multiple interactions. Supporting multiple events allows for a more compact proto with less duplication in those cases. Bug: b/168195199 Change-Id: I5614fc741ab83801a1102e1e4c2b99a4add04e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435639 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811954}
-
Ben Joyce authored
Test time reduced from 38143ms to 1521ms. Bug: 989569 Change-Id: Ibe0b271138bcfcc3095d216d2af91013b412e84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439476 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811953}
-
Maksim Sisov authored
Bug: 1132807 Change-Id: I96aebad4dce77d1e9ae5dde8675e79eac83da108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437949 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#811952}
-
Aya ElAttar authored
- Added a mapping from the url matching conditions IDs of sources and destinations to Rules IDs so URL matching will work properly when multiple patterns are configured in one rule. Bug: 1132804 Change-Id: Idfb04bbf1887fbbdf14804e48363212a41d215e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435643 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811951}
-
Derek Basehore authored
This removes the code for unmounting the FUSEs (filesystem in userspace) on suspend. Instead of unmounting to resolve the FUSE/freeze on suspend race condition, we will be using powerd code that orders freeze using freezer cgroups. Crostini still has some work left to do before this can be done for it, so unmount on suspend for its FUSE, sshfs, will be done in a later patch. Test: "suspend_stress_test -c 2500" on device Bug: b/134792837 Change-Id: Icb8f9e309f6780e6f935be550c6c4e048a44b1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336869 Commit-Queue: Derek Basehore <dbasehore@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#811950}
-
Michael Thiessen authored
Bug: 989569 Change-Id: If9f2bf207142253262bca092ca7dad6975893322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811949}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601402113-7fdca9625e1fa7a11789090d4f40670ef10ac97f.profdata to chrome-linux-master-1601423519-160c1675b60a0784f3486044879abd6ac9140863.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ia1373c59db738d843c959dc60aed7d3baad46b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811948}
-
Wenyu Fu authored
Same implementation as crrev.com/c/2427524. Adding another empty text view to load Google Sans that used for FRE buttons. More context in the original bug. Bug: 1119990 Change-Id: Ic4820db06b635237ece07d1780d7188aaeb85796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437369 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811947}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I27e07b274a6031b927d0f210fcc493842ed51fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439701Reviewed-by:
-
Erik Jensen authored
The session chooser was previously hardcoded to call /etc/X11/Xsession. However, it turns out that file is Debian specific, so this change introduces an Xsession script in the CRD directory and updates the session chooser to call that. On Debian, this file just delegates to /etc/X11/Xsession, but it makes it possible to install CRD on other distros by swapping in an appropriate replacement. Change-Id: I50c9599c929b1875798ba04043762358024607f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436624 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#811945}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601402113-90af030cdb9e3c62fe724fde5c9a9eda66c16b0e.profdata to chrome-mac-master-1601423519-0313967a598efe443ce9d62f0d47f5b337e79203.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I66a40d8b21f4ee9d3536f81651b090c3eccb407c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439698Reviewed-by:
-
edchin authored
Previously, there was only one snapshot cache so the image did not need to be moved during drag and drop. Recently, there was a change to have a snapshot cache per browser. This CL moves the snapshot image from the source cache to the destination cache when the corresponding WebState is moved. Bug: 1132306 Change-Id: I30599d17e33f9610adc7d715675bcbf829eadf8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438312 Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811943}
-
Nazerke authored
This CL adds a collection view layout class for creating the tabstrip viewcontroller. Bug: 1128249,1130488. Change-Id: Ie9faa75720fb0da8de3174887af945a4ee945bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421648Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#811942}
-
Peng Huang authored
SharedContextState could be released before releasing all WrappedSkImage backings. To avoid this problem, by holding a ref of SharedContextState. Bug: None Change-Id: I2ebe99a18b939f77894ee24049b23d5e0cc6764e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438189 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811941}
-
My Nguyen authored
UX feedback to add back the label. However, the functionality seems obscure so adding metrics to gauge usage. View: http://screen/6VCZQPfziWwa4kk Note: Restart now and Restart later in enum has never been used, it was added due to earlier designs. Bug: 1113439, 1133061 Change-Id: Ia33cb71b3bd22133faaecec60f80cb302b16f349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437581 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811940}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I081997ef57d966f33509dccb0a7340c358b37246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439703Reviewed-by:
-
edchin authored
Undo-Close-All is only valid when the tab grid is empty. This CL disables the undo action when a tab is added. Bug: 1112759 Change-Id: I41e407068a227fc87b53be12db8f35329cff52a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438233 Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Bug: 989569 Change-Id: Iccfbc60f2e3d2c7026c5e310ab94dd2076ea3713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438473 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We rewrite below tests fast/scroll-behavior/main-frame-interrupted-scroll.html, fast/scroll-behavior/overflow-interrupted-scroll.html and fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests because we cannot guarantee that the scroll arrives before the animation completes. TBR=bokan@chromium.org Bug: 1047176 Change-Id: I59bb34a98326892380d748a2a4691ea4664cad26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438652Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811936}
-
Xing Liu authored
The empty implementation will be used when the read later feature is disabled. So we won't hit the actual backend. TBR=dtrainor@chromium.org Bug: 1128074 Change-Id: I5c2bed4b2136d758a6c504eabf6a77547650f69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438484 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811935}
-
Findit authored
This reverts commit c14fae86. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 811926 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2MxNGZhZTg2Y2M0MzIyMDcyN2Q2NzNmYjJjMDRiNDJhZTI4YTI3NTQM Sample Failed Build: https://ci.chromium.org/b/8867766288975154688 Sample Failed Step: compile Original change's description: > [fuchsia][a11y] Refactors convert node ID logic. > > This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID. > > It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID. > > R=yangsharon > > TEST: web_engine_unittests > Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> > Cr-Commit-Position: refs/heads/master@{#811926} Change-Id: Ide2c5fe9720fffc79de88a7b462906a4edc93d2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439702 Cr-Commit-Position: refs/heads/master@{#811934}
-
Jimmy Gong authored
This is a reland of 6a3c229f Original change's description: > [CrOS PhoneHub] Add setter functions to various manager classes > > The added setters are going to be used by a future Cl that implements > the PhoneStatusProcessor class. > > Bug: 1106937 > Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810084} Bug: 1106937 Change-Id: I0278e9221eac360ac6f6000fa1400bf83d0d6437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439014Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#811933}
-
Mike Jackson authored
Feedback provided in a different CL (2375597: dpwas: Add window-controls-overlay as a new display mode | https://chromium-review.googlesource.com/c/chromium/src/+/2375597) and in https://github.com/w3c/manifest/pull/932 is that we need a way to say new display modes are allowed in display_override but not display. The plan is to introduce a new enum EnhancedDisplayMode, and display_override should be: sequence<DisplayModeType or EnhancedDisplayModeType>. To support that, this CL deprecates the existing display_override field, and renames it. Renaming here should be fine, as long as we don't use JSON serialization. Once the new field has landed, we will remove this field, and mark it reserved so that future users don't reuse the field. Explainer: https://github.com/WICG/display-override/blob/master/explainer.md Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Manifest w3c PR: https://github.com/w3c/manifest/pull/932 Bug: 1092667 Change-Id: Ifbc0160a88263d4994d138f99921371ceea2bcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436417 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#811932}
-
Prashant Nevase authored
Add virtual tests for default dark mode behavior for images. This will help check and correct default behavior for images. Bug: 1116914 Change-Id: Ifcd6db9df15b5616511fdc50125f277071341976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434023Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#811931}
-
Clark DuVall authored
This change adds new application classes for Chrome/Monochrome which can be used with isolated splits to load the logic from the real application classes from the chrome split in the browser process. In child processes, only the necessary initialization will be done, and the chrome split will never be loaded. Application methods which have logic in ChromeApplication or MonochromeApplication have been moved an inner implementation class, which will then be called from the SplitCompatApplication superclass. Fonts were moved to the base module because they were conflicting with resources from the elements aar. Unfortunately, there is an Android bug with how services are loaded from isolated splits (b/169196314). I'll fix this in a follow up. Bug: 1126301 Change-Id: Icafe93a8c6fb560315c3022839544faaa0327fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425404 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Minggang Wang authored
Currently, when running the unit test WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete locally, the result reports all tests passed: [1/1] WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete (12 ms) SUCCESS: all tests passed. but actually, there is an error reported: Actual function call count doesn't match EXPECT_CALL(*mock_observer, DidReceiveResponse(_, _, _, _, _)) Expected: to be called once Actual: never called - unsatisfied and active The root cause is that we must execute a forced GC in order to finalize objects depending on the mock object before the test finished, and the test begins to fail consistently after executing a GC in the dtor. Meanwhile, we should call ResourceLoadObserver's DidReceiveResponsei() method before stopping loading the main script by WorkerMainScriptLoader. The WorkerMainScriptLoader class is designed to load the main script for workers, which is pre-requested in browser process and passed to renderer process through WorkerMainScriptLoadParams, and when the http status code indicates a failure, we should notify the |resource_load_observer_| by invoking its DidReceiveResponse() method, thus the devtools could be aware of this response. This patch implements that behavior to make the test runs successfully. Change-Id: I03f062276abad2253b35ebfa4ed8b4f58eddab4f Bug: 1132634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433631 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811929}
-
Andrew Grieve authored
Also opts aliases into symbol sorting. Bug: None Change-Id: I62b01b7a59156b7599769666f854209e9cd63ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438872 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811928}
-
tby authored
1. Adds a 'type_detail_fields' into the request json which makes the response as small as possible. 2. Removes the FileTasksNotifier pointer from the provider, which we don't need anymore. Bug: 1034842 Change-Id: I8c663c10543e1547aa3379cf6acce173e653a71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438089Reviewed-by:Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811927}
-
Lucas Radaelli authored
This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID. It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID. R=yangsharon TEST: web_engine_unittests Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#811926}
-
Alex Newcomer authored
Add this metric to help us understand usage and plan improvements. Bug: 1099338 Change-Id: I77ce043b2e54031b8c35d8ba302be8b7b254edcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424508 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811925}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I03396595652afda6036ac5cb0a2187eb25e4228a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439428Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811924}
-
zhaoyangli authored
Beta builders build on default and run tests on beta version. SDK builder build and run on beta version. Bug: 1132967 Change-Id: Iee320ec6154986dd7811d5193b0febc39b4b5713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436864Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811923}
-
Bartek Nowierski authored
Most of the new issues are related to BackupRefPtr, but some unrelated ones surfaced recently too. While at it, format the CheckedPtr2/MTECheckedPtr better. See this section for more details: https://docs.google.com/document/d/1cnpd5Rwesq7DCZiD8FIJfPGHvQN3-Gul6xib_4hwfBg/edit?ts=5ed2d317#heading=h.jeb8au4vq4yf Bug: 1069567 Change-Id: Ic49feaff08450ed4ac9ca93b03ef9d5b71245f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437832Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811922}
-
Anastasia Helfinstein authored
This is a pure refactor, no functional change. TBR=dmazzoni@chromium.org AX-Relnotes: n/a. Bug: None Change-Id: If8d4eb247f61e0abe1df9e32879d3641974bab1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438481Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#811921}
-
John Z Wu authored
Update password was calling the save password delegate method. Accidentally introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2315252 Change-Id: I5779831c37aa24f383940abbfb534e1b618ec9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439018 Auto-Submit: John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811920}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::SetTextWithOffset()| not to reuse last glyph in run to handle kergning, e.g. "AV". When inserting character "V" after "A", before this patch, we have glyph run for "A" and "V" without adjusting spaces between space "A" and "V" because we reuse shaping result of "A" then concatenating shape result of "V". After this patch, we does shaping "AV" once. Bug: 1129710 Change-Id: I2ecf2ce04945dba18ed9622a9f6745ea4060ce87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423802 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#811919}
-
Kartik Hegde authored
Introduce the fake host resolver class, used by unit tests, to avoid duplication across multiple routines. BUG=chromium:956783 TEST=none Change-Id: I4a5e9b6f07de4b55a07e54cd46c8e879c3df080e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434555Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#811918}
-
