- 20 Aug, 2020 21 commits
-
-
Zhenyao Mo authored
On Intel GPUs where YUV hardware overlays are supported, BRGA8 overlays seem to be supported, but the system fails to report that. BUG=1119491 TEST=manual, gpu_unittests R=magchen@chromium.org Change-Id: I304aef3731f142c13c945ca22ce0df81afbcd21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364580 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#799901}
-
Joshua Bell authored
Now that Blink can talk directly to Mojo (it's only been what... 3 years?) remove the WebIDBFactory cruft and have blink::IDBFactory make calls directly to the backend mojom::blink::IDBFactory. No functional changes. Bug: 843764,717812 Change-Id: I7f8370570a21fd19c5a98b2b1d5d8e31db702a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363176 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#799900}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4978cb248d45e82f58fdd92b53a93f4c5fffc2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799899}
-
Orin Jaworski authored
This CL adds one last language that was previously excluded due to pak file versus spreadsheet-data naming mismatch: hu vs. hu-HU. Bug: 893183 Change-Id: I3443fe36588d4c91d217b019d324313235e07fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364582 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799898}
-
Kyle Horimoto authored
Change-Id: I160b4cde304ef843070e0dc60fda9c60799cec18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365675 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#799897}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0a8bf0b805057659f5f1678b6b38174b892d690f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364084Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799896}
-
Chris Hall authored
R=meredithl Change-Id: Iacf878aea64518ad9e66a661589c7e11f55cc66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362382Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799895}
-
Salvador Guerrero authored
The following tests are failing on builder "android-bfcache-rel" CoopReportingOriginTrialBrowserTest.AccessReportingWithToken CoopReportingOriginTrialBrowserTest.CoopStateWithToken TBR=arthursonzogni@chromium.org Bug: 1119555 Change-Id: I3cf6acde50f9ea42773a92f5b2d4229d59433722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365362Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#799894}
-
Ian Kilpatrick authored
There was only one caller for this within: ThemePainterDefault::PaintInnerSpinButton This replaces that one caller with the equivilent logic. Removes other auxillary methods only used within ControlStatesForNode, e.g. LayoutTheme::IsFocused There should be no behaviour change. Change-Id: I0717e4fe9dd5c0ec9448f916e38671b2a37b8539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363325Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#799893}
-
Shakti Sahu authored
This CL moves ThinWebView to components/thin_webview so that features such as payments can use it while being on components. Bug: 1116770 Change-Id: Ie412a88f2ef630739b2bf5828b89b3c1c5e4c44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358994Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799892}
-
Miguel Casas authored
Original CL was reverted because it wrongly removed the line va_buffers_.erase(buffer_id); Reland changes in crrev.com/c/2363833/1..2/media/gpu/vaapi/vaapi_wrapper.cc Original CL description ------------------------------------------------ media/gpu/vaapi: use new |va_buffer_for_vpp_| for Vpp/BlitSurface() ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for external VEA/JEA use. This CL starts refactoring these VABufferIDs lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and into a ScopedID |va_buffer_for_vpp_|. Bug: b:162962069 Change-Id: Id377ebb44b6add14eb9227d1450c68a24eaee42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#799410} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363833 Cr-Commit-Position: refs/heads/master@{#799891}
-
Andre Le authored
Add the logic to update visibility for "Clear all" button depends on the count of total and unpinned notification. BUG=1111167 Change-Id: Ie609ae1225c0041e3c45815b1f4c2550136ace77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339942 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799890}
-
Avi Drissman authored
Bug: 1119479 Change-Id: I889ae0f4f01e5e4a79d48fca1172b920a1393a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363363Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799889}
-
Wan-Teh Chang authored
These test images were added in commit ea65e680: https://crrev.com/c/2321307 Bug: 1108626 Change-Id: I35f7b58ab9b38d308744513c77b617e271fcd47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365220Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799888}
-
Ian Kilpatrick authored
Removes a combination of unused methods, or methods which only returned one possible value. There should be no behaviour change. Change-Id: Iabc747262dcf46dc514b361890a85adc171754fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363659Reviewed-by:
-
Roman Arora authored
Mojo bindings and API to show the feedback page. Bug: 1099917 Change-Id: Ie1fd176f67d069b1eb7b9bed1db79751ea4c6df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356971Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#799886}
-
rajendrant authored
static_cast<TabWebContentsDelegateAndroid> maybe a problem if different delegate got used. So using a different method to check for isCustomTab Bug: 1117533 Change-Id: Ibf5fde78e77bfaa407538880c181c713e176cb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363215Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#799885}
-
Adam Langley authored
This code matches up with the Android accessory device code recently added on the desktop side. It is not yet wired into anything on the phone side. BUG=1002262 Change-Id: I802eb6a0275a71744b374589003f5a0675bbb58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341033 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799884}
-
minch authored
The root window and root_location of the event are still based on the original display while dragging a window across displays. This makes the magnifier will not be activated in the display that the window has been dragged to until the drag be released. This cl updates the root window and root location during drag to make sure the magnifier can be activated at corresponding display immediately while drag a window across displays. Bug: 1082392 Change-Id: Ie3feb7679c29e1e9c0b4f8811ae98bd0f170ade0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354997Reviewed-by:
-
Timothy Loh authored
The path for vm disks recently changed so we need to correspondingly update the code here. This is a follow-up to http://crrev.com/c/2362163 which fixed detection of crosvm processes for Crostini. A tast test will be added in http://crrev.com/i/3186385 once this has uprevved. Bug: chromium:1114826 Change-Id: I97a7fb93fa18f54121ab9ca384281181b7ea0f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364148Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
-
Mustafa Emre Acer authored
When Delayed Warnings feature detects and delays an interstitial, Client Side Detection could send another phishy verdict for the same URL. This causes the interstitial to be undelayed immediately. This CL changes the CSD behavior so that it never checks if a Delayed Warning observer is attached to a tab which only happens if a warning is being delayed. This is manually tested to work both on official and non-official builds. A follow up CL will add browser tests. Bug: 1118192 Test: Manual Change-Id: I418910c35ec692ef23e4295a6b59092cb55d5968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364213Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799881}
-
- 19 Aug, 2020 19 commits
-
-
Dirk Pranke authored
This reverts commit cd69e8f5. Reason for revert: re-landing with a fix. Original change's description: > Revert "Rework generated_script handling in MB." > > This reverts commit b05d8793. > > Reason for revert: Broke ios full_configs bot. See: > https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885 > > Doesn't look like this change triggered the full_config bots on try. > > Original change's description: > > Rework generated_script handling in MB. > > > > It turns out the work I did on the "wrapped_*" targets in > > gn_isolate_map was somewhat overlapping with the already-existing > > iOS work to declare things as "generated_scripts". However, the > > generated_scripts did not include test_env.py. > > > > So, this CL rearranges things so that the generated script will call > > test_env.py, and then we can share logic between the generated_script > > targets (and every target on iOS and LaCrOS) and use that as the > > basis for the rest of the work going forward. > > > > Bug: 816629 > > Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917 > > Reviewed-by: Erik Staab <estaab@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#799171} > > TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org > > Change-Id: I94597d58417f7aa76320579ca282293e6b643811 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 816629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799629} TBR=dpranke@google.com,justincohen@chromium.org,estaab@chromium.org,jeffyoon@chromium.org # Not skipping CQ checks because this is a reland. Bug: 816629 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I1f481f23ff1f1de991b13f3e5aadf967818c2763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364696 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#799880}
-
zhaoyangli authored
This is required from Xcode 12 which is rolled to main builders today. No-try: true Bug: 1119510 Change-Id: I7db1dcfdb3dde77d692bfc978ba6502db7592813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365432 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799879}
-
Tommy Steimel authored
Bug: b:154517281 Change-Id: I4dbdbfb787db3d6436def3f77a2d19b0052a26ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361044 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799878}
-
Yuke Liao authored
This reverts commit 66870c32. Reason for revert: 1. The root cause is not lacros, symptom is generally seen across all builders. 2. #pending tasks is ~0 now: https://chromium-swarm.appspot.com/task?id=4e21b13cf27db110&o=true&w=true. 3. 400 VMs were temporarily added to the pool to mitigate the outage. Original change's description: > Revert "[lacros] Enable linux-lacros-rel by default" > > This reverts commit ac7726b8. > > Reason for revert: reverting to shed load on CQ, crbug.com/1119483 > > Original change's description: > > [lacros] Enable linux-lacros-rel by default > > > > This CL enables linux-lacros-rel on CQ by default. > > > > Bug: 1116180 > > Change-Id: I67bf89a5eefd7382bbd2886f416bc38c411213bf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360496 > > Reviewed-by: Erik Staab <estaab@chromium.org> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799123} > > TBR=estaab@chromium.org,liaoyuke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1116180, 1119483 > Change-Id: I2be0017d3af1e863ec15efaa3c3cdf1ff1764911 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364140 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799798} TBR=estaab@chromium.org,liaoyuke@chromium.org,bpastene@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1116180 Bug: 1119483 Change-Id: Ib9211794c4eb92e3e5c721c77f4821dda49d8a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365223Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799877}
-
Kevin McNee authored
These tests crash under android asan. Tbr: asvitkine@chromium.org Bug: 1102747 Change-Id: If26aff18beacc1108e0617b4ba04d66ac3197709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365152Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799876}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Idc828b72f08583ab336c706c1bd8843e076bf573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357457Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799875}
-
Jeff Yoon authored
ios14-beta-sim upstream is failing b/c of bad xcode value. Change-Id: I1572a773f4ce33d76bb536cbe0c39f88e3340693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365294 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Nick Burris authored
Add the header icon and progress bar to the secure payment confirmation dialog. Before this patch, the header icon was a property of the model. Since the model lives in //components, but the icon comes from //chrome, it's awkward for the controller to get the icon from the view just to pass a pointer to the model for the view to dereference later. See patch set 3 for what this looks like. Since the icon is specific to the SecurePaymentConfirmationDialogView implementation anyway, this patch removes the icon from the model and keeps the logic local to the view. Bug: 1110322 Change-Id: I8681bc00c4d48d1b98f3c939f920b5ea44f0ff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358821 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799873}
-
Michael Tang authored
Change-Id: Id3868d6e9fd854a0c7fd34868101227dd6adb540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363362 Commit-Queue: Michael Tang <tangm@microsoft.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799872}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1hJB_rmXQ13zfwdMI-we-LoVPlOy9Fspt/view?usp=sharing Bug: 1115056 Change-Id: I324dfca8105e439aeb1d29c2a7a6130b9cf5af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362753 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799871}
-
Domenic Denicola authored
As part of this, we fix a bug in send-header-page-script.mjs which was not correctly reading the "send-loaded-message" query parameter. In the less-comprehensive tests that were there previously, the buggy code still worked, but these new tests brought out the problem. Bug: 1042415 Change-Id: Id34c627d1d7fdd41727f3db362ada25a6651498f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364172 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#799870}
-
Adam Langley authored
This change plumbs a NetworkContext for WebSocket creation into the |FidoDiscoveryFactory| when caBLEv2 is enabled. BUG=1002262 Change-Id: I0fabe9642c785669c75516207bf4d8f2f8c147e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340389 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a64aed23..afdbedf7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f7803630d49074644892a4dc5ecd12add7e42a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362635Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799868}
-
Karandeep Bhatia authored
in hacker_case. When the type name is in hacker_case, generate HackerCase as the class name instead of Hacker_case. BUG=1113513 Change-Id: Ie94419b088a8c5de9434a2f6bcb962ca0a1a20cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360508 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799867}
-
Claude van der Merwe authored
Bug: 1117619 Change-Id: Ied3c92682a776d83b27e848b7496151fd2618e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364079 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799866}
-
Henrique Nakashima authored
Failures are not very informative without the stderr output. For example: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8871613511001211808/+/steps/Generate_dependency_graph_data/0/stdout Bug: 1111056 Change-Id: I50142bd4d2c8fa9ee43dea572359c2c331f91186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363699 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#799865}
-
Mark Yacoub authored
When getting displays, if an update for a Drm Display has an invalid connector, do not create a Display Snapshot for it. This prevents attempts to use displays with invalid connectors. Bug: 1105427 Change-Id: Id3422686b019942e924d3e98172394f6caa23eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362442 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#799864}
-
Camille Lamy authored
This CL allows reporting browsing context group switches triggered by redirects and updates the reports sent in this case to the latest version of the spec PR (https://github.com/whatwg/html/pull/5518). Since the status of COOP was becoming hard to track, I moved it to its own class for better encapsulation. Bug: 1059303 Change-Id: Ifafb23073301bd05cd9ce83fdb0b748c28e8a51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352880 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799863}
-
Zhenyao Mo authored
On Windows, if we call swap chain's Present1 with damage rect info, even the damage rect info indicates full damage, the chance of Chrome's back buffer being promoted into an overlays are much lower. If we want to consistently Chrome's BGRA back buffer to an overlay, we have to always call Present which doesn't take damage rect info, indicating full damage. I measured some common use case, and their percentage of frames being promoted to overlays are as below: - Google Meet (5 person, 2x2): 97.8% - wikipedia: 80.5% - a story sharing site: 77.2% - gmail (reading a few emails and then compose one): 61.3% - Google speadsheet: 78.2% - Google photos: 95.5% If we promote a frame to overlay, then we save an extra copy (DWM doesn't need to copy chrome's back buffer into OS's back buffer). If we fail to promote a frame to overlay and it's partial damage, now we use full damage, so at worst we do an extra copy. So as far as we promote more than 50% frames to overlays, there is performance gains. For use cases where performance is critical, like Google Meet, or when we scroll, we get almost 100% promotion, so we get maximum performance gain. Besides, always use full damage simplifies logic quite a bit. The UMA "GPU.DirectComposition.CompositionMode.MainBuffer" will show us if this is a good decision by collecting overlay promotion percentage from the wild. BUG=1117185 TEST=manual R=sunnyps@chromium.org Change-Id: I12d927f472652f17e146debc83e40d9f40a1b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363771 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
