- 04 Dec, 2017 26 commits
-
-
Fumitoshi Ukai authored
add config for new bot names in tools/mb, testing/buildbot and ios/build/bots rename as cl/177104371 Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id46a0e61115d0699925f0219313086b3bae0dd65 Reviewed-on: https://chromium-review.googlesource.com/792672Reviewed-by:
smut <smut@google.com> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521261}
-
Hiroshige Hayashizaki authored
XMLHttpRequest's responseXML's SecurityOrigin is aliased with its ExecutionContext, i.e. either with Document or an isolated world, in XMLHttpRequest::InitResponseDocument(). This CL is a preparation for making SecurityContext::GetSecurityOrigin() and XMLHttpRequest::GetSecurityOrigin() return const SecurityOrigin* in [1], while preserving the aliasing behavior in XHR. [1] https://chromium-review.googlesource.com/744586 This CL - Introduces XMLHttpRequest::GetMutableSecurityOrigin(), - Uses ExecutionContext::GetMutableSecurityOrigin() for aliasing with another Document and - Uses the registered SecurityOrigin of an isolated world in DOMWrapperWorld for aliasing with the isolated world. This CL Takes IsolatedCopy() before DOMWrapperWorld::SetIsolatedWorldSecurityOrigin() in WebLocalFrameImpl::SetIsolatedWorldSecurityOrigin(), to make SecurityOrigin inside its argument (WebSecurityOrigin) const. This IsolatedCopy() doesn't cause semantic changes, because the callers of SetIsolatedWorldSecurityOrigin() never pass an aliased WebSecurityOrigin. Bug: 779730 Change-Id: I503c0623f15e37cba010a0c7f0b72e2b44f5af08 Reviewed-on: https://chromium-review.googlesource.com/752006 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521260}
-
Hidehiko Abe authored
Migrated seven test cases. BUG=234463 TEST=Ran bots. Change-Id: Idc33683a4221246ac3ec9e3414435144273c8866 Reviewed-on: https://chromium-review.googlesource.com/803774Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521259}
-
Christopher Lam authored
Flakes starting from: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64945 til https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64973 TBR=gene@chromium.org Bug: 517420 Change-Id: Ib75f72c56584acdc9e3f95163443e3eef14b5ace Reviewed-on: https://chromium-review.googlesource.com/804622Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521258}
-
David Reveman authored
Modifier flags needs same treatment as pressed keys. Move modifier flag tracking to Seat class. Bug: 788731 Tbr: yoshiki@chromium.org Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ife2fae2d622dfff3617830ba232d0267fdbc9b35 Reviewed-on: https://chromium-review.googlesource.com/805359Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521257}
-
Raymes Khoury authored
This adds support to automatically grant the Default Search Engine the notifications permission on Android. The behavior is similar to the way the geolocation permission works for the DSE. Although the behavior is mostly the same, this CL changes the way permissions (geolocation and notifications) are transferred between DSEs when the user changes their DSE. The new approach stores the permissions that the user had set on the DSE origin prior to it becoming the DSE. When the user changes the DSE, we restore the old settings. No UI for the notifications part has yet been implemented. Bug: 780344 Change-Id: Ifa57e395ad4a647f42debb78146d50574ee1b636 Reviewed-on: https://chromium-review.googlesource.com/756657 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521256}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id90c5a04af42b64ddc7b66984dc2b948f75f6532 Reviewed-on: https://chromium-review.googlesource.com/789719Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521255}
-
Victoria Su authored
Added a use counter for :-webkit-any-link Change-Id: I4da11399a356b9cb9fd2be54930656bf23115b69 Reviewed-on: https://chromium-review.googlesource.com/804805 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#521254}
-
Yuki Awano authored
- Do not call OnInfoBubbleDestroyed if anchor view is not live. Anchor view can be destructed before info bubble is destructed. Bug: 787796 Test: ash_unittests:TrayNetworkTest.NetworkInfoBubble with asan Original commit: > Activate widget of anchor view only if it's live > > Bug: 787796 > Test: ash_unittests:TrayNetworkTest.NetworkInfoBubble > Change-Id: I54918830a0cc246af8ce34510f3a0e10193450d0 > Reviewed-on: https://chromium-review.googlesource.com/788710 > Commit-Queue: Yuki Awano <yawano@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520506} Change-Id: If366e4778d9af5526817eb884173c1c57ef86384 Reviewed-on: https://chromium-review.googlesource.com/802605Reviewed-by:
-
Marti Wong authored
To be consistent with history and bookmarks, adjust the style of reading list's toolbar: 1. Horizontal margin: 16pt 2. Vertical margin: 8pt 3. Spacing between button: 8pt 4. Font size: (same as bookmark cell) 5. Shadow opacity and radius Screenshot: https://drive.google.com/file/d/1DU5BpaWTIGFJuHUje7ideAcYEyWQG600 https://drive.google.com/file/d/1Bvxv5rcrn2P1dPQwai0rD9J_0pC9pKnN Bug: 789417 Change-Id: I6b5791941ea68e5fe9c52ae46569ce0bbd3ad9fc Reviewed-on: https://chromium-review.googlesource.com/796251 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521252}
-
Christopher Lam authored
TBR=dmazzoni@chromium.org Bug: 791268 Change-Id: I81d58c4b588969b9f7a119aa424abe85f2f6a5bd Reviewed-on: https://chromium-review.googlesource.com/804919Reviewed-by:
-
Christopher Lam authored
This CL adds a button that opens the app info dialog to the hosted app menu. Bug: 762401 Change-Id: I23ec79904932bdb35dce80d642a6d3582e29ec5e Reviewed-on: https://chromium-review.googlesource.com/788630 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
Blake O'Hare authored
Now there's a default empty body, so no need to override with another empty body. Bug: Change-Id: Ic089e628e44e41dd3c1d0891fd8640f4e9eea89d Reviewed-on: https://chromium-review.googlesource.com/795396 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521249}
-
Yutaka Hirano authored
This CL tightens the throttling policy initially (if certain conditions are met), and loosen the policy when Document::WillInsertBody is called. Bug: 785770 Change-Id: I1fea7ced1105f48dabb25a68a546fd281db5e6eb Reviewed-on: https://chromium-review.googlesource.com/799517 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Wez authored
The accelerator system was fixed to use this function when mapping the modifiers in a WebInputEvent to construct an Accelerator, and the reverse mapping, from ui::Event flags to WebInputEvent modifiers, already handles the AltGraph modifier correctly. A simple test is also added to verify that the two functions both handle the required set of modifier flags. Bug: 787137, 25503 Change-Id: I53e5353dc4f1fa5eba15f1b91ec4c361e50264db Reviewed-on: https://chromium-review.googlesource.com/802081Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521247}
-
David Bokan authored
MouseEvents are initialized with client coordinates and translated into offset and page coordinates based on the main frame's scroll offset. This patch fixes the scroll offset calculation for when root-layer-scrolls is turned on. Bug: 781431 Change-Id: Ibdbb24600ff6f0ded589b9e4a31be8bf9e753cb5 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/798537 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521246}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=jochen@chromium.org Change-Id: I93ef943b0160683eaea33d40d8d86c0b04253baf Reviewed-on: https://chromium-review.googlesource.com/799512Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521245}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=zentaro@chromium.org Change-Id: Ic92828720da66aac49d94d9403c6a56b0ae2cbee Reviewed-on: https://chromium-review.googlesource.com/799013Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521244}
-
Ben Wells authored
Using resource ids with the content settings API is supported but is apparently not being used. This change adds some DCHECKS to check that this is true as preparation for removing resource ids from the API. Bug: 754178 Change-Id: I6ac49bf697fc342332905c7e814ef4e61f32695f Reviewed-on: https://chromium-review.googlesource.com/790075Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521243}
-
Morten Stenshorne authored
A margin before a block may push the start of the block to the next fragmentainer. The remaining part of the margin will then be "eaten" by the fragmentainer boundary, as per spec: https://www.w3.org/TR/css-break-3/#break-margins Blocks that start exactly at a fragmentainer boundary no longer create a bogus empty fragment in the former fragmentainer. This affects the BlockStartAtColumnBoundary unit test. Quite a few layout tests behave better now, by going from Crash to Failure, from Crash to Pass, or from Failure to Pass. fast/multicol/dynamic/insert-spanner-between-out-of-flow.html regresses. Not sure why, but it's not so interesting, since that test uses column-span: all, which we still don't support. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3be1b735e70f05a375ea328a7fc11fd515e77e3a Reviewed-on: https://chromium-review.googlesource.com/803482 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521242}
-
Denis Kuznetsov authored
Bug: 676195 Change-Id: I450fcf3416f620ce9867d55ea225c610583d1169 Reviewed-on: https://chromium-review.googlesource.com/764168Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#521241}
-
Naina Raisinghani authored
This patch stashes all ComputedStyle information about all descendants when an element will need to undergo Reattach. It does so by recursing over all ContainerNode, ShadowRoot and PseudoElement descendants in the case where the node itself needs to Reattach. We then use the ComputedStyle stashed on the Node in LayoutTreeBuilder::style() eliminating the need to call Element::styleForLayoutObject() in Layout Tree Construction. Bug: 595137 Change-Id: I7e6ca2431e602dff80d7d3e84d1bffe1e25d8b2c Reviewed-on: https://chromium-review.googlesource.com/765097 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521240}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=mmenke@chromium.org Change-Id: I480fc15a2b48369f3943661d092a4a85e0698400 Reviewed-on: https://chromium-review.googlesource.com/799596Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521239}
-
François Degros authored
Change-Id: I2fe10a0aa80796b4af0a36c7db355cfa8b8144e7 Bug: Reviewed-on: https://chromium-review.googlesource.com/790112Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#521238}
-
François Degros authored
By using move semantics and scoped_refptr::swap, we avoid calling AddRef and Release in some circumstances. Change-Id: I919690e2ecbdca4e1303a29a3a3fa017148a7355 Reviewed-on: https://chromium-review.googlesource.com/802849Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#521237}
-
Kenichi Ishibashi authored
Bug: 776665 Change-Id: I41ea9c3315d53a26fdf450ce34e670896bffb962 Reviewed-on: https://chromium-review.googlesource.com/802848Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521236}
-
- 03 Dec, 2017 14 commits
-
-
Kenichi Ishibashi authored
Fix two typos in OomInterventionTabHelper. Bug: 776665 Change-Id: I4066d742bbfed519b771f2035155ead865f9d4f2 Reviewed-on: https://chromium-review.googlesource.com/802600Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Chris Mumford authored
The prior two values are not considered to be errors, and will be mapped to FILE_ERROR_FAILED. Adding the DCHECK to detect incorrect use of this function. Bug: None Change-Id: Id8dcfa01bf18010fc1a59fc20defb907475aac6c Reviewed-on: https://chromium-review.googlesource.com/798050 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Xing Liu authored
This reverts commit 2dcec349. Reason for revert: Still flaky, see https://bugs.chromium.org/p/chromium/issues/detail?id=791213 Original change's description: > Fix DownloadHistoryCheck on windows continuous builder. > > Currently it's flaky that a partial buffer is read through network > pipeline when the first history db record is generated. > > This CL changed the observer to be able to optionally wait for a > certain number of bytes read from network IO. > > Bug: 788160 > Change-Id: I110653433e8c80c2dabf9f3162df99d7bb354e86 > Reviewed-on: https://chromium-review.googlesource.com/790946 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519930} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788160 Change-Id: If59f7f82c7bd2a75bbc4655f665fc9f9581e170e Reviewed-on: https://chromium-review.googlesource.com/804648Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521233}
-
Pavol Marko authored
Enable client certificate authentication in the sign-in profile for the StoragePartition which is currently used by the sign-in frame. Additionally, wire up the DeviceLoginScreenAutoSelectCertificateForUrls policy to content settings on the sign-in screen. BUG=723849 TEST=browser_tests --gtest_filter=WebViewClientCertsLoginTest.* Change-Id: Ic5345bc3446c621008088909771c6eca445aa3f3 Reviewed-on: https://chromium-review.googlesource.com/790295 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521232}
-
Robert Sesek authored
Bug: 598854 Change-Id: I380ef1cb8bf2de2a72d52091b619b374b4dc3c33 Reviewed-on: https://chromium-review.googlesource.com/804338 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521231}
-
Ricky Liang authored
- Sync mojom files from arc-camera repo, which include Mojo interface updates for v2.4 API. - Hook up the new functions in v2.4 API in unit tests. BUG=36378334 TEST=unit tests TEST=Make sure camera works on Soraka. Change-Id: I428af0c37f706905eb20c43ea06c227995345855 Reviewed-on: https://chromium-review.googlesource.com/798933Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521230}
-
Takashi Toyoshima authored
Explicit PLATFORM_EXPORT for an inner class static method was needed for Windows. This is a reland of 1cb7ac27 Original change's description: > ResourceLoadScheduler: add traffic monitoring metrics > > This patch adds TrafficMonitor to count number of resource > requests and bytes of received data. Data are counted > per-frame basis, and classified by main frame vs sub-frames, > and throttled vs not-throttled. > > Bug: 789354 > Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff > Reviewed-on: https://chromium-review.googlesource.com/795482 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521202} Bug: 789354 Change-Id: I9cf5edb2c8af0b5ecc09bf0b4deaba90e9f3fd66 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/804707 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is a prerequisite to enable ScopedTaskEnvironment MOCK_TIME on top of any RunLoop::Delegate (i.e. on top of MessageLoopForUI/ForIO). This CL also removes RunLoop::Delegate::Client::IsNested() as it was a mere shortcut for its TLS complement and had to switch to using TLS itself to remain valid in override scenarios... Ran base_perftests.exe --gtest_filter=*MessageLoop* in static/Release and things look the same. Bug: 708584 Change-Id: I143f6e6afb47de11f95702c337dbe63eb0887596 Reviewed-on: https://chromium-review.googlesource.com/784214 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#521228}
-
Gabriel Charette authored
This mimics the pre-existing paradigm for MessagePump::Delegate : public methods on Delegate which are then privately inherited. There were cr-dev discussions on these topics (composition vs private inheritance) but I don't see a reason to deviate from the pre-established MessagePump paradigm here. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/XdsXTHy9lis/discussion https://groups.google.com/a/chromium.org/d/topic/chromium-dev/CwzjcWd9cYM/discussion I did consider composition here (e.g. with a private RunDelegate class in MessageLoop, but the many outer_-> in Run/Quit/EnsureWorkScheduled made it ugly. R=danakj@chromium.org Bug: 708584 Change-Id: I42830b3a28d29b1a518db4cfc767a655de491a90 Reviewed-on: https://chromium-review.googlesource.com/798290Reviewed-by:
-
Christopher Cameron authored
The parameters for sending a CALayer tree from the GPU process to the browser process will have to be shuffled a bit for viz. Before doing this, clean up the existing path. Current relevant sequence of events: * gpu::ImageTransportSurfaceOverlayMac populates gpu::SwapBuffersCompleteParams in the GPU process. * Structure includes gfx::SwapResponse, gpu::TextureInUseResponses, and CALayer parameters. * gpu::CommandBuffer un-and-re-packs this structure as GpuCommandBufferMsg_SwapBuffersCompleted_Params to send via IPC. * gpu::CommandBufferProxyImpl::OnSwapBuffersCompleted then un-and-re-packs that structure as two separate arguments * gfx::SwapResponse * Is consumed on all platforms * gpu::GpuProcessHostedCALayerTreeParamsMac * Is consumed by GpuOutputSurfaceMac only, passed by pointer * Includes gpu::TextureInUseResponses as a member * These arguments ultimately resurface in a function named OnGpuSwapBuffersCompleted in viz::DisplayOutputSurface or content::GpuBrowserCompositorOutputSurface (or subclasses thereof). The reason for this patch is that, in viz, we will need to split up gpu::GpuProcessHostedCALayerTreeParamsMac, because different parts go to different places. In particular: * The actual CALayer-related parameters need to go up to the browser * The TextureInUseResponses parameter just goes to the GLRenderer Since we're doing surgery in the neighborhood, some of the un-and-re-packing can be done away with. The changes made are: * Add a new gfx::CALayerParams structure * In gfx because it will be passed into ui code on the browser side. * Not ifdef-ed out on non-macOS (though is largely depopulated) to avoid ifdef-spaghetti (an is_empty parameter will be used for early-out) * Keep the IOSurface as a mach port much longer, because viz will need to re-pass it to the browser side (via mojo). * Populate gpu::SwapBuffersCompleteParams with all three separately-destined components: * gfx::SwapResponse (as before) * gpu::TextureInUseResponses (as before) * This is not ifdef-ed out even though it is macOS-only avoid preprocessor-spaghetti and to help testing. * gpu::CALayerParams (new) * This was previously just inline * Move gpu::SwapBuffersCompleteParams from service into common * This is passed without any inspection or modification from gpu::ImageTransportSurfaceOverlayMac to *GpuOutputSurfaceMac, where its sub-parts finally diverge. * This lets us remove the un-and-re-pack of parameters. * Delete the redundant structures: * GpuCommandBufferMsg_SwapBuffersCompleted_Params * gpu::GpuProcessHostedCALayerTreeParamsMac Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8fd06898a4b1f8432b563c0bc63975787b05cb46 Reviewed-on: https://chromium-review.googlesource.com/798642Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#521226}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d75f3f99d47b..79ee73938d7d $ git log d75f3f99d..79ee73938 --date=short --no-merges --format='%ad %ae %s' 2017-12-03 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I4f430a68a384684569935c5d26ccd2b74b9f484b Reviewed-on: https://chromium-review.googlesource.com/804917Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521225}
-
Dmitry Skiba authored
Bug: 789732 Change-Id: I660cad683bcc96772ddb5fc25f1a94ae8a988bb6 Reviewed-on: https://chromium-review.googlesource.com/803617 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521224}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1ec99b9b8e27..d75f3f99d47b $ git log 1ec99b9b8..d75f3f99d --date=short --no-merges --format='%ad %ae %s' 2017-12-01 fmalita Fix SVGPong slide crash in Viewer Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Idff805c9e8eeb8ab6a3fffc4c5e26152ae9235d0 Reviewed-on: https://chromium-review.googlesource.com/804705Reviewed-by:
-
Jungshik Shin authored
Explicitly disallows the following blocks. Latin Ext B (Pinyin subblock), Latin Ext D, Cyrillic Ext B/C, Greek Ext, Latin Additional (other than Vietnamese). Note that Latin Ext C & E, Cyrillic Ext A do not belong to [:IdentifierStatus=Allowed:] and need not be explicitly banned. 218 characters are blocked. In the Unicode set notation, they're [:IdentifierStatus=Allowed:] & [:Ll:] & [[\u01cd-\u01dc] [\u1c80-\u1c8f][\u1e00-\u1e9b] [\u1f00-\u1fff][\ua640-\ua69f][\ua720-\ua7ff]] Below are the number of domains blocked before and after this CL out of about a million .com domains as of 2017-11-30. 6400 : before this cl 7058 : after this cl 658 : additional domains blocked with this CL Bug: chromium:770709 Test: components_unittests --gtest_filter=*IDN* Change-Id: I4de1df5f79b43d9ceddfd01c7dd9af61d1a0e130 Reviewed-on: https://chromium-review.googlesource.com/802978 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521222}
-
