GitLab

This CL corrects situations where the tab grid may position its scroll
offset incorrectly when handling a size class transition.

The issue was that none of the call points for updating the scroll
position (via setting self.currentPage) were guaranteed to take place
after the scroll view's width had changed.

This CL moves some of those call points into -viewWillLayoutSubviews,
so that whenever the scroll view width changes it will be repositioned
correctly. Since this change should often not be animated, the
currentPage setter now doesn't animate by default, and a
-setCurrentPage:animated: method is available when animations are
needed.

Bug: 822328
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36833314fc6d79d32cfddf9be8dacbeabc8ba4b9
Reviewed-on: https://chromium-review.googlesource.com/1093990Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566008}

Change-Id: Idb448e01008f2e11df1215dd693e5f859b5790b7
Reviewed-on: https://chromium-review.googlesource.com/1089710
Commit-Queue: Nick Burris <nburris@google.com>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566007}

kChromeVoxExtensionId should match the built-in extension
id, not the web store version.  Added rule to set
IS_CHROMECAST define.

Bug: b/73383411
Test: None
Change-Id: I4d5da20066a54b2dd12a1f76cabc3214836117c0
Reviewed-on: https://chromium-review.googlesource.com/1087171Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566006}

No one is calling these methods, instead GetDisplayNodes() is used.

Bug: 843995
Change-Id: I76d5a711527eca20497fdc283ca55e47683b37a3
Reviewed-on: https://chromium-review.googlesource.com/1090283Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566005}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6a21b5f9..c19206c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ie3346cc722e3acb1440488a51ce9c368b8afd3f3
Reviewed-on: https://chromium-review.googlesource.com/1094713Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566004}

This is a speculative re-enabling based on the testharness dashboard
appearing green for both these tests.

Bug: 805794, 805788
Change-Id: Ibfe69c9882a8ec1534329fe568b846d8c1cf8750
Reviewed-on: https://chromium-review.googlesource.com/1094979Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566003}

These appear to be no longer crashing now that the surfance
synchronization bug has been fixed on MacOS.

Bug: 846632, 846693
Change-Id: I4ecc748429a6a19d565d88d84db9ad1427a6af48
Reviewed-on: https://chromium-review.googlesource.com/1094978Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566002}

To route audio streams through (in-process) audio service on bots.

Bug: 832666
Change-Id: Ie885b6b725a46e8eeb1859d7abe408c9f4412549
Reviewed-on: https://chromium-review.googlesource.com/1091314
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566001}

Change-Id: I981049dc691f41a34bdaf96628a32a08b51739a8
Reviewed-on: https://chromium-review.googlesource.com/1093442Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566000}

In Jumbo build, the local redefinition of the namespace
errors, for example "namespace errors = manifest_errors",
causes conflicts between files. This is resolved by removing the local
redefinition and using the full name instead.

Bug: 850484
Change-Id: I5b8aecd3dc5b7c922bef515b82f11c5bfdf19515
Reviewed-on: https://chromium-review.googlesource.com/1095075Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#565999}

CardUnmaskPrompt is modified to use ModalDialogView instead of
AlertDialogs. This is part of an afford to convert all instances of
modal dialogs to use ModalDialogView.

Bug: 836366
Change-Id: I3a0b785f89b1e49768578529ba2c4a8302e8e83e
Reviewed-on: https://chromium-review.googlesource.com/1059709
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565998}

This adds style-invalidation.md and also several in-code comments that
go along with it.

Change-Id: If0cfbae69ae23652d617d7fa195611134f8a8fe3
Reviewed-on: https://chromium-review.googlesource.com/1086679
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565997}

healess is already added a few lines down as additional flags.

Bug: internal b/80500112
Test: None
Change-Id: Ibb57a383b1ceca74474258aecc7507d835ff3ff6
Reviewed-on: https://chromium-review.googlesource.com/1093118Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Gaofeng Huang <gfhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565996}

The tests have been split in the upstream and should no longer time out:
https://github.com/web-platform-tests/wpt/pull/11016
https://github.com/web-platform-tests/wpt/pull/11292

Bug: 736056
Change-Id: I2267ffb05e8c74c5d70bd6d8a4020bb24c78bd0c
Reviewed-on: https://chromium-review.googlesource.com/1081123Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565995}

This CL makes sub headers in detailed view transparent. As sub headers
in detailed view sticks to the top, we should clip the contents behind
the sub header when it's sticking.

Screenshot (before): http://screen/VdTYhhOnzmB
Screenshot (after): http://screen/42SJVs7U1RF

TEST=manual
BUG=850396

Change-Id: If112681997014c5bf7696dea775d414250e67f39
Reviewed-on: https://chromium-review.googlesource.com/1094853
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565994}

-- BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize
-- BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize

are flaky.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotal.*ThanActualSize

TBR=peter@chromium.org

Bug: 851229,839438
Change-Id: I0aee9f1fdbabcbe7802d85e3ee782b522a03ff61
Reviewed-on: https://chromium-review.googlesource.com/1095183
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565993}

TBR=mariakhomenko@chromium.org

Bug: 851444
Change-Id: I0014915bad3ed6ceb79a9ec3c8a53c4e1b0d51fc
Reviewed-on: https://chromium-review.googlesource.com/1095337Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565992}

Bug: 807724
Change-Id: Idf518b751e1b0399c14c33f1be485da9be9247aa
Reviewed-on: https://chromium-review.googlesource.com/1091959Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565991}

Doubles the amount of shards for the win(dbg) clang tot bots, and removes a
spurious test suppression on the tot thin lto bot. (If the suppression is still
needed, it should have a bug and should be disabled via DISABLED_ in the source.)

Bug: 843511
Change-Id: Ie54de8f21578dadbcbe2a6005c5d6ff49feef111
Reviewed-on: https://chromium-review.googlesource.com/1095317
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565990}

Adds support for types which contain variable length lists of references
in DEX. These lists take the form: |NTTTTT|NTT|N|NTT|... where N is the
header containing the length and T is a reference body. There are three
types which utilize this format. AnnotationsDirectoryItem also uses a
variant of this format with multiple lists per item (to be added in a
separate CL).

Method:
We pre-cache the offsets of each T within the list using the parser and
iterate over it in the ReferenceReader. This is faster than implicitly
parsing each list and avoids having to handle all the accounting for
the number of lists, items per list, map size, etc. in the
ReferenceReader. The tradeoff is memory which varies by number of types
and annotations but could exceed 1 MB in a very large DEX file. This is
an acceptable cost for the time and simplicity gained. Explicitly
parsing beforehand is also safer as it delegates the validation of DEX
structure to the parser early before any references are read. This is
also inkeeping with the style of the other ReferenceReaders in the file.

Bug: 847571
Change-Id: I853905b10ab7003e87895cc50c5ebf6b9fb4a424
Reviewed-on: https://chromium-review.googlesource.com/1087409
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565989}

This CL improves the bug fix for an issue with TYPED_URL. Before this
CL, one could hit DCHECK if typing an url that got expired in the
current running instance of Chrome. The DCHECK was due to the sync
entity still being tracked by ClientTagBasedModelTypeProcessor.

This is a reland of a previously reverted CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1078667
Over the previous version, it handles well the case if the entity has
never been tracked by the processor.

Bug: 827111
Change-Id: Id17707cc6fb66e1ae30ed5b02e534c93d388e124
Reviewed-on: https://chromium-review.googlesource.com/1078969
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565988}

Before the change, in WebUIImpl::RegisterMessageCallback,
a base::StringPiece has been emplaced as a key into the map
that has std::string as a key.
This results in the construction of
std::pair<std::string, MessageCallback> with
{ const base::StringPiece&, const MessageCallback& }.
This is constructor (3) of std::pair
(http://en.cppreference.com/w/cpp/utility/pair/pair).
It seems perfectly fine in C++17 (std::string is constructible
from base::StringPiece as per explicit conversion in the latter).
However, before C++17, the requirement is that the argument is
implicitly convertible to the pair's type, which we cannot
tell of base::StringPiece and std::string.

Therefore, the code has been, I believe, a C++17 already and is not
a valid C++14.

TBR=jam@chromium.org

Change-Id: I9499aaecbe43ae1036f4fb737e76d452385cafe7
Reviewed-on: https://chromium-review.googlesource.com/1074757
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565987}

With https://crrev.com/c/1070158, base::Bind() supports
block so convert uses of base::BindBlockArc() to instead
use base::BindOnce() or base::BindRepeating().

Fix new usages introduced after https://crrev.com/c/1090911.

Bug: 701275
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If6eb2eeed72d4540ccb3e3a8fc49a8a03d72085c
Reviewed-on: https://chromium-review.googlesource.com/1095297Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565986}

It seems it's been leaking for some time, but this didn't show on
buildbots running it with --no-sandbox. With recent Clang versions
the leaks are starting to show up anyway.

These are hard to suppress because they are in callbacks, some of which
run without anything MediaSession related on the stack, so instead this
disables the test under LSan until it's fixed.

Bug: 850870
Change-Id: Ib9d098c64f4a6db3cb68fb796a35219fdba74f35
Reviewed-on: https://chromium-review.googlesource.com/1092737Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565985}

viz_browser_tests, viz_content_browsertests and content_browsertest take more than 20 minutes on linux asan bot.
This patch increases the shard for such slow tests.
* viz_browser_tests, 10 -> 20: max shard duration become 14 mins from > 25 mins
* viz_content_browsertests, 2 -> 8: max shard duration become 15 mins from > 50 mins
* content_browsertests, 4 -> 8: max shard duration become 16 mins from > 25 mins

linux_chromium_asan_rel_ng has the slowest average CQ cycle time, so reducing test execution time is effective for overall CQ cycle time.
1 week stats of average cycle time of each try builder: http://shortn/_bEvlzGZaH9


Recent history of tests on linux_chromium_asan_rel_ng:
* viz_browser_tests
https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1528691160000&f=state%3ACOMPLETED_SUCCESS&f=name-tag%3Aviz_browser_tests&f=buildername-tag%3Alinux_chromium_asan_rel_ng&l=50&s=duration%3Adesc&st=1528604760000
* viz_content_browsertests
https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1528691160000&f=state%3ACOMPLETED_SUCCESS&f=buildername-tag%3Alinux_chromium_asan_rel_ng&f=name-tag%3Aviz_content_browsertests&l=50&s=duration%3Adesc&st=1528604760000
* content_browsertests
https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1528691160000&f=state%3ACOMPLETED_SUCCESS&f=buildername-tag%3Alinux_chromium_asan_rel_ng&f=name-tag%3Acontent_browsertests&l=50&s=duration%3Adesc&st=1528604760000

Bug: 794372
Change-Id: Ic5a4daae81890e702b9090055ed30e65bea92231
Reviewed-on: https://chromium-review.googlesource.com/1094816Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565984}

PredictorDatabaseInternal::Initialize() can be called after the shutdown of
PredictorDatabase. In testing scenario it could lead to accessing a database
file in a directory that doesn't exist, because profile directories are deleted
after test.

This CL checks a cancellation flag that is set on PredictorDatabase shutdown
before opening a database file.

This CL also enables the predictor by default on ChromeOS since the disk I/O
issue should be resolved.

Bug: 839886
Change-Id: I27fbdda2cac282a44bd1bac962b27bf11de8520b
Reviewed-on: https://chromium-review.googlesource.com/1092851Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565983}

CustomTabs.DetachedResourceRequest.FinalStatus enum contains labels for
-net::ERR_*, not the direct value. This causes reporting in UMA to be
incorrectly labeled.

Bug: 816837, 851399
Change-Id: I7febe0ec98f9ae7b028f36af9ff4a40cc938191d
Reviewed-on: https://chromium-review.googlesource.com/1095178Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565982}

PrimaryAccountAccessTokenFetcher currently listens for
SigninManagerBase::Observer::GoogleSigninFailed() and stops waiting
for the user to sign in, returning the error to its client. However,
there's no particular reason it *should* stop waiting for the user to
sign in in this case:
- It's not part of the documented contract of
  PrimaryAccountAccessTokenFetcher
- It's not conceptually different than other cases such as the user
  signing out while the fetcher is waiting for a refresh token to
  become available. However, in no other such case does the fetcher
  abort waiting for the primary account to become available.

Conceptually, the contract of PrimaryAccountAccessTokenFetcher's
WaitUntilAvailable mode is that the fetcher will wait until the
primary account becomes available. Hence, the client understands that
the fetcher might wait forever.

This CL simply rips out the listening to GoogleSigninFailed(). The
concrete motivation (in addition to the consistency reasons presented
above) is that we will shortly be porting this class to talk to
IdentityManager. IdentityManager doesn't currently expose this
observer callback and I want to wait to see if there's a strong
reason for providing it before doing so.

Bug: 796544
Change-Id: I45ff3eb0eeddf54a80fae58039e41c946097c9c2
Reviewed-on: https://chromium-review.googlesource.com/1092852Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565981}

The original change lacks of initialization of new member variable,
so it broke MSan tests.
It's fixed in this CL.

Original change's description:
> Get an incognito flag of text fields of ARC++ apps.
>
> This CL adds a new boolean argument to OnTextInputTypeChanged()
> to send the flag.
>
> Bug: 311180
> Test: Manual testing on the device.
> Change-Id: I130552f4657e0bdd97745fdeffe5e7088ff2583a

Bug: 311180
Test: Manual testing + MSan tests
Change-Id: I920e1e50a6bbd1bb183aa6385cd4701dd926e6f2
Reviewed-on: https://chromium-review.googlesource.com/1086550Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565980}

Using wpt-import in Chromium 081912dd.
With Chromium commits locally applied on WPT:
69af6f38 "webrtc wpt: add cleanup to close peerconnections"
03ef65db "Update existing WebUSB WPT to be multi-global"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19415

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I7db0cffabb4e4e62e5ccaaca0da29a6c8bd34e3c
Reviewed-on: https://chromium-review.googlesource.com/1094919
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565979}

Typo corrected in traffic annotations FYI bot script.

Bug: 844014
Change-Id: Ifb6109c444403a4f62c5bc58cfca53a0901a71cf
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1095095Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565978}

We have no idea why it's failing, so let's disable for now while
we investigate.

Bug: chromium:850936
Change-Id: I94643c513d06d51940b93b06ba98504b38b8e117
Reviewed-on: https://chromium-review.googlesource.com/1095100Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565977}

This CL is a follow-up to https://crrev.com/c/1091192. It adds presubmit
check to enforce prefix consistency for the most used XML namespace
("http://schemas.android.com/apk/res-auto").

Bug: 850616
Change-Id: I03e3825b22a65d9637a6da0cdf3cfd1e233e46a7
Reviewed-on: https://chromium-review.googlesource.com/1092744Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565976}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3e514e..a10370c


git log c3e514e..a10370c --date=short --no-merges --format='%ad %ae %s'
2018-06-11 bratell@opera.com Add --log-file arg to post_build_ninja_summary.py
2018-06-11 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@a10370c

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I1f729af3717821e079f6f60e3f3417028730f877
Reviewed-on: https://chromium-review.googlesource.com/1094976Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565975}

This CL removes theme-wide 'chrometint' attribute, adding explicit
attribute to XMLs tags that instantiate TintedImageView and
TintedImageButton. This is necessary for the upcoming replacement of
TintedImageView and TintedImageButton with AppCompatImageView and
AppCompatImageButton.

Bug: 727723
Change-Id: Ia935e9e863b09a3384e0c3c0a07cb393ffc5bb34
Reviewed-on: https://chromium-review.googlesource.com/1092866
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565974}

The method is now exclusively used from thread_state.cc and there are no
more duplicates defined elsewhere which could break jumbo builds.

Bug: chromium:840789
Change-Id: I09fa55c01f60eda79d2c08707d0520e8f3b1cfda
Reviewed-on: https://chromium-review.googlesource.com/1095056
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565973}

The crash occured if the handler was deleted in-between calling
setLocalDescription() and the request finishing, the WeakPtr to the
RTCPeerConnectionHandler would be null when dereferenced by the
SetLocalDescriptionRequest. If there is no handler, that means the PC
is closed and the event must not be surfaced. Guarding the handler_ with
an "if" is standard practise for these operations and is already done in
the setRemoteDescription() case, so no change needed there.

This fixes the crash described by https://crbug.com/851369.

Bug: 851369
Change-Id: I1c219f2470a1ffcbcdfc414ebbe3f1b673b13898
Reviewed-on: https://chromium-review.googlesource.com/1094639
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565972}

In RTCPeerConnection-setRemoteDescription-offer.html.

Bug: 777617
Change-Id: I43b579b6ca0cbc0e950a379dc519fac95ac18f58
Reviewed-on: https://chromium-review.googlesource.com/1095189Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565971}

Move from `SetBuildEmbedderGraphCallback` to
`AddBuildEmbedderGraphCallback`.

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/890260
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1082441
Change-Id: I11e35a2353bbc4e4a721450f47a9ebfe000dc85c
Reviewed-on: https://chromium-review.googlesource.com/1089055
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565970}

TBR=nainar@chromium.org

Change-Id: Ibaabacd0af2af87fecc397003b8bc0c75f0e3229
Reviewed-on: https://chromium-review.googlesource.com/1095215Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565969}