GitLab

This change links tile raster tasks to the tile manager that
initiated them. Tile managers are in turn linked to a frame,
which is processed by telemetry later on to determine the time
difference between when raster tasks start to when the
compositor frame is submitted.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I876a029f6db1e664aafe945fcdd629da3bdc681e
Bug: 912730
Reviewed-on: https://chromium-review.googlesource.com/c/1286889
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615572}

This CL reduces the amount of PictureBuffers requested to be allocated
by the |client_| when we are not |decode_using_client_picture_buffers_|.
Instead, it "splits" the requested allocations into
- the actual needed PictureBuffers (A)
- the codec's requested reference frames (B) (a new method
 GetNumReferenceFrames() is added to AcceleratedVideoDecoder for this).

This splitting saves a lot of memory, since we allocate A+B buffers
instead of 2*(A+B). (B is 5 and A is 4-VP8, 4-12 H264/VP9)

Test: crosvideo changing resolutions for each codec, v_d_a_unittest
on nocturne (KBL) and caroline (SKL).

Bug: 909926
Change-Id: I1fce92863beddce0e8b221861cf156b9c3ad0c0f
Reviewed-on: https://chromium-review.googlesource.com/c/1363807Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615571}

This reverts commit 00c1b7ab.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness."
> 
> This reverts commit 0c873bf2.
> 
> Reason for revert: Fix for flake in crrev.com/615269
> 
> Original change's description:
> > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness.
> > 
> > Tbr: ccameron@chromium.org
> > Bug: 913490
> > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1369721
> > Commit-Queue: Samuel Huang <huangs@chromium.org>
> > Reviewed-by: Samuel Huang <huangs@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#615159}
> 
> TBR=huangs@chromium.org,ccameron@chromium.org
> 
> Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 913490
> Reviewed-on: https://chromium-review.googlesource.com/c/1370571
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615274}

TBR=huangs@chromium.org,ccameron@chromium.org

Change-Id: I72829b7b404a571095123f2ffd028ff189563ee8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 913490
Reviewed-on: https://chromium-review.googlesource.com/c/1371931Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615570}

This test covers initial sync, i.e. when there are pre-existing
autofill profiles at the time Sync is turned on.

Bug: 904390
Change-Id: I7c7f32f9ceb754c5d517a8e182eca6415a2abc61
Reviewed-on: https://chromium-review.googlesource.com/c/1371845
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615569}

This feature has been enabled by default since M70 and stable enough to
be always on.

Bug: 913694
Test: manual and coverred by unittest
Change-Id: Ice7240c8d47e45b89324c85de85d398dc9233df8
Reviewed-on: https://chromium-review.googlesource.com/c/1371066
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615568}

The old keyboard overlay has been removed in M72 and
the flag kAshEnableKeyboardShortcutViewer is also removed.

Bug: 778874
Test: manual
Change-Id: I6ab9c350728c1e81f2d2437ac089187c4ab604c6
Reviewed-on: https://chromium-review.googlesource.com/c/1371073
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615567}

This CL removes two SigninTestUtil.resetSigninState calls from tests.
ClearBrowsingDataPreferencesBasicTest calls resetSigninState before
starting a test, when these preferences are already wiped by
SigninTestUtil setup method.
HistoryActivityTest calls resetSigninState right before calling
SigninManager.signOut, which should clear the state as the part of
the sign-out process.

Bug: 738533
Change-Id: I646313550ec0c52e979520f62c9a49e9ff137427
Reviewed-on: https://chromium-review.googlesource.com/c/1371804Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615566}

This CL removes unnecessary imports and forward declarations from the
header file, and move them to the necessary implementation files.

Change-Id: If6e41ffe9d85d063f2b14e4c74b12b06b46261b7
Reviewed-on: https://chromium-review.googlesource.com/c/1370581Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615565}

Bug: 851533
Change-Id: I6cc6def8e7def7b6231dfb7e735a66b596b90b36
Reviewed-on: https://chromium-review.googlesource.com/c/1371964Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615564}

Bug: 899236
Change-Id: Id541261326bfd44528b08ebc6b0edbe5fafb317f
Reviewed-on: https://chromium-review.googlesource.com/c/1370313Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615563}

Bug: 905524
Change-Id: I5699e4b01c3a7f91bd98458e83064811aff53980
Reviewed-on: https://chromium-review.googlesource.com/c/1371218Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615562}

Bug: 832289
Change-Id: If82589e3e690fbf31b8806182e61568d8263119f
Reviewed-on: https://chromium-review.googlesource.com/c/1368945Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#615561}

This patch changes WebFrameContentDumper to use Element.innerText
instead of its ad-hoc TextDumper, so that its output is more
predictable.

This patch also allows all WebFrameSwapTest to pass in LayoutNG.

Bug: 781434
Change-Id: I961fa43c1821e2a0e7eae6b01a6affe884eacc72
Reviewed-on: https://chromium-review.googlesource.com/c/1371145Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615560}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84629852e33d..a030e16bdf09


Created with:
  gclient setdep -r src-internal@a030e16bdf09

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8ff88d678adc149dc066d8f1000f1c2ae1e98bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1372084Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615559}

Removed string from ASSERT_DEATH, because official tests strip
the string passed to CHECK(false) and LOG(FATAL).

Bug: 913441
Change-Id: Ib68905b60d214064f341262789b31f763e8108b3
Reviewed-on: https://chromium-review.googlesource.com/c/1370307Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615558}

This is a reland of b9e5ed2a

Original change's description:
> Refactor OOPIF scroll bubbling state and cancellation
>
> Whether or not a child is bubbling scroll was being tracked in both
> CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's
> simpler to just have it in RWHVCF.
>
> There are several cases where we generate fake scroll updates when
> cancelling scroll bubbling. This is a relic from the non-scroll latching
> code paths and has been removed. We also deduplicate the scroll bubbling
> cancellation code.
>
> We were tracking the view from which scroll events are bubbled by keeping
> a reference to that view's parent. We now just keep a reference to the
> originating view directly.
>
> We also now properly cancel scroll bubbling when a child detaches.
>
> Bug: 828422, 897216
> Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057
> Reviewed-on: https://chromium-review.googlesource.com/c/1357563
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615184}

Tbr: kenrb@chromium.org
Bug: 828422, 897216
Change-Id: If529545300f6bbb7a7056cdbebbd8317cb274f7a
Reviewed-on: https://chromium-review.googlesource.com/c/1371010Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615557}

If the layout is forced, then we temporarily allow the processing of
the subtree. The locked element's frame rect still remains to be the same
as at the time the lock was acquired.

R=chrishtr@chromium.org, mstensho@chromium.org, futhark@chromium.org

Bug: 907613, 882663
Change-Id: I9d1f63c287a73e7a8f3cbc9cb5acc2a009ddd024
Reviewed-on: https://chromium-review.googlesource.com/c/1363957
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615556}

On Windows, non-broker processes should only accept HANDLEs in messages
coming from the broker and/or inviter process. This is because a
non-broker or invitee receiver has to assume the sender has already
duplicated sent HANDLEs into the receiver's process, and making that
assumption requires a level of trust that should not be granted to
arbitrary peers.

This constraint is already met today under normal circumstances, but a
malicious or misbehaving process could easily violate it, tricking an
unassuming receiver into attempting double-ownership of an existing
handle or closure of an invalid handle value, both of which can result
in a crash (though thankfully nothing worse, because of
ScopedHandleVerifier).

This adds an option to Channel which allows it to reject incoming
platform handles and essentially treat them as malformed messages. The
option is set on Windows for any non-broker process's receiving Channel
endpoint which is not connected directly to a broker process or to the
process which invited that client.

The Channel fuzzer also sets this option to avoid a crash since it
exercises only the non-broker receiving path today. A follow-up CL will
extend fuzzer coverage to include broker receivers as well.

Bug: 909713
Change-Id: Ie0fece347fcf23d6f8111be4e41398f22d617531
Reviewed-on: https://chromium-review.googlesource.com/c/1363649
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615555}

We need to attach the document animation timeline to the animation host
to make animations work. In pre-CompositeAfterPaint, this is done from
PaintLayerCompositor.

For CompositeAfterPaint, attach animation timeline from
Document::Initialize() and WebLocalFrameImpl::SetFrameWidget().

Bug: 702353
Change-Id: I5e19add5196e5b52ebcade42b58e336051b111e6
Reviewed-on: https://chromium-review.googlesource.com/c/1368994Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615554}

This reverts commit 1a9264dd.

Reason for revert: rebaseline didn't seem to work.

Failing builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/3655
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/3470
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/2954

Failing tests:

gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4

Original change's description:
> Re-enable video pixel tests after rebaselining
> 
> The tests were marked as failing and version numbers were incremented in
> https://crrev.com/c/1182222, but I forgot to re-enable the tests.
> 
> Bug: 869677, 913138, 858826, 819635, 774809
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08
> Reviewed-on: https://chromium-review.googlesource.com/c/1214364
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615353}

TBR=kbr@chromium.org,sunnyps@chromium.org

Change-Id: I553c10ca8022a90a0afa73ffafa44aa5bbf4e2d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869677, 913138, 858826, 819635, 774809
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1372234Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615553}

A combination of std::atomic (for a raw GC count) and appropriate higher-level
primitives from base is used to replace the current use of atomics.

Bug: 736037
Change-Id: Id4856d4b8d21ff989694bbece70c61d86c686323
Reviewed-on: https://chromium-review.googlesource.com/c/1369720
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615552}

https://skia.googlesource.com/skia.git/+log/9cabb4f98e99..4f738832a976


git log 9cabb4f98e99..4f738832a976 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 caryclark@skia.org fix bookmaker
2018-12-11 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-12-11 kjlubick@google.com [canvaskit] Refactor Canvas2D JS into own files


Created with:
  gclient setdep -r src/third_party/skia@4f738832a976

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I961018fd96caecd13c2d8a371501981f262f6a53
Reviewed-on: https://chromium-review.googlesource.com/c/1371710Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615551}

CompositorImpl Android had obsolete Vulkan prototype code. Removing
this as all Vulkan access should happen on Viz process. Removes a
DCHECK we were hitting when running with the new Vulkan code.

Bug: 848375
Change-Id: Ifba9927809290618346867e52ad71f3edc2b66a9
Reviewed-on: https://chromium-review.googlesource.com/c/1370935Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615550}

Bug: 910372
Change-Id: Ic0859c1fab02010f22664d0138d6e3516012545f
Reviewed-on: https://chromium-review.googlesource.com/c/1358649
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615549}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9a1b0e72..72448bed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1b37dea72dce8da3904aa7c6f490b8a0ad88f78a
Reviewed-on: https://chromium-review.googlesource.com/c/1372024Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615548}

https://android.googlesource.com/platform/external/perfetto.git/+log/152255fcc745..c8b5fd3f2752


git log 152255fcc745..c8b5fd3f2752 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 lalitm@google.com Merge "perfetto: fix tracing test on Android ASAN"


Created with:
  gclient setdep -r src/third_party/perfetto@c8b5fd3f2752

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I079a8f7540ce6d1ac814a6d1c64ad0748d1f10bb
Reviewed-on: https://chromium-review.googlesource.com/c/1372085Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615547}

Change-Id: I21b6ea7ddeb722bf91ce184c9d21c35baedf8749
Reviewed-on: https://chromium-review.googlesource.com/c/1372046Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615546}

This reverts commit 9ef757a8.

Reason for revert: is again needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 was reverted

Original change's description:
> Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."
> 
> This reverts commit 0baa5bdf.
> 
> Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457
> 
> Original change's description:
> > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz.
> > 
> > Bug: 911836
> > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/1361725
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Max Moroz <mmoroz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#613792}
> 
> TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 911836
> Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e
> Reviewed-on: https://chromium-review.googlesource.com/c/1365083
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614534}

TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 911836
Change-Id: Id09d7c0394e8c5eb445aa19ba5a62f8fa251ecb0
Reviewed-on: https://chromium-review.googlesource.com/c/1371885Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615545}

https://webrtc.googlesource.com/src.git/+log/8f66ddbae325..e011cb742d99


git log 8f66ddbae325..e011cb742d99 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 terelius@webrtc.org Move chart proto for event_log_visualizer.
2018-12-11 nisse@webrtc.org Rename EncodedImage::_size to capacity_, make private.
2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aec72e9e..d5698f68 (615246:615355)


Created with:
  gclient setdep -r src/third_party/webrtc@e011cb742d99

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5a31afacdbc38767ae24412a821ba8738974fbcc
Reviewed-on: https://chromium-review.googlesource.com/c/1371711Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615544}

Replaces many deprecated uses of v8 functions Object::Get/Set,
Value::ToString, in extensions/renderer with versions that return
Maybe/MaybeLocals or by using casts if there are already
checks that ensure the cast will always succeed.

Bug: v8:7279, v8:7283, v8:8562, chromium:913942
Change-Id: I4aeec76251bd11dfc274156d8d00586e04e9a99e
Reviewed-on: https://chromium-review.googlesource.com/c/1353985
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615543}

chrome_nibs.gyp went away a while ago, and gyp is no longer deps'd in.

Bug: none
Change-Id: I71d7503b0f95ff15575653da7efe35e4e62a6fcd
Reviewed-on: https://chromium-review.googlesource.com/c/1371928Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615542}

Bug: 913948
Change-Id: I2712119f0ff48a56d1a8b994dc470e76b37250d2
Reviewed-on: https://chromium-review.googlesource.com/c/1371925Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615541}

Bug:913625
Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84
TBR=jbudorick@chromium.org, bradhall@chromium.org

NOTRY=true # linux_chromium_rel_ng flake

Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84
Reviewed-on: https://chromium-review.googlesource.com/c/1371646
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615540}

Make Add Cookie command compliant to W3C spec. Also added a set of
helper functions to help parsing some property types used in W3C spec.
ChromeDriver now passes all WPT WebDriver tests related to cookie.

Bug: chromedriver:2002
Change-Id: I3779a14e010bca865498a9d40710974e38ede829
Reviewed-on: https://chromium-review.googlesource.com/c/1366925
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615539}

The AutofillProfileDataTypeController waits for PDM to load all its data
before doing data association. However, with Butter, PDM needs to ask
the sync service whether the sync feature is enabled to know whether to
read the server cards from the local or account database. Currently, PDM
only gets the sync service whenever we create an AutofillManager, which
isn't always the case on startup.

This CL adds a quick fix, where we also pass the sync service to PDM in
the AutofillProfileDataTypeController, so we know for sure it can load
all data.

A better fix would be to have a single place where we pass the sync
service to PDM, and remove both the call in AutofillManager and this new
call.

Bug: 913945
Change-Id: Ia872cb8ce0cb97467237665e5a92b1d70eb1c2bc
Reviewed-on: https://chromium-review.googlesource.com/c/1371427
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615538}

Disable this data upload as it's not used by server.

Change-Id: I7da2e3b82aef19318a3ed5ec6c00f2cabe15fb2b
Reviewed-on: https://chromium-review.googlesource.com/c/1370723Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615537}

These are the ones that didn't explicitly include wtf/atomics.h and so were missed earlier.

Bug: 736037,247328
Change-Id: I407d1ad6f53c058866bb4a98ca910768fe9ce6c5
Reviewed-on: https://chromium-review.googlesource.com/c/1370187Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615536}

This CL adds a README.md to the fast/animations/scroll-animations
directory, explaining when that directory should be used vs
external/wpt/scroll-animations (aka, rarely).

Bug: 911254
Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c

TBR=yigu@chromium.org

Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c
Reviewed-on: https://chromium-review.googlesource.com/c/1367825Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615535}

There will need to be a follow up CL that adds an implementation for Chrome to provide an actual key.

Bug: 906202
Change-Id: Ib471b1124e19b11755b410f384a447f929a1b547
Reviewed-on: https://chromium-review.googlesource.com/c/1351709
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615534}

ash::Shell owned by ChromeBrowserMainExtraPartsAsh is released
before UiDevToolsServer owned by ChromeBrowserMainExtraPartsViews.
This causes a use-after-free in DOMAgentAura dtor when it tries to
RemoveObserver from the already released Env of ash::Shell.

Fix the issue by explicitly releasing |devtools_server_| in
ChromeBrowserMainExtraPartsViews::PostMainMessageLoopRun.

Bug: 896977
Change-Id: I07172d8014dc17c1a91a11e220579a13ad0524b0
Reviewed-on: https://chromium-review.googlesource.com/c/1370832Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615533}