GitLab

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952,679288

Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}

R=dpapad@chromium.org
BUG=680012,680084
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626173004
Cr-Commit-Position: refs/heads/master@{#443484}

Cr-Commit-Position: refs/heads/master@{#443483}

Updated independent-inheritance-fast-path.html to test all keywords
instead of just testing a single keyword. Updated the independent
properties table to include all keywords for the independent properties.

BUG=628043

Review-Url: https://codereview.chromium.org/2620383008
Cr-Commit-Position: refs/heads/master@{#443482}

Previously the host telemetry logger doesn't report these information. This
CL fixes this problem so that we can use host info to filter stats.

BUG=680644

Review-Url: https://codereview.chromium.org/2629593003
Cr-Commit-Position: refs/heads/master@{#443481}

This is a follow-up fix to http://crrev.com/2630493002.

In that CL, I changed the path to the manifest command but
used the wrong path, resulting in the latest import failing:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7868

The manifest script is actually checked into:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest

BUG=678077

Review-Url: https://codereview.chromium.org/2626183004
Cr-Commit-Position: refs/heads/master@{#443480}

The new test harness has been deployed; let's see whether it's more
reliable.

BUG=603329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2629763002
Cr-Commit-Position: refs/heads/master@{#443479}

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2627153003
Cr-Commit-Position: refs/heads/master@{#443478}

BUG=460102,679417

Review-Url: https://codereview.chromium.org/2619863002
Cr-Commit-Position: refs/heads/master@{#443477}

Currently even there is no custom search engine to show (such as clean
start), "Recently visited" header will still be displayed. This
is confusing for users.

To fix this, there is no custom search engine to show, remove the "Recently
visited" header.

BUG=679608

Review-Url: https://codereview.chromium.org/2623113002
Cr-Commit-Position: refs/heads/master@{#443476}

The test quickly finishes usually, but sometimes it doesn't finish.
We guess it's possible to call checkInputs() before loading js-test.js.

This CL doesn't remove a TestExpectations entry. We'll check if the flakiness is
gone later.

BUG=675907

Review-Url: https://codereview.chromium.org/2629033004
Cr-Commit-Position: refs/heads/master@{#443475}

Reason for revert:
Sheriff: Suspect CL for causing net_unittest failures on several bots such as https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder

Original issue's description:
> Add quic_logging.
>
> Merge internal change 143128776
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2611613003
> Cr-Commit-Position: refs/heads/master@{#443413}
> Committed: https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4c3519504ec39

TBR=rch@chromium.org,fayang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2629723003
Cr-Commit-Position: refs/heads/master@{#443474}

Revert of Perform InterfaceProviderSpec intersection in the ServiceManager (patchset #12 id:220001 of https://codereview.chromium.org/2610853013/ )

Reason for revert:
This CL is causing chrome --mash to fail to start up on Chromebook hardware. See https://bugs.chromium.org/p/chromium/issues/detail?id=680700

I'm not sure why our existing test coverage doesn't catch this. Let me know if I can help manually test a future patch.

Original issue's description:
> Perform InterfaceProviderSpec intersection in the ServiceManager.
>
> . Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe.
> . Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change.
>
> Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Review-Url: https://codereview.chromium.org/2610853013
> Cr-Commit-Position: refs/heads/master@{#443119}
> Committed: https://chromium.googlesource.com/chromium/src/+/e70e635ab325eede70d564b995130583bb3404ce

TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2634493002
Cr-Commit-Position: refs/heads/master@{#443473}

This change makes wtf::ArrayBuffer::data() require that the underlying
ArrayBuffer be non-shared. The caller must use dataShared() or
dataMaybeShared() to access the underlying data of a SharedArrayBuffer.

BUG=678410

Review-Url: https://codereview.chromium.org/2617073002
Cr-Commit-Position: refs/heads/master@{#443472}

This CL does not fix the linked bug, but was discovered
during its investigation and might be related to it.

BUG=675584

Review-Url: https://codereview.chromium.org/2630583003
Cr-Commit-Position: refs/heads/master@{#443471}

https://skia.googlesource.com/skia.git/+log/b621a35b436b..aeef5610d7a3

$ git log b621a35b4..aeef5610d --date=short --no-merges --format='%ad %ae %s'
2017-01-12 liyuqian Revert "Reland https://skia-review.googlesource.com/c/6091/"
2017-01-12 msarett Use RasterPipeline to support full precision on 16-bit RGBA pngs
2017-01-12 stani Add support for drawImageLattice in SKIA debugger
2017-01-12 liyuqian Reland https://skia-review.googlesource.com/c/6091/
2017-01-12 msarett Revert "Use RasterPipeline to support full precision on 16-bit RGBA pngs"
2017-01-12 reed impl clipping for GDI raster-handle

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2628293002
Cr-Commit-Position: refs/heads/master@{#443470}

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.

Review-Url: https://codereview.chromium.org/2629253002
Cr-Commit-Position: refs/heads/master@{#443469}

Allow there to be multiple suites that run on the flaky bot, since
we have more than one test suite. Use the appendix "_flaky_egtests"
to denote targets. Previously it only ran "ios_chrome_flaky_egtests".

BUG=675613

Review-Url: https://codereview.chromium.org/2629733002
Cr-Commit-Position: refs/heads/master@{#443468}

BUG=none

Review-Url: https://codereview.chromium.org/2626293003
Cr-Commit-Position: refs/heads/master@{#443467}

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627353003
Cr-Commit-Position: refs/heads/master@{#443466}

Adds DeviceDetailsPage to internals page so users can view all the properties
of the DeviceInfo object. No display of service properties is included in this
patch.

Splits action link in Devices table into two separate links: "Inspect"
and "Forget".
Adds functions to add and remove items from the sidebar.
Adds test infrastructure for Device proxy-based tests.
Adds test for DeviceDetailsPage.
Adds unregister function to PageManager.

GIFs: https://goo.gl/photos/zLiv86gyYmQhRn9w8

BUG=651282,663470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576603002
Cr-Commit-Position: refs/heads/master@{#443465}

Add an alternative function for combining resource weight with host
visit frequency. This one is a measure of the probability that there
will be a cache hit for the resource, given that resource_weight is the
probability of a cache hit for a single trial and host_visits is the
number of independent trials.

BUG=

Review-Url: https://codereview.chromium.org/2623553003
Cr-Commit-Position: refs/heads/master@{#443464}

 * Adds EnumTraits for TextInputMode and TextInputType.
 * Adds corresponding unittests.
 * Adds missing enum entries in ime.mojom.

BUG=631527

Review-Url: https://codereview.chromium.org/2626383002
Cr-Commit-Position: refs/heads/master@{#443463}

Reland of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #1 id:1 of https://codereview.chromium.org/2600863002/ )

Reason for revert:
Fixed the root cause of the crash.
https://crrev.com/64efa56e5bb67106cea0eb4033b866d9217d8324

Original issue's description:
> Revert of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #3 id:40001 of https://codereview.chromium.org/2569993002/ )
>
> Reason for revert:
> Causes crashes on canary. See https://crbug.com/676984
>
> 0x5eb4a4fa	(chrome.dll + 0x000fa4fa )	base::Callback<void ,1,1>::Callback<void ,1,1>(base::Callback<void ,1,1> const &)
> 0x6003ec7d	(chrome.dll -service_worker_version.cc:1095 )	content::ServiceWorkerVersion::OnSimpleEventFinished(int,content::ServiceWorkerStatusCode,base::Time)
> 0x5ff64f33	(chrome.dll -bind_internal.h:214 )	base::internal::FunctorTraits<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),void>::Invoke<scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode,base::Time>(void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5ff50241	(chrome.dll -bind_internal.h:285 )	base::internal::InvokeHelper<0,void>::MakeItSo<void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int,blink::WebServiceWorkerEventResult,base::Time>(void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int &&,blink::WebServiceWorkerEventResult &&,base::Time &&)
> 0x5ff655a6	(chrome.dll -bind_internal.h:339 )	base::internal::Invoker<base::internal::BindState<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion>,int>,void >::Run(base::internal::BindStateBase *,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5fbe1b09	(chrome.dll -callback.h:85 )	base::internal::RunMixin<base::Callback<void ,1,1> >::Run(filesystem::mojom::FileError,__int64)
> 0x5fba0984	(chrome.dll -service_worker_event_dispatcher.mojom.cc:225 )	content::mojom::ServiceWorkerEventDispatcher_DispatchPushEvent_ForwardToCallback::Accept(mojo::Message *)
> 0x6037605b	(chrome.dll -interface_endpoint_client.cc:336 )	mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message *)
>
> Original issue's description:
> > [ServiceWorker] Mojofy PushEvent of Service Worker.
> >
> > This CL converts push event IPCs into mojo interface:
> >   ServiceWorkerMsg_PushEvent
> >   ServiceWorkerHostMsg_PushEventFinished
> >
> > BUG=629701
> > TEST=content_unittests
> >
> > Committed: https://crrev.com/35842853527f50a04662a6dfe2c3cd1b10cf5915
> > Cr-Commit-Position: refs/heads/master@{#439739}
>
> TBR=leon.han@intel.com,peter@chromium.org,shimazu@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=629701
>
> Committed: https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9
> Cr-Commit-Position: refs/heads/master@{#440693}

TBR=leon.han@intel.com,peter@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com,falken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629701

Review-Url: https://codereview.chromium.org/2620333003
Cr-Commit-Position: refs/heads/master@{#443462}

Previously we only tested FFTs up to size 2048, but the AnalyserNode
supports up to 32768.  Test all sizes.

BUG=676722
TEST=realtimeanalyser-fft-scaling.html

Review-Url: https://codereview.chromium.org/2629543005
Cr-Commit-Position: refs/heads/master@{#443461}

BUG=303429
TEST=Manual. Check that no black area appears when the virtual
     keyboard moves between displays.

Review-Url: https://codereview.chromium.org/2627963004
Cr-Commit-Position: refs/heads/master@{#443460}

Make APIRequestHandlerUnittest derive APIBindingTest, clean up a few of
the instantions, and remove some unneeded includes.

BUG=653596

Review-Url: https://codereview.chromium.org/2625363003
Cr-Commit-Position: refs/heads/master@{#443459}

This layouttest turns off the WebKitSupportsMultipleWindows property which means that popups
open in the same window. It then initiates a navigation to a data URL by clicking on the
corresponding href. It then compares the window counts and expects the window counts to
remain unchanged.

Without PlzNavigate the data URL navigation creates a provisional loader in blink which
is then cancelled when data is written to the main document, via Document::writeln.

With PlzNavigate the top level navigation for the data URL is sent to the browser. The
provisional loader is created when the navigation is committed via the
FrameMsg_CommitNavigation IPC. This is too late and hence the data written to the page
via the Document::writeln calls never shows up.

Fix is to add a check for whether there is a client side navigation in process for PlzNavigate
and if yes stop ongoing loaders.

BUG=673744, 673742

Review-Url: https://codereview.chromium.org/2628153002
Cr-Commit-Position: refs/heads/master@{#443458}

Move MediaControls hideMediaControlsTimer and panelWidthChangedTimer to
TaskRunnerTimer, which associates it with the documents's timer task
queue.

BUG=624694

Review-Url: https://codereview.chromium.org/2627803002
Cr-Commit-Position: refs/heads/master@{#443457}

Update pref service before showing the interstitial only if it is available. Also
remove an unused method.

BUG=

Review-Url: https://codereview.chromium.org/2627343003
Cr-Commit-Position: refs/heads/master@{#443456}

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628123002
Cr-Commit-Position: refs/heads/master@{#443455}

Geolocation access via the geo API and via the X-Geo header has been
made consistent. As part of this project the UI is being updated to show
the geolocation status for the default search engine in more places.

This change updates the page info popup to show allow / block for the
default search engine.

BUG=674398

Review-Url: https://codereview.chromium.org/2633433002
Cr-Commit-Position: refs/heads/master@{#443454}

This patch undoes some of the previous work to add separate x/y
raster scales since we decided that it was too complicated to use, and
decided to go in a different direction.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2629233002
Cr-Commit-Position: refs/heads/master@{#443453}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL changes the template file that is used to generate
XPathGrammar.cpp.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2627023004
Cr-Commit-Position: refs/heads/master@{#443452}

BUG=680099

Review-Url: https://codereview.chromium.org/2625013003
Cr-Commit-Position: refs/heads/master@{#443451}

In theory this will reduce memory wasted by std::deque. It may also help diagnose
some puzzling crashes we've seen related to the immediate incomming and work queues.

BUG=674625, 674895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2579773002
Cr-Commit-Position: refs/heads/master@{#443450}

BUG=680797
TEST=Win Intel HD 530 bot on GPU FYI waterfall
TBR=kbr@chromium.org,yunchao.he@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2628883007
Cr-Commit-Position: refs/heads/master@{#443449}

The new search geolocation system slightly changes the way geolocation
permission work. This change updates the search engines UI to work with
the new system.

BUG=674398

Review-Url: https://codereview.chromium.org/2629523003
Cr-Commit-Position: refs/heads/master@{#443448}

BUG=661011

Review-Url: https://codereview.chromium.org/2626073006
Cr-Commit-Position: refs/heads/master@{#443447}

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237

Review-Url: https://codereview.chromium.org/2615653003
Cr-Commit-Position: refs/heads/master@{#443446}