- 04 Oct, 2018 40 commits
-
-
Raphael Kubo da Costa authored
Alexander's no longer at Intel, so remove his email from those files. While here, add myself to external/wpt/generic-sensor's OWNERS file. Change-Id: Ic14db99aa9caf7f7ec208da5a26d975edc06d824 Reviewed-on: https://chromium-review.googlesource.com/c/1256787Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#596655}
-
Marc Treib authored
https://crrev.com/c/1030177 introduced lazy creation of the ConfigurationRefresher in SyncTest::InitializeInvalidations. However, it unconditionally re-created it for every Sync client. Re-creating it drops any previous observer registrations, which means the refresher would effectively only work for the *last* client. This CL fixes this by creating it only if it doesn't exist yet. Interestingly, this didn't seem to cause any problems in practice. Bug: 832019 Change-Id: Ic9df260fdc5b8955d591d96678b4e1500035067f Reviewed-on: https://chromium-review.googlesource.com/c/1261439Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596654}
-
Stephane Zermatten authored
Before this patch, unknown action would be skipped and not reported to the server. This made it difficult to see what actions were unsupported. Also, this made the client mistakenly think that response with only unsupported action signalled the end of a script. This patch introduces an unknown action type, which always fail. This way, neither the client nor the developer will be confused by this case. This patch also transition UpdateProcessedAction from taking a boolean to taking a ProcessActionStatusProto, which lets us be more specific in what failed. I also left TODOs for the cases where we should be more specific and distinguish at least "element not found" from other errors. Bug: 806868 Change-Id: I6efe1f2ac733f2048a5028c5ebb51fab2953868c Reviewed-on: https://chromium-review.googlesource.com/c/1257901 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596653}
-
Fredrik Söderquist authored
Rather than deferring the check until ExpandUseElementsInShadowTree (which will fail if the initial target is an ancestor of the <use>), just check for cycles directly in BuildShadowAndInstanceTree(), and don't build the initial shadow tree if the cycle check fails. Stop cleaning up the partial tree after ExpandUseElementsInShadowTree(), and adjust HasCycleUseReferencing such that it detects cycles earlier (not requiring a clone into the shadow tree before a cycle can be noticed.) Behavior-wise this means that we now don't clone a target subtree if it will create a cycle. We will however abort cloning of nested <use> after a cycle is detected. Bug: 397525 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b2c22bacb63d788509ec7984ac35357b84a3020 Reviewed-on: https://chromium-review.googlesource.com/c/1258065 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596652}
-
Mario Sanchez Prada authored
Migrated to IdentityManager::Observer and implemented the corresponding virtual functions from there. Bug: 887465 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9436fe11d90b7593d05a0bf97ab11134d12105b7 Reviewed-on: https://chromium-review.googlesource.com/c/1257834 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596651}
-
stkhapugin@chromium.org authored
Calling -containsString: with nil argument throws an exception, so this check is needed. Bug: 880590 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ieb3944b05fdf3573f6a552c8910025bf93312987 Reviewed-on: https://chromium-review.googlesource.com/c/1225983Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596650}
-
Mario Sanchez Prada authored
Add new overloads to FakeProfileOAuth2TokenService and IdentityTestEnvironment methods so that we can specify the |id_token| that should be returned along with a token when fetched via AccessTokenFetcher, and use that to check that such information is indeed passed along from the relevant unit tests. Bug: 889764 Change-Id: I593dca07362ce7392d2cd2439369f1b440deb1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1249086Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#596649}
-
Javier Ernesto Flores Robles authored
This CL adds the capability to pause the keyboard views when the webstate is hidden. This happens i.e. when the passwords coordinator presents a full screen selection. This way, when the webstate is shown again, it can restore it's views if needed. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5eddf31ada277a1a9c0c0e8cc0ae7be3d8d01ad2 Reviewed-on: https://chromium-review.googlesource.com/c/1236436 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596648}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/sync. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 809610 Change-Id: Ie5cf8f1bb9884eb74ed4bd44697b8b5a94a85e39 Reviewed-on: https://chromium-review.googlesource.com/c/1258169 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#596647}
-
Marc Treib authored
We have reports of the DCHECK firing; this will let us figure out which ModelType(s) hand inconsistent data to the processor. Bug: 872360 Change-Id: I7d206a075870fe5be65234a6ebc5ba8d93e2099c Reviewed-on: https://chromium-review.googlesource.com/c/1261396Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596646}
-
Mathieu Perreault authored
In this change we properly clear PaymentsCustomerData from disk and update several sync integration tests to take this into account. Bug: 884689 Test: sync_integration_tests, components_unittests Change-Id: I851d17fc0d0f1e02817e73d94e6cb7cf8341d6ae Reviewed-on: https://chromium-review.googlesource.com/c/1256283 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596645}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/identity. This CL was uploaded by git cl split. R=courage@chromium.org Bug: 809610 Change-Id: Id702299e37de9a9f224e11f948537c13df068fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1259042 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Michael Courage <courage@chromium.org> Cr-Commit-Position: refs/heads/master@{#596644}
-
Javier Ernesto Flores Robles authored
This new button opens passwords settings. This CL also sets accessibility identifiers for manual fill accessories. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5dde83c04d3e07e37526c2c8456ebe79d549f3c9 Reviewed-on: https://chromium-review.googlesource.com/c/1249486 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#596643}
-
Koji Ishii authored
When lines are wrapped, line-height quirks mode requires each line not to have a strut by default. LayoutNG does this by resetting |text_metrics|, but it forgot to reset |text_top| and |text_height|, two derived variables from |text_metrics|. This results in slightly different geometry for LayoutBR when the layout was paused and restarted from a break token (such as reusing unchanged lineboxes or an inline formatting context was fragmented) from when we layout from top to bottom. This patch properly resets these values so that the layout result is consistent in such cases. Also the changes match better to legacy. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I76cdb57daf68833639fc454862af1e296a89d4cd Reviewed-on: https://chromium-review.googlesource.com/c/1260743Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596642}
-
Vasilii Sukhanov authored
It was recording an obsolete event. Bug: 860737 Change-Id: I642fbd2bf2fd30e33e604c28070371a8fb318bb4 Reviewed-on: https://chromium-review.googlesource.com/c/1255637Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596641}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/autocomplete. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: I5c6588a869225aeefef8b6d8198d92678a2d7642 Reviewed-on: https://chromium-review.googlesource.com/c/1259028 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#596640}
-
Morten Stenshorne authored
Writing back to legacy layout is a bit bumpy, because legacy layout has the rendered legend inside the anonymous fieldset content wrapper, while in NG it's a direct child fragment of the fieldset container. This solution uses NG painting of block children, which isn't really ready yet. The NG paint code, when first entered, will attempt to descend into everything that doesn't establish a new formatting context. Luckily, both the fieldset container and the anonymous child wrapper establish new formatting contexts, and we have to make sure to mark them as such, to help the NG paint code fall back to legacy painting. Introduced a new NGBoxType that is kMinimumBlockFormattingContextRoot or greater, since none of the other existing types were right (this isn't floated, atomic inline, OOF, etc.) There's no support for self-painting layers established by legends. Most likely better to wait for NG to support layers natively, rather than hacking something up for legends. Similarly no support for fieldsets that establish scrollable containers (also layers), which are supposed to be delegated to the anonymous fieldset content wrapper, and the paint code doesn't want scrollable containers to be established by anonymous objects. The new painting code is inspired by FieldsetPainter and NGBoxFragmentPainter. Added some virtual tests that enable NGFieldset. Rebaselined those that only had irrelevant differences in render tree dumps. Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I49e9eab8bb4aa469c76a13f15bc16d63c80d5940 Reviewed-on: https://chromium-review.googlesource.com/c/1252581 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#596639}
-
Daniel Vogelheim authored
- An empty trusted-types declaration means no policies are allowed. - A declaration of only "*" means all policies are allowed. - Quoted strings are considered reserved (and thus cannot be policy names) This aligns the implementation close with the trusted types polyfill. Bug: 739170 Change-Id: If9fc66e80d60a81ec4228da35ae8c8820ebaa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1249269 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/333dfc148ff3..7a4d068d23a6 git log 333dfc148ff3..7a4d068d23a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 dproy@google.com Merge "[perfetto-ui] Make query table a scrolling panel" Created with: gclient setdep -r src/third_party/perfetto@7a4d068d23a6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If5b51be215b31e852c48a36360a8f1f581eed6ba Reviewed-on: https://chromium-review.googlesource.com/c/1261418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596637}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions. This CL was uploaded by git cl split. R=karandeepb@chromium.org Bug: 809610 Change-Id: Id51b769ac4c45ca7a92330cb820397ac42f4392e Reviewed-on: https://chromium-review.googlesource.com/c/1257934 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596636}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/supervised_user. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 809610 Change-Id: I3280d803989a93c67ff0d34b21c409028f8011d5 Reviewed-on: https://chromium-review.googlesource.com/c/1259037 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/plugins. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: Ic5c4219a327a8ab038371a21c5d62bba54595d2d Reviewed-on: https://chromium-review.googlesource.com/c/1258919 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/search_engines. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 809610 Change-Id: I8f556cf9c85b9103051c036d2a81720d6bdcdb87 Reviewed-on: https://chromium-review.googlesource.com/c/1258173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#596633}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions. This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 809610 Change-Id: I8acd294b25decd9f81be9cb8b76c41f3302644af Reviewed-on: https://chromium-review.googlesource.com/c/1258171 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596632}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f6417f480e7..4a72ba99a704 git log 7f6417f480e7..4a72ba99a704 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 nisse@webrtc.org Delete RtpReceiver and related code. 2018-10-04 oprypin@webrtc.org Autoroller: don't run presubmit hooks Created with: gclient setdep -r src/third_party/webrtc@4a72ba99a704 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:836566 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id76b42048cc8fd3cf92a5c316127332381b58717 Reviewed-on: https://chromium-review.googlesource.com/c/1261415Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 809610 Change-Id: I69743ec252e8de02491fb85992a9f74ce197f696 Reviewed-on: https://chromium-review.googlesource.com/c/1257795 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596630}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/password_manager. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Icfc16e13a6e72e0fbf99e3024c87470ead622e53 Reviewed-on: https://chromium-review.googlesource.com/c/1259012 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596629}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fbdcc7add70..e3685e77a08d Created with: gclient setdep -r src-internal@e3685e77a08d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3af0e4308b467c618ea78564a700025f617a56 Reviewed-on: https://chromium-review.googlesource.com/c/1261417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596628}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/arc. This CL was uploaded by git cl split. R=hidehiko@chromium.org Bug: 809610 Change-Id: I5fc6a8372a65e5433e17abdbd60c54c397ecc4d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258351 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596627}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/search. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 809610 Change-Id: I3c0bdf40ecbde2810d84368080ed8e316e2bd938 Reviewed-on: https://chromium-review.googlesource.com/c/1257861 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
David 'Digit' Turner authored
This reverts commit 04c5a83e. Reason for revert: it broke the translation import process (see related bugs). A fix is in the work in [1] but is not ready yet. Reverting will unblock the situation. Once [1] is submitted, the original should be applied without breaking anything. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1256822 BUG=890511,890035 R=jshin@chromium.org,govind@chromium.org TBR=thestig@chromium.org Change-Id: I70ec089a438175edd13c4cd577e5c7327509b633 Reviewed-on: https://chromium-review.googlesource.com/c/1261635Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#596625}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/startup. This CL was uploaded by git cl split. R=tmartino@chromium.org Bug: 809610 Change-Id: I90d1bbb37bbb2fefa701b1505a5e901c25bcbeda Reviewed-on: https://chromium-review.googlesource.com/c/1259022 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#596624}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/resource_coordinator. This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 809610 Change-Id: I057b0bd65c07e68f71692e9f02259cd1e02448c9 Reviewed-on: https://chromium-review.googlesource.com/c/1259030 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/language_settings_private. This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 809610 Change-Id: I565984f1f787a2b730d1f0c659e4d9c2f084fcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258920 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596622}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/media/router. This CL was uploaded by git cl split. R=btolsch@chromium.org Bug: 809610 Change-Id: I04ceb8b57dfd8772d31bee0ea7f49e9025325934 Reviewed-on: https://chromium-review.googlesource.com/c/1258350 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#596621}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/gcm. This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 809610 Change-Id: I977d7f9586dffd411471f2c5a201f3d2cd386211 Reviewed-on: https://chromium-review.googlesource.com/c/1258985 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#596620}
-
Eric Seckler authored
This fixes a bug where the order of scheduled timeouts is reshuffled during debugging via DevTools, since these timeouts are paused and unpaused when a breakpoint is reached, and notified about this via a Lifecycle observer. I'd like to try replacing the HeapHashSet currently used by Lifecycle observers with a HeapLinkedHashSet to preserve the observer iteration order, resolving the problem above. If this turns out to negatively impact performance elsewhere significantly, we can revert. Bug: 638255 Change-Id: I5c0be5c2132d3869863e3be6b8913c1f3ea3859f Reviewed-on: https://chromium-review.googlesource.com/c/1261182Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#596619}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/arc/auth. This CL was uploaded by git cl split. R=khmel@chromium.org Bug: 809610 Change-Id: I16703180cb1ca7b4acdf5b2d5eb7d81125b5695e Reviewed-on: https://chromium-review.googlesource.com/c/1259010 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596618}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/media/media_engagement_service_unittest.cc. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 809610 Change-Id: I6bef551f35ebab6bb192af99f86365e62ebe0b55 Reviewed-on: https://chromium-review.googlesource.com/c/1259002 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596617}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/print_preview. This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 809610 Change-Id: I054ccb17b5557e700aff2ccb0f72307af5e41a5f Reviewed-on: https://chromium-review.googlesource.com/c/1258353 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596616}
-
