GitLab

This change alters the functionality of getObjectAttr slightly: it no
longer accepts null or Array objects as "object" values.  I made this
change because the type checking code seems designed to mirror the
semantics of JSON, where each value belongs to exactly one of the
following categories: array, boolean, number, null, object, or string.

This change also changes the type of values thrown from strings to Error objects so that there are more likely to be useful stack traces when an error occurs.

BUG=

Review URL: https://codereview.chromium.org/1015553003

Cr-Commit-Position: refs/heads/master@{#321415}

Fix for a crasher in the browser seen while dispatching mouse enter or mouse exit messages via the root view.

Based on a number of crash dumps I looked at starting from M40 onwards, the crash occurs in the RootView::NotifyEnterExitOfDescendant function while dereferencing a NULL view parameter.

The parameter passed as the view, is the mouse_move_handler_ member which is checked for validity before calling this
function. However the disassembly in the crash dump clearly suggests that the parameter passed on the stack is NULL.

Looking at the code the only way that could happen if we end up in a nested invocation to the root view, which could
potentially happen in the context of a modal loop. I could not repro that hypothesis however.

Given that this is a browser crash and seems to be occurring frequently enough, I think this warrants a NULL check
for the mouse_move_handler_ before calling the RootView::NotifyEnterExitOfDescendant function.

I added a CHECK for the view parameter in the NotifyEnterExitOfDescendant  function in case there are additional callsites
added in the future.

BUG=467356
TEST=No test at the moment as I could not verify the hypothesis with actions in the UI.

Review URL: https://codereview.chromium.org/996103009

Cr-Commit-Position: refs/heads/master@{#321414}

Fix a mistake I made in http://crrev.com/1003853004.
Before that CL, the "More tools" submenu was incorrectly using IDC_ZOOM_MENU
command, and I fixed that. But then I incorrectly added checks for
IDC_MORE_TOOLS_MENU wherever it was checking for IDC_ZOOM_MINUS, causing this
incorrect spacing bug. This removes those checks, but we still need a check
to make sure it is enabled, because when it was incorrectly using IDC_ZOOM_MENU,
it was getting enabled by BrowserCommandController.

BUG=468644

Review URL: https://codereview.chromium.org/1016413002

Cr-Commit-Position: refs/heads/master@{#321413}

BUG=466721,431489

Review URL: https://codereview.chromium.org/1020783002

Cr-Commit-Position: refs/heads/master@{#321412}

Previously |cdm_id| is guarded by the ENABLE_BROWSER_CDMS macro, which makes a
lot of code more complicated and brings very little savings. This CL always
defines |cdm_id| to clean this up.

BUG=432998

Review URL: https://codereview.chromium.org/835683002

Cr-Commit-Position: refs/heads/master@{#321411}

Removes the unused shutdown() function from WebSchedulerImpl now that it is
no longer used by Blink.

BUG=467369

Review URL: https://codereview.chromium.org/1022443002

Cr-Commit-Position: refs/heads/master@{#321410}

The banner engagement persisted data should be per-origin. This test
ensures that is the case.

BUG=468148

Review URL: https://codereview.chromium.org/1019763002

Cr-Commit-Position: refs/heads/master@{#321409}

BUG=468474

Review URL: https://codereview.chromium.org/1019943002

Cr-Commit-Position: refs/heads/master@{#321408}

BUG=349185

Review URL: https://codereview.chromium.org/1000863003

Cr-Commit-Position: refs/heads/master@{#321407}

Re-mask all unmasked cards when the user disables autofill integration.

Delete all server cards and addresses when the user disables the sync type or stops syncing.

Fix a bug where addresses were always written to the DB on startup because profiles were being created differently from protos than they were from sqlite so wouldn't match.

Optimize autofill profile comparisons. I was offended by the number of autofill profile and card comparisons we do at startup, the small number of items in the list means std::set is operating at a worst-case. I switched to brute-force with a "give up and rewrite the data" escape valve if you have a large number of addresses.

BUG=450843

Review URL: https://codereview.chromium.org/1007003007

Cr-Commit-Position: refs/heads/master@{#321406}

BUG=463780

Review URL: https://codereview.chromium.org/1019303004

Cr-Commit-Position: refs/heads/master@{#321405}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/647211f..3ef71e3

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1009603004

Cr-Commit-Position: refs/heads/master@{#321404}

This deduplication becomes a particularly good win when implementing
GetThreadPriority() in https://codereview.chromium.org/1006933003/

BUG=456903,468793

Review URL: https://codereview.chromium.org/1015503002

Cr-Commit-Position: refs/heads/master@{#321403}

Revert of Allow users to add third-party VPNs from the settings page (patchset #5 id:80001 of https://codereview.chromium.org/1017443002/)

Reason for revert:
Invalid JS caught by Closure bots:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/18417/steps/compile/logs/stdio

Original issue's description:
> Allow users to add third-party VPNs from the settings page
>
> This CL adds "Add $provider..." entries to the "Private network" and
> "Add connection" drop-down menus on the Chrome OS settings page. The
> contents of these menus updates dynamically as VPN providers are
> added/removed.
>
> BUG=460428
> TEST=Manual
>
> Committed: https://crrev.com/4f6e1a2ded3a56e7c2d1360b94990b025a309ecb
> Cr-Commit-Position: refs/heads/master@{#321395}

TBR=michaelpg@chromium.org,stevenjb@chromium.org,isherman@chromium.org,bartfab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460428

Review URL: https://codereview.chromium.org/1026463003

Cr-Commit-Position: refs/heads/master@{#321402}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2960bec..5e13200

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1016383002

Cr-Commit-Position: refs/heads/master@{#321401}

Frecon requires BSD style file locks since the lock needs to be held
past forking. So we also need to change the Ozone side since Posix and
BSD locks don't mix.

BUG=463665

Review URL: https://codereview.chromium.org/1007993007

Cr-Commit-Position: refs/heads/master@{#321400}

This adds five methods to the NotificationDatabase class to read or delete
multiple notifications, which share two actual implementations.

They will be used as follows:
- Read all data: browsing data overviews.
- Read all data for an origin: for origin storage overviews, quota
  client integration (storageQuota.queryInfo()).
- Read all data for a SWR id: to get all notifications associated
  with a given SWR (SWR.getNotifications()).
- Delete all data for an origin: clearing browsing data for a
  given origin.
- Delete all data for a SWR id: to remove notifications when a service
  worker registration gets dropped.

Actual integration with these features will be done in separate patches,
this patch just introduces the primitives in the database.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1019073002

Cr-Commit-Position: refs/heads/master@{#321399}

This causes racy sadness.

BUG=235188

Review URL: https://codereview.chromium.org/1020803002

Cr-Commit-Position: refs/heads/master@{#321398}

BUG=460581

Review URL: https://codereview.chromium.org/1003883004

Cr-Commit-Position: refs/heads/master@{#321397}

https://codereview.chromium.org/1019863002

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1024523002

Cr-Commit-Position: refs/heads/master@{#321396}

This CL adds "Add $provider..." entries to the "Private network" and
"Add connection" drop-down menus on the Chrome OS settings page. The
contents of these menus updates dynamically as VPN providers are
added/removed.

BUG=460428
TEST=Manual

Review URL: https://codereview.chromium.org/1017443002

Cr-Commit-Position: refs/heads/master@{#321395}

Revert of https://codereview.chromium.org/1006003005/ and https://codereview.chromium.org/1001153002/.

We've already collected enough data to triage this bug.

BUG=464633

Review URL: https://codereview.chromium.org/1016183002

Cr-Commit-Position: refs/heads/master@{#321394}

All the major work has already been done. This CL just finishes flushing out
the documentation on tab.py and web_contents.py so that consumers know exactly
which exceptions can be thrown.

This CL contains one small behavioral change: InspectorBackend.IsInspectable()
catches DevToolsClientConnectionError and returns False. This is useful since
IsInspectable() gets called in the exception handling code, and no other
consumers of IsInspectable expect the method to throw an exception.

BUG=460625

Review URL: https://codereview.chromium.org/1007903004

Cr-Commit-Position: refs/heads/master@{#321393}

BUG=369661
TEST=tests should stay passing

Review URL: https://codereview.chromium.org/1010243002

Cr-Commit-Position: refs/heads/master@{#321392}

BUG=392620

Review URL: https://codereview.chromium.org/1006813005

Cr-Commit-Position: refs/heads/master@{#321391}

BUG=454815

Review URL: https://codereview.chromium.org/978913004

Cr-Commit-Position: refs/heads/master@{#321390}

BUG=462584
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/1017243002

Cr-Commit-Position: refs/heads/master@{#321389}

BUG=
TBR=jamesr@chromium.org for third_party/mojo
TBR=dpranke@chromium.org for build

Review URL: https://codereview.chromium.org/1019173002

Cr-Commit-Position: refs/heads/master@{#321388}

BUG=b/13306957

Review URL: https://codereview.chromium.org/1015343002

Cr-Commit-Position: refs/heads/master@{#321387}

Path used to be a std::vector<std::string>. Now it is just a C array of size
PATH_MAX.

The code has a lot of nasty edge cases because it is trying to match the
previous behavior. Really, all this code should be axed -- it is incorrect to
handle paths the way nacl_io does currently. AFAICT, the only place that should
have to handle paths is the path lookup routine.

Fixing that is a much larger change.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/1016873004

Cr-Commit-Position: refs/heads/master@{#321386}

Original work around done in: crbug.com/455327 and crbug.com/459782

BUG=440601

Review URL: https://codereview.chromium.org/1019593002

Cr-Commit-Position: refs/heads/master@{#321385}

BUG=431230
TEST=manual

Review URL: https://codereview.chromium.org/1014913002

Cr-Commit-Position: refs/heads/master@{#321384}

Show the toolbar redesign bubble once per 24 hour period when the mouse
enters the toolbar, if and only if the user has not acknowledged it previously
and there is something new in the toolbar (i.e., and extension that was not
there previously).

BUG=461039

Review URL: https://codereview.chromium.org/1004063003

Cr-Commit-Position: refs/heads/master@{#321383}

BUG=467059
TBR=pfeldman

Review URL: https://codereview.chromium.org/1013753009

Cr-Commit-Position: refs/heads/master@{#321382}

Add a chrome.developerPrivate.updateExtensionConfiguration function, which allows
for setting particular extension traits.  Coalesce the existing allow file
access and allow incognito access into this, and add others.  Update the
chrome://extensions page to use the new function.

BUG=461039
(get past histogram presubmit warning)
NOTRY=true

Review URL: https://codereview.chromium.org/997183005

Cr-Commit-Position: refs/heads/master@{#321381}

Revert of Add RoutingIDIssuer to help track routing id issues. (patchset #4 id:60001 of https://codereview.chromium.org/999193003/)

Reason for revert:
We've already collected enough data to triage this bug.

Original issue's description:
> This is a re-land of https://codereview.chromium.org/643733002.
>
> This CL adds a RoutingIDIssuer that verifies that the routing IDs are being sent to the correct process.
>
> BUG=464633
> TBR=sky@chromium.org
>
> Committed: https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1
> Cr-Commit-Position: refs/heads/master@{#320207}

TBR=nasko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464633

Review URL: https://codereview.chromium.org/1019913002

Cr-Commit-Position: refs/heads/master@{#321380}

Revert of Disable gpu_perftests on android. (patchset #1 id:1 of https://codereview.chromium.org/1014573007/)

Reason for revert:
Fixed already!

Original issue's description:
> Disable gpu_perftests on android.
>
> Failing on Nexus 4/5/7v2 and MotoE.
>
> TBR=dcastagna
> BUG=464373
>
> Committed: https://crrev.com/cbcf11d9fa9fd06dd81dd3faf7f69a0e8f54e54f
> Cr-Commit-Position: refs/heads/master@{#321367}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464373

Review URL: https://codereview.chromium.org/1016433004

Cr-Commit-Position: refs/heads/master@{#321379}

This CL should make IsRepeated more robust for a code that needs to create KeyEvent from native code, like key rewriter, or https://codereview.chromium.org/1013003002/

BUG=468442
TEST=covered by test, and also tested manually.

Review URL: https://codereview.chromium.org/1017323002

Cr-Commit-Position: refs/heads/master@{#321378}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/732bda7..2960bec

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1010433005

Cr-Commit-Position: refs/heads/master@{#321377}

This refactor removed a lot of unnecessary repeated code. The other guestview types (that currently do not have attributes modules) will be refactored to use guest_view_attributes as well in a subsequent patch.

BUG=466215

Review URL: https://codereview.chromium.org/1017863007

Cr-Commit-Position: refs/heads/master@{#321376}