- 20 Dec, 2018 40 commits
-
-
Tomasz Wiszkowski authored
Bug: 871798 Change-Id: If3c9199ec66ef48db305f3cd09d6eec619ed4921 Reviewed-on: https://chromium-review.googlesource.com/c/1383437 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618338}
-
Tao Bai authored
Bug: 917112 Change-Id: Idcfac659688b33f48d4dede027cf56173a1e4414 Reviewed-on: https://chromium-review.googlesource.com/c/1387665Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#618337}
-
Lukasz Anforowicz authored
LoadDataWithBaseURL should be avoided in browser tests, because 1. It doesn't fully, correctly simulate navigating to a real website. 2. It is only used in production in Android WebView and in GuestView (both of which don't run with site-per-process, which is the default mode on desktop platforms). Cleaning up test usage of LoadDataWithBaseURL will help proceed with enforcement of CanCommit origin checks - LoadDataWithBaseURL is problematic because it commits https://foo.com origin in a SiteInstance associated with data: site URL. Bug: 770239 Change-Id: Ic68697be28cace0d8ff8abc0951e12cb5f81ac68 Reviewed-on: https://chromium-review.googlesource.com/c/1385471Reviewed-by:Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#618336}
-
Tom Anderson authored
This is needed to enable in-tree libc++ on Android. Otherwise, we'll see errors that look like this: FAILED: libwebviewchromium.so libwebviewchromium.so.TOC lib.unstripped/libwebviewchromium.so ld.lld: error: undefined symbol: __cxa_guard_acquire >>> referenced by aw_contents.cc:122 (../../android_webview/browser/aw_contents.cc:122) >>> obj/android_webview/common/aw_contents.o:(android_webview::(anonymous namespace)::g_locale()) The issue is that libc++abi is not a dependency of libc++ in asan builds -- instead it's exported from executables to prevent multiple definitions of libc++abi symbols. -Wl,-z,-defs is normally added only for non-sanitizer builds [1] on Linux, Android, and Fuchsia. But the Android-specific config adds -Wl,--no-undefined (which is identical to -Wl,-z,-defs) all the time. The solution is to simply remove the Android-specific -Wl,--no-undefined and rely on the -Wl,-z,defs added by //build/config/compiler:compiler. [1] https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=c6dd1fda26ff8dddd92ba7830e8696afe3b031f5&l=398 BUG=916962 R=thakis Change-Id: If6887c96a0eaeeac3c831511e3e4519dac3532b5 Reviewed-on: https://chromium-review.googlesource.com/c/1387399Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#618335}
-
Sophie Chang authored
This is redundant for me since I'm on breve-team-reviews@chromium.org and do not need this to personally cc me. Change-Id: I5d330ce512b813c6803efbbf2b5b7f0724c3db2d Reviewed-on: https://chromium-review.googlesource.com/c/1387835Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618334}
-
Henrik Boström authored
Previously, associated media streams were only updated on the "addition" and "removal" of a track. But MSIDs can change for active receivers as well. In this CL, we always update the associated media streams based on the state of the webrtc-layer receiver. Bug: webrtc:10083 Change-Id: I54bb00a5077a0b7b78964faf13882055c8101427 Reviewed-on: https://chromium-review.googlesource.com/c/1384257 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#618333}
-
Min Qin authored
Resuming an offline page download will construct OfflineContentAffregatorNotificationBridgeUiFactory. That class uses the browser profile, which is not available for service manager only mode. This CL excludes offline page download from service manager only mode. BUG=916393 Change-Id: I1ac9185adc2890568d7eaf5304550644ab7c3d89 Reviewed-on: https://chromium-review.googlesource.com/c/1387544Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618332}
-
Tomasz Wiszkowski authored
Change-Id: Id25261aac8f8f5228bf69ff46a6ee8763f96169e Bug: 871798 Reviewed-on: https://chromium-review.googlesource.com/c/1380958Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Remove ARCore SDK 1.1 now that we are switching to newer version. android-binary-size trybot was complaining about growth of APK - this is suppressed by adding "Binary-Size" explanation in the footer. The size impact is 300369 additional bytes - it should be acceptable since it only affects canary & dev channels (not present on stable). Additionally, the AR support will be deployed as a DFM when we release it, so the impact on on base APK size should be way smaller than what is currently reported by trybots. is currently only packaged for dev, canary and default channels. Bug: 887669 Change-Id: I56a2230f31b4e17925ddb4e2d2b20266e55c1091 Binary-Size: Increase is due to packaging ARCore into the APK. ARCore Reviewed-on: https://chromium-review.googlesource.com/c/1357349Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618330}
-
Mathieu Perreault authored
Feature has been on by default for a while. TBR=rkaplow Bug: 906135 Change-Id: Ib44fe4d5cc728c622d33b2e4a9eeb5c0415b6aae Reviewed-on: https://chromium-review.googlesource.com/c/1387153 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618329}
-
Xida Chen authored
This CL is a re-land of: https://chromium-review.googlesource.com/c/chromium/src/+/1281702 Previous CL depends on the usage of default hash traits implementation of enum, which could crash. In this CL, instead of keeping two hash maps: 1. HashMap<CSSPropertyID, String> native_values_ 2. HashMap<String, String> custom_values_ We keep one hash map only: HashMap<String, String> values_ Because we guarantee that CSS native and custom property name will never conflict, this is safe. PS#1 is the original CL so that we can easily see the diffs. TBR=pdr@chromium.org Bug: 884698 Change-Id: Ifc74a13ba67fa74ff1a3dd9dbca628675b42c777 Reviewed-on: https://chromium-review.googlesource.com/c/1386648 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#618328}
-
Richard Knoll authored
We use two nested |BoxLayout|s to layout the notification header. This CL uses the shiny new |FlexLayout| which is already in use by the |ToolbarView| to prevent very long URLs from moving the control buttons off the side. Also set the correct text elide behaviour to trim URLs from the start to see the TLDs. Bug: 915224 Change-Id: I662eb4e7f71356e8d441229c2e01b7b2da0caa95 Reviewed-on: https://chromium-review.googlesource.com/c/1384372 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#618327}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cc6e2553669..7b72af28fb84 git log 2cc6e2553669..7b72af28fb84 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7b72af28fb84 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6b85769d91926eeca77ec05f6acf5e8b6defa40b Reviewed-on: https://chromium-review.googlesource.com/c/1387289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618326}
-
Lei Zhang authored
Also delete an unused placeholder exception. Change-Id: Ice6cff86ec75c32d950a5f0dec87f0ea34a71b4d Reviewed-on: https://chromium-review.googlesource.com/c/1385455 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Maks Orlovich authored
They were disabled when Windows was not supported by the backend at all, but now it is used for things like CacheStorage on the platform, and there is support for renames of open files. Change-Id: I69d353041a6920cfd6ec7d312026a3cc650ec3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1387685 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#618324}
-
Lei Zhang authored
Use early returns and ternary operators. Change-Id: I6eb8154736e8bbe9f740cb2887b2ae44d610ea00 Reviewed-on: https://chromium-review.googlesource.com/c/1385857 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Richard Knoll authored
Move UpdateControlButtonsVisibility up to |MessageView| and removing unused code. This is a preparation to fix the |NotificationHeaderView|. Note: |ArcNotificationView| is now the only class overriding this. Bug: 915224 Change-Id: Ide72668c7bb88c63148c43e756061bbdb9ff13eb Reviewed-on: https://chromium-review.googlesource.com/c/1386624 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#618322}
-
Xiyuan Xia authored
Until test infra code is updated similar to content_browsertests to use Window Service. Bug: 916180 Change-Id: Ic348c81874cae60258ebfe20cd6f4223a2ec7e4a Reviewed-on: https://chromium-review.googlesource.com/c/1385468Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618321}
-
Vikas Soni authored
1. Implemented Vulkan backed skia representation of SharedImageBackingAHB. 2. Added synchronisation between gl backed and Vk backed representations. Bug: 891060 Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168 Reviewed-on: https://chromium-review.googlesource.com/c/1370471Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618320}
-
edchin authored
A prior fix early exited the observer method |didDetachWebState| if the WebStateList is nil. We also logged a histogram to see how often we see that WebStateList is nil. The histogram shows that the WebStateList is never nil at that point. However, we are still seeing these real world crashes in a free function one frame lower in the call stack. This CL adds an early exit and histogram log to the free function, which is where the crash has always been occurring. Bug: 877792 Change-Id: Icd099af3e399a748fa744674cc6756cfac09cf4e Reviewed-on: https://chromium-review.googlesource.com/c/1384791 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#618319}
-
Ryan Sleevi authored
Retire Net.CertificateTransparency.[MainFrameValidSCTCount,SCTsPerConnection] and Net.OCSPResponseStapled The first two histograms were related to the policies around and the rollout of Certificate Transparency, and as the ecosystem has matured and evolved, provide less direct value. The latter is related to our policies around OCSP and OCSP stapling, and as those have evolved, is no longer a priority for measurement and assessment, as there is no longer a need to assess the webcompat impact. Bug: 898016, 842976 Change-Id: I1c87eb73635f92b6a52bc6b8cebd69660db3d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1385549 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3793bb447ae5..7f57788ab7e2 git log 3793bb447ae5..7f57788ab7e2 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 srte@webrtc.org Removes trial to enable BBR congestion controller. 2018-12-20 crodbro@webrtc.org Make pacing buffer send interval configurable. 2018-12-20 ssilkin@webrtc.org Propagate spatial index to EncodedImage. 2018-12-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdf260ef..5397835a (617896:618202) Created with: gclient setdep -r src/third_party/webrtc@7f57788ab7e2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8beb51c490e84b00aa662aafaeb380d09cb738d Reviewed-on: https://chromium-review.googlesource.com/c/1386990Reviewed-by:
-
Xianzhu Wang authored
For pre-CompositeAfterPaint, we call InvalidateChromeClient() when an object is invalidated in a view referenced from a plugin or an svg-image. Now let the path also work for CompositeAfterPaint. This fixes several web plugin tests for CompositeAfterPaint. Bug: 524134 Change-Id: Ia4c3ccba4632ddcdfdfdfec299fb7a68440a1419 Reviewed-on: https://chromium-review.googlesource.com/c/1385112Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#618316}
-
Doug Arnett authored
Originally, the HintCache was on the IO thread while the UI thread was responsible for sending resource blocking hints to Blink and so a copy of those hints was staged in the PreviewsUIService. This approach has some bug cases and now that the HintCache is on the UI thread, this CL drops that staged copy and retrieves from the HintCache when needed instead. There are some interface layers that makes this CL look a bit more complicated than actually is. Bug: 916186 Change-Id: Ib14bfc3fa7a9580e40223d02092ed7014164fc1f Reviewed-on: https://chromium-review.googlesource.com/c/1384933Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#618315}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30cf62bf481a..9fbd2ad38c75 git log 30cf62bf481a..9fbd2ad38c75 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 96c11cc79490..bcb7890895d2 (1 commits) 2018-12-20 herb@google.com Move the maskStyle into the GrGlyph Created with: gclient setdep -r src/third_party/skia@9fbd2ad38c75 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I4b5e047bcb6a79dc238417c063e9774434454110 Reviewed-on: https://chromium-review.googlesource.com/c/1387288Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/345719ad7687..b903bc0f5428 Created with: gclient setdep -r src-internal@b903bc0f5428 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I403f614efac0ead3781bb7ae2d7d474f64ece6f9 Reviewed-on: https://chromium-review.googlesource.com/c/1386989Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618313}
-
edchin authored
|drawViewHierarchyInRect:| has undefined behavior when the view is not in the visible view hierarchy. In practice, when this method is called on a view that is part of view controller containment, an UIViewControllerHierarchyInconsistency exception will be thrown. This method has been crashing when snapshotting overlays, such as infobar. This crash was introduced recently because infobars became child view controllers of BVC. Interestingly, the method does not raise an exception when the view is a standalone subview of a view controller that is not contained and not in the view hierarchy. This explains why there were no crashes before infobar was converted to a child view controller. This CL resorts to CALayer's |renderInContext:| when the view is not in the view hierarchy. Bug: 911484, 881998 Change-Id: I95058c8c3cc8276686c666aa3b5fef414ac06c88 Reviewed-on: https://chromium-review.googlesource.com/c/1387159Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618312}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b78a068ced74..44d98b424db4 git log b78a068ced74..44d98b424db4 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 thestig@chromium.org Remove a useless assignment in CPDF_Parser::ParseCrossRefV4(). Created with: gclient setdep -r src/third_party/pdfium@44d98b424db4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaba516693be11b1a2fb42feb0740f74f6b3dd29b Reviewed-on: https://chromium-review.googlesource.com/c/1386988Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee899a100b3f..9948742b0b60 git log ee899a100b3f..9948742b0b60 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 treehugger-gerrit@google.com Merge "profiling: Demangle C++ names." Created with: gclient setdep -r src/third_party/perfetto@9948742b0b60 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I54a6e5ecb34f5084455ea47ce801b66a57f81327 Reviewed-on: https://chromium-review.googlesource.com/c/1386991Reviewed-by:
-
Matt Simmons authored
Adding a utility class to handle the logic of calculating if enough time has passed. The last backgrounded time is already tracked in ChromeTabbedActivity::onStopWithNative(). Experiment name is enable-tab-switcher-on-return. See `chrome://flags` Available options are 30 or 60 minutes. R=yusufo@chromium.org Bug: 898685 Change-Id: I916eb86b55525f06335d27cec84de78b1e366e98 Reviewed-on: https://chromium-review.googlesource.com/c/1384658Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e49bd96f2c1e..c2013e248bb0 git log e49bd96f2c1e..c2013e248bb0 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 stevenperron@google.com Make the constant and type manager analyses. (#2250) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c2013e248bb0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id5140a3f626b7fb01eacbf0c0aff899dc0a2a01a Reviewed-on: https://chromium-review.googlesource.com/c/1387286Reviewed-by:
-
W. James MacLean authored
This CL adds a test for https://chromium-review.googlesource.com/c/chromium/src/+/1367864. It modifies an existing, but disabled test to do this, so it's possible this test was flakey or otherwise had issues, so this is being landed separately from the main CL so we can diagnose it separately. Bug: 734209 Change-Id: I7bf8a14f0d126a62e8ac4c5815d4b1802e27b3e6 Reviewed-on: https://chromium-review.googlesource.com/c/1384940Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e535ffd2. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I29e5d88c203866363764ac60da80c563ed3f5f55 Reviewed-on: https://chromium-review.googlesource.com/c/1387195Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618306}
-
manuk authored
crrev.com/c/1381145 set the 'show all providers' checkbox checked by default (on page load). However, this state is not propagated to OmniboxOuptut until at least 1 display option was changed by the user, leading to unintuitive results: 1) 'show all providers' behaved as if it was unchecked but was displayed checked 2) unchecking 'show all providers' would appear to change nothing 3) checking another display checkbox (e.g. 'show all details'), would also active 'show all providers' This CL initializes OmniboxOutput's displayOptions to the default values. Bug: 891303 Change-Id: I328180d1b79319ff60f23a9c1d860bc1f68d8c76 Reviewed-on: https://chromium-review.googlesource.com/c/1384930 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#618305}
-
Morten Stenshorne authored
This makes us match legacy engine behavior more closely, and both Edge and Firefox have something similar, although Firefox triggers based on element type (LI), and not display type (list-item). There's currently nothing in the spec [1] that suggests such special behavior for list items. [1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk This fix makes the line height differences go away in the test tables/mozilla/bugs/bug23235.html (but note that it will still require a rebaseline, because of minor text rendering differences between legacy and NG). See https://github.com/whatwg/quirks/issues/38 for spec discussion. Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e Reviewed-on: https://chromium-review.googlesource.com/c/1379897 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618304}
-
Koji Ishii authored
CSS Text Level 3 has a rule for collapsing line break for East Asian writing systems that do not use spaces to delimit words. The rule is based on Unicode East Asian Width property, but recently it was brought to the attention that the rules may need more logic at: https://github.com/w3c/csswg-drafts/issues/337 As the discussion seems to take longer to resolve, and there is a possibility to change the rules in the current spec, this patch disables the rule until WG reaches to a consensus. LongFind.txt was changed in r616898 (CL:1379086) when find- in-page switched to NGOffsetMapping. Since this CL changes whitespace collapsing rules for East Asian text back to the same as legacy, the test data change is reverted. Bug: 636993 Change-Id: I9e78e4fc8791981ef49315ac173912403c8d23f1 Reviewed-on: https://chromium-review.googlesource.com/c/1385696Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Sven Sauleau authored
Fix WebAssembly's table/grow js-api. Bug: v8:8319 Change-Id: I453ed390dd3b616ace8180a5f3b6a8c0c9dcc079 Reviewed-on: https://chromium-review.googlesource.com/c/1386344 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#618302}
-
Joe DeBlasio authored
As HTTP-Bad now treats nearly all HTTP sites as universally bad, this CL removes tracking of incognito mode, insecure credit card editing, and insecure password entry no longer needed for updating security state. It also removes now-unused flag conditions no longer used in experiments. Bug: 908620 Change-Id: Ia10f399638b3e4b81d733e9bcd955c5ac42feb73 Reviewed-on: https://chromium-review.googlesource.com/c/1350922Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618301}
-
Kristi Park authored
Set the text direction for input fields using the "dir" element attribute instead of CSS "direction". This allows users to change the writing direction from the right-click context menu if they wish to. The URL field will still be LTR by default. With LTR selected (default): https://screenshot.googleplex.com/gRVdNvJ6HWR.png https://screenshot.googleplex.com/5hwGvnZ8rRy.png With RTL selected: https://screenshot.googleplex.com/Brge2TxgB6h.png https://screenshot.googleplex.com/MvZi3cnWutz.png Bug: 916474 Change-Id: Ie20ab4d91afc10498495998c7166f28abf0c45e3 Reviewed-on: https://chromium-review.googlesource.com/c/1385387 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#618300}
-
Jun Mukai authored
This CL cleans up the initialization of AshKeyboardUI, since some tests assume to use TestKeyboardUI (ash/keyboard/test_keyboard_ui) but the existing AshKeyboardController always creates AshKeyboardUI. With this CL; the following KeyboardUI class will be used: - unit tests (whatever uses AshTestHelper): TestKeyboardUI - Mash/SingleProcessMash: AshKeyboardUI - otherwise: ChromeKeyboardUI Bug: 910240 Test: trybot Change-Id: I9d45e8ad25af40ce4dbbd7e437d2b28fab7f325c Reviewed-on: https://chromium-review.googlesource.com/c/1380968 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#618299}
-
