- 22 Feb, 2019 40 commits
-
-
Bo Liu authored
Test renders 4 colors in 4 quadrants and use glReadPixels to read the center pixel of each quadrant and and check if the rendering result matches expectation. Change-Id: If7b89506c1b84448e98f18b58c85aecff99f04bc Reviewed-on: https://chromium-review.googlesource.com/c/1476120 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#634715}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c6461681d608..18e5841c0dae git log c6461681d608..18e5841c0dae --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 thomasanderson@chromium.org Make SkFontConfigInterface_direct and sysroot-aware Created with: gclient setdep -r src/third_party/skia@18e5841c0dae The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:822737,chromium:908463 TBR=jvanverth@chromium.org Change-Id: I9bd3e3b98970fd6363c4f4868c53abc303361fab Reviewed-on: https://chromium-review.googlesource.com/c/1483154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634714}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a33c0190f771..67e798b11f20 Created with: gclient setdep -r src-internal@67e798b11f20 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0e857226297c5f614936a0192f1b066da65cd13c Reviewed-on: https://chromium-review.googlesource.com/c/1483290Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634713}
-
manuk authored
This CL adds two chrome://flags flags for crrev.com/c/1475065. Bug: 931836 Change-Id: I513f988e36c853383c41f48b1ed0841a5ca10b60 Reviewed-on: https://chromium-review.googlesource.com/c/1481904Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634712}
-
Fredrik Söderquist authored
This adds a test for the case where the start and end circles of a radial gradient fully overlap (while having non-zero radii). Bug: 933413 Change-Id: Id059cb607f6fc137111d2306dd9c9eef1f55b6bc Reviewed-on: https://chromium-review.googlesource.com/c/1483023 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#634711}
-
Rouslan Solomakhin authored
This patch refactors the relationship between PaymentRequestDialogView and PaymentRequestState to be more generic. Instead of waiting for the state event of fetching all payment instruments (specific), the view now waits for an initialization task (abstraction) to finish initialization (generic). This will help to add more initialization tasks in follow up patches. For example, PaymentRequestSpec will become an initialization task as well, so the view can wait for the spec to completely initialized, in case if PaymentRequest.show() was called with a promise. Bug: 817073 Change-Id: I19c133ab3084a7a26628380135c21abeeb1c7436 Reviewed-on: https://chromium-review.googlesource.com/c/1478090 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#634710}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 Change-Id: I2783d2caf8b915a06bb5277d35ca650f079a58c7 Reviewed-on: https://chromium-review.googlesource.com/c/1483173 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634709}
-
Tommy Steimel authored
This CL adds a null check to prevent a crash occurring in MediaSessionImplParamBrowserTest. Bug: 933742 Change-Id: Ia2d6eaf9a8a8c7ce1e165ad56d09ec3d6830730c Reviewed-on: https://chromium-review.googlesource.com/c/1481081Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634708}
-
Andrew Grieve authored
Change-Id: I21690fe27cb4ea7e256943fe6ffc6ed7e8bb99c1 Reviewed-on: https://chromium-review.googlesource.com/c/1481964 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634707}
-
Robert Ogden authored
This reverts commit f54db458. Reason for revert: Miscommunication with server team requirements. Need to change some logic Original change's description: > HTTPS Previews: Use the DRP experiment instead of a Finch-provided one > > This experiment doesn't actually seem very useful in Finch. It's better > to reuse the DRP experiment which is accessible in chrome://flags. > > Bug: 934376 > Change-Id: I27a5bdfa4f57fa761eaae62106113e7fc5529ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/1481995 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634682} TBR=robertogden@chromium.org,ryansturm@chromium.org Change-Id: I354e3ca9ccd61617b47031ba0880890084210a9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934376 Reviewed-on: https://chromium-review.googlesource.com/c/1482947Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634706}
-
Sidney San Martín authored
It's hit when creating a new window in fullscreen. The linked bug mentions leaving it in place as a reminder to add a test, but I keep getting bit. The bug should sufficiently document the need for a test. Bug: 844482 Change-Id: Ibbd1cf24864c8122e82ba189072dcc2711afc326 Reviewed-on: https://chromium-review.googlesource.com/c/1482558 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634705}
-
Jimmy Gong authored
- This change prevents more than one instance of a UpdateCredential dialog for a single mount. - Each mount, when prompted, will have their own dialog to update credentials. - Previously, it was possible to have multiple dialogs and would crash the File App. The cause of the crash is after successfully updating the credentials of the share via the first dialog, the second dialog is no longer in a stable state and holds stale callbacks. Bug: 931846 Test: end to end manual test Change-Id: I09f85c084028943bceed3831e81cefce503f2bb7 Reviewed-on: https://chromium-review.googlesource.com/c/1470726 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#634704}
-
Christos Froussios authored
[Sheriff] Expectations for virtual/outofblink-cors-ns/http/tests/security/cross-origin-worker-indexeddb-allowed.html The test is flaky (crashing) on Mac Bug: 934866 No-try: True No-presubmit: True Change-Id: I8ab29cf258e6b7c80e0c4589c54f6fedab6641db Reviewed-on: https://chromium-review.googlesource.com/c/1482833Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634703}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1b14cdf2bee..e83100437106 git log b1b14cdf2bee..e83100437106 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e83100437106 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3b4597457ac412068081c32fbd0ce0a4e60d6592 Reviewed-on: https://chromium-review.googlesource.com/c/1482937Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634702}
-
Eric Lawrence authored
The Content Security Policy specification calls for comparing host values using an ASCII case-insensitive comparsion. Previously, Chrome only used an insensitive comparison when the source directive specified a wildcard. This CL changes to an insensitive comparison, matching Firefox and Edge. Bug: 882145 Change-Id: Ibd9ea7cb667e0cd1a9042158858a831e86bb0f42 Reviewed-on: https://chromium-review.googlesource.com/c/1471267Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634701}
-
Lan Wei authored
When we have keyboard events and mouse events send together, we should keep the keys that we are pressing now and set them to the mouse events that are in the same action sequence. Bug: chromedriver:1897 Change-Id: I700d7a87d3d0a1b45c1588318ab21314aa284417 Reviewed-on: https://chromium-review.googlesource.com/c/1482009Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#634700}
-
Takuto Ikuta authored
non variant enum is used for alias in variant header https://cs.chromium.org/chromium/src/out/Debug/gen/third_party/blink/public/mojom/cache_storage/cache_storage.mojom-blink-forward.h?g=0&l=48 This is found by wanderview@chromium.org in https://bugs.chromium.org/p/chromium/issues/detail?id=922875#c104 Bug: 922875 Change-Id: I94e0c0063d067d085bc964ee37996a9eb40ec2c8 Reviewed-on: https://chromium-review.googlesource.com/c/1481146 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#634699}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ia0fe5b5f50427e018fbc5d02e613b2ebd7c4b368 Reviewed-on: https://chromium-review.googlesource.com/c/1482564 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#634698}
-
Tatiana Buldina authored
Bug: chromedriver:2773 Change-Id: I663a3a4f280f31e5428c2056d7bdfc64b0c6a048 Reviewed-on: https://chromium-review.googlesource.com/c/1482110Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#634697}
-
Brian White authored
Bug: 882892 Change-Id: Id84d55aab6a947f3d36a785d01a705a15e2fed4a Reviewed-on: https://chromium-review.googlesource.com/c/1482554 Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634696}
-
Avi Drissman authored
BUG=none Change-Id: If8781725a059b835cd48796e4ccb93244244e59a Reviewed-on: https://chromium-review.googlesource.com/c/1482145 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#634695}
-
Clemens Arbesser authored
We are seeing frequent issues where phones are connecting to the wrong script server domain, leading to permission errors and abort. This log message should help us in debugging those issues. Bug: 806868 Change-Id: I49c469d33e924c0cb65db2398c686b6930313098 Reviewed-on: https://chromium-review.googlesource.com/c/1482961Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634694}
-
Tim Volodine authored
As per local run the WebViewDeviceSideStartupTest.testStrictModeNotViolatedOnStartup test is passing, see crbug.com/933815 for details. Verification: [4/7] com.android.cts.webkit.WebViewHostSideStartupTest#testStrictMode pass BUG=933815,841556,923938 Test: run cts -m CtsHostsideWebViewTests --test com.android.cts.webkit.WebViewHostSideStartupTest Change-Id: I5f34ce7bb867cb44a095f89c8513608bd077261e Reviewed-on: https://chromium-review.googlesource.com/c/1482457 Auto-Submit: Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#634693}
-
Nico Weber authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1481910 Without this, we still get In file included from ../../third_party/flatbuffers/src/tests/test.cpp:18: ../../third_party/flatbuffers/src/include/flatbuffers/idl.h:332:25: warning: extra ';' after member function definition [-Wextra-semi] EnumVal() : value(0){}; ^ Also add a TODO for undoing this again at some point. Bug: 934834,926235 Change-Id: I6ad57d7a9973dfdf6ab546daffc2f99bea284e96 Reviewed-on: https://chromium-review.googlesource.com/c/1482561Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634692}
-
Stephen McGruer authored
The spec (https://fetch.spec.whatwg.org/#data-urls) states that both base64 matching (step 11) and charset matching (step 13, then step 11.4 of https://mimesniff.spec.whatwg.org/#parse-a-mime-type) should be case insensitive. Previously Chrome did both case-sensitive, this CL corrects that. Bug: 807562 Change-Id: I336a04abdbe45e41207d131984a15a9f36c1b486 Reviewed-on: https://chromium-review.googlesource.com/c/1480569Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#634691}
-
Clark DuVall authored
This makes sure that errors generated in the network service when offline will trigger the auto-fetch feature. The current tests didn't catch the bug because they use URLLoaderInterceptor to fail the request, which prevents the request from reaching the network service. Bug: 929909 Change-Id: I26f532d3d44331e495cb0e1cba16276bcd0074d9 Reviewed-on: https://chromium-review.googlesource.com/c/1479584Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634690}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d74d6a30bce..a33c0190f771 Created with: gclient setdep -r src-internal@a33c0190f771 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifc355ebfc034bb7559a20bfda0104a241abac44a Reviewed-on: https://chromium-review.googlesource.com/c/1483153Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634689}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fda0617505c1..87bf834109fd git log fda0617505c1..87bf834109fd --date=short --no-merges --format='%ad %ae %s' 2019-02-22 yunchao.he@intel.com Add more validations for input state Created with: gclient setdep -r src/third_party/dawn@87bf834109fd The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iaefa5299be2c09da7c33c8de0ea5db066acd41a5 Reviewed-on: https://chromium-review.googlesource.com/c/1483152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634688}
-
Colin Blundell authored
Bug: 883330 Change-Id: I926f9d1e568d26d3c6d0355123fa3404f0e28a68 Reviewed-on: https://chromium-review.googlesource.com/c/1483013Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634687}
-
Andrew Grieve authored
Choosing Hindi because it is popular. This keeps normalization for .pak files, but drops it for .arsc (because its hard and not sure how necessary it is). Binary-Size: Change in the way we measure size. Bug: 873714 Change-Id: Ieb2c6b445307f47717495c97949e247727cc761e Reviewed-on: https://chromium-review.googlesource.com/c/1480692 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#634686}
-
Christos Froussios authored
[Sheriff] Disable some tests in ArcRobotAccountAuthServiceTest and ArcAuthServiceChildAccountTest on MSan Several tests in these suits have become flaky on non_single_process_mash_browser_tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests TBR=khmel@chromium.org Bug: 934796 Change-Id: I41f8af80d207d820ba234e0854bf53fce52d93ee Reviewed-on: https://chromium-review.googlesource.com/c/1483020Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634685}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/12a4eb908a7b..202f8887f83f git log 12a4eb908a7b..202f8887f83f --date=short --no-merges --format='%ad %ae %s' 2019-02-22 jclinton@chromium.org Refresh PreCQ default coverage per thread on c-i-d Created with: gclient setdep -r src/third_party/chromite@202f8887f83f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If1509cc6d0526b47f72b88331714f618e860e767 Reviewed-on: https://chromium-review.googlesource.com/c/1482939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634684}
-
Henrik Grunell authored
Error codes are apparently negative, whereas the histogram enum is defined with positive values. Bug: 915679 Change-Id: Ie14569dcb1283b5960f11c94321863537238dae7 Reviewed-on: https://chromium-review.googlesource.com/c/1473170Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634683}
-
Robert Ogden authored
This experiment doesn't actually seem very useful in Finch. It's better to reuse the DRP experiment which is accessible in chrome://flags. Bug: 934376 Change-Id: I27a5bdfa4f57fa761eaae62106113e7fc5529ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1481995Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634682}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ff0f3bb. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context." 1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If82d0dff652b9f016e283b6735009436a7473953 Reviewed-on: https://chromium-review.googlesource.com/c/1483150Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634681}
-
Stefan Zager authored
The IntersectionObserver algorithm must run using the throttling status that was in effect when the frame was generated. Since the IO steps have been moved to happen later (in RunPostLifecycleSteps), we must delay propagating throttling status. BUG=933694,928228 R=bokan@chromium.org Change-Id: Ic6a5fc37d3871eb30d8d1138d5c63fe8d61b53c8 Reviewed-on: https://chromium-review.googlesource.com/c/1481998Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#634680}
-
Robert Ogden authored
The new icon, same as the other preview icons, is simpler and smaller. This CL implements the UI mocks, specifically: * New speedometer icon * No enabled/disabled shading * 24dp instead of 32dp Bug: 909915 Change-Id: Icf4aed99869986b8e285a14e3179e7a054584667 Reviewed-on: https://chromium-review.googlesource.com/c/1481795Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634679}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0a94c0324d42..b4fdbb737c98 git log 0a94c0324d42..b4fdbb737c98 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 perezju@chromium.org [Telemetry] Clean up tracing_controller code Created with: gclient setdep -r src/third_party/catapult@b4fdbb737c98 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I03538f3a11396644509e2af97924070ecf05a82e Reviewed-on: https://chromium-review.googlesource.com/c/1482933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634678}
-
oysteine authored
This reverts commit 8b42fd6c. Reason for revert: Flakes https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGI0MmZkNmM5MmZiNjY2MWNmYzNlOTIzNWM4NmYwMjU2MjZkZjA4ZQw Original change's description: > Revert "Tracing: Move the tracing service in-process again to figure out test flakes" > > This reverts commit 6b27bca8. > > Reason for revert: Should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1474309/ > > Original change's description: > > Tracing: Move the tracing service in-process again to figure out test flakes > > > > Effectively temporarily reverting https://chromium-review.googlesource.com/c/chromium/src/+/1412016 > > > > Bug: 914579, 929142 > > Change-Id: I443e41fee17f6f09ca5cf5c243dbf330bafef6f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1456871 > > Commit-Queue: oysteine <oysteine@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Reviewed-by: Alexei Filippov <alph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#629738} > > TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 914579, 929142 > Change-Id: I9585a500916c0d90b16901572823a3c7c14bbbbb > Reviewed-on: https://chromium-review.googlesource.com/c/1477877 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634229} TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org Change-Id: I87f62967a2a0006b3b2f7a8c91bd44a26306643d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914579, 929142 Reviewed-on: https://chromium-review.googlesource.com/c/1483250Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634677}
-
Daniel Bratell authored
In an effort to reduce or even ban symbol shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/core/svg/svg_svg_element.cc:456:28: error: declaration shadows a local variable [-Werror,-Wshadow] TransformationMatrix transform; ^ third_party/blink/renderer/core/svg/svg_svg_element.cc:449:19: note: previous declaration is here AffineTransform transform; ^ Bug: 923510 Change-Id: I99c001d0eb513d73bfc33d540601479a6fd7280d Reviewed-on: https://chromium-review.googlesource.com/c/1482975 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#634676}
-