- 25 Jul, 2018 40 commits
-
-
Yannic Bonenberger authored
This CL delays the execution of update() for an increasing amount of time if the calling worker doesn't control a client. The delay is reset every time a controller is added to the worker, or an event is dispatched. postMessage from service workers, |install| and |activate| don't reset the delay. Bug: 805496 Change-Id: I9c25ba4315ce6a915634ecdf6405db8774c40929 Reviewed-on: https://chromium-review.googlesource.com/900763 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577875}
-
Elodie Banel authored
Darkening anything under a 4.5 contrast ratio. Bug: 859651 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b56ca36d89e6d62a9104aaddf14e12f7c4b8e0a Reviewed-on: https://chromium-review.googlesource.com/1150159Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#577874}
-
tzik authored
The first reference to ConnectivityCheckerImpl used to made by base::Bind implicitly in the constructor. The reference is moved to a task runner, and released when the resulting callback object is destroyed. However, the posted task may be immediately destroyed if the PostTask failed, or the posted task may run soon before the constructor finished. That implies, `new ConnectivityCheckerImpl` may return a stale pointer. This CL adds a static constructor to ConnectivityCheckerImpl, and moves the setup code that touches ref count out of the ctor. Bug: 866456 Change-Id: I5ea6f7cf80175abb63f6318e454075f2678ff45d Reviewed-on: https://chromium-review.googlesource.com/1149437Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577873}
-
Jan Krcal authored
No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletMetadataSyncableService. This CL fixes a few omissions from an analogous CL 1147223: - ios specific code for getting the controller delegate, - getting the delegate in ProfileSyncComponentsFactoryImpl. Bug: 853688 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibfef1455df0d1a94aa56d34a8c838a9ac43fa5f4 Reviewed-on: https://chromium-review.googlesource.com/1148575Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577872}
-
Javier Ernesto Flores Robles authored
Removes autofill dependency from passwords. This was not used and removing it prevent a dependency cycle in a following CL, where manual fill uses some parts from this component. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I576ac73b8d31dfb112d65af034caab807016e3a8 Reviewed-on: https://chromium-review.googlesource.com/1148880Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#577871}
-
Philip Jägenstedt authored
The existing kHTMLLinkElementDisabled counter is poisoned by the reflected IDL attribute, as pointed out by bz: https://github.com/whatwg/html/issues/3840#issuecomment-407275073 Change-Id: Ic4917290475f1ad6d9baba06620a485b78edac59 Reviewed-on: https://chromium-review.googlesource.com/1148203Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#577870}
-
Farah Charab authored
Sequence manager fuzzer test is causing an overflow when posting tasks with big delays and durations. This patch fixes that. Bug: 863345 Change-Id: Ie2709c4fe2eff9d668946de7fb33f10812eb0262 Reviewed-on: https://chromium-review.googlesource.com/1146928Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577869}
-
Aaron Leventhal authored
When focus moves from UI back into content, but the same content element is focused as was previously, an accessibility event must be fired for the caret location change, as it is no longer in the UI. This fix assists screen magnification software that must track the caret location. Bug: 864563 Change-Id: Ie9cc745288c124ddd73a54906c41dc16e07b9ff6 Reviewed-on: https://chromium-review.googlesource.com/1140199Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577868}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/715cc238d24b..b732b81e5520 git log 715cc238d24b..b732b81e5520 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 oprypin@webrtc.org Limit iOS bots to use machines that have 'xcode_version' dimension 2018-07-25 nisse@webrtc.org Add spatial index to EncodedImage, not yet used. 2018-07-25 nisse@webrtc.org Delete obsolete file call/video_config.h. 2018-07-25 titovartem@webrtc.org Move fft to proper third_party directory 2018-07-25 sakal@webrtc.org Move cropAndScaleI420 to JavaI420Buffer. 2018-07-25 buildbot@webrtc.org Roll chromium_revision e56ee1dd..deb63e97 (577600:577752) 2018-07-24 buildbot@webrtc.org Roll chromium_revision 83a1a9ed..e56ee1dd (577482:577600) Created with: gclient setdep -r src/third_party/webrtc@b732b81e5520 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:867367,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5416fe26428055da909e81c0865c1c2f6ffcefc8 Reviewed-on: https://chromium-review.googlesource.com/1150041Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577867}
-
Joshua Peraza authored
03abd1bb3497 mac: Tolerate the new flavor of weird cl_kernels modules on 10.14 98ebb0060b3e Add whitespace file e50ea6032180 Make BuildHandlerArgvStrings() return its result 3af81d7012e4 DEPS: Use gclient's native cipd instead of runhooks c11c8833f78f Add ProcessSnapshotMinidump::ProcessID() 2418cb8fbef8 Make upload report metrics optional 0909bee2e26c linux: Fix broken tests with address sanitizer 2f3a8b8f72dc Add CrashSkippedReason::kPrepareForUploadFailed Change-Id: Iefdaf2365615586fec6f4dcefc4f857e6e166074 Reviewed-on: https://chromium-review.googlesource.com/1148933Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#577866}
-
Reza.Zakerinasab authored
virtual/gpu/fast/canvas/canvas-blending-color-over-image.html timouts. NOTRY=true TBR=fserb@chromium.org BUG: 866850 Change-Id: I100893337485277667c10e788464bac66e2d8868 Reviewed-on: https://chromium-review.googlesource.com/1149992Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577865}
-
Mikel Astiz authored
Prior to this patch, base::PostTaskAndReplyWithResult() required ReplyArgType to expose a default constructor AND and an assigment operator, because the implementation constructed a temporary value first before it was overriden by the task's reply. There's however no fundamental reason to require any of this, since the only consumed value is the one returned by the task, which is guaranteed to run before the reply task, which is the only reader. We do however need some reserved memory to store the result of the task, so we leverage std::unique_ptr which satisfies both needs, and allows a straighforward migration. Note that base::Optional would have been more idiomatic, but it doesn't compile on iOS for certain callers, due to C++ unions being incompatible with iOS reference counting. Change-Id: I8b1946364fe7baa56451a351ee8dc94ca7231c76 Reviewed-on: https://chromium-review.googlesource.com/1146185Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577864}
-
Marcin Wiacek authored
Change-Id: Ia7ebdaec2b425da08aae6a7d2c36ade1e75c3808 Reviewed-on: https://chromium-review.googlesource.com/1146188 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577863}
-
Sylvain Defresne authored
The variable account_info is moved into std::map::emplace() and thus should not be accessed after that method is called as the state after a move is undefined. Current code appears to work because by defining an explicit copy constructor on AccountInfo, the implicit move constructor is not generated by the compiler. This use after move was found after adding an explicit move constructor to AccountInfo that caused a DCHECK to fail (as account_info member std::string are empty after being moved). Bug: none Change-Id: I096d89e40d09a934eb213173f4b491c151433d7b Reviewed-on: https://chromium-review.googlesource.com/1149867 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577862}
-
Georges Khalil authored
This reverts commit 448c3822. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove unused rlz_lib::SendFinancialPing variant > > Another driven-by CL, that removes an unused method. > > TBR=rogerta@chromium.org > > Change-Id: If7853aad29c007bd8aac5784b4994064d89d8e16 > Reviewed-on: https://chromium-review.googlesource.com/1149621 > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#577854} TBR=rogerta@chromium.org,tonikitoo@igalia.com Change-Id: I78570c02309379c4cfff49b3c40bc3378992acad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1150122Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#577861}
-
stkhapugin@chromium.org authored
Adds a flag to the animation orchestrator to ignore all calls when there is an animation in progress. Bug: 866858 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8990b0c60083723d9e6727538293480cc42b9a6 Reviewed-on: https://chromium-review.googlesource.com/1150143Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577860}
-
Dmitry Gozman authored
There is already a healthy animation -> transforms dependency. To remove the reverse one, we factor out Blend() functions to platform/geometry. Bug: none Change-Id: Iab048cbaec013c6af2701b7ba82a79a83f69341f Reviewed-on: https://chromium-review.googlesource.com/1149335Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577859}
-
Xida Chen authored
When there is a touch ack time out, all the gesture events will be flushed to the touch action filter. This case is already taken care of in the non-iframe case, and this CL handles the iframe case. When we see that a gesture event is flushed due to time out, we set the effective touch action to auto which will allow all the gesture event. A browser test is added to ensure the correctness. This CL is break into few patches: PS#22: The essential fix in line 1190 in the render_widget_host_input_event_router.cc is commented out. When running the newly added browser test, it will hit the DCHECK in touch_action_filter.cc at line 55. PS#23: Uncomment the essential fix in the render_widget_host_input_event_router.cc and remove the DCHECK in touch_action_filter.cc at line 55. Uncomment the temporary fix in touch_action_filter.cc for bug 851664. TBR=creis@chromium.org Bug: 851644 Change-Id: Ic381dd17fa531c1e9f7d649b48dc9f0f0d7d9c21 Reviewed-on: https://chromium-review.googlesource.com/1102729 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577858}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15020ea2cf44..c062b6be5a01 git log 15020ea2cf44..c062b6be5a01 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 benjaminwagner@google.com [infra] Adjust job priorities. (skia) Created with: gclient setdep -r src/third_party/skia@c062b6be5a01 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I5e4fdb0b651fb8136e88b6cd875c863451dfeaaf Reviewed-on: https://chromium-review.googlesource.com/1150040Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577857}
-
Maxim Kolosovskiy authored
This reverts commit 8faf0805. Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 Original change's description: > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > Reviewed-on: https://chromium-review.googlesource.com/1144230 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577727} TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150180Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#577856}
-
Sergio Villar Senin authored
The data structure used to store the grid items is currently a matrix, a Vector of Vectors. That's pretty convenient because it's quite easy to use, to implement and also provides O(1) access to grid cells and easy row/column traversals. However the problem is that we need to allocate the whole size of the grid even if we have just a small number of items on it (sparse matrix). We're replacing it by a new data structure based on doubly linked list. We'd be only creating the grid rows/columns/cells required to store the actual grid items inside the grid. The drawback of this new implementation is that O(1) access to individual cells is no longer possible. However that's not the most usual way to access data on the grid, most of the times we simply iterate through tracks. It's also a bit more complex to implement, but the good thing is that it does not require any change in the Grid class API, so the current layout code is unaffected by this change. Last but not least, although this change involves memory saves with sparse grids it does not completely fix the issue of dealing with large grids. That's because the track sizing algorithm is still using Vectors to store the list of tracks, so we have to do large allocations of those. This should be addressed in follow-up patches where content sized empty tracks would be ignored and not allocated by the algorithm. Bug: 688640 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d44914ed976358dcb5ef92cc3ff9df7a720102e Reviewed-on: https://chromium-review.googlesource.com/1104166 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577855}
-
Antonio Gomes authored
Another driven-by CL, that removes an unused method. TBR=rogerta@chromium.org Change-Id: If7853aad29c007bd8aac5784b4994064d89d8e16 Reviewed-on: https://chromium-review.googlesource.com/1149621Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#577854}
-
Antonio Gomes authored
rlz_lib::SetURLRequestContext does not need to be called explicitly since URLRequestRAII's ctor call it, and an instance of it is already being constructed. This is a driven-by preparation for crbug.com/844989. TBR=rogerta@chromium.org BUG=844989 Change-Id: Ib7e2e0809c4e1e65c386e02008fdce877b829b08 Reviewed-on: https://chromium-review.googlesource.com/1149620Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#577853}
-
Yutaka Hirano authored
Per RFC7230 empty header field is valid, but HttpResponseHeaders::GetNormalizedHeader sometimes ignores empty values. This CL fixes the issue. Bug: 866787, 736308 Change-Id: I227e18e413740e345d557e2c24a25e45e68b0ae8 Reviewed-on: https://chromium-review.googlesource.com/1148091Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577852}
-
Kent Tamura authored
*.h for RAILModeObserver implementors can avoid including large web_thread_scheduler.h by this CL. This CL reduces the pre-processed size of platform/heap/handle.h from 3.07MB to 1.59MB Bug: 242216 Change-Id: I95fef4e3e0dcafe5c4f5ee1f6ba77c4095a41ca1 Reviewed-on: https://chromium-review.googlesource.com/1149427Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#577851}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same scope and conflict. This commits moves such functions to shared util files, instead of having duplicates. Bug: 867350 Change-Id: I9986d6d653ef71acbf9583e18aa85a8e34f6e6f0 Reviewed-on: https://chromium-review.googlesource.com/1149781Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#577850}
-
Nico Weber authored
TBR=pmonette Bug: 867322 Change-Id: I11743753b408430741588f8a8ef4895cdc33bf45 Reviewed-on: https://chromium-review.googlesource.com/1150085Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577849}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef17db9d..58ea46ee Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8063f91121600d4e3a6c3dc659b180a3328f3e6e Reviewed-on: https://chromium-review.googlesource.com/1149983Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577848}
-
Oscar Johansson authored
When building using jumbo, files get merged together and macros may end up in the same scope and conflict. In media/mojo/services/test_mojo_media_client.cc a include resulted in including ui/gl macros, which conflicted with GLES2 macros. This commit solved the issue by removing the include. The include seems to be unnecessary and not used within the file. Bug: 867350 Change-Id: I54f01bcd5d18b4acbaa231a5cf78a8b5e8f719e7 Reviewed-on: https://chromium-review.googlesource.com/1149862Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#577847}
-
David Davidović authored
When testing the recording of Gaia consents by ConsentAuditor, instead of relying on the current wall-clock time to check if the consent time was recorded correctly, inject a fake clock set to a hardcoded date & time instead. Bug: 859878 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I86354fcfdd22e6e4147d1b056a0ffdef377a30e1 Reviewed-on: https://chromium-review.googlesource.com/1146803Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: David Davidović <davidovic@google.com> Cr-Commit-Position: refs/heads/master@{#577846}
-
Ian Vollick authored
This reverts commit 58e4a081. Reason for revert: appears to be still required. Original change's description: > [ar] Do not refer to ARCore shim in APK merger > > This hard-coding should no longer be required. > > Bug: 839191 > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843 > Reviewed-on: https://chromium-review.googlesource.com/1147706 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577662} TBR=vollick@chromium.org,torne@chromium.org Change-Id: Ia4e5bd3908b40e5cbcff058230cad20542c57a31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839191 Reviewed-on: https://chromium-review.googlesource.com/1150120Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577845}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I171b21d7de8868bc27767a8dcbb2b9a5bc954d39 Reviewed-on: https://chromium-review.googlesource.com/1149912Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577844}
-
Rayan Kanso authored
This is a reland of 9311d412 TBR=avi@chromium.org Original change's description: > Reland "[Background Fetch] Move all updatable UI options to their own proto." > > This is a reland of d3981964 > > TBR=avi@chromium.org > > Original change's description: > > [Background Fetch] Move all updatable UI options to their own proto. > > > > Bundle up the icon and the title since they will be accessed/modified > > together in the updateUI call. > > > > It also makes sense to move the icon from the metadata proto since that > > will speed up getting the registration info. > > > > TBR=avi@chromium.org > > > > Bug: 865063 > > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > > Reviewed-on: https://chromium-review.googlesource.com/1146650 > > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577272} > > Bug: 865063 > Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25 > Reviewed-on: https://chromium-review.googlesource.com/1148261 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577500} Bug: 865063 Change-Id: I766da48a901bc9da8e70acc02855b770f71e09e3 Reviewed-on: https://chromium-review.googlesource.com/1148361 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577843}
-
David 'Digit' Turner authored
This ensure that the GN android_app_bundle() template will also generate a wrapper script to manage bundles easily from the local machine during development and testing. For example, $OUT/bin/chrome_public_bundle is generated for the 'chrome_public_bundle' target. The script is very similar to the wrapper script for APKs, it also uses apk_operations.py, which has been lightly modified to support bundles. A few important notes about this CL: - The 'generate_apks' variable of android_app_bundle() is now a no-op, i.e. .apks archives are no longer generated by the build itself. Instead, the wrapper script will generate the .apks archive on demand. This simplifies the build, and allows to locally test any bundle if needed easily. The variable still exists to avoid breaking the clank/ build. - The generation of .apks archives from bundles is implemented by using 'bundletool build-apks', which is called from the new helper script app_bundle_utils.py This is performed lazily through a small closure function generated by the bundle wrapper script, which is passed to the new apk_operations.RunForBundle() function. This scheme is used to considerably reduce the amount of modifications required in apk_operations.py, since this avoids the need to pass 6 more command-line flags down to the internal _Command class. - The new 'build-bundle-apks' command can be used to build said .apks archive on demand, and optionally copy it to a different location. Generation is also triggered in case of 'install'. MD5 checks are used to ensure the .apks archive is only rebuild if strictly necessary, since this is a slow process (e.g. around 40s for chrome_public_bundle on my machine). - Installation currently uses 'bundletool install-apks' directly and avoids using devil, since the latter doesn't have a good way to support bundle installation. Proper support for app bundles in devil will be added in a future CL, after which apk_operations.py may be updated to use it. What was tested and works: 'devices', 'install', 'uninstall', 'launch' (without a URL), 'stop', 'clear-data', 'logcat', 'ps', 'disk-usage', 'run' Tested but does not work: 'launch <URL>' (but see TODO inside apk_operations.py) Not tested yet: 'argv', 'gdb', 'mem-usage', 'shell', 'compile-dex', 'profile' BUG=862525 R=agrieve@chromium.org, benmason@chromium.org, jbudorick@chromium.org Change-Id: Ic1074a723b0a705f1f53ff484a19a1ca1041e7d7 Reviewed-on: https://chromium-review.googlesource.com/1146811 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577842}
-
Vaclav Brozek authored
The old FormData -> PasswordForm parser reported to the PasswordManager.UsernameDetectionMethod histogram, which method was used to detect the username in the form. This CL teaches the new parser to do the same. The supporting enum is copied from the old one and modernised. There is not point in attempting to share that code given that the old parser is going away soon. Bug: 845426 Change-Id: I7737cb8dc598c11b42c0e7e0f929afed5e830d7c Reviewed-on: https://chromium-review.googlesource.com/1149866Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577841}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/17fb50f21647..09f0990a2db0 git log 17fb50f21647..09f0990a2db0 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 dhanyaganesh@chromium.org cbuildbot/stages: Serialize DebugSymbols to run after UnitTest 2018-07-25 lannm@chromium.org Annotate failed CommitQueueHandleChanges with CL counts Created with: gclient setdep -r src/third_party/chromite@09f0990a2db0 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I45a4215fae8592006e2f580e2fc363e09e5e1ed7 Reviewed-on: https://chromium-review.googlesource.com/1149544Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577840}
-
vitaliii authored
USER_EVENTS is a special datatype, because it is commit-only. Therefore, it is handled in a special way in a processor. As a result, when the datatype is disabled (e.g. in Sync settings), it does not stop recording. This was not a problem before, because there was no user visible way to disable user events recording (except through history, but that works well), however after unified consent there will be a separate toggle in settings. This CL adds a temporary workaround (explicit check in the user event service for the datatype) for M69 and only when USER_CONSENTS type is enabled. Once we improve handling of commit only types (https://crbug.com/830535), this workaround won't be needed anymore. Bug: 860616 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idac71d1d8d8d5a504940ffb1e09d6a7173989c57 Reviewed-on: https://chromium-review.googlesource.com/1143475 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#577839}
-
Vaclav Brozek authored
As discussed in person, vabr@ accidentally failed to consult other owners when adding ioanap@ in password manager OWNERS, and introduced an inconsistency compared to how other team members are being added. This CL therefore removes ioanap@ from that OWNERS file for the time being. Bug: None Change-Id: I532f3abc060908241432c9ee8c493149207e173d Reviewed-on: https://chromium-review.googlesource.com/1149880Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577838}
-
Gemene Narcis authored
These tests are supposed to validate the behavior that bubble has when a user has blacklisted a site from a type of form and then login successfully from another type of form from the site. For tests were used HTML and HTTP auth forms. The bubble will not be shown if in the PasswordStore exists an blacklisted entry with the same signon_realm as submitted form. Even if the submited form has different Password::Scheme, if the signon_realm is the same as blacklisted one, then the bubble will not be shown. Bug: 456158, 862930 Change-Id: I7b07bb6164be315f43fe1609f4ac167233b76869 Reviewed-on: https://chromium-review.googlesource.com/1148560 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577837}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90d0244a..ef17db9d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If18a9c834d7739d625bd31754ae2968ed6f64d41 Reviewed-on: https://chromium-review.googlesource.com/1149710Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577836}
-