- 09 Jan, 2020 40 commits
-
-
Andrew Grieve authored
finalize_apk.py changed in 7d191755 Bug: 1040240 Change-Id: I70b73881098aa7b1b5f0375052d62cb7b0d61624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992249 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729822}
-
Fabrice de Gans-Riberi authored
Bug: 1040247 Change-Id: I22671b5e97b5dba49f467cf734b41b773e2a2872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992982Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081c5b597968..b92d20526b83 git log 081c5b597968..b92d20526b83 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@chromium.org vpython3: Add Python3 bin dir to PATH on Windows Created with: gclient setdep -r src/third_party/depot_tools@b92d20526b83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003139 Tbr: agable@chromium.org Change-Id: I55c94cc4de00434c66e7f661d3e98090e6dfb542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729820}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c18d96f563fb..caa32a553682 git log c18d96f563fb..caa32a553682 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 hjd@google.com Merge changes Id83e6be8,I120166cc Created with: gclient setdep -r src/third_party/perfetto@caa32a553682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic52393f5bf26ff376ec3759f5950e51c217ff83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993484Reviewed-by:
-
Piotr Bialecki authored
This change will make Chrome for Android stop using DFM to ship the ARCore SDK. This is done to enable us to provide AR experiences for apps using WebView. The changes are introduced in a way to enable us to switch back to using AR DFM if need be. Changes summary: - chrome_java target (defined in chrome/android/BUILD.gn) now also compiles ArCoreShimImpl.java (see java_sources.gni) - this means that java parts from ARCore SDK have to be added to its deps - libarcore_sdk_c.so needs to be listed in loadable modules - this is done in monochrome_public_common_apk_or_module_tmpl (only if target is a base module when ARCore is enabled) - AndroidManifest.xml no longer needs to contain the min_apk_version and InstallActivity entries explicitly - they will be brought in auto-magically by the build system and were needed only because manifest merging did not work for DFMs - ArCoreInstallUtils (java) should never report that we can request installation of AR DFM - ArCoreConsentPrompt (native) should never think it needs to request installation of AR DFM - Added a DCHECK and graceful handling of null jstring for java_path (path to ARCore SDK .so) - it can be null if loadable_modules do not contain correct entry - with the DCHECK, debug builds will still crash but the release builds should just report that the WebXR specified session configuration (session mode == "immersive-ar") is not supported Binary-Size: Tracked in crbug/1040289 Bug: 1031623, 1040289 Change-Id: Ia2f305d1685f1c7207cc187d253f59a6331c36fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988834 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#729818}
-
Connie Wan authored
Previously this was using TabGroupModel::ListTabGroups(), which pulls from a map: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_group_model.cc?l=50&rcl=1158206625559148ac779e86e5d53da50ebf39b4 The consistently ordered experience is better for users, even if it's slightly more expensive. Tested as part of crrev.com/c/1990423, which adds color bubbles that make it more obvious when groups are out of order with the tab strip. Change-Id: Ie6081130f310b1e2501b1fbd50c7848cc5d815ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992344Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#729817}
-
Sasha McIntosh authored
Enable WebP YUV decoding by default and remove the field trial testing config. Bug: 900264 Bug: 966008 Change-Id: Idfaf993fda19bf22e71986ba8410ffd84e254ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986029Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#729816}
-
Stepan Khapugin authored
This method with a stale todo will probably never be implemented. Remove it to not confuse new people :) Bug: none Change-Id: I8f91a021158d7c275e8230a65746e692d780a1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993461 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729815}
-
Wez authored
Debugging issues in the GPU process with zxdb is easier without the watchdog running. Change-Id: I9ff0e7fa8f00360ddf2b88475c17051207e6e5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992539 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729814}
-
Nate Fischer authored
This swaps out the app package name for the application "label" (the user-friendly name for the app) and the version number (to disambiguate between similarly-named apps). This is for consistency with the system's webview chooser dialog (which the user is likely to go into next by clicking the dialog button). Fixed: 1040336 Test: manual - click icon when this is not the current provider Change-Id: Iacb73cd2f0ca41844f2ff668230b3b95bb4ed472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991745Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729813}
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I92c343d9ca09cc429fb4b6fa1723534c43beb317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992691Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729812}
-
Andy Paicu authored
There is no notification channel when the notifiction permission for the origin is merely embargoed, so it is not possible to intent to notification channel settings. This CL updates the SingleWebsitePreferences page on Android, so that when the automatically blocked setting is changed for the first time, a synthetic CONTENT_SETTING_BLOCKED is directly written just-in-time. This will trigger lifting embargo, and create an initially disabled notification channel, and finally we intent into channel settings. Bug: 996201 Change-Id: Ice838b1ca971c9d8117f1c56ecc107bf41417550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970473Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729811}
-
Joshua Peraza authored
This is a reland of 9747ecdd Original change's description: > linux: Enable Crashpad for content shell > > Bug: 942279 > Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699880} Bug: 942279 Change-Id: I7ced7adacbbe585f5ea47d00163b69953912b99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847882Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#729810}
-
Ahmed Fakhry authored
This is only supported on ChromeOS, so make it conditional and follow the example of Browser::ShouldShowStaleContentOnEviction(): https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?dr=CSs&q=Browser::ShouldShowStaleContentOnEviction&g=0&l=1453 BUG=1036760 Change-Id: Idcf003483600046a4e64ebe0b681bbdb30b8449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992515Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#729809}
-
Mike Wasserman authored
Bug: None Test: Manual Change-Id: I08f2dd1b7925ba2ab5136470a029e6ac462d0698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992623 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#729808}
-
Mike West authored
Based on the discussion in [1], we should change the spec to support nameless cookies parsed from headers like `Set-Cookie: foo`. This patch updates the WPT expectations accordingly. [1]: https://github.com/httpwg/http-extensions/issues/159 Bug: 1037996 Change-Id: Iefabea524377857d524c74457153347a107401ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982551Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#729807}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c40e03a4215..bf8bd8052673 git log 1c40e03a4215..bf8bd8052673 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e70b009b0f1e..fb2e819819ef (14 commits) Created with: gclient setdep -r src/third_party/angle@bf8bd8052673 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I69cbbb812473412403ef2d9bdc13db4e2f658023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992256Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eca1091a52a8..a88cab1ad9f2 git log eca1091a52a8..a88cab1ad9f2 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 brianosman@google.com Add CachingHint to makeRasterImage, default to kDisallow 2020-01-09 mtklein@google.com add back src-in-gamut tracking Created with: gclient setdep -r src/third_party/skia@a88cab1ad9f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I61d9f24777b0756af928937898931f25f0d3903e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993425Reviewed-by:
-
Stepan Khapugin authored
Moves TabSwitching protocol to SceneController. Bug: None Change-Id: I43af00d43fdca5fb3fdb66381e447ec24e9a7d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983220 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#729804}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/835559f20f96..fe5c3f7d1da4 git log 835559f20f96..fe5c3f7d1da4 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tvanderlippe@chromium.org Migrate formatter/ to ESM internally 2020-01-09 aerotwist@chromium.org Migrates browser_debugger to ESM internally 2020-01-09 tvanderlippe@chromium.org Migrate emulation/ to ESM internally 2020-01-09 szuend@chromium.org Cleanup early returns in SourcesPanel.js 2020-01-09 almuthanna@chromium.org Add test files for classes depending on UI Created with: gclient setdep -r src/third_party/devtools-frontend/src@fe5c3f7d1da4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8cc1105308b223c4e9c1e85b7c5e329ed6040db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993434Reviewed-by:
-
Joe Mason authored
R=fdoray Bug: 947576 Change-Id: I1f901367e6fcc5243f34f50e5704b68727a40731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990135 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#729802}
-
Tommy Li authored
This CL made it much more likely that OmniboxPopupModel::selected_line() could return kNoMatch (-1): https://chromium-review.googlesource.com/c/chromium/src/+/1906882 But when we put kNoMatch into a size_t index, we get the maximum value size_t, i.e. 0xffffffff. That just overruns the results array and reads garbage memory. Instead we should ignore the popup when we are selecting a match that's not from the popup (no default match case). This CL does that, and adds a DCHECK to OmniboxLog to prevent this from happening again. Bug: 1034946 Change-Id: I989c139c9a9b9525555424987124627130f0a5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989517Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#729801}
-
Vasiliy Telezhnikov authored
This CL removes ClipBounds DCHECK in SoftwareRenderer for Android. It is not compatible with WebView and SoftwareRenderer isn't used on Android elsewhere. Change-Id: I7a90a1e3f579fa5274737b6881d118d633398cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992580Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#729800}
-
Mikel Astiz authored
In subtle cases like state CONNECTING being entered via MCSClient::ResetStateAndBuildLoginRequest(), it is possible that the error callback gets triggered twice. With OnceCallback() being adopted recently in https://chromium-review.googlesource.com/c/chromium/src/+/1939891, this leads to a crash, and surfaced by flakiness in sync integration tests. Bug: 1039598 Change-Id: Iad23dfe81e07f11939a6640fb792a7ae1386c397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991434 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#729799}
-
chrome://omniboxmanukh authored
Previously, the download results and console printed error messages were formatted (indentation and new lines). However, the copy results and download 'Additional Info's were not formatted. This CL fixes those 2 cases as well. Change-Id: Ia14634f8d072293aa88ac226f91fcc62a47cea60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992356Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#729798}
-
Eric Seckler authored
Regenerated privacy_filtered_fields-inl.h. Change-Id: I392cd4cf1be3920da32c7deab7322db3d22a2692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992066Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#729797}
-
sandromaggi authored
The removed tests should no longer fail as the offending changes have been reverted in crrev/c/1978659. Bug: 1035956 Change-Id: Ib41f74dccec45788f1bcba88ab54aa15e599b9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991487 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#729796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I25aa1a907ea6ed28dcf8eec2c6bd2a528263a7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992259Reviewed-by:
-
Rahul Arakeri authored
This CL deletes the workaround that exists in scrollbar_controller which was added for preventing scroll chaining. This is no longer needed since crbug.com/996537 has been fixed and ScrollEndImpl doesn't get called before ScrollAnimatedBegin anymore. The scrolling_node in LayerTreeHostImpl::ScrollBegin can be determined by the information contained in the synthetic WebGestureEvent's ScrollState. Bug: 1039976 Change-Id: I93b818cd57a25eb3355ce07c2d1c39a51cec3d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991944Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729794}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3609d224afd..1dbb52862979 git log c3609d224afd..1dbb52862979 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@1dbb52862979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1037829 Tbr: cwallez@google.com Change-Id: Ia9f17a9ecd9a18064e619de6d54beaf643fb4a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992257Reviewed-by:
-
Avery Musbach authored
You shall be able to start dragging from overview, drag to another display, and snap. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DragFromOneDisplayToAnotherAndSnap/0 Bug: 961170 Change-Id: Ib237fa253603433d307f232d0fc8a04affebeb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986956 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#729792}
-
Kurt Horimoto authored
This allows for a more flexible API that doesn't need additional checks to verify that conditions are met before creating supports with their aggregate constructors. Bug: none Change-Id: I8e7fdf65780c698339554e5e2c7f3b0799a3a5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992004 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729791}
-
Gauthier Ambard authored
This wasn't used anymore. Bug: 894800 Change-Id: I4b53741346a4435fd5fb2889dc432a6713c6c2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991568 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6f9b1b9..549216f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I602257a3f2a298c5dfe18a2bb6e141747d811c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992538Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729789}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e2896bef114..c18d96f563fb git log 0e2896bef114..c18d96f563fb --date=short --first-parent --format='%ad %ae %s' 2020-01-09 lalitm@google.com Merge "trace_processor: migrate args to macro tables" Created with: gclient setdep -r src/third_party/perfetto@c18d96f563fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9ef20710024279e0fbc6144753fc7e81fb4c5047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992254Reviewed-by:
-
Miguel Casas authored
This CL teaches PlatformVideoFramePoolTest to use the parameterization defined inside (ToT did not use it). It also removes the surprising (unnecessary?) explicit unique_ptr deleter, using PlatformVideoFramePool directly, and also takes the chance to remove the private ctor in that class, since anyway the Test is a friend and can access the internal members (albeit we lose a const). Test: media_unittests on a target_os="chromeos" build Bug: 1040291 Change-Id: I660e579b34a0ebea213f3c4a9b66b64a17043f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992762 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#729787}
-
Dominique Fauteux-Chapleau authored
Update the dialog when the deep scanning verdict is retrieved. The success dialog will not appear if the scan is faster than kInitialUIDelay, but the failure one will. The sizes, alignments, colors, padding, etc.. in this CL are not definitive and are most likely to change, this CL is to setup the class so updating all of these later is simple. Bug: 999145 Change-Id: Ia7160b9bb9cccab1d8f98d9e8fc26e05243f26db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979057 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#729786}
-
Greg Thompson authored
Tests may leak files/directories in temp due to ScopedTempDir lifetime issues (see linked bug) or as a result of crashes. This CL augments the TestLauncher to handle such leaks a bit better. When launching a child proc on Windows, the TestLauncher now directs that child to its own dedicated temporary directory. Upon child exit, the launcher checks for leaked files/directories in that dir and deletes the dir. On test iteration completion, the launcher will emit a list of the tests that produced leaks when run with --test-launcher-print-temp-leaks that looks a lot like this: ERROR: 2 files and/or directories were left behind in the temporary directory by one or more of these tests: PaymentManagerTest.ClearPaymentInstruments:PermissionControllerImplTest.ResettingOverridesForwardsReset:PermissionControllerImplTest.SettingOverridesForwardsUpdates:PermissionControllerImplTest.RequestPermissionsDelegatesIffMissingOverrides:PermissionControllerImplTest.GetPermissionStatusDelegatesIffNoOverrides:PermissionControllerImplTest.GetPermissionStatusForFrameDelegatesIffNoOverrides:PermissionControllerImplTest.NotifyChangedSubscriptionsCallsOnChangeOnly:PermissionControllerImplTest.PermissionsCannotBeOverriddenIfNotOverridable:PermissionControllerImplTest.GrantPermissionsReturnsStatusesBeingSetIfOverridable:PictureInPictureServiceImplTest.EnterPictureInPicture Curious developers can binary search in that short list of tests to find the one(s) that are leaking and clean them up. This is a reland of https://crrev.com/728475 with macOS support disabled and a new unit test. BUG=546640 Change-Id: I93bef02a6282476b968ebd3938bc4d07357b88d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991565 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#729785}
-
Sergio Villar Senin authored
A double is currently used to represent the time the animation is going to be paused. A base::TimeDelta is much more appropiate as it represents precisely durations. The overall amount of double<->TimeDelta conversions is the same (as we need to add one at the Blink level) but the API is all converted all the way down from Blink to the compositor. Bug: 737867 Change-Id: I3df4bd04ab7117bd2db5901cbd04e9dd71ed80d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980616Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#729784}
-
Olivier Li authored
Bug: 1014464 Change-Id: I6738bba3443d4dfae9950201a2acd61f9722aae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991938 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
-
