- 17 Dec, 2020 40 commits
-
-
Prabir Pradhan authored
This reverts commit 43be36f0. Reason for revert: Multiple CTS failures Bug: b:175379280 Bug: b:175514308 Bug: b:175829322 Original change's description: > exo: Allow Pointer Capture when window is active > > Pointer Capture was being rejected by chrome when an app came into > focus using keyboard shortcuts (Alt-Tab), but was working as intended > when an app came into focus using the mouse or touchscreen. It was being > rejected because the capture_surface was the sub-surface of the current > focused surface. > > Since the client is responsible for providing the capture surface > through the wayland pointer constraints protocol, it is possible > for the client to request capture on a sub-surface of the current > active surface. Requesting capture on a sub-surface is a valid request > for capture. Rather than ensuring that the capture surface is focused > (used for directing key events), we verify that the active window > contains the window of the capture surface in its hierarchy before we > allow the pointer to be constrained to the surface. > > This also allows the client to change the cursor while the client has > capture, even when the mouse cursor is not currently over a client > window. > > BUG=b:153973515 > TEST=manual: request pointer capture, leave app, return to app using > Alt+Tab, verify app has pointer capture. > TEST=exo_unittests > > Change-Id: I56e76469f35ea43100748ebe27966464e32805fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559255 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832613} TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:153973515 Change-Id: I582f775f37c34149fb7f0c2a6b9162b5e72cbf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596065 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#837908}
-
Xing Liu authored
Add two metrics for read later feature. 1. Total number of reading list items. 2. Three action button entry point action. Bug: 1140277 Change-Id: If704fb6a5258d4e0aaa58973ae0bb1a5fb3c21dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592392 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#837907}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsSwitchAccessActionAssignmentDialog* Change-Id: Id346d80dba4eefd7cda822db567bbbc45304a43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587561 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837906}
-
Oriol Brufau authored
Bug 1155342 was already fixed by r837219, but I didn't add a unit test for SelectionModifier since the testcase that I had wasn't trivial. However, turns out that bug 1155309 is a duplicate, but with a simpler testcase which does seem a good fit for a unit test. This new unit test would have crashed before r837219. Bug: 1155342, 1155309 Change-Id: I52def532cf8eda92d6009e473d3a28ac4960cc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596297Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#837905}
-
Eric Willigers authored
If an Intent is received that has a blank title, we don't include the title in the generated GET or POST request. Current Intent instances are created with either non-empty strings or with nullopt. This CL protects against any future Intent sources that might create share_title with empty string. Bug: 1125880 Change-Id: I5b5a854eb8b849d1d07877f46e3855cf29c6109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592544 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#837904}
-
Louise Brett authored
This hooks up the existing web badging API to the UI so that a PWA will show an attention badge if the PWA has called the web badging API. - When the flag "enable-desktop-pwas-attention-badging-cros" is set to "notifications-only", a badge will only show when a notification is showing. - When the flag is set to "api-only" a badge will only show if the web badging api has a badge set. - When the flag is set to "api-and-notifications" a badge will show either if a notification is showing or if the web badging api has a badge set. This is the default behaviour. Bug: 1157273 Change-Id: Ic0275e5e2d023f13554ed6ca001665b69f49f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589055 Commit-Queue: Louise Brett <loubrett@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#837903}
-
Brian Sheedy authored
Removes expectations for the hardware_accelerated_feature suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 254724, 1155766 Change-Id: I99f8dff856308e072114e3d4d416f99faa48dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592327Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837902}
-
Bruce Dawson authored
This change (based on crrev.com/c/2576881) is a temporary workaround for a bug in the x86 emulator on ARM64 Windows. The bug is that movvdup reads sixteen bytes instead of eight and this makes Chrome unusably crashy. The fix is to add eight bytes to allocations so that the over-reads aren't fatal. This change will make x86 Chrome on ARM64 Windows use slightly more memory. On normal x86 builds the only difference should be an extra add in the allocation path. The emulator bug has been reported and fixed. This change will be reverted some time after the fix has shipped. See the bug for details. This has been manually tested on ARM64 hardware to confirm that the crash is avoided with this change. This has been more extensively tested with a modified version of this change (crrev.com/c/2590684) which always adds the eight bytes. This change will be reverted when the emulator fix has shipped. Bug: 1151455 Change-Id: I2fcd9fb5169239b9957e9e8838f441f5780e2610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577893 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837901}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic17f054e6ff0cd22b66b80cbdd370dd1d9ac47fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595297 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837900}
-
Jeroen Dhollander authored
This will allow us to easier move this class to the Libassistant mojm service. All dependencies have been moved to the new class |AudioInputHost|. This class currently talks directly to |AudioInputImpl|, but later it will instead talk to the mojom APIs. Some notes: - |AudioInputImpl| still depends on |AssistantClient::Get()->RequestAudioStreamFactory()|, because the Libassistant mojom service will also use an audio stream factory to open/close its audio input. In a follow up CL I will introduce a delegate to sever this dependency. - There is one behavior change: |power_manager_client_->NotifyWakeNotification()| was previously only called when DSP was enabled, and it is now always called (when Libassistant starts a conversation). I can think of no reason why this would be an issue. This is a reland of crrev.com/c/2582537, with the added fix that we no longer crash when we get a request to set an empty DSP hotword locale. Bug: b/171748795 Test: chromeos_unittests, deployed on real hardware with and without DSP. Change-Id: I9ace389ad27e44cafe422d668946bf29ac7f56a9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596238 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837899}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/91beff4e632a..4a33b7b19905 2020-12-17 jophba@chromium.org Bikeshed: fix spelling mistakes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic90c565a3bfba6c476ee4a47a0e49a3a1a814683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837898}
-
Xiqi Ruan authored
Records the device and account statistics metrics for Chrome OS family user. Those metric will be reported either on the user session started or on the first session each day. Bug: 1133856 Change-Id: Iabe9cbaf36de6036817d7744ac73246b091089a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466394 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837897}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2af92c98. With Chromium commits locally applied on WPT: ef476588 "Canvas-WCG: Update names to reflect the specification" e1e1bb4a "Ignore layout shift under opacity:0" 845edb23 "Avoid double relpos offset in NGSimplifiedOOFLayoutAlgorithm." 370de89c "[AspectRatio] Correctly detect indefinite percentages" 58aad48a "Handle inner floated multicol at outer boundary." 9d15ff73 "Handle inner fieldset / legend multicol at outer boundary." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mustaq@chromium.org: external/wpt/html/interaction/focus NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I603ba35d1b49b0f9f78bdda71e3ec7f713011c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595732Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837896}
-
Jarryd authored
* Add a parameterized test that takes a collection of strings, each of which is a comma-separated list of testing actions. * Add a ParseParams() method that will split each input string into a collection of testing action strings * Add an ExecuteAction method that will call the appropriate testing action implementation for each testing action * Add ActionNotImplemented method to handle unrecognized or not yet implemented testing action strings * Implement new testing actions: - uninstall_from_menu - assert_installable - assert_install_icon_shown - assert_install_icon_not_shown - assert_launch_icon_shown - assert_launch_icon_not_shown Design Doc: https://docs.google.com/document/d/1Gd14fjwA4VKoRzL2TAvi9paXwyh36ehlS4gbpUmUeeI/edit?pli=1# Bug: 1145240,1156354,1156358,1156339,1156341,1156359 Change-Id: Ic2190e59ddc1d9a4ae4360dfc7ce12e5666af39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586187 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#837895}
-
Ben Goldberger authored
TBR=Time sensitive, low risk Bug: 1099982 Change-Id: Ib09444062d5cc24ec7d690950099b70fbc2bb166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595482 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#837894}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I38a3ea7dbf0bdec4ddbdc778fc6f7c274f80e24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596379Reviewed-by:
-
Brian Sheedy authored
Removes expectations for the gpu_process suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 257109, 700522, 1028974, 1102542, 1155766 Change-Id: Iae762a64c60555b571827fcb6ec39c41d2e905d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591972Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608141458-a5500324610cca8317ad489f360bbb6633944839.profdata to chrome-mac-master-1608163120-6c9e93d828b8e2586093ed8c8e6e7f26f6a53c36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2c5b06b286feb317e2621986c90c193a117efd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596740Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Add basic start/stop and send/receive tests for the Cast Streaming component * Merge 2 core targets in cast_streaming into one. Bug: 1110490 Change-Id: Ia949ca73c69badeaaad60adb024b3f4bcb44f40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553143Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#837890}
-
Hirokazu Honda authored
video_encode_accelerator_tests crashes if the test is built with --dcheck_always_on=true. It is because the sequence that destroys a decoder used in BitstreamValidator is different from one that initializes the decoder. This fixes the issue by destroying the decoder in the same sequence as of initialization. Bug: b:174318867 Test: video_encode_accelerator_tests on volteer Change-Id: I76a224705534945ee7f4c4ab8e1c1dd73fdcacea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#837889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0da7da798b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icb1c9f0301043bd8c455ef6bebf1d59fc262f8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596057Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I3cfc0267c733659383f007e19cc98ec174ed1026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592220Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837887}
-
Ahmed Mehfooz authored
This CL adds a feature flag for stylus battery status in the stylus tools menu. Also adds skeleton code to set up the UI to be hooked up with backend CL in a subsequent CL. Bug: 1158537 Change-Id: I873c1dac4827a64e0f66a18aa63a4df1e0c44036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590366 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837886}
-
hscham authored
For Python3 compatibility. hash function added in crrev.com/c/2277687 for Field requires hash function for EnumValue (self.default). BUG=941669 Change-Id: I787bca64a05d379088a6e2846f03b76e258e0701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584728Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
-
Roman Arora authored
Fixed: 1147535 Change-Id: If8ad3df877d1baa5ce32c7199b50ff4d886555dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585994 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#837884}
-
Yu Liu authored
Bug: b/175707921 Change-Id: I9f54d970e45ffb6a8cee83f3b70aa5f6f75f8bbf Corresponding BlueZ metrics implementation can be found at: https://chromium-review.googlesource.com/c/chromiumos/third_party/bluez/+/2595924 Change-Id: I9f54d970e45ffb6a8cee83f3b70aa5f6f75f8bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595525Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yu Liu <yudiliu@google.com> Cr-Commit-Position: refs/heads/master@{#837883}
-
Josiah K authored
(http://go/magnifier-panning-improvements-design-doc) AX-Relnotes: n/a Bug: 1144037 Change-Id: I82c2b1c330826a4e48ed47482f98f1a0c0168894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503568 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837882}
-
Matt Mueller authored
This should reduce the impact of cache initialization on the first page load. Bug: 1159560 Change-Id: Ib21e9c9736e3dd1d81b194e59fcd1fb26fba6e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595971Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837881}
-
Nancy Wang authored
This CL implements below functions: 1. Save the app launch information to local variable |file_path_to_restore_data_|. 2. Add flags |ShouldUpdate| per profile path to record whether there are updates to be saved to the full restore file. 3. Add a timer to delay and cache the restore data writing. 4. Call FullRestoreFileHandler to write the restore data from |file_path_to_restore_data_| to the full restore file on a background task. There will be a separate CL to add tests. Bug: 1146900 Change-Id: Icf7a674d0d474005eb8dc33b39b5660ab6436153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589613 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837880}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608097529-a53990c96ba4fe0e9c85a726eccdb7c47db8df34.profdata to chrome-win32-master-1608141458-c308516ff1ef658b0966cc17b391babeaf39cbb5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I48f115b6a196344c2390b67eee62d8e426c6c44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595705Reviewed-by:
-
Xiaocheng Hu authored
This patch switches counter() and counters() to use @counter-style rules (including predefined ones) instead of relying on the deprecated EListStyleType enum. Note: The purpose of this patch is to ensure that there's no breakage after fully switching counter() and counters() to the new implementation for the predefined counter styles. Follow up patches will verify the new implementation against custom counter styles and apply fixes, if needed. Bug: 687225 Change-Id: I981f55dfffff97feac5edfd42b1569fa40de47e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591873Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837878}
-
Chris Thompson authored
Change-Id: I2e9656516a03bbb43c31175dd178cc223a171ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596776Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#837877}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608141458-ce789808658cedde2d9d2bce7c84c9a07b9d1c0e.profdata to chrome-linux-master-1608163120-124e90d18fac2bedecb2b27b978f1959d49c27fb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38f0b034d1ee9e02ac0e49b45bcedf8e13ef2a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596738Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a5112747ff0..508bcddc99e4 2020-12-16 yiorsi@gmail.com Fix: right-click in CSS var() cannot open the context menu 2020-12-16 andoli@chromium.org [module.json extensions] Migrate profiler views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707,chromium:1134103,chromium:1152391 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I42afedfb2df40d05c9320ed8deec16de0206b974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596003Reviewed-by:
-
Gabriel Charette authored
Sheriff notes: This is expected to artificially reduce IOJank* metrics. Modal dialogs launched via GetAppOutputInternal in launch_posix.cc are guaranteed to block and thus should use WILL_BLOCK semantics (as opposed to MAY_BLOCK like it did). However, Process::WaitForExit can't use WILL_BLOCK semantics because of an existing workaround for TestLauncher to not use ScopedBlockingCallWithBaseSyncPrimitives when waiting on processes or TestLauncher ends up creating or TestLauncher ends up flooding the pool to 256 workers regardless of --test-launcher-jobs (it posts each test as a task right off the bat and expects the pool to cap the parallelism...). The best solution to get proper tracing and thread restrictions right is thus to add custom trace events and keep assertions that waiting is allowed when launching the process. Each platform was doing something slightly different here, this CL brings all platforms inline with annotations that are visible in tracing but ignored by IOJank metrics. Example broken trace showing up in IOJank slow reports on Linux: https://goto.google.com/btbzu (SS: https://snipboard.io/7sDO1r.jpg) R=fdoray@chromium.org Bug: 1064645, 1144161, 899897 Change-Id: Id087f91df8c2201ca10db5438456c638f9b791e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233299 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837874}
-
Daniel Murphy authored
This cleanup migration should be complete now. See this bug [1], which gives more context on the cleanup itself. Removing, which is basically reverting commit d3d65a10 [1], but leaves the pref value for cleanup as per guidelines. This is also being done to replace this functionality with WebAppMover [2] (google only). [1] https://crbug.com/1127128 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2391704 [2] https://docs.google.com/document/d/1GOek_Q4O_jTewHHx0MLnbYXvlTdEKT-KmkPZ5R0VJ3c/edit Bug: 1158066, 1127128 Change-Id: I75de00f67a3f26984c10f1dbdf0389b6f31c71a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587402 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Leonid Baraz authored
No semantics changes whatsoever. Change-Id: If7d2aee72d62b09cbe864157416988835febfc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596016Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837872}
-
John Williams authored
Bug: 1159209, b/1154342 Change-Id: I67f862c2f1e9cd2f8cfaeb2d73c5e22ebd360bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559589Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#837871}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_OnContentsSizeChanged to FrameHost interface. This CL uses AssociatedRemote to keep the message order. OnMessageReceived() is removed because AwRenderViewHostExt doesn't handle IPC message anymore. Bug: 1157128 Change-Id: If1e6132ac4c99cb1f1f7ee484a424ba5cc3a75a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592269Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#837870}
-
Asami Doi authored
This CL replaces `data.errors.empty()` with `data.NoBlockingErrors()` because we don't want to consider the WARN_NOT_OFFLINE_CAPABLE state as an error. The state just logs a warning message to DevTools and Application > Manifest > Installability and it should not affect the behavior. Bug: 1157809 Change-Id: I03cf02f134ff4f96441723bf893aac380160cced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592245Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
