- 25 Apr, 2018 40 commits
-
-
Mike West authored
In order to make a reasonable decision about the reasonable-sounding feature request in https://crbug.com/835465, this patch starts processing XFO headers on redirect responses in order to collect metrics about how many requests we'd impact by tightening our enforcement. Bug: 835465 Change-Id: Ieb4571aae10e31fb61f1ccc245da5eb5dab791ae Reviewed-on: https://chromium-review.googlesource.com/1023393 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553520}
-
Ulan Degenbaev authored
Currently the function adds "other_spaces" that contains the difference between the total metrics and the sum of spaces. If the sizes do not match, then this can result in size_t underflow: https://bugs.chromium.org/p/v8/issues/detail?id=7668 We should just assert that the sizes match and remove "other_spaces". Bug: v8:7668 Change-Id: Ib768cec6b2fb7faf3e2c53a89cbd926547ddf603 Reviewed-on: https://chromium-review.googlesource.com/1016602 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#553519}
-
Henrik Boström authored
The test is flaky. See https://crbug.com/836783. TBR=orphis@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836783 Change-Id: I854823be77f95bed0d562f5f2968064e7342352e Reviewed-on: https://chromium-review.googlesource.com/1027871Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553518}
-
Rune Lillesveen authored
The style_ member of StyleResolverState is a ComputedStyle which is being built. There's no reason to have a separate Mutable* method to access it, we can always return it non-const. Bug: 813068 Change-Id: I7282441f2cac2e37ace98d0ee0709baf1ec656ea Reviewed-on: https://chromium-review.googlesource.com/1026682Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#553517}
-
https://webrtc.googlesource.com/src.git/+log/2ff7b6adf0b1..a945aee72e4e $ git log 2ff7b6adf..a945aee72 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:829238,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6e47e0f319c3331213e79ebac289a16527b4e16 Reviewed-on: https://chromium-review.googlesource.com/1027415Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553516}
-
Ben Wells authored
For each Crostini app launch, this records the type of app being launched - either the terminal, a registered app, or an unknown app. Bug: 703927 Change-Id: I326ff4a11028b1030b3c86a0ea4e98048441b983 Reviewed-on: https://chromium-review.googlesource.com/1025542Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#553515}
-
Gauthier Ambard authored
This CL clean the HeaderDefinition class, removing unused properties. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iddc78f1a52ca587617d1def9c03455c2a1052f5b Reviewed-on: https://chromium-review.googlesource.com/1026679 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#553514}
-
Dan Elphick authored
Add PageRead to PageAccessibilityConfiguration so pages can be marked read-only. Matching CL in V8: https://chromium-review.googlesource.com/c/v8/v8/+/1006756 Bug: v8:7464 Change-Id: I9acdd9d5c00db9b89b1a2103be83fa2dde257b37 Reviewed-on: https://chromium-review.googlesource.com/1013564Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Henrik Boström authored
See https://crbug.com/836763 TBR=qyearsley@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836763 Change-Id: I91e1edb6e7fac3aa3957b2ac0c20fc25d628be7d Reviewed-on: https://chromium-review.googlesource.com/1027850 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Alexis Hetu authored
In order to enable SwiftShader as the default software GL implementation on MacOS with EGL, a previous change had to be reverted where native buffer formats were disabled for software GL. These formats are required on MacOS with EGL, for IOSurface support, and SwiftShader supports the same formats as Angle anyways, so only OSMesa needs this restriction. Bug: chromium:726075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20d9bb4083807ad9ae6d5f7092b912ea18ecb679 Reviewed-on: https://chromium-review.googlesource.com/1024500Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553511}
-
Takuto Ikuta authored
Bug: 832211 Change-Id: I9dbfdb0c49aa10f6655454e0d9958f869454f31c Reviewed-on: https://chromium-review.googlesource.com/1025435Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553510}
-
David Roger authored
Going forward the default API for interacting with authentication error should be the token service rather than the SigninErrorController. This CL updates tests to use the token service instead of AuthErrorProvider to set authentication errors. TBR=ellyjones Bug: 836212 Change-Id: I694068a1d037b1f2314d389328b9ccbea5f2bcf3 Reviewed-on: https://chromium-review.googlesource.com/1016642 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#553509}
-
Stuart Langley authored
This CL introduces an overload GetChangeList method in JobScheduler that accepts a team_drive_id and a start_page_token as parameters to retrieve the changes. This is the next step in being able to use start tokens to retrieve changes rather then the deprecated largest change id, which does not work for team drives. In DriveServiceInterface I did not overload GetChangeList but rather introduced a new method name that accepts team_drive_id and start_page_token as parameters. This is because base::Bind cannot resolve overloads and I would have had to add static_casts throughout the code to tell base::Bind which method to resolve to, and it's just not worth it. Bug: 833690 Change-Id: I5598cfe9d5a53a47ae8e8482585ae617f0851765 Reviewed-on: https://chromium-review.googlesource.com/1016181 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553508}
-
Henrik Boström authored
This reverts commit 008759aa. Reason for revert: Breaks MSan Tests Findit (https://goo.gl/kROfz5) confirmed this CL at revision 553428 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwODc1OWFhNWJjOGNkMDVjNTI5NjkwOGVmYmY3NGRjYjA0M2Q2NmUM Example: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6869%2F%2B%2Frecipes%2Fsteps%2Fmus_browser_tests%2F0%2Flogs%2FOutOfProcessPPAPITest.Printing%2F0 Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside [0x7f914c1f9524, 4) ==9854==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x12c35d8e in WriteBytesCommon ./../../base/pickle.cc:430:3 #1 0x12c35d8e in void base::Pickle::WriteBytesStatic<4ul>(void const*) ./../../base/pickle.cc:395:0 #2 0xb00ffa1 in WritePOD<int> ./../../base/pickle.h:327:5 #3 0xb00ffa1 in WriteInt ./../../base/pickle.h:190:0 #4 0xb00ffa1 in Write ./../../ipc/ipc_message_utils.h:186:0 #5 0xb00ffa1 in WriteParam<unsigned int> ./../../ipc/ipc_message_utils.h:110:0 #6 0xb00ffa1 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:223:0 #7 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33 ... Uninitialized value was stored to memory at #0 0xb010122 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:0:1 #1 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33 #2 0xd1e82ee in content::PepperPrintingHost::PrintSettingsCallback(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>) ./../../content/browser/renderer_host/pepper/pepper_printing_host.cc:55:0 #3 0xd1e87e2 in Invoke<const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:447:12 #4 0xd1e87e2 in MakeItSo<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:550:0 #5 0xd1e87e2 in RunImpl<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const std::__1::tuple<base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext> &, 0, 1> ./../../base/bind_internal.h:604:0 #6 0xd1e87e2 in base::internal::Invoker<base::internal::BindState<void (content::PepperPrintingHost::*)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext>, void (std::__1::pair<PP_PrintSettings_Dev, int>)>::Run(base::internal::BindStateBase*, std::__1::pair<PP_PrintSettings_Dev, int>&&) ./../../base/bind_internal.h:586:0 #7 0xd1e7292 in Run ./../../base/callback.h:96:12 ... Original change's description: > Add N-up feature support to pdfium_engine. > > In printing, 2-up, 3-up, or more generally N-up refers to a page > layout strategy in which multiple pages are composited onto a > single page. > > 1. Added ability to pass the N-up feature UI settings (which will be > added in the next CL) to the print preview workflow, so that the > PDF plugin can take action based on user's input. > 2. Added N-up feature support to pdfium_engine, so that when the > source is PDF, pdf plugin will generate the N-up output doc based > on user's input. > > Bug: 775999 > Change-Id: I27933d1a7da65376e70bdcb538393bb8bb3ec688 > Reviewed-on: https://chromium-review.googlesource.com/1014628 > Commit-Queue: Shirleen Lou <xlou@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553428} TBR=raymes@chromium.org,palmer@chromium.org,dcheng@chromium.org,thestig@chromium.org,skau@chromium.org,jochen@chromium.org,xlou@chromium.org Change-Id: I017a6dd2527c843ebb365bf5ec2da19696860898 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775999 Reviewed-on: https://chromium-review.googlesource.com/1027770Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4bd4e9a. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16247 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding TBR=markdittmer No-Export: true Change-Id: Icdd8a31def9fa28dca027343a6ce3e21c40b2d0d Reviewed-on: https://chromium-review.googlesource.com/1027315 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553506}
-
Tsuyoshi Horo authored
HttpRawRequestResponseInfo in ResourceResponseInfo is not thread safe. So if the shared ResourceResponseInfo is deleted on the UI thread, DCHECK(CalledOnValidSequence()) in RefCountedBase::Release() fails. To avoid this, this CL makes a deep copy of ResourceResponseHead before passing it cross-thread. This CL also introduces |devtools_enabled_| in DelegatingURLLoaderClient to avoid unnecessary operations. Bug: 836680 Change-Id: I5cee9b2da8b6183b660e8fc6375d9ee7ab2da343 Reviewed-on: https://chromium-review.googlesource.com/1027390Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/56610207ead6..9f63153a03c7 $ git log 56610207e..9f63153a0 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ f2807385c..023371b3a (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Icc5728a970de3bb3f10c4cdbb3058cc87508f62a Reviewed-on: https://chromium-review.googlesource.com/1027439Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553504}
-
Thomas Tangl authored
The following strings in the user menu are updated: - "Guest" -> "Open Guest window" - "Close all your windows" -> "Exit <Profile>", in case there are multiple profiles - "Close all your windows": titlecase added Bug: 836066, 130656 Change-Id: I526db685f3efd0c7b8623ab8a0081b9414ceed94 Reviewed-on: https://chromium-review.googlesource.com/1025758 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#553503}
-
Vadym Doroshenko authored
It turned out that PROBABLY_ACCOUNT_CREATION_PASSWORD is not so helpful for server-side classification and wasn't used. Let's remove it in order to keep our code clean. Bug: None Change-Id: If53a48f1d8121ac3bb2efaecc291cd6370de9e1c Reviewed-on: https://chromium-review.googlesource.com/1007234Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#553502}
-
https://chromium.googlesource.com/angle/angle.git/+log/2565d48b47aa..023371b3af90 $ git log 2565d48b4..023371b3a --date=short --no-merges --format='%ad %ae %s' 2018-04-24 oetuaho Fix setting mip level metadata on GL backend Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I9c211d86c5b3dfae99338e2b590802a4f2430c9e Reviewed-on: https://chromium-review.googlesource.com/1027434Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553501}
-
Wez authored
The 'shell' feature removal CL was reverted after the sandbox policy files had been split into production and test versions, so the revert did not apply to the new test process policy. TBR: kmarshall Bug: 823927, 836341 Change-Id: I9a4c75cb01c255887a4928c31ab199e039d53397 Reviewed-on: https://chromium-review.googlesource.com/1027441Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#553500}
-
Jonas Olsson authored
Bug: chromium:672469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e24e99df4a6d9dc0480aeb460115bafdceeafd5 Reviewed-on: https://chromium-review.googlesource.com/1018475 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#553499}
-
Yang Guo authored
The old V8 API is being deprecated. R=haraken@chromium.org Change-Id: Iaa5af927df5522ad78ce2b3db2b663568855193e Reviewed-on: https://chromium-review.googlesource.com/1026676Reviewed-by:
-
Friedrich Horschig authored
This CL imports all attribute tests from https://github.com/abarth/http-state/tree/master/tests/data/parser. There are small changes that ensure the tests also clean up when they are run via the debug path. Change-Id: I5cf30824091471e7f65aceb19ad03bd07cfb91d1 Reviewed-on: https://chromium-review.googlesource.com/977923 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Just skip it for now. TBR=atotic@chromium.org Bug: 829804 Change-Id: I279e565e5e26d0355cbba2d3aa7945c73c61b5e1 Reviewed-on: https://chromium-review.googlesource.com/1026678Reviewed-by:
-
Boris Sazonov authored
This CL implements the actual sign-in for the streamlined sign-in screen. The main sign-in flow is similar to the one implemented in AccountSigninView, but account seeding in SigninFragmentBase is triggered by the accept button, not by the account selection. Code to disable controls in the sign-in screen while sign-in is ongoing will be added by subsequent CLs. Bug: 814728 Change-Id: I57d146641e3a4a9e75093550dc9e033159a83d78 Reviewed-on: https://chromium-review.googlesource.com/1024410Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553495}
-
Naoki Fukino authored
By the recent visual refresh on ext4 migration dialog, the header icon was changed from chrome logo to warning icon, and the illustration was modified. Bug: 835461 Test: Manually confirmed on Pixelbook. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I639b7b22f21d73396f33e41af3dc8bfa084ad2de Reviewed-on: https://chromium-review.googlesource.com/1025851Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#553494}
-
Takashi Toyoshima authored
This patch changes the field study default configurations to be aligned with parameters that are planned for launch. Bug: 729954 Change-Id: Idf4cb1097efee62d20a8bd1b2fa67dc872967517 Reviewed-on: https://chromium-review.googlesource.com/1016142 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
We set writing-mode based on parent layout objects, but now modify the ComputedStyle before SetStyle to avoid non-const access to LayoutObject ComputedStyle member. This is part of the work to make the ComputedStyle member of LayoutObject const. Bug: 813068 Change-Id: Id1128c036e05532067a87a33f8b5f8b4b75ab8da Reviewed-on: https://chromium-review.googlesource.com/1024838 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#553492}
-
Rakina Zata Amni authored
TBR=wychen@chromium.org Bug: 836700 Change-Id: I6c72f9404a3373030a65a4acb31597fb70cb0974 Reviewed-on: https://chromium-review.googlesource.com/1027550Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553491}
-
Hayato Ito authored
Once we can land the IncrementalShadowDOM (and remove Shadow DOM V0), we no longer need to call UpdateDistribution, however, some usages of UpdateDistribution are unclear at this point. Thus, except the cases where we can tell its intent cearly, we call RecalcAssignments too for IncrementalShadowDOM there. UpdateDistribution is now divided into the followings: 1. UpdateDistributionForFlatTreeTraversal: This should be used in most cases. 2. UpdateDistributionForLegacyDistributedNodes: This should be used only by the implementation of V0 shadow trees, where they need to access distributed_nodes directly. 3. UpdateDistributionForUnknownReasons: This is a tentative workaround for the sake of safety. In addition to calling (old) UpdateDistribution, we call RecalcAssignments for IncrementalShadowDOM too. The future plan is: 3 can be replaced with 1, however, that needs a careful investigation, so that should be done on a case-by-base basis after this CL lands. TBR=aboxhall Bug: 776656 Change-Id: I826850e04093d2278a2f0aedf8e06f85f2fe8485 Reviewed-on: https://chromium-review.googlesource.com/1025155 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553490}
-
Tatiana Gornak authored
Bug: 801985 Change-Id: I1783db374cf4bcdeda6e5bb6a8a85ce9a8fbc03e TBR=carlosk@chromium.org, rdevlin.cronin@chromium.org,jkrcal@chromium.org Change-Id: I81f3d958715fb2a33fb7269c655912e5bc2db036 Reviewed-on: https://chromium-review.googlesource.com/1023404Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#553489}
-
Findit authored
This reverts commit 59692b72. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 553433 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5NjkyYjcyYmMzNGNiYmM5ZGM3ZmY0NDE0ZjNjODQ2YTU4NzMyOWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27188 Sample Failed Step: mus_ash_unittests Original change's description: > Observe ClockModel directly from DateView/TimeView > > This CL changes DateView and TimeView to directly observe ClockModel. > It removes unrelated logic from SystemTrayItem and makes embeding these > views easier. > > TEST=ash_unittests > BUG=none > > Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462 > Reviewed-on: https://chromium-review.googlesource.com/1025615 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553433} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=none Change-Id: Ife07647a589f9caa276788bae5dccff68bcf41a0 Reviewed-on: https://chromium-review.googlesource.com/1027272 Cr-Commit-Position: refs/heads/master@{#553488}
-
Michael Lippautz authored
Any roots from V8 into Blink need to be cleared before running the termination garbage collection to ensure that all objects die and finalizers are called. Bug: chromium:831117 Change-Id: I09042623ceafe141819f4e9b52b15e784dd623a9 Reviewed-on: https://chromium-review.googlesource.com/1025032 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Boris Sazonov authored
assertEquals accepts an expected value as the first argument and an actual value as the second. This CL fixes some tests that were using the reversed order. Bug: None Change-Id: I158277a01d6146ef46b1b2fc97af04c7dcd7a563 Reviewed-on: https://chromium-review.googlesource.com/1008002Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553486}
-
Hiroki Nakagawa authored
This is just a cleanup and doesn't change behavior. Bug: 825740 Change-Id: I36c4002ca29bd3ad5af1a8f63ef2b33e6b977981 Reviewed-on: https://chromium-review.googlesource.com/1027370Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#553485}
-
Tatsuhisa Yamaguchi authored
This is preparation for fixing Issue 834675, where we will be changing execution paths for these procedures based on input file locations. Test: manually tested by zipping files on My Drive Bug: 834675 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac3637d46760066b18c36e799448af5d7f6cd705 Reviewed-on: https://chromium-review.googlesource.com/1027332 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553484}
-
Matt Falkenhagen authored
We were only doing this check at registration time previously, which is sketchy since the browser or content settings could change in the meantime after registration. Actually the motivating example was if you register an extension service worker once and then run Chrome with --disable-extensions and then try to start the worker via chrome://serviceworker-internals. It turns out the checks for JavaScript and cookies in ChromeContentBrowserClient::AllowServiceWorker were disallowing start worker in that case, but it seems fragile to rely on those. Change-Id: Iea3706ccf08ec72ed9e2306b01a6ddfd0fa3b9eb Reviewed-on: https://chromium-review.googlesource.com/1027171Reviewed-by:
-
Yuzu Saijo authored
Now that Document leak bug (crbug.com/734427) is fixed, leak detector must no more skip any tests. This CL updates the expectation file. Change-Id: Ieaa29267952d259c1a7911f566a25257b7f29a63 Reviewed-on: https://chromium-review.googlesource.com/1025537 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553482}
-
Bill Orr authored
This reverts commit 0ad90c2f. Reason for revert: Found the issue with the broken tests. Original change's description: > Revert "WebXR: Do not provide poses to frames without focus" > > This reverts commit 666960b1. > > Reason for revert: Causing a test bug. Reverting while I investigate that bug (crbug.com/835047). > > > > Original change's description: > > WebXR: Do not provide poses to frames without focus > > > > This change plumbs through focus (both blink/frame and device) to XRSessions, so we > > only call raf callbacks when focused. > > > > BUG=813230 > > > > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 > > Reviewed-on: https://chromium-review.googlesource.com/1011288 > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551842} > > TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 813230 > Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789 > Reviewed-on: https://chromium-review.googlesource.com/1020800 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552268} Change-Id: I065ccb0972a33e553aa73140bd649a939a6547f8 Bug: 813230 Reviewed-on: https://chromium-review.googlesource.com/1022560Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553481}
-
