- 28 Oct, 2020 40 commits
-
-
Dave Tapuska authored
This message which is only sent on windows and ash. Looking back on the history (http://crrev.com/30f75e61) when this message was added it was intended to hide auto complete popups. Being that we dismiss select popups on focus changes and size changes I believe this method is not needed anymore. BUG=1051648 Change-Id: I463da85c9916c2140e4093447df1aacefc75b9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493282 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821841}
-
Stephen McGruer authored
This rolls up to sha 178d0b3f04a Bug: None Change-Id: Ib9d3628b514e46f8710ee9a49550dd381ef57206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506114Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821840}
-
Dave Tapuska authored
DidDetach wasn't getting called and there was no receiver for the message anymore. So all of this code is dead. Remove it. BUG=993189,533069 Change-Id: I71b712fd0f21a89ab60cd1c509afbb6e02604a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505126Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821839}
-
Takumi Fujimoto authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56470 TBR=jdoerrie@chromium.org Bug: 1143312 Change-Id: Ice856557d80337fae79ad41e6a3b06630d3d1e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506209Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#821838}
-
Christopher Cameron authored
The capture system is built around the assumption that the VideoCaptureBufferPool allocates buffers and manages their lifetime. This does not match the behavior on macOS where the macOS capture APIs manage buffer pools (via a CVPixelBufferPool). Prior to this change, these "external" buffers were not tracked by the VideoCaptureBufferPool beyond having an id assigned for them. They were never "reused" -- every new frame was treated as though it was a new buffer. This was problematic because it caused these buffers to be opened and closed as they propagated through three processes (the capture, renderer, and GPU process), burning lots of CPU. In fact, the underlying IOSurfaces are indeed reused in the CVPixelBufferPool. This patch enables VideoCaptureBufferPool to exploit the IOSurface reuse done by the CVPixelBufferPool. It uses GpuMemoryBufferTrackerMac to track the externally-provided buffers. When a new IOSurface is presented in VideoCaptureDeviceClient::OnIncomingCapturedExternalBuffer, the function VideoCaptureBufferPoolImpl::ReserveIdForExternalBuffer uses the new IsSameGpuMemoryBuffer function to determine if we are already tracking the GpuMemoryBuffer. Of note is that VideoCaptureBufferPoolImpl::ReserveIdForExternalBuffer uses LRU order to discard old buffers (which matches the CVPixelBufferPool usage pattern), while the other function that does this, VideoCaptureBufferPoolImpl::ReserveForProducerInternal, finds the largest buffer to discard. To prevent the CVPixelBufferPool from reclaiming the IOSurface before the consumer is done with it, add a OnHeldByConsumersChanged function which calls IOSurfaceIncrementUseCount (via gfx::ScopedInUseIOSurface) to signal to the CVPixelBufferPool that the IOSurface can't be reclaimed yet. This involves some refactoring of the VideoCaptureBufferTracker class. Prior to this patch, the IOSurface's in use count was being updated by the ScopedAccessPermission argument provided to the VideoCaptureDeviceClient::OnIncomingCapturedExternalBuffer function. Just drop that ScopedAccessPermission on the floor for now -- it will be cleaned up in a follow-on patch (this one is already big). Update tests to test this. Bug: 1125879 Change-Id: I9eaf6dd47126103b094f54bf23a3f28cf2318d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493089Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#821837}
-
Henrique Nakashima authored
This makes it possible to know what revision a graph corresponds to, so that users know how old the graph they are viewing is and makes it possible to track regressions. Bug: 1115268 Change-Id: Iedceabe885d90b14bb639e810dcaa75f48be844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353292Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821836}
-
Chong Gu authored
Fix recipe issue with the CQ builder: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8865185421221209248/+/steps/Incorrect_or_missing_bot_configuration/0/logs/details/0 Bug: 1135171 Change-Id: I01fc7650a5b3012cfc8bb042244319f52a87204b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505971 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#821835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71f12666647b..541601602ee9 2020-10-28 bungeman@google.com Roll freetype 0a3d2bb99b45b72e1d45..40c5681ab92e7db1 2020-10-28 tdenniston@google.com Improve var-width miter joins 2020-10-28 egdaniel@google.com Revert "In Vk don't set dynamic blend constant on Pipeline if we don't use it." 2020-10-28 johnstiles@google.com Add `reportLeaks` method to GrMemoryPool. 2020-10-28 michaelludwig@google.com Fix clip shader coverage combining with geometry processor coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I971d0508eeb4ae3e2b804b4bdfacd73bc4f1a743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821834}
-
Ian Struiksma authored
Several tests are timing out on win10-blink-rel that don't on previous Win10 version (moving from 1703 to 1909). These tests pass on the longer 1200 timeout on win10 test builder. Also, adding failure expectation for media/track/track-cue-rendering-vertical.html Bug: 1142023,1143005 Change-Id: Ifd19bff72b84438b7e015909885af67ded4fb2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503842 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#821833}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/763dc305cc96..9e8d3a2d7e05 $ git log 763dc305c..9e8d3a2d7 --date=short --no-merges --format='%ad %ae %s' 2020-10-20 yichengli system_api: Add request_id parameter for WebAuthn requests Created with: roll-dep src/third_party/cros_system_api Change-Id: Ie36c7bb7cfe35f1d63041020ad3cc3b96c168a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503319 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821832}
-
Gavin Williams authored
Add browser proxy to give Scanning UI access to ScanningHandler functions. Bug: 1059779 Change-Id: Iad0f72305ae315c3079393ff077c784ec9b8f101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497427 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821831}
-
Matt Menard authored
Enables print server scaling support where print server may be selected individually when more than 16 print servers are available via policy. Relevant Design Docs: go/cros-print-server-scaling and go/cros-print-servers-backend Bug: b:168650771 Change-Id: I16c10f4e80504e1c0b0cfda8ce93af5b724e917d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499164 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821830}
-
David Black authored
The background is composed of an opaque white circle with a drop shadow. The next CL will implement painting of the actual contents representing the associated holding space item. Screenshot: https://screenshot.googleplex.com/KDyRTn7ALwdy8U2 Bug: 1142572 Change-Id: I9bd8ea71e9977487bd59df69ce78d79015192146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503321 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821829}
-
rbpotter authored
With the update of OS settings to generate_grd, this method is no longer used. Bug: 1132403 Change-Id: Id06f6249b05bebcc72eb22b417d0334bc4d5a708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505936Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821828}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bc42696a. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" 0c2d7260 "[scroll-animations] Handle changes to selector(#id) references" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I5b5741b0088f9e9dbf952889330a219529b89a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505455Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f40a48d..3542c2cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibda221d2f77fc4e60b1a0657ecfa9b646deb42fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821826}
-
Dave Tapuska authored
These metrics expired in M81 and they'd need to be re-implemented in blink with RenderWidget's removal. Since they aren't used it is easier to remove them. BUG=1037221,1097816 Change-Id: I2879ce11795b090a4244838579167e61f7d34daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500248Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821825}
-
adoneria authored
Fix broken Windows Deterministic builder issue that caused revert crrev.com/c/2502022. Change test cases to use typ.TestCase instead of unittest.TestCase. Bug: 1141577 Change-Id: I79d6c93dd15c2e3e727c5368a97142d5572c1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503396Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#821824}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/cr/ui/. Bug: 1143194 Change-Id: I128845c864e439cbf262f343cfa77153916d8dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504740 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821823}
-
Ilia Samsonov authored
New baseline are from: https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html Bug: 1130741 Change-Id: I6d5f2bcb820717b6f6053125cfffe5d9e49963d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491982Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#821822}
-
Side Yilmaz authored
This CL adds null check for mTabSwitcherModeToolbar to IncognitoTabModelObserver callback not to cause NPE. In addition to that, this CL introduces |maybeInitializeOnIncognitoTabsExistenceChanged| and |maybeInitializeIncognitoTabModelObserver| functions to perform initialization in both |setTabModelSelector| and |initializeTabSwitcherToolbar| functions. Bug: 1142547 Change-Id: Ib539d70e06b4ebe86464867409e0a736dd7bd4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502373 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#821821}
-
Xinghui Lu authored
One major refactoring in this CL is removing FeedbackCollector's dependency on ScreenshotTask, because ScreenshotTask is not modularizable at the moment. Replace the takeScreenshot parameter in the init function with a ScreenshotSource object(the interface of ScreenshotTask), so FeedbackCollector doesn't need to construct a ScreenshotTask itself. Some outstanding blockers for further modularization: * DataReductionProxyFeedbackSource, blocked on DataReductionProxySettings. * HelpAndFeedbackLauncherImpl, blocked on AppHooks. * ScreenshotTask, blocked on ChromeActivity. * connectivity_checker.cc, blocked on circular dependency of chrome/browser/profiles. Bug: 1117343 Change-Id: I93dd06b4146ad57d53c0cdc082d8ff0c9a32cdc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478108Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821820}
-
Mikel Astiz authored
This patch migrates the helper libraries to avoid using the concept of a 'seed', which was hard to grasp, and instead migrates tests to more directly use keywords. Change-Id: Ibcdae092baade651daca059850ac31f276f47564 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495461Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821819}
-
David Tseng authored
Strategy: - manually edit the Eslinter rule: third_party/node/node_modules/eslint/lib/rules/eqeqeq.js to allow for auto fixing; this was intentionally disabled upstream. - run tools/web_dev_style/eslint.py --fix and git cl format --js on the directory R=akihiroota@chromium.org, josiahk@chromium.org Test: assumed automated test coverage Change-Id: I97913d8d198e2fe049eeeb52473a8c58aebcd94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503851Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821818}
-
Ben Pastene authored
This is the first in a series of changes to make all ToT linux CQ builders builderfull. crrev.com/i/3351753 allocates the machines for this builder, so this shouldn't be submitted before that. Bug: 1140727 Change-Id: I976f419b4be7249534b210e05151694734acbe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503391Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#821817}
-
Rushan Suleymanov authored
The DCHECK could be violated during a sync incremental update when remote updates have entities having different sync ids and the same GUIDs. This is a temporary measure until it is guaranteed that GUIDs are unique across all bookmarks. Bug: 1142790 Change-Id: Ic1279eee89290f4245f5e7f76528e888ff0dec39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506030Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821816}
-
Rune Lillesveen authored
Check the call site instead. There should be no behavioral change. Preparing for making HighlightPaintingUtils::SelectionPaintingStyle HighlightPaintingStyle and share the code with other highlight pseudo elements. Bug: 1136817 Change-Id: I240fdc2689db914862bc4ae64f64969ed3099acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503552Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821815}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6c47e326364bbe75df8507ba18bb04c4bb07c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505096Reviewed-by:
-
Ben Kelly authored
This CL adds some initial liburlpattern code and tests. The main goal is to stub things out so we can get the build system in place. The CL does this by creating an initial Parse() API, validates that input characters are ASCII, and provides a unit test that checks the case where invalid characters are passed. Bug: 1141510 Change-Id: I7571d278e2e6d3d2b2a81ffe0e2df677c6831cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493246 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821813}
-
Nate Chapin authored
NavigatorClipboard is mostly boilerplate, and Clipboard can be the Supplement<Navigator> cleanly. Change-Id: Ieb7db5f8172a08c193dff261bcaa43fda7f47dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499367 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#821812}
-
Jeffrey Kardatzke authored
BUG=chromium:1141237,b:153111783 TEST=media_unitests, media_h265_parser_fuzzer Change-Id: I0be4bbb23add3c1a47d66a36cb331ae8776d0d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503432 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821811}
-
rbpotter authored
Followup from https://chromium-review.googlesource.com/c/chromium/src/+/2493991 Bug: 1132403 Change-Id: Idc2d9473feef2ad9746473a6bd8724a2f15616ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505955Reviewed-by:
-
Liquan (Max) Gu authored
Context: The isWebContentsActive() method used for testing purpose, but it's always set to true in tests, so this CL removes the method. Going forwards, if there's a need to create "inactive" WebContents in tests, we should fabricate an inactive WebContents instead. Bug: 1128658 Change-Id: Idc22ee0471c960781554418ce2035fa25b7c4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500569Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821809}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/5121556831272960 Bug: 1143294 Change-Id: Iba4cdf6717e090f7041ca43af4ed5153820d89ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505454Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821808}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d81fd3dbd55e..b28ec889c239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nicolaso@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nicolaso@google.com,drott@google.com Change-Id: Ia69f9cd352b2f4fae5cc387dbc23596d62631b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821807}
-
Hoch Hochkeppel authored
Adding a class for performing a navigator.share() operation on Windows, and corresponding tests. Originally committed as part of https://crrev.com/c/2443757, but reverted due to test issues. Patchset 1 is a cherry pick of this original change (reduced to the files relevant to this portion) for easy comparison. Bug: 1035527 Change-Id: I82a61739c168b0a2c9aa9f9f9d20572d8a45a2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503819 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#821806}
-
Kevin Marshall authored
Adds annotations and a check-only js_binary() target to provide static typechecking assurances for NamedMessagePortConnector's JS. Bug: 159646269 Change-Id: I8340e4ef8ca291431a26dccef642745625e36911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458811 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821805}
-
Daniel Cheng authored
All usage has been migrated to use the standard //base/metrics functions. Bug: 1047547 Change-Id: I548b683c758f2251a3af1db8280c9c63e6245bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505932 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b5ba693316fd..47e66f22759a 2020-10-28 jmadill@chromium.org Revert "Re-enable crash testing in angle_unittests." 2020-10-28 geofflang@google.com Expand DrawArraysWithAlignedAndUnalignedBufferOffset supression 2020-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e56348f0 to 80c364fa (530 revisions) 2020-10-28 timvp@google.com Vulkan: Add descriptor set allocation counters 2020-10-28 jmadill@chromium.org Trace Tests: Allow runs against SwiftShader. 2020-10-28 timvp@google.com Create test Texture2DTestES3::ChangeTexSizeWithTexStorage() 2020-10-28 jdarpinian@chromium.org ANGLE_platform_angle_device_context_volatile_* extensions 2020-10-27 ianelliott@google.com Enable debug-util markers with an env var/property 2020-10-27 syoussefi@chromium.org Vulkan: Remove VVL warning suppression for push constants 2020-10-27 jmadill@chromium.org Capture/Replay: Move exported data to start of header. 2020-10-27 jmadill@chromium.org Fix extension requirement for "World of Tanks". 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from abe2eff36f3c to 34ae8a475754 (1 revision) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 91ce213a1d88 to 8e2b7d03ccfd (2 revisions) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb66fa41a163 to c1839ee3cedd (1 revision) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3b334b2b8e1a to 740ae9f60b00 (1 revision) 2020-10-27 xinghua.cao@intel.com Refactor uniform block test cases 2020-10-27 syoussefi@chromium.org Increase MAX_UNIFORM_BUFFER_BINDINGS to 72 2020-10-27 syoussefi@chromium.org Vulkan: Initial emulated prerotation support 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5f7e3cf2 to e56348f0 (434 revisions) 2020-10-27 syoussefi@chromium.org Use 4 colors in Checkered test shader 2020-10-26 jmadill@chromium.org BinaryStream: Preserve 64-bit integer data. 2020-10-26 m.maiya@samsung.com Vulkan: Fix exposure requirements for EXT_texture_format_sRGB_override 2020-10-26 jmadill@chromium.org Capture/Replay Tests: Expand suppressions. 2020-10-26 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation support 2020-10-26 jmadill@chromium.org Capture/Replay: Test improvements. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) 2020-10-26 geofflang@google.com GL: Use ANGLE_GL_TRY for draw calls. 2020-10-26 jmadill@chromium.org Output nullptr pointer parameters correctly. 2020-10-26 jmadill@chromium.org Re-enable crash testing in angle_unittests. 2020-10-26 jmadill@chromium.org Fix uninitialize state in ProgramState. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Manual verification with angle_perftestsTest: Test: Texture2DTestES3::ChangeTexSizeWithTexStorage Change-Id: I1dd6158a2e0fc49e438cba50edf03b75000b4e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505093Reviewed-by:
-
Matt Menard authored
Bug: b:168650771 Change-Id: Ied905968e428857f3890e4355db65c25b2dde282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496000Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#821802}
-
