- 01 Oct, 2019 40 commits
-
-
liberato@chromium.org authored
Test is flaky. Bug: 1009587 Change-Id: Ic4c04980273e48b3802259d599407e46a1bda8e2 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832249Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701668}
-
Zentaro Kavanagh authored
- Add final strings for mouse and touchpad acceleration BUG=chromium:589190 TEST=visual confirmation Change-Id: I009ad45a802e3717a0cf4c6ddc151b4191732f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831452Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#701667}
-
Abhijeet Kandalkar authored
This CL converts usage of 1. |ProducerHostRequest| to |mojo::PendingReceiver<mojom::ProducerHost>| 2. |StrongBindingSet| to |UniqueReceiverSet| Bug: 955171, 978694 Change-Id: I06953f0494b3504901faa5e6cc65c8b59fd30298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831921 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#701666}
-
Caleb Raitto authored
Change-Id: I2df10d1aefd0be2c9a740838426bf01c03f85f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829358Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701665}
-
Michael Liao authored
Changes: - Placeholder view automatically gains focus - Each suggestion (Open File, Run Command, Drop in a folder...) is now functional and keyboard accessible Reasoning: When initially opening the "Quick Source" tool from the top right menu > More tools > Quick Source, the focus is set to the widget's contentElement. https://imgur.com/JUDmjDR This is mainly an issue when the placeholder view is up since the focus seemingly disappears and the user is required to click tab again to find their focus. This CL fixes this issue shifting focus into the suggestion elements themselves, and allows keyboard users to quickly access the suggested actions via Space/Enter. Change-Id: Ie937ebd79a00be5ef993de09a772e8b275ccc042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756851 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701664}
-
Andrew Xu authored
The CL was reverted by an unrelated crash. Now reland it. The link to the original CL: crrev.com/c/1815723 Original description: Now scrollable shelf ensures that when two arrow buttons show, the right gradient zone always cuts the half of the rightmost icon. To implement this feature, some available space is wasted. As a result, there may be no sufficient space for scrollable shelf on small-screen devices. In this CL, the width of the gradient zone becomes a constant. Bug: 1005989 Change-Id: I29fcb766562860d9d4ca5d21a497b193300ddd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832914Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701663}
-
Mikhail Khokhlov authored
So far TBMv2 metrics have been computed on the Telemetry side and passed to Results Processor as a special artifact. This CL implements metric computation in RP. Metrics will be computed if this artifact is absent. Bug: 981349 Change-Id: I46803784bd75269e578e951f5dd2e5bfaa5cae68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821527 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701662}
-
Daniel Nicoara authored
Responses need to be matched to their request. So add a unique identifier to ensure the client can match the response to the appropriate request. Bug: b/132811925 Test: Compiled Change-Id: I8358e5baed4922de2960a8eebd712443473bebdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833483Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#701661}
-
Michael Liao (WPT) authored
Problem: - NVDA does not currently support reading <optgroup> elements in Chromium - Optgroup labels are inaccessible in Network throttling select element in Network Conditions tab Changes: - Select options are given a new accessible name that prefaces the option title with the optgroup title. Bug: 963183 Change-Id: Id9a71997c96d3646c7cf35de94213bccf5e68912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730863Reviewed-by:
John Emau <johnemau@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yasmin authored
Bug: 1005813 Change-Id: I4661aefa91ecc2d19a8057d1e0233fcebee2bc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833824Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701659}
-
David Tseng authored
Summary ChromeVox (Spoken Feedback) receives key events earlier than any other event handler or rewriter in Chrome today. This was done partly because ChromeVox requires the ability to override all system shortcuts including Search+l (lock), Search+f1-f12 (various functions), and many other combinations. However, as noted in the below bugs, users want the ability to remap some modifiers (e.g. Control as Search). This change: - does some light refactoring so all EventRewriter instances live within EventRewriterControllerImpl. - makes clear the ordering in which keys flow. - makes SpokenFeedbackEventRewriter hold a weak pointer to EventRewriterChromeOS in order to be able to rewrite modifiers and build key events. This is necessary because EventRewriterChromeOS::RewriteModifierKeys calls through and has hard dependencies on |dleegate_| an instance member. Bug: 821657, 822493 Test: manually with ChromeVox. Change-Id: I2d808e1ac640528fba2063afdb99fac0325c8106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822982Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701658}
-
Daniel Rubery authored
This option is very confusing, compared to the "DoNotScan" option, and was added just to support a planned feature (scanning for Advanced Protection users). When scanning for Advanced Protection users actually launches, we can add a new policy to handle it. Bug: 980777 Change-Id: I9e2cdc08ee70eaf9c37bfa2eb59304d1eff0d8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827465Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701657}
-
Andrew Xu authored
Re-enable those tests which were disabled due to crbug.com/1008744. Bug: 1008744 Change-Id: Id67c436f50777631b855eb5c4405473dcadf14d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832708 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Lindsay Pasricha authored
Bug: 137010 Change-Id: I3f8c1674e1ccfaa5edfd924c7044154d603738c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827952Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#701655}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010145 Change-Id: Iadfef1df01f3b5d1c926aededd05cfb3cf8358b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833785Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701654}
-
Fredrik Söderquist authored
Notify once at the end up said functions - after all the conditions have been processed. Renames AddInstanceTime() to AddInstanceTimeAndUpdate(), and then splits out a new AddInstanceTime() which just adds the instance time to the selected instance list. Bug: 998526 Change-Id: I4d350c7752e95eb87923eab79ec1ad87b1d7f27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831816 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701653}
-
Robbie McElrath authored
This CL almost makes gn check happy for all webview build targets. I still need to move AwFeatureList to a common location since it's used from multiple places. Test: gn check out/aw '//android_webview/*' Bug: 934152 Change-Id: I3635f36db8015db342350b0a50f0787d8c936bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828346Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#701652}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The member was already there. This CL simply exposes it and starts using it, rather than calling RenderWidget::compositor_deps(), since |render_widget_| may be nullptr in the future. Bug: 912193 Change-Id: Ib36ee51473100f2cee8fc685f6817647a1c6fc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829675 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701651}
-
Daniel Nicoara authored
Webview clients want to know the URL for the page event. Include it for convenience to reduce the number of IPCs. Bug: b/132811925 Test: Compiled Change-Id: I4d2b4fd7ead9002270f5008cb4bbfb5be57b3904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833117Reviewed-by:
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Ic3c8f365886d98d8007a4eeb06c42522d00ce109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832441Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701649}
-
Fabian Henneke authored
Since the U2F Zero authenticator cannot deal with check-only sign requests, exclude lists are probed with UP-requiring sign requests instead. Since these requests are indinstinguishable from actual sign requests, they are problematic for authenticators that want to show the request type to the user (e.g. soft tokens and authenticators with a display). This change aims to make these workaround sign requests stand out while preserving compatibility with authenticators behaving like the U2F Zero. This is achieved by setting the challenge of the sign requests sent while probing an exclude list to the same fixed bogus challenge used to collect a touch on certain errors. R=agl@chromium.org Bug: 1000641 Change-Id: I7ae43a0ecc2380714ce4752a84c7b6cd4572cdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831857 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#701648}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 214 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-29. Change-Id: I9d6a210147e8729a474786f021f153667f5749f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829679 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#701647}
-
Morten Stenshorne authored
LayoutInline::ChildBecameNonInline() is called when a child of an inline becomes in-flow block-level (e.g. when its position changes from absolute to static) and we need to set up a continuation chain because of this. Part of this operation is to wrap the in-flow block-level child inside a new anonymous containing block. AddChildIgnoringContinuation(), which is what we call when inserting new children, did a few nice things to such anonymous containing blocks, which ChildBecameNonInline() didn't do, most crucially, setting the position of the anonymous containing block to relative if the inline is relatively positioned (to contain absolutely positioned descendants). So if the continuation was set up as a reaction to something becoming block-level, rather than being set up as part of inserting new children, the anonymous containing block of block-level children of the inline didn't get position:relative, which made any absolutely positioned children escape its relatively positioned inline parent, and find a containing block further up (the viewport, in the included testcase). To fix this, break out the code that sets up such an anonymous block into a separate method, and have ChildBecameNonInline() call it. Bug: 732397 Change-Id: I06b120c3173403ba6db3b93019e95a66575ba0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833581Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#701646}
-
Geoff Lang authored
The the passthrough command decoder did deferred image bindings, it didn't ensure that the correct GL texture was bound first. This caused canvas -> WebGL copies to fail when they are using IOSurface backed canvases. BUG=990368 TBR=true Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701645}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a7d9ac2af4684747c4524cbeba9737b04dce3e3e..bd522862a0b4c84a0ed8e37096d1c361dc6beaa9 Bug: none Change-Id: I38612b6cfdc378bbca6163f725445dae3d42eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829582 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#701644}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1008826 Change-Id: I6b05ebd733f1a69f4194f3b2ea7febd2b1812ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832697Reviewed-by:
-
Ahmed Fakhry authored
This CL implements the new spec for adding an item to overview while overview is active. The new animation is a fade-in plus scale-up of the new added window in its final position in the overview grid. BUG=990831 TEST=Manually Change-Id: Ie7721e59af02f4fc2d5ca5664a43e8b13f6dd752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832477 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#701642}
-
Etienne Bergeron authored
This CL is adding the RenderFontParams explicit to the font constructor. On Linux, the call to GetFontRenderParams(..) is making a call to the FcFontMatch to retrieve the rendering parameters. It is quite common on Linux to iterate through fonts returned by FcFontSort(...) and to create gfx::Font with them. There is no need to make a second call to GetFontRenderParams(..) [and to FcFontMatch] since the rendering parameters are known (see etFontRenderParamsFromFcPattern(...)). On windows, the call to GetFontRenderParams(..) returns the same parameters, no matter which font family is provided. R=robliao@chromium.org Bug: 1008531 Change-Id: Ia368e3c797cf43b3bd726f871e01389b41092c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830061 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701641}
-
Skipping chromeos-betty-chrome, since betty's broken. BUG=762641, 1010136 TBR=satorux@chromium.org Change-Id: Iea95d313597a770cd80cc332ee8df18b0993e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833521 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701640}
-
Alexander Cooper authored
This reverts commit c96640df. Reason for revert:Suspected cause of 1010101 Original change's description: > Support WebXR Inputs Using OpenXR > > Support webxr input using OpenXR And Enable related WebXR input tests. > This change can be tested with this page. > https://immersive-web.github.io/webxr-samples/controller-state.html > > Bug: 986394 > Change-Id: I346d7808769a2ab1979d0f1f023b9c815611f292 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808086 > Commit-Queue: Zheng Qin <zheqi@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701357} TBR=alcooper@chromium.org,zheqi@microsoft.com Change-Id: I8775e296a86a286f607987fda1528cbe28150439 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832712Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701639}
-
Oleg Davydov authored
UserCloudPolicyManagerTest didn't work for chrome branded builds, because it tried to show sync consent screen on fake user login, and therefore made browser tests to hang waiting for user interaction. This commit adds an option to skip all post-login screens. Bug: 976987 Change-Id: Ie42980bc4791efe9a455780c5dff9ec8c8abbd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833465Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701638}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e49df747da7e..755417dd7907 git log e49df747da7e..755417dd7907 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 jaime@janeasystems.com GLES2: Use require_constant_initialization for g_Mutex 2019-10-01 cnorthrop@google.com Vulkan: Narrow skip lists for 3D and 2DArray tests to Compute Created with: gclient setdep -r src/third_party/angle@755417dd7907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:3188,chromium:3189,chromium:3810 Change-Id: I4f4960b14c2c4373ca1f8bebed2921d2e3150ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701637}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7914a872657..8c500751cd1c git log a7914a872657..8c500751cd1c --date=short --no-merges --format='%ad %ae %s' 2019-10-01 halcanary@google.com experimental/minimal_mtl_app: more cleanup 2019-10-01 jvanverth@google.com Add TransferBuffer and AsyncRead support to Metal. 2019-10-01 bsalomon@google.com SkColorInfo: It's SkImageInfo minus the dimensions. Created with: gclient setdep -r src/third_party/skia@8c500751cd1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I3728b99f083c48d7bb6f10003111875eb41a7fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833292Reviewed-by:
-
Michael Liao authored
Changes: - Adding label to search input, number of matches and line number - Added SR functionality for when the search finishes and # of matches Keyboard Nav CL: https://chromium-review.googlesource.com/c/chromium/src/+/1819493 Different ways to read search result status: https://imgur.com/koruZRk Bug: 963183 Change-Id: Ia5dc1608d3cffe3c6164f15da895896b4191b008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613675 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/gfx to the recommended methods/types. Bug: 1007851 Change-Id: Iac0a7b8e9bb05a9f9c3f498bc43c078e0d7ee64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831862 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c079f650def..65235d3ae771 git log 7c079f650def..65235d3ae771 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 nisse@webrtc.org Add GetStats at end of PeerConnection quality tests 2019-10-01 nisse@webrtc.org Avoid memcpy in JavaToNativeEncodedImage 2019-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa4c7d6a..443491f4 (701411:701518) 2019-10-01 nisse@webrtc.org Delete old placeholders for moved api/ header files Created with: gclient setdep -r src/third_party/webrtc@65235d3ae771 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ida0c6a0e838a58148f9f4428d08f6ff134f58b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833288Reviewed-by:
-
Trevor Perrier authored
This CL changes the Lite mode FRE to include a "Learn more" link that points to the Chrome Lite mode help documents. This uses p-link "lite_mode" The wording on the FRE page has also been changed to make indicate that Lite mode sends web traffic to Google. Bug: 997248 Change-Id: Idb2f69ecfefe68f1a5f6d8052d393d213283e64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830106Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#701632}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I06b679d48413f0b30bc72fe88b199205c6b37429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834061Reviewed-by:
-
arthursonzogni authored
Add regression tests for https://crbug.com/1003167. This checks what happens with cookies in iframes when using special URLs like about:srcdoc, about:blank, and data-URLs. This checks normal navigations and history navigations. This is able to trigger the DumpWithoutCrashing() in: network::RestrictedCookieManager::ValidateAccessToCookiesAt Tests= - NavigationBaseBrowserTest.CookiesInheritedSrcDoc - NavigationBaseBrowserTest.CookiesInheritedAboutBlank - NavigationBaseBrowserTest.CookiesInheritedAboutBlank2 - NavigationBaseBrowserTest.CookiesInheritedDataUrl Bug: 1003167 Change-Id: I73b9e62021490cfb74caf49c32009171dd9bea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831762Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701630}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I184d6bdef8cc39577faab29f9b7b87314cf5776f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833900Reviewed-by:
-
